osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
40922 commits 26 branches 0 tags 795 MiB
Commit graph

18394 commits

Author SHA1 Message Date
Anders Broman
6e3d56f039 For RLC re-assembly to work we need to fake urnti. 
svn path=/trunk/; revision=42970
 2012-06-01 13:01:32 +00:00
Anders Broman
a2f13cad70 Don't call subdissectors if the CRCI bit is set. 
svn path=/trunk/; revision=42969
 2012-06-01 12:28:05 +00:00
Anders Broman
c8625796f1 Make the cosnaming dissector a builtin dissector. 
svn path=/trunk/; revision=42968
 2012-06-01 12:27:04 +00:00
Anders Broman
b42bbc2cd6 Make the tango dissector a builtin dissector. 
svn path=/trunk/; revision=42967
 2012-06-01 10:31:34 +00:00
Anders Broman
5959f75518 parlay changes to Cmake 
svn path=/trunk/; revision=42965
 2012-06-01 09:04:28 +00:00
Anders Broman
5ef6c6d08a Make the parlay dissector a buil tin dissector. 
svn path=/trunk/; revision=42964
 2012-06-01 08:48:31 +00:00
Anders Broman
d8d6de9561 Remove debug code left by mistake 
svn path=/trunk/; revision=42959
 2012-06-01 06:14:08 +00:00
Anders Broman
fcfb9795d2 Fix a couple of warnings 
svn path=/trunk/; revision=42958
 2012-06-01 05:55:45 +00:00
Anders Broman
728584510b Fix a couple of warnings 
svn path=/trunk/; revision=42957
 2012-06-01 05:55:20 +00:00
Anders Broman
6a505b4cce Fix a couple of warnings 
svn path=/trunk/; revision=42956
 2012-06-01 05:36:52 +00:00
Gerald Combs
5690373d48 g_snprintf → ep_strbuf. I can't find an ERF file with a virtual 
container but the conversion seemed be straightforward enough.

svn path=/trunk/; revision=42951
 2012-05-31 21:30:40 +00:00
Pascal Quantin
b83080f5b6 From Erwin Rol via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7311 : 
Fix a cut and paste error in packet-dmx.c

svn path=/trunk/; revision=42949
 2012-05-31 20:40:07 +00:00
Gerald Combs
ae6e4d6dd3 Fix a possible zero division found by scan-build. While we're at it replace 
occurrences of g_snprintf+strlen with ep_strbuf.

svn path=/trunk/; revision=42948
 2012-05-31 20:24:04 +00:00
Anders Broman
b9e5955f46 Set dir if we don't have it. 
svn path=/trunk/; revision=42945
 2012-05-31 13:23:42 +00:00
Pascal Quantin
08c7db0421 Display hf_smb_server_guid, hf_smb_volume_guid and hf_smb_dfs_referral_server_guid as FT_GUID 
svn path=/trunk/; revision=42944
 2012-05-31 13:22:52 +00:00
Pascal Quantin
4d1abc7bbb From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7306 : 
RPC: show the AUTH_GLUSTERFS/lk_owner as hex

svn path=/trunk/; revision=42940
 2012-05-31 08:56:19 +00:00
Pascal Quantin
48fee70339 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7307 
svn path=/trunk/; revision=42939
 2012-05-31 08:25:00 +00:00
Anders Broman
867de6145e From Sheetal Kshirsagar and Andrew Williams: 
Updating the RPL SRH dissector and implementing RPL Options header dissection.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986

svn path=/trunk/; revision=42937
 2012-05-31 07:25:11 +00:00
Anders Broman
fc19f32931 Try to squelch a couple of warnings 
svn path=/trunk/; revision=42936
 2012-05-31 05:42:02 +00:00
Gerald Combs
37af1a5f94 Add some needed parenthesis as pointed out by Jakub and the OS X 
builders.

svn path=/trunk/; revision=42935
 2012-05-30 23:14:07 +00:00
Jakub Zawadzki
14bfedccd9 Revert r42853, cleanup packet-jxta which might really fix CID 280210 
References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00226.html

svn path=/trunk/; revision=42932
 2012-05-30 22:39:56 +00:00
Gerald Combs
22d347ae3e In recent versions of GLib (test with 2.32) g_log_default_handler 
helpfully ignores G_LOG_LEVEL_INFO and G_LOG_LEVEL_DEBUG messages by
default. If the console_log_level preference includes either of those
two levels set the G_MESSAGES_DEBUG environment variable so that those
messages are printed.

Add checks for various console log messages to the stdin capture suite.

Fixes bug 7265.

svn path=/trunk/; revision=42930
 2012-05-30 21:42:24 +00:00
Jeff Morriss
6341191d72 From Richard Sharpe on -dev: 
Attached is a patch that fixes (I think) the handling of extended
responses on NTCreate&X requests.

svn path=/trunk/; revision=42923
 2012-05-30 18:29:37 +00:00
Pascal Quantin
59b621e67b Prefix TransportFormatSet_type_enum values with NBAP_ to avoid a clash with 'PCH' in <WinNT.h> 
svn path=/trunk/; revision=42922
 2012-05-30 18:27:40 +00:00
Chris Maynard
b35b911748 Mark pinfo as unused. Change args to proto_tree_add_text(). 
svn path=/trunk/; revision=42921
 2012-05-30 17:26:00 +00:00
Chris Maynard
39d4fbeb52 PPP CCP improvements. And yay, checkAPIs no longer complains about the number of useless add_text()'s since the ratio is finally below 50%. This ratio should continue to drop as more and more fields become filterable. 
svn path=/trunk/; revision=42920
 2012-05-30 17:02:44 +00:00
Anders Broman
79e91685b7 Stab at DCH 31 dissection. 
svn path=/trunk/; revision=42915
 2012-05-30 14:04:45 +00:00
Anders Broman
a307c8318d Dissect non segmented MiB and SiB:s 
svn path=/trunk/; revision=42914
 2012-05-30 11:48:05 +00:00
Pascal Quantin
d9b845534d Use ett variable for proto_item_add_subtree function call 
svn path=/trunk/; revision=42913
 2012-05-30 08:49:56 +00:00
Jakub Zawadzki
4c3735771a Fix bug #5077 in IPv6. 
svn path=/trunk/; revision=42909
 2012-05-30 05:39:39 +00:00
Jakub Zawadzki
a2dac52152 Cleanup geoip support in ipv6. 
svn path=/trunk/; revision=42908
 2012-05-30 05:33:37 +00:00
Pascal Quantin
86dd3248f6 Avoid using C99 '%hh' length modifier 
svn path=/trunk/; revision=42904
 2012-05-29 21:51:52 +00:00
Pascal Quantin
3f07cc05bc From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7301: 
Dissector for DVB Application Information Table (AIT)

svn path=/trunk/; revision=42903
 2012-05-29 21:36:39 +00:00
Pascal Quantin
0e557f4421 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7302: 
Small updates to ISO 7816 dissector

svn path=/trunk/; revision=42902
 2012-05-29 21:09:46 +00:00
Pascal Quantin
8b72c6506e From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7303 
Remove unnecessary null checks before calling proto_item_set_len() in DVB-CI dissector

svn path=/trunk/; revision=42901
 2012-05-29 20:28:41 +00:00
Jakub Zawadzki
dfa5a78130 Fix bug #7304, stupid mistake. 
svn path=/trunk/; revision=42900
 2012-05-29 20:27:22 +00:00
Jakub Zawadzki
e5be60bc81 Fix bug #5735 
dissect_attribute_value_pairs() should be also called with NULL tree.
Broken from r29964.

svn path=/trunk/; revision=42899
 2012-05-29 20:01:25 +00:00
Anders Broman
2a7bef2cb0 Handle E-DCH 
svn path=/trunk/; revision=42898
 2012-05-29 14:34:34 +00:00
Ronnie Sahlberg
5f04a8404b SCSI SBC: Add dissection of GET_LBA_STATUS command 
svn path=/trunk/; revision=42897
 2012-05-29 11:25:38 +00:00
Anders Broman
8d6b6f58d6 From Deepti Ragha: 
Additions to the ARP dissector as per the IANA specifications for ARP

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7216

svn path=/trunk/; revision=42895
 2012-05-29 08:00:35 +00:00
Anders Broman
7aa5527274 From Aditya Ambadkar and Diana Chris: 
Enhancement to LDP dissector to support changes proposed in RFC6391 - flow aware transport of PW over an MPLS PSN.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7046

svn path=/trunk/; revision=42894
 2012-05-29 07:45:40 +00:00
Anders Broman
859f794544 From Evan Huus: 
Fix to
BACapp item length causes Buildbot crash output: randpkt-2011-04-13-1899.pcap

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5825

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7296

svn path=/trunk/; revision=42893
 2012-05-29 07:31:38 +00:00
Guy Harris
1020c20d9e From Erwin Rol: fix a copy-and-paste leftover. 
svn path=/trunk/; revision=42890
 2012-05-29 00:05:39 +00:00
Pascal Quantin
a891f54067 Keep backward compatibility with UDP framing format for UMTS RLC dissector 
Fix a few typo errors while we are at it

svn path=/trunk/; revision=42889
 2012-05-28 20:34:27 +00:00
Anders Broman
091138dafe Use C/T as rbid 
svn path=/trunk/; revision=42888
 2012-05-28 20:11:59 +00:00
Anders Broman
1c9920ada6 Use ett instead of hf variable 
svn path=/trunk/; revision=42887
 2012-05-28 20:09:00 +00:00
Chris Maynard
3e52049ff5 Fix Coverity CID's 702388 and 702422: OVERFLOW_BEFORE_WIDEN. 
svn path=/trunk/; revision=42886
 2012-05-28 18:37:10 +00:00
Anders Broman
b74438e41d Set but not used variable 
svn path=/trunk/; revision=42885
 2012-05-28 17:55:47 +00:00
Anders Broman
4312a9dd61 Remove C++ style comments initilize some variables. 
svn path=/trunk/; revision=42884
 2012-05-28 16:00:20 +00:00
Jakub Zawadzki
5020a3f170 While iterating over string characters don't use strlen(), but check for NUL. 
svn path=/trunk/; revision=42883
 2012-05-28 15:59:00 +00:00
Anders Broman
bb08a70594 Set SVN properties. 
svn path=/trunk/; revision=42882
 2012-05-28 15:30:09 +00:00
Anders Broman
136ad63adf Set SVN properties. 
svn path=/trunk/; revision=42881
 2012-05-28 15:29:36 +00:00
Anders Broman
14eb5154ac From Erwin Rol: 
Artnet, RDM and DMX dissector updates

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7286

svn path=/trunk/; revision=42880
 2012-05-28 15:24:54 +00:00
Anders Broman
55261641d9 Extend the switch statement. 
svn path=/trunk/; revision=42879
 2012-05-28 15:09:33 +00:00
Anders Broman
d52a12c60e Move defenition of rlc_mode. 
svn path=/trunk/; revision=42878
 2012-05-28 14:50:54 +00:00
Anders Broman
2a412f000b Try to pacify the Ubuntu buildbot. 
svn path=/trunk/; revision=42877
 2012-05-28 13:53:33 +00:00
Anders Broman
d8ddd39c3d Enhance CHANNEL_HSDSCH dissection. 
svn path=/trunk/; revision=42876
 2012-05-28 13:38:40 +00:00
Ronnie Sahlberg
4baba1c684 Sometimes you might have plaintext LDAP for a SASL LDAP connection if the handshake never occured. 
Observed with exchange in some configurations.

From Matthieu Patou <mat@matws.net>


svn path=/trunk/; revision=42875
 2012-05-28 09:40:54 +00:00
Gerald Combs
7e5bc5d6ca [Automatic manuf, services and enterprise-numbers update for 2012-05-27] 
svn path=/trunk/; revision=42862
 2012-05-27 14:03:33 +00:00
Gerald Combs
3e24d3bbce Add a null check to fix Coverity CID 280210. It doesn't look like we'd 
run into this in the wild.

svn path=/trunk/; revision=42853
 2012-05-25 18:25:31 +00:00
Chris Maynard
cd7c8f671b Fix Coverity CID 700177 Unused pointer value. 
svn path=/trunk/; revision=42849
 2012-05-25 02:51:23 +00:00
Chris Maynard
22415dc211 The rest of the fix for Coverity CID's 280507 and 280508. (There were multiple occurrences grouped into the 2 CID's, but I hadn't noticed them all.) 
svn path=/trunk/; revision=42848
 2012-05-25 02:43:39 +00:00
Chris Maynard
c0b55e486a tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280507 and 280508. 
svn path=/trunk/; revision=42847
 2012-05-25 02:18:49 +00:00
Chris Maynard
973b45c401 Add a "fallthrough" comment to avoid a missing break report from Coverity. Fixes Coverity CID 702382 Missing break in switch. 
svn path=/trunk/; revision=42845
 2012-05-25 01:49:49 +00:00
Chris Maynard
814682d0d8 Fix Coverity CID 701035: Dereference after null check of hfinfo. 
svn path=/trunk/; revision=42843
 2012-05-25 01:14:29 +00:00
Chris Maynard
3445d93bf2 Fix Coverity CID 700201: Dereference after null check, by ensuring "decoder" is not NULL before passing it to ssl_decrypt_record(). 
svn path=/trunk/; revision=42842
 2012-05-25 00:54:49 +00:00
Chris Maynard
8fd9342f7d tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID 281367. 
svn path=/trunk/; revision=42840
 2012-05-25 00:29:46 +00:00
Chris Maynard
0c49176411 tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280233-280235. 
svn path=/trunk/; revision=42839
 2012-05-24 23:35:23 +00:00
Chris Maynard
b7e5cce721 Update asn1-generated dissector. 
svn path=/trunk/; revision=42838
 2012-05-24 23:31:38 +00:00
Chris Maynard
06606bb68f tvb_reported_length_remaining() can return a negative number. In dissect_gadu_gadu_userlist80_compressed(), bail out if it does. Fixes Coverity CID 703085. In dissect_gadu_gadu_stringz_cp1250(), be sure to compare against its return value as being only positve rather than non-zero. Also, fixed a couple of typos. 
svn path=/trunk/; revision=42837
 2012-05-24 23:14:30 +00:00
Jakub Zawadzki
c09a95a0e3 Fix bug #7283 
When Engine ID is 128 we should only break when we know the enterprise id.

svn path=/trunk/; revision=42825
 2012-05-24 12:26:34 +00:00
Anders Broman
d40cb34ba9 From Martin Kaiser: 
RVALS() needs BASE_RANGE_STRING 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7282

svn path=/trunk/; revision=42823
 2012-05-24 09:17:11 +00:00
Anders Broman
a51cd8a036 From Mayuresh Raut. 
Addition of DDMAP TLV and Downstream FEC stack change sub-TLV to DDMAP [RFC 6424]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7006

svn path=/trunk/; revision=42819
 2012-05-24 06:55:18 +00:00
Pascal Quantin
25e70c04d7 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7275 : 
iso7816: dissect ATR (answer to reset)

svn path=/trunk/; revision=42814
 2012-05-23 20:51:38 +00:00
Jakub Zawadzki
401dba8987 Fix bug #7277 
Check tvb length before fetching data.

svn path=/trunk/; revision=42812
 2012-05-23 12:20:15 +00:00
Anders Broman
551dcff815 Dissect MAC and RLC for CHANNEL_FACH_FDD 
svn path=/trunk/; revision=42811
 2012-05-23 10:47:52 +00:00
Anders Broman
714705bfe8 Add conv_id.h 
svn path=/trunk/; revision=42810
 2012-05-23 07:27:35 +00:00
Anders Broman
33794c58a0 Add file missing from http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=42806 
svn path=/trunk/; revision=42809
 2012-05-23 07:13:43 +00:00
Anders Broman
0832853fa8 From Robert Bullen: 
The Wireshark and tshark TCP conversations stats tables aggregate reused connections into a single line item

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7248

svn path=/trunk/; revision=42806
 2012-05-23 06:36:47 +00:00
Anders Broman
a6deef666c Fix a typo 
svn path=/trunk/; revision=42805
 2012-05-23 06:26:46 +00:00
Anders Broman
ab58c26ff3 From Jim Wright: 
Enhance the DTN dissector so that it understands ECOS blocks (Extended Class of Service)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7242

svn path=/trunk/; revision=42804
 2012-05-23 06:25:00 +00:00
Bill Meier
8f5f906146 All: 
- whitespace cleanup;
   - Remove redundant code;

   packet-ymsg.c:
   - Check if bytes available before doing tvb fetch for heuristic check;
   - Required tcp pdu "fixed part length" is 10 (not 8);
   - Use val_to_str_const() as appropriate;
   - Remove some unneeded initializations.

svn path=/trunk/; revision=42802
 2012-05-23 03:26:35 +00:00
Bill Meier
e72c6574ef From Evan Huus: "Fix Potential padding issues in Yahoo dissectors" 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7276

svn path=/trunk/; revision=42801
 2012-05-23 03:22:51 +00:00
Chris Maynard
509917229b Fix Coverity CID 703086: Dereference after null check in decode_tcp_ports(). 
svn path=/trunk/; revision=42798
 2012-05-23 00:56:15 +00:00
Jeff Morriss
a59aa64da4 Fix: packet-gsm_a_gm.c:3965:6: error: comparison is always true due to limited range of data type [-Werror=type-limits] 
svn path=/trunk/; revision=42797
 2012-05-22 23:59:41 +00:00
Guy Harris
dba158c167 Suppress a (legitimate) compiler warning for now, and leave a comment 
indicating that we should do *something* about nanoseconds values >= 1
billion.

svn path=/trunk/; revision=42796
 2012-05-22 23:57:54 +00:00
Jakub Zawadzki
261fb63ec4 nflog dissector: 
- dissect NFULA_TIMESTAMP as 16B time.
 - fix byte_order_types (selecting BE selected little endian)

svn path=/trunk/; revision=42793
 2012-05-22 22:34:57 +00:00
Anders Broman
4e7d87caa2 Fix PCH dissection 
svn path=/trunk/; revision=42791
 2012-05-22 21:12:59 +00:00
pascal
9746c22630 Dissect Operator Specific Use container in Protocol Configuration Options IE 
Put protocol and container ID in a subtree

svn path=/trunk/; revision=42790
 2012-05-22 20:34:20 +00:00
Anders Broman
e460267b82 Set paging indication and start fixing TFI list. 
svn path=/trunk/; revision=42783
 2012-05-22 15:39:12 +00:00
Jeff Morriss
913455d3b3 Get rid of non-ASCII chars. Remove a few trailing commas. 
svn path=/trunk/; revision=42782
 2012-05-22 14:00:19 +00:00
Anders Broman
ec5ec34f1f Collect and use E-DCH data. 
svn path=/trunk/; revision=42779
 2012-05-22 11:53:12 +00:00
Ronnie Sahlberg
2a2dc8c5f3 TCP: Some protocols running ontop of TCP needs the PDUs to be delivered in order. for example decryption of DCERPCoverHTTP. 
For such protocols, hte state gets out of sync of for example the same PDU is invoked twice in a row, which sometimes can happen if there is tcp retransmission and we see the same PDU twice. First for hte original segment and a second time for the tcp retransmission.
These protocols might lack an easy way to detect that a PDU is seen twice or out of order.

To handle this a little better, offer a TCP option that defaults to being disabled but when enabled skips invoking any subdissector for retransmitted or out of order packets.
(For some virtualization environments it sometimes becomes VERY common to see false tcp retransmissions due to segments being captured twice making this even worse)


We dont want this option to default to ON because for most cases we do want the current behaviour where the subdissector is called twice, or more, for any PDU that is retrasnmitted on the TPC layer.
For example, assume a SMB response packet is retransmitted on the TCP level.
This may result in a capture file that looks like
1 -> SMB request
2 <- SMB response to 1  
... 1 second ...
3 <- SMB response to 1   TCP retransmission

For this case we definitely want packet 3 to be passed to the SMB layer so that 
the request/respons ematching will detect that the response time for this transaction was > 1.0 second
We want smb.time to indicate the delta betwenn packets 1 and 3
as well as the SMB Service Response Time to indicate that this command took very long.





svn path=/trunk/; revision=42774
 2012-05-22 07:51:12 +00:00
Ronnie Sahlberg
7e0c167eb0 HTTP: RPC/HTTP do a better detection and parsing of RPC over HTTP 
From Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=42773
 2012-05-22 06:23:36 +00:00
Ronnie Sahlberg
b3bfefd03c packet-smb2: dissect the channel sequence in the SMB 2.2 header 
From Stefan Metzmacher <metze@samba.org>

svn path=/trunk/; revision=42772
 2012-05-22 05:56:39 +00:00
Ronnie Sahlberg
ba54127556 SMB: Add dissection of TRANS2_REQUEST_TRANSPORT_ENCRYPTION messages 
From Stefan Metzmacher <metze@samba.org>

svn path=/trunk/; revision=42771
 2012-05-22 05:55:05 +00:00
Ronnie Sahlberg
50b992d139 SMB: Dissect TRANS2_SET_FS_INFORMATION infolevel 
From Stefan Metzmacher <metze@samba.org>

svn path=/trunk/; revision=42770
 2012-05-22 05:53:28 +00:00
Ronnie Sahlberg
920b760f15 SMB: Call dissect_nt_quota() via a new dissect_sfsi_request/response() 
From Stefan Metzmacher <metze@samba.org>


svn path=/trunk/; revision=42769
 2012-05-22 05:51:16 +00:00
Ronnie Sahlberg
4ded3c7fe0 SMB2: Add dissection of the encrypted SMB2 headers 
From Matthieu Patou <mat@matws.net>


svn path=/trunk/; revision=42768
 2012-05-22 05:48:55 +00:00
Ronnie Sahlberg
cf0a6d0b96 SMB2: Add support for the "encrypted" flag for shares 
From Michael Adam <obnox@samba.org>

svn path=/trunk/; revision=42767
 2012-05-22 05:46:47 +00:00