Commit Graph

35539 Commits

Author SHA1 Message Date
Jakub Zawadzki e21e71e46e Add generic tvb_get_bits_buf() which accepts any no_of_bits.
svn path=/trunk/; revision=37217
2011-05-17 22:20:14 +00:00
Guy Harris 1372515b02 More eradication of old-style function definitions.
svn path=/trunk/; revision=37216
2011-05-17 22:18:32 +00:00
Guy Harris 592f0ba6da Declare wtap_dump_has_name_resolution().
svn path=/trunk/; revision=37215
2011-05-17 22:17:04 +00:00
Jeff Morriss 82a8d6b153 Add a filterable item for the length of the GT digits in a subtree under the
digits.

Since we now have a subtree from which to hang things, make the generic (called
or calling) digits fields visible under this new subtree (one less hidden item).

Don't use add_string_format() to add the GT digits, let epan format it for us.
Use more descriptive field descriptions for these entries.

svn path=/trunk/; revision=37214
2011-05-17 21:59:58 +00:00
Guy Harris 4ae55217d0 This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.

svn path=/trunk/; revision=37212
2011-05-17 21:28:07 +00:00
Guy Harris da1403c6dd This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.

svn path=/trunk/; revision=37211
2011-05-17 21:26:25 +00:00
Gerald Combs b216f4b2ac Fix docbook errors.
svn path=/trunk/; revision=37210
2011-05-17 21:00:58 +00:00
Guy Harris 092b0120ae Don't leave the truncation flag unset in any of the info level
dissectors.

svn path=/trunk/; revision=37209
2011-05-17 20:04:22 +00:00
Jeff Morriss 99a76aca46 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5875 :
Error out if the user asked us to install dumpcap with a particular group but
we are not building dumpcap.

svn path=/trunk/; revision=37208
2011-05-17 19:59:18 +00:00
Michael Tüxen a385b7c9f3 * Don't declare a used arg as unused.
* Really clear the EOF flag. This fixes a bug where
  tshark is not able to do a live capture from a pcapng
  file.

svn path=/trunk/; revision=37207
2011-05-17 19:51:55 +00:00
Gerald Combs 11dec46275 Update the release notes for 1.7/1.8.
svn path=/trunk/; revision=37206
2011-05-17 19:26:00 +00:00
Jeff Morriss cdedb31e94 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).  A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.

Store the return value of match_strval() rather than calling it repeatedly.

svn path=/trunk/; revision=37204
2011-05-17 18:58:40 +00:00
Jeff Morriss c204df4719 Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).

svn path=/trunk/; revision=37203
2011-05-17 18:53:35 +00:00
Jeff Morriss ec460c3e99 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).

svn path=/trunk/; revision=37202
2011-05-17 17:40:26 +00:00
Jeff Morriss 7a93fdab12 Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.

svn path=/trunk/; revision=37201
2011-05-17 16:07:24 +00:00
Chris Maynard 568fdf18a7 All ELEM_MAND_* macros ensure curr_len > 0; no need to check again afterwards.
Resolves Coverity CIDs 381-382.

svn path=/trunk/; revision=37200
2011-05-17 14:41:01 +00:00
Anders Broman 5a0acb469e Use the correct value string and bitmasks.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5928

svn path=/trunk/; revision=37199
2011-05-17 08:23:30 +00:00
Jörg Mayer 619dad545b Update to FindGTK2 from cmake 2.8.3. Add back quartz options which
are not part of the official cmake release.

svn path=/trunk/; revision=37198
2011-05-17 04:20:35 +00:00
Guy Harris 96e2a4ffea According to MS-NLMP, the "version" field in the NTLMSSP blobs is
present only if the NTLMSSP_NEGOTIATE_VERSION flag is set in the flags
field, and that appears to be true in at least one capture I've seen.

svn path=/trunk/; revision=37197
2011-05-17 02:29:43 +00:00
Guy Harris 0f1503ef8a Fix cut-and-pasteo.
svn path=/trunk/; revision=37196
2011-05-17 01:38:28 +00:00
Guy Harris 91200c27a3 Dear GLib Developers:
Thank you very much for using "gulong" rather than "gsize" as the
"buffer length" argument to g_snprintf(), the fact that the
corresponding argument to snprintf() is a size_t nonwithstanding. 
Developers building for LLP64 platforms such as Win32 greatly appreciate
this decision.

svn path=/trunk/; revision=37195
2011-05-17 00:08:47 +00:00
Bill Meier bf271ce2d0 From beth.tridium [At] gmail.com: 6LoWPAN dissector selects wrong byte for HC_UDP Encoding subtree
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5926

svn path=/trunk/; revision=37194
2011-05-16 23:15:08 +00:00
Guy Harris 9927d1ff31 Give the UNIX-extension routines used for info levels that appear both
in set and get names beginning with dissect_qspi_.

svn path=/trunk/; revision=37192
2011-05-16 22:55:22 +00:00
Michael Tüxen 55f70620c0 Add support for capturing from multiple interfaces.
This patch is basedon work done by Irene Ruengeler.

This feature is considered experimental at the moment.
However, you need to use the -t command line option
to use the feature. When not providing it, the old
method will be used.

svn path=/trunk/; revision=37191
2011-05-16 21:56:12 +00:00
Guy Harris f153eb070b Cast away some warnings about alignment; ep_alloc() guarantees
sufficient alignment for all types of data.

svn path=/trunk/; revision=37190
2011-05-16 21:42:49 +00:00
Chris Maynard 4530909323 A gboolean is a gint; technically, it doesn't fit in a bit field of length 1,
so eliminate the bit field.  Fixes Coverity CIDs 1195-1196.

svn path=/trunk/; revision=37189
2011-05-16 20:33:39 +00:00
Chris Maynard 332d669f74 Fix endian issues, especially w/endian arg to proto_tree_add_item().
Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5464.

svn path=/trunk/; revision=37188
2011-05-16 20:02:14 +00:00
Chris Maynard 36506f2f55 #include <conio.h> when compiling under Windows with DEBUG_DUMPCAP defined.
svn path=/trunk/; revision=37187
2011-05-16 19:56:27 +00:00
Guy Harris 88fe523c48 Fix some comments.
Get rid of null-pointer tests for t2i in the "not null" branch of an
earlier test whether it's null, as those tests are redundant.

Use a switch statement to check the subcommand for Trans2.

If t2i->info_level is -1, it means we don't know the info level, for
whatever reason (e.g., the request was cut short by the snapshot length
before the info level).  Report it as such.

svn path=/trunk/; revision=37183
2011-05-16 18:32:35 +00:00
Jeff Morriss e96cd69468 Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.

svn path=/trunk/; revision=37181
2011-05-16 17:02:22 +00:00
Michael Tüxen 37b16db8f2 Use correct variable...
svn path=/trunk/; revision=37180
2011-05-16 16:27:42 +00:00
Michael Tüxen 64297b9be0 Fix compilation on windows (hopefully).
svn path=/trunk/; revision=37179
2011-05-16 15:25:33 +00:00
Michael Tüxen 70ae440e15 Make remote capturing settings a per interface thing. You can now
configure that you want to capture on multiple remote interfaces
on mulitple hosts.
Improve some #ifdef mess in dumpcap.

svn path=/trunk/; revision=37178
2011-05-16 15:19:54 +00:00
Anders Broman 313dbdb114 Remove extra ;
svn path=/trunk/; revision=37177
2011-05-16 14:42:34 +00:00
Michael Tüxen 122452f864 Make pcap samping a per interface setting.
Use consistent naming of variables on capture_options.
Make pcap sampling independent of remote capturing, since
it seems to work local pcap devices using winpcap (at
least that is what the documentation says).

svn path=/trunk/; revision=37176
2011-05-16 14:12:35 +00:00
Anders Broman 0cb247defc More GUIManager stuff.
svn path=/trunk/; revision=37175
2011-05-16 06:28:33 +00:00
Michael Tüxen 448fdb60b3 * Fix a bug when printing a pointer.
* Remove number_of_ifaces, since ifaces->len can be used instead.

svn path=/trunk/; revision=37174
2011-05-16 00:55:04 +00:00
Michael Tüxen 9a2ba01e85 Don't use debug output.
BTW: Why does compilation fail with it being enabled?

svn path=/trunk/; revision=37173
2011-05-16 00:19:47 +00:00
Michael Tüxen 2d2815b5d1 Fix compilation on Windows (hopefully).
svn path=/trunk/; revision=37172
2011-05-15 23:41:21 +00:00
Michael Tüxen 03d7987ba6 Change internal data structures to store and handle mulitple
pcap devices / pipes to capture from and open and close them.
However, capturing currently happens only on the last specified
interface.
So this does not add user visible functionality except that
some bugs are fixed. For example a crash when capturing on
a pipe and saving in pcapng format.

svn path=/trunk/; revision=37171
2011-05-15 22:54:52 +00:00
Bill Meier 5a54b1d742 Mark a function arg as unused.
svn path=/trunk/; revision=37170
2011-05-15 21:28:21 +00:00
Bill Meier c4a6e2f044 Replace a number if 'if(...){exit(10);}' by _g_asserts;
Fix an event callback function signature;
Change quit() signal calback function to return void;
#include <stdlib.h> not req'd;
Misc minor changes.

svn path=/trunk/; revision=37169
2011-05-15 21:12:55 +00:00
Bill Meier e9326d7152 Don't assign to an unused variable;
#include <stdlib.h> not req'd

svn path=/trunk/; revision=37168
2011-05-15 21:09:04 +00:00
Gerald Combs cdca166a64 Fix the ChmodBPF startup item permissions. Handling this within
PackageMaker would be a more correct fix. Replacing PackageMaker with
something that fits our development and deployment model would be an
even more correct fix.

svn path=/trunk/; revision=37167
2011-05-15 19:25:50 +00:00
Bill Meier 6a5644b497 Replace some 'if(...){exit(10);}' by g_asserts;
Fix some event callback functon signatures;
Change the "destroy" callback function (quit()) to return void: It's not an event callback.
Do some whitespace cleanup.

svn path=/trunk/; revision=37166
2011-05-15 19:01:38 +00:00
Alexis La Goutte d4a80250c0 Add EUI64 display type for Source/Target Link-layer Address (RFC4861)
svn path=/trunk/; revision=37165
2011-05-15 18:48:39 +00:00
Stig Bjørlykke c479a32028 Mark an unused argument.
svn path=/trunk/; revision=37163
2011-05-15 17:54:33 +00:00
Alexis La Goutte d05788974e From Colin O'Flynn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5921
Fix for RPL DAO-ACK Processing when DODAG ID present

Reported and fixed by Jakob Ruhe

svn path=/trunk/; revision=37162
2011-05-15 17:47:56 +00:00
Martin Mathieson 6c57efee2a Add missing trailing 0 to an hf mask value.
svn path=/trunk/; revision=37160
2011-05-15 16:52:05 +00:00
Bill Meier da1fcc2347 Use correct signature for event callback functions;
Use event callback function user_data arg instead of using a property;
Replace an 'if(...) {... exit(10);}' by a g_assert;
Remove several unneeded 'if(...) {... exit(10);}' groups of code;
Do whitespace cleanuip.

svn path=/trunk/; revision=37159
2011-05-15 16:51:21 +00:00