osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
14616 commits 26 branches 0 tags 795 MiB
Commit graph

2765 commits

Author SHA1 Message Date
Anders Broman
28b803303d Dissector for ISUP over TCP. 
svn path=/trunk/; revision=14565
 2005-06-06 18:01:58 +00:00
Anders Broman
44ef4de0d5 Fix a typo and add an ifdef 
svn path=/trunk/; revision=14562
 2005-06-06 17:07:04 +00:00
Anders Broman
ae1add1c13 From Mike Duigou: 
a patch which adds support for displaying jxta 
conversations and endpoints from the 'Statistics' menu. Also adds :

  - a generated field to Welcome messages to indicate whether this 
welcome is from the initiator or the receiver. You can filter on this 
field with 'jxta.welcome.initiator==[0|1]'

  - Marks the source and destination fields of message added in the last 
patch as generated fields. (Saw it being done for some other protocol).

  - Cleans up dissection of Message which used to assume it would 
dissected more than one set of hdr/message per tvbuff. Now it only 
attempts to dissect one.

- Uses GMemChunk for tap info and for conversation data rather than 
g_malloc() There's still a major leakage of g_malloc()ed the c-strings 
which are used in jxta addresses. Any suggestions for how these can be 
allocated such that they can be freed re-init is called would be 
appreciated. For address objects whose data ptr doesn't point into a 
tvbuff it's not clear what the lifecyle of an address object is.

  - Fixes a bug with filling in the of the transport layer conversation 
data. >= vs. >


svn path=/trunk/; revision=14558
 2005-06-06 15:20:10 +00:00
Anders Broman
45fb18a2d6 From Mike Duigou: 
a patch to to_str.c which adds support for printing 
AT_STRINGZ address type. Amazing that this wasn't there!

svn path=/trunk/; revision=14557
 2005-06-06 15:17:41 +00:00
Anders Broman
0d7fce8c7d From Richard Rabbat: 
a patch for a couple of fixes to rsvp sub-objects.

svn path=/trunk/; revision=14555
 2005-06-06 13:55:47 +00:00
Ulf Lamping
960f3e60b4 if some PER errors has to be put to the stderr, give at least info where it's coming from (__FILE__ and __LINE__) 
BTW: time for something like a "NotImplementedException"?!?, this seems to be a common mechanism, if a dissector hasn't implemented all protocol elemements (yet)

svn path=/trunk/; revision=14554
 2005-06-04 22:05:50 +00:00
Ulf Lamping
41b7272c0e fix #225-#231: the enum lmp_filter_keys contained holes, so the logic to detect the field type failed, resulting in the bug 
svn path=/trunk/; revision=14552
 2005-06-04 21:39:36 +00:00
Luis Ontanon
a547ad95eb Give the user the ability to decide how to decode USER DLTs 
svn path=/trunk/; revision=14551
 2005-06-04 19:22:39 +00:00
Ulf Lamping
b59c893573 fix #201 second part: adapt the string length of the unformatted text, so it won't show \000 and beyond 
svn path=/trunk/; revision=14550
 2005-06-04 11:47:38 +00:00
Luis Ontanon
9b1c4525df fix the PDU list, and put it at the bottom 
svn path=/trunk/; revision=14544
 2005-06-03 14:02:06 +00:00
Luis Ontanon
8a975571a3 keywords and eol-style 
svn path=/trunk/; revision=14543
 2005-06-03 13:54:34 +00:00
Luis Ontanon
6cb47c1a7a - add a way to call the sscop dissector with an arbitrary handle\ 
- make most fields "filterable"
- dissect stat and ustat pdu lists


svn path=/trunk/; revision=14542
 2005-06-03 13:50:30 +00:00
Anders Broman
98de72d588 Register the ISUP dissector to make it callable through 
call_dissector()

svn path=/trunk/; revision=14541
 2005-06-03 09:56:03 +00:00
Anders Broman
f01b2b6197 From Mike Duigou: 
A few doxygen updates and an improved section on 
writing dissectors that don't use tcp_dissect_pdus().

svn path=/trunk/; revision=14537
 2005-06-03 06:35:44 +00:00
Anders Broman
52e6e313ed From Mike Duigou: 
A few doxygen updates and an improved section on 
writing dissectors that don't use tcp_dissect_pdus().

svn path=/trunk/; revision=14536
 2005-06-03 06:34:35 +00:00
Anders Broman
bd44e72c95 From Mike Duigou: 
A minor change to the prototype of tcp_dissect_pdus() 
which uses the function pointer type from packet.h

svn path=/trunk/; revision=14535
 2005-06-03 06:31:58 +00:00
Anders Broman
5df33850a9 From Mike Duigou: 
Extends the jxta dissector to add higher level conversation 
tracking, improved display, tapping and fixes a bug which caused some 
conversations to get lost.

svn path=/trunk/; revision=14534
 2005-06-03 06:29:25 +00:00
Ashok Narayanan
7c75e42fee Updated LMP to handle the latest protocol. Removed old protocol values 
since they are no longer useful.

Manu Pathak <mapathak@cisco.com> contributed these changes


svn path=/trunk/; revision=14533
 2005-06-02 22:49:59 +00:00
Ulf Lamping
b88fc96be7 fix call to show_fragment_seq_tree() reported by buildbot 
svn path=/trunk/; revision=14532
 2005-06-02 22:11:22 +00:00
Ulf Lamping
56a9fe6d2a add a generated toplevel line between the connectionless DCE/RPC protocol and the defragmented DCE/RPC content, to better understand what's going on if defragmentation is done. 
svn path=/trunk/; revision=14531
 2005-06-02 20:55:58 +00:00
Ulf Lamping
b575d97309 use [] not () brackets to indicate [correct] UDP checksum, as this is a generated field 
svn path=/trunk/; revision=14530
 2005-06-02 20:52:13 +00:00
Ulf Lamping
a699e351d1 add length information to "Content-encoded entity body" 
svn path=/trunk/; revision=14529
 2005-06-02 20:03:15 +00:00
Ulf Lamping
d3f821035b fix #223: add another tvb_ensure_bytes_exist() call 
svn path=/trunk/; revision=14528
 2005-06-02 19:31:16 +00:00
Ulf Lamping
e2c3b60280 add a generated toplevel line between the TCP protocol and the desegmented content, to better understand what's going on while desegmenting. 
We'll have to add similar mechanisms for other protocols as well...

svn path=/trunk/; revision=14527
 2005-06-02 18:52:55 +00:00
Ulf Lamping
5c4f877031 bugfix (fuzz_tested): t2i can be zero, test at all places before using it 
svn path=/trunk/; revision=14526
 2005-06-02 18:44:17 +00:00
Ulf Lamping
3c4401b95d bugfix (fuzz_tested): add tvb_ensure_bytes_exist() before adding a fragment at two places, otherwise we get an access violation 
svn path=/trunk/; revision=14525
 2005-06-02 18:39:45 +00:00
Ulf Lamping
9784fa242a add new function proto_tree_move_item(), which will move an already existing proto_item inside the tree (but it can't be moved to a different "tree level") 
svn path=/trunk/; revision=14524
 2005-06-02 18:35:20 +00:00
Ulf Lamping
4984c5e949 show Ethernet and IPX addresses the same way as we do with other fields as well (e.g. IP addresses), first the converted value (e.g. IP address or manufaturer name) and then in brackets the "raw data" 
svn path=/trunk/; revision=14523
 2005-06-02 18:29:29 +00:00
Ulf Lamping
e3e7b4d229 bugfix: don't use match_strval() in combination with format strings (as it may return NULL) but val_to_str() 
I don't know if the output as hex is appropriate, someone with more WBXML knowledge might have a look (however, it's done for unknown values only)

svn path=/trunk/; revision=14522
 2005-06-02 07:29:24 +00:00
Ulf Lamping
e419fe42a9 add the resolved Ethernet addresses to the "Ethernet II" summary line 
svn path=/trunk/; revision=14520
 2005-06-02 00:28:38 +00:00
Ulf Lamping
e1a366b5fc add a reference to the corresponding RFC's of the Differentiated Services field pref setting 
svn path=/trunk/; revision=14519
 2005-06-01 23:47:55 +00:00
Ulf Lamping
7b376820af add some hidden fields to be able to filter on the resolved hostname "ip.host" / "ip.src_host" / "ip.dst_host", this was formerly not possible. 
replace some deprecated proto_tree_add_..._hidden() calls by seperate calls by proto_tree_add_...() and PROTO_ITEM_SET_HIDDEN()

some other cosmetic changes

svn path=/trunk/; revision=14518
 2005-06-01 23:44:24 +00:00
Ulf Lamping
76778cc78b mark some fields as generated and clarify some field descriptions 
svn path=/trunk/; revision=14517
 2005-06-01 21:28:40 +00:00
Ulf Lamping
46ff66522f prevent "Dissector Bug": prevent a string processing of length 0 
svn path=/trunk/; revision=14516
 2005-06-01 19:19:40 +00:00
Ulf Lamping
bb4e980df1 bugfix: use g_snprintf instead of sprintf to prevent a buffer overflow 
svn path=/trunk/; revision=14515
 2005-06-01 19:17:59 +00:00
Ulf Lamping
bc200f879c better dissect ProtSeqs values 
svn path=/trunk/; revision=14508
 2005-05-31 18:31:27 +00:00
Ulf Lamping
06c1482f6c bugfix: remove some not required dissect_dcom_that() calls, as "ORPC that" was errorneously dissected twice 
svn path=/trunk/; revision=14507
 2005-05-31 18:30:37 +00:00
Gilbert Ramirez
46788b3336 Remove bitmasks from field definitions for FT_IPv4 
and FT_IPv6 fields.

svn path=/trunk/; revision=14504
 2005-05-31 14:03:34 +00:00
Ulf Lamping
e821e8a1f2 fix handling, if ArraySize of a BSTR is 0, 
replace a g_assert by DISSECTOR_ASSERT

svn path=/trunk/; revision=14503
 2005-05-31 08:02:24 +00:00
Ulf Lamping
772af896b9 add a tvb_ensure_bytes_exist() to prevent a dissector bug 
svn path=/trunk/; revision=14502
 2005-05-30 22:40:55 +00:00
Ulf Lamping
e8c5cd2342 don't go into an (almost) endless loop, if si->info_count is -1, which is the default value. Seems to be a general bug worth to thought about, but I don't know the SMB internals and this bugfix should work anyway. 
Found this by a privately fuzzed capture file (sorry, can't give it away)

svn path=/trunk/; revision=14501
 2005-05-30 21:10:21 +00:00
Gerald Combs
fe89e3d640 Don't try to check the suboption length type if we don't have a suboption. 
Found by Steve Grubb.  Fixes part of bug 217.

svn path=/trunk/; revision=14499
 2005-05-30 21:04:58 +00:00
Gerald Combs
bcd1c5b9fa From Steve Grubb: Fix buffer and array length checks. Fixes part of bug 217. 
svn path=/trunk/; revision=14498
 2005-05-30 21:01:52 +00:00
Gerald Combs
923446f1f5 From Steve Grubb: Initialize some variables. Fixes part of bug 217. 
svn path=/trunk/; revision=14497
 2005-05-30 21:00:05 +00:00
Gerald Combs
861dc4e340 More bug fixes from Steve Grubb. See bug 217 for details. 
svn path=/trunk/; revision=14496
 2005-05-30 20:58:20 +00:00
Gerald Combs
12b7466381 From Steve Grubb: Fix a memory leak. 
Don't pass a null to atoi().

Fixes part of bug 217.

svn path=/trunk/; revision=14495
 2005-05-30 20:55:16 +00:00
Gerald Combs
1d3ba8764b From Steve Grubb: Fix off by one errors. Fixes part of bug 217. 
svn path=/trunk/; revision=14494
 2005-05-30 20:53:08 +00:00
Gerald Combs
651ee9a2fe From Steve Grubb: Initialize a variable. Fixes part of bug 217. 
svn path=/trunk/; revision=14493
 2005-05-30 20:51:36 +00:00
Gerald Combs
cebf5bc459 Fix an off-by-one error found by Steve Grubb. Steve gets the award 
for longest standing bug found so far.  This has been present since
version 0.5.0.

Fixes part of bug 217.

svn path=/trunk/; revision=14492
 2005-05-30 20:48:12 +00:00
Anders Broman
05376bd969 Add dissection of MSRP 
http://www.ietf.org/internet-drafts/draft-ietf-simple-message-sessions-10.txt

svn path=/trunk/; revision=14491
 2005-05-30 18:39:39 +00:00
Ulf Lamping
cb51c2662a fix highlighting length, if more than one RPC call is in a TCP PDU 
set "n*DCERPC" in the proto column if more than one RPC call in a TCP PDU, overwriting the interface name, as there's probably more than one interface involved

add some more RPC info to the toplevel RPC proto_item

add a comment, if some bytes are not dissected but might be in the next TCP PDU

svn path=/trunk/; revision=14490
 2005-05-30 18:37:19 +00:00
Ronnie Sahlberg
2edd8a7a00 add MMC READ DISC INFORMATION cdb 
svn path=/trunk/; revision=14486
 2005-05-30 12:09:39 +00:00
Ronnie Sahlberg
3b4e688073 add MMC READ TRACK INFORMATION cdb 
svn path=/trunk/; revision=14485
 2005-05-30 11:16:08 +00:00
Ulf Lamping
feb55854c7 fix #215: the field hf_smb_print_spool_file_name used the wrong type, use FT_STRINGZ to add a string 
svn path=/trunk/; revision=14482
 2005-05-30 03:10:37 +00:00
Ulf Lamping
f3037e2f53 add two more tvb_ensure_bytes_exist() calls to fix #216 
When I look at the remaining code, I fear this will become a never ending story :-(

svn path=/trunk/; revision=14481
 2005-05-30 02:58:13 +00:00
Ulf Lamping
c173da9fec fix #201: add format_text before output of the DNS name, in case it contains invalid chars 
svn path=/trunk/; revision=14479
 2005-05-29 13:02:57 +00:00
Ulf Lamping
2b30b539ee fix #86: use format_text before adding version string to the info column 
svn path=/trunk/; revision=14478
 2005-05-29 12:27:31 +00:00
Ulf Lamping
7c07e00f1d fix #11: add a [truncated] to the label, if the message to display is too long 
svn path=/trunk/; revision=14477
 2005-05-29 11:23:42 +00:00
Ronnie Sahlberg
acaf8730be add MMC RESERVE TRACK cdb 
svn path=/trunk/; revision=14476
 2005-05-29 08:45:09 +00:00
Ronnie Sahlberg
bbf29dd862 MMC SET STREAMING command 
svn path=/trunk/; revision=14475
 2005-05-29 08:29:55 +00:00
Jörg Mayer
0fc3001d6a Add minimal 802.11j decoding. There's not fun in doing more unless 
someone provides a capture file.


svn path=/trunk/; revision=14474
 2005-05-29 08:19:11 +00:00
Ronnie Sahlberg
aa7157462c remove offset and len from the signature of dissect_scsi_payload() 
svn path=/trunk/; revision=14473
 2005-05-29 03:18:53 +00:00
Ronnie Sahlberg
e66ff913ff make all callers of dissect_scsi_cdb() first create a new subset tvb 
change the signature for dissect_scsi_cdb since we no longer need to pass offset over.



svn path=/trunk/; revision=14472
 2005-05-29 02:55:12 +00:00
Ronnie Sahlberg
fc9688991f create a subset tvb before calling off to the SCSI dissector 
so that the right part of the hexpane is highlighted when one clicks on an nondissected data line

svn path=/trunk/; revision=14471
 2005-05-29 02:30:49 +00:00
Ronnie Sahlberg
6eb6d5f9af minor prettification 
in the decode pane for the SCSI protocol,
put the name of the CDB on the protocol line


svn path=/trunk/; revision=14470
 2005-05-29 01:54:22 +00:00
Ronnie Sahlberg
ae9968883e update iscsi so that when we have ImmediateData we also call SCSI to decode the 
payload (DATAOUT)  and not just the scsi CDB.



svn path=/trunk/; revision=14469
 2005-05-29 01:49:09 +00:00
Ronnie Sahlberg
3007142732 add MMC READ BUFFER CAPACITY command 
svn path=/trunk/; revision=14467
 2005-05-28 13:29:45 +00:00
Ronnie Sahlberg
5d7e4750d2 add the SynchronizeCache command for MMC 
svn path=/trunk/; revision=14466
 2005-05-28 13:01:14 +00:00
Ulf Lamping
f8b3fe7668 add some tvb_ensure_bytes_exist() calls, fixes #197, #202 and #208 
svn path=/trunk/; revision=14465
 2005-05-28 12:49:19 +00:00
Ronnie Sahlberg
fb65ef09eb updates to mmc, add more dissection of GET_CONFIGURATION and READ_TOC 
svn path=/trunk/; revision=14464
 2005-05-28 12:45:38 +00:00
Ronnie Sahlberg
5c1e7a37de some more MMC4 updates 
svn path=/trunk/; revision=14462
 2005-05-28 08:27:44 +00:00
Ronnie Sahlberg
3df89a9d25 more scsi refactoring 
starting to implement MMC codeset : CDROM/DVD



svn path=/trunk/; revision=14461
 2005-05-28 05:42:39 +00:00
Ronnie Sahlberg
fd6d7dd38e refactor scsi dissector toi be table driven so it will be easier to add new 
commandsets.



svn path=/trunk/; revision=14460
 2005-05-28 03:37:16 +00:00
Olivier Biot
97babfb98d From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one). 
svn path=/trunk/; revision=14459
 2005-05-28 00:51:56 +00:00
Ronnie Sahlberg
0890269d05 from Gilbert, 
make kink compile again on non-kerberos builds.

encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos.


svn path=/trunk/; revision=14458
 2005-05-27 21:39:38 +00:00
Ronnie Sahlberg
6879e6da67 from didier fix for the regression for bug 62 
svn path=/trunk/; revision=14457
 2005-05-27 21:33:27 +00:00
Anders Broman
d328993c0d From Martin Mathieson 
packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)
Missed eralier...

svn path=/trunk/; revision=14456
 2005-05-27 18:35:19 +00:00
Luis Ontanon
4cd25ccc5e don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that 
the string always fits.


svn path=/trunk/; revision=14455
 2005-05-27 18:33:09 +00:00
Gilbert Ramirez
c2454f0260 Add a "-G fields3" report which prints the bitmask of the field, and avoids 
printing the blurb twice, like fields2 does.
Add a script, fsanity.py, to check sanity of FT definitions. Right now the
only check is for bitmasks for integer-like fields.

svn path=/trunk/; revision=14454
 2005-05-27 15:13:09 +00:00
Ronnie Sahlberg
94d8512749 From T.Nakashima 
updates to KINK


svn path=/trunk/; revision=14453
 2005-05-27 08:53:07 +00:00
Ronnie Sahlberg
864245ef6e cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used. 
Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string()

Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string()




svn path=/trunk/; revision=14452
 2005-05-27 06:00:08 +00:00
Guy Harris
cb3bc515e2 The DESIRE_ and OS_ values are bit indices, not numerical values that 
appear by themselves; get rid of the value_string tables for them.

svn path=/trunk/; revision=14450
 2005-05-27 02:30:10 +00:00
Anders Broman
7f936ea1c4 These 2 patches make RDT support pretty complete now: 
From Martin Mathieson:

packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)

packet-rtsp.c:
- improve detection of RDT as the transport
- allow interleaved frame data to be dissected as RDT packets

svn path=/trunk/; revision=14443
 2005-05-26 20:11:35 +00:00
Gerald Combs
4a5deae575 In some places we call proto_tree_add_item() with hfindex and length 
values that may not be valid (e.g. dissect_ber_octet_string()
in packet-ber.c).  If the length is invalid, get_uint_value() or
get_int_value() will abort.  Change them to throw an exception instead.
This keeps us from having to do a lot of extra work in the dissector.

Fixes bug 182.


svn path=/trunk/; revision=14437
 2005-05-26 14:53:39 +00:00
Guy Harris
4a1414164f Add some more reassembly routines. 
svn path=/trunk/; revision=14430
 2005-05-25 08:25:14 +00:00
Ulf Lamping
d35789c6c7 fix IRemUnknown2 UUID 
svn path=/trunk/; revision=14429
 2005-05-24 20:01:08 +00:00
Ulf Lamping
5fd2ecb1d5 add values for STDOBJREF flags 
svn path=/trunk/; revision=14428
 2005-05-24 20:00:14 +00:00
Ulf Lamping
c911c15371 dissect ORPC this/that of RemoteCreateInstance 
svn path=/trunk/; revision=14427
 2005-05-24 19:59:20 +00:00
Ulf Lamping
5812f26b65 dissect ServerAlive response 
svn path=/trunk/; revision=14426
 2005-05-24 19:57:37 +00:00
Gerald Combs
1c650087ac Add extra TLV length checks and signedness fixes. Fixes the infinite loop in 
bug 196.

svn path=/trunk/; revision=14425
 2005-05-24 16:46:18 +00:00
Gerald Combs
1a5605dc21 Throw an exception instead of calling g_assert_not_reached(). Fixes bug 175. 
svn path=/trunk/; revision=14424
 2005-05-24 13:50:20 +00:00
Jörg Mayer
19e90d9a5c Warning fix: 
packet-bacapp.c:1264: warning: ISO C does not allow extra ';' outside of
a function


svn path=/trunk/; revision=14420
 2005-05-23 12:32:37 +00:00
Jörg Mayer
4a6049d3b1 Warning fix: 
packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined


svn path=/trunk/; revision=14419
 2005-05-23 12:19:00 +00:00
Jörg Mayer
83f9a803ac Warning fix: 
packet-bacapp.c:1266:1: warning: C++ style comments are not allowed in ISO C90
packet-bacapp.c:1266:1: warning: (this will be reported only once per input file)


svn path=/trunk/; revision=14418
 2005-05-23 12:18:10 +00:00
Anders Broman
33aa290b25 From Steve Karg: 
* added additional value string enumerations from BACnet-2004
* removed vendor specific value string enumerations
* corrected some value strings enumerations that were incorrect
* refactored some common strings as strings + format
* refactored some value strings to use a reserved range and a 
proprietary range by using val_to_split_str function which now correctly 
shows the split range when a value is not matched.
* corrected some spelling errors
* converted some item text values to dissector registration
* added protocol tree for the BACnet tag headers
* added value strings tree display for some bit string BACnet properties
* added value strings tree display for some enumerated BACnet properties
* changed the conversion of signed, unsigned, and enumerated BACnet 
values to use ntohx functions.
* added proper handling for large values of signed, unsigned, and 
enumerated BACnet values.
* refactored BACnet Null and Boolean Tag tree
* refactored BACnet Real and Double Tag tree
* changed comments into functions for special tags
* changed some white space to match existing file style
* refactored tvb_reported_length to tvb_length_remaining to simplify
* corrected octet-string tree when length is zero
* refactored octet-string tree to use tvb_bytes_to_str
* corrected application tagged productions that were context tagged
* corrected context tagged productions that were application tagged
* corrected offset for BACnet character strings
* refactored some identical service request tree handling
* changed confirmed APDU to highlight the correct portion of the APDU
* changed some dissector registration values to display as decimal
* changed cast in call to iconv() to fix compiler warning
* corrected bit-wise AND in AtomicFile tree handling

packet-bvlc.c
* added error text in tree when encoded length doesn't match actual length

svn path=/trunk/; revision=14417
 2005-05-23 05:52:28 +00:00
Anders Broman
c40a7d2ad9 From Javier Acuna: 
filter packets by their Billing ID

svn path=/trunk/; revision=14409
 2005-05-21 09:13:28 +00:00
Ulf Lamping
d2233711d9 add get_manuf_name_if_known (returns NULL if unknown) in addition to get_manuf_name 
svn path=/trunk/; revision=14405
 2005-05-20 21:44:17 +00:00
Luis Ontanon
98d824e05b dup the filter string so that it can be freed without problems. 
fixes bug 195


svn path=/trunk/; revision=14402
 2005-05-20 19:40:10 +00:00
Luis Ontanon
bc1292ff1d some cosmetic fixes 
svn path=/trunk/; revision=14401
 2005-05-20 19:38:24 +00:00
Anders Broman
416c350db1 Use value_string for codec values/strings. 
svn path=/trunk/; revision=14400
 2005-05-19 20:35:30 +00:00
Anders Broman
b8cd3ff407 Display version number and product number as strings. 
svn path=/trunk/; revision=14399
 2005-05-19 20:34:35 +00:00
Anders Broman
59516e5f4f Add Sony and Nokia VendorID:s 
svn path=/trunk/; revision=14398
 2005-05-19 20:33:59 +00:00
Guy Harris
d444801e4a Clean up indentation. 
Add some comments with questions.

Mark an unused argument as such, and get rid of an unused variable.

svn path=/trunk/; revision=14396
 2005-05-19 09:26:15 +00:00
Luis Ontanon
3f36640526 - add an isup stats_tree with statistics regarding message types and the directions in which they flow. 
svn path=/trunk/; revision=14393
 2005-05-18 13:51:49 +00:00
Anders Broman
443d4bf1c1 Add a dissector for h221 nonstandard data which can easily be expanded with publically avalable data or 
replaced by a propriatary one.

svn path=/trunk/; revision=14392
 2005-05-18 05:44:12 +00:00
Anders Broman
399e571547 Make it possible to dissect h221nonstandard data and fix some compile warnings from asn2eth. 
svn path=/trunk/; revision=14388
 2005-05-17 20:32:30 +00:00
Anders Broman
dadf75a031 From Mark C Brown,: 
Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records.

svn path=/trunk/; revision=14386
 2005-05-17 19:51:09 +00:00
Anders Broman
4968c6f086 From Yuriy Sidelnikov: 
A perfectly good tvb_bytes_to_str() has been used instead of string_to_hex. 

svn path=/trunk/; revision=14384
 2005-05-17 19:21:45 +00:00
Anders Broman
090464f76e Add some more AVP:s. 
svn path=/trunk/; revision=14383
 2005-05-17 19:15:31 +00:00
Anders Broman
dc82444047 Add TCP port for "radan-http 8088/tcp Radan HTTP" from IANA. 
svn path=/trunk/; revision=14378
 2005-05-16 18:24:27 +00:00
Anders Broman
cd773d0e99 Add some more media types. 
svn path=/trunk/; revision=14377
 2005-05-16 18:15:33 +00:00
Anders Broman
a14646212b From Martin Mathieson: 
new version of the RDT dissector.  It turns out that
specs are available for this protocol on www.helixcommunity.org  - this
version was written by myself and Tom Marshall of RealNetworks, Inc.

I Changed stream_id and asm_rule_number to be guint16 to fix compiler warnings.

svn path=/trunk/; revision=14372
 2005-05-16 06:16:45 +00:00
Anders Broman
7263d93115 From Tim Endean: 
Ss-code is Optional in some cases.

svn path=/trunk/; revision=14371
 2005-05-15 21:17:29 +00:00
Ronnie Sahlberg
cb2fc4e58b from martin m 
prettify dcerpc


svn path=/trunk/; revision=14369
 2005-05-14 22:05:56 +00:00
Gerald Combs
f404b15be5 When we catch an exception, make sure we don't throw the same exception again 
(and catch it again in the process).  Fixes bug 170.

svn path=/trunk/; revision=14368
 2005-05-14 21:13:07 +00:00
Ronnie Sahlberg
4c29a93f64 from dinesh 
fix to make Zone_Alias objects decode properly


svn path=/trunk/; revision=14367
 2005-05-14 21:08:20 +00:00
Ronnie Sahlberg
c07f0f0a45 From Guillaume Chazarain 
New protocol : ARMAGETRONAD    dissector for the protcol used by the game of the same name


svn path=/trunk/; revision=14366
 2005-05-14 21:00:43 +00:00
Gerald Combs
7effa95f95 Throw an exception if AndXOffset is less than the current offset. Fixes bug 
163.  I'm not sure if this fix is entirely correct, but it doesn't appear to
have affected any SMB captures here adversely.

svn path=/trunk/; revision=14365
 2005-05-14 19:13:02 +00:00
Ronnie Sahlberg
432a015797 add decoding of teh REMOVABLE bit in inquiry data 
svn path=/trunk/; revision=14364
 2005-05-14 17:41:07 +00:00
Ronnie Sahlberg
ceb1c26871 add a missing field to the REPORT LUNS datain pdu 
svn path=/trunk/; revision=14363
 2005-05-14 17:12:45 +00:00
Luis Ontanon
1eeda6e946 - make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets 
- set COL_INFO to something useful


svn path=/trunk/; revision=14361
 2005-05-13 11:16:05 +00:00
Guy Harris
38c139dce3 Squelch a compiler warning (GCC 4.0's data flow analysis is 
interprocedural, so it knows "sip_parse_line()" doesn't always set
"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE
it *does* always set it, so it's safe not to set it as long as it's
never used if the return value is OTHER_LINE).

svn path=/trunk/; revision=14355
 2005-05-12 02:55:59 +00:00
Guy Harris
bd29cb1267 Fix a routine to return the value it's supposed to return. 
svn path=/trunk/; revision=14354
 2005-05-12 02:51:59 +00:00
Guy Harris
3a8d46d8e9 Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks 
and a tip of the hat to GCC 4.0's interprocedural data flow analysis for
catching this one!).

svn path=/trunk/; revision=14353
 2005-05-12 02:50:27 +00:00
Anders Broman
92b1092937 Reinsert Gerards patch (r14342) which was lost. 
svn path=/trunk/; revision=14352
 2005-05-11 22:20:11 +00:00
Anders Broman
eac5e05d3a pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages. 
svn path=/trunk/; revision=14350
 2005-05-11 22:00:50 +00:00
Anders Broman
0232c81b91 From Viorel Suman: 
Enable a proper deconding of an alphanumeric 7-bit encoded SMS TP-Originating-Address.

svn path=/trunk/; revision=14349
 2005-05-11 21:59:44 +00:00
Ronnie Sahlberg
4e3c7cc716 From Hannes Gredler 
support for Juniper PPPOE encapsulation


svn path=/trunk/; revision=14346
 2005-05-11 11:24:17 +00:00
Ronnie Sahlberg
fcab322ada Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle. 
This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector().


To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0,   meaning   yes there is indeed a protocol registered for this conversation but that protocol rejected this packet.
(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way)

When this happens  the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet.


Update SNMP and TFTP dissectors to  check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector.

Since ethereal keeps track of which frame number a conversation started in, this actually works really well.



svn path=/trunk/; revision=14345
 2005-05-11 10:40:53 +00:00
Luis Ontanon
5535853bf2 - export Audio Codec modes from isup/bicc 
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248


svn path=/trunk/; revision=14343
 2005-05-10 21:54:37 +00:00
Anders Broman
88c39bc93b Fix dissection of mo-forwardSM 
svn path=/trunk/; revision=14342
 2005-05-10 20:09:09 +00:00
Ronnie Sahlberg
39e517a9b3 make SNMP over UDP a new style dissector and add some heuristics to check if this is SNMP or not, 
svn path=/trunk/; revision=14339
 2005-05-10 08:49:27 +00:00
Gerald Combs
c64e5e59f6 Make a field type check more strict. Remove some unnecessary code. 
svn path=/trunk/; revision=14338
 2005-05-10 03:10:09 +00:00
Gerald Combs
cd321f5958 Make sure we don't feed a null string to strncmp(). Fixes bug 161. 
Make sure we don't free static memory.  Fix a small memory leak.

svn path=/trunk/; revision=14337
 2005-05-10 03:08:36 +00:00
Jörg Mayer
78d0e8b33d I just found a packet with an option e. As the value looked very much 
like the mac-address of the switch, I added decoding of option e as
mac address.


svn path=/trunk/; revision=14336
 2005-05-09 11:21:16 +00:00
Lars Roland
9a47db0c3d Add another sanity check to the new SIP URI parser. 
Just to be sure.

svn path=/trunk/; revision=14335
 2005-05-09 01:21:41 +00:00
Lars Roland
74328742ed Some fixes for the new SIP contact header parser. 
svn path=/trunk/; revision=14334
 2005-05-09 01:15:45 +00:00
Lars Roland
20901fcedf only lower-case ASCII letters, numbers, 
underscores, and dots are allowed in the
preference name. 

Fix it the camel dissector.

svn path=/trunk/; revision=14333
 2005-05-09 00:11:03 +00:00
Lars Roland
5f092fe201 Mark a function parameter as unused 
svn path=/trunk/; revision=14332
 2005-05-08 23:29:55 +00:00
Lars Roland
01f10ccd00 When saying that I remove the trailing white spaces I should do it, too. 
So I do it now and do some more reindentation, too.

svn path=/trunk/; revision=14331
 2005-05-08 22:39:38 +00:00
Lars Roland
e5134e2f2d Improve dissection of SIP contact header and counting of bindings in REGISTER messages. 
Introduce a function for disseting a sip uri in general

TODO: 
- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
      by using the new function for uri dissection

svn path=/trunk/; revision=14330
 2005-05-08 22:19:18 +00:00
Lars Roland
429d72c457 Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c. 
svn path=/trunk/; revision=14329
 2005-05-08 21:17:37 +00:00
Anders Broman
fd075dadf0 From Javier Acuna: 
Added some code to dissect DateAndTime.

svn path=/trunk/; revision=14328
 2005-05-08 20:35:44 +00:00
Lars Roland
52d26f6eb8 Increase size of an integer to prevent an integer overflow 
Fixes Bug 162

svn path=/trunk/; revision=14325
 2005-05-07 00:14:11 +00:00
Ronnie Sahlberg
a456014e29 prettify YPSERV 
svn path=/trunk/; revision=14324
 2005-05-06 10:11:08 +00:00
Gilbert Ramirez
61e5a33ea2 A fix for the previous fix for the infinite loop in bootp, bug #160. 
svn path=/trunk/; revision=14323
 2005-05-06 02:08:30 +00:00
Gilbert Ramirez
01a3ed9c58 Check the offset delta while we loop through the options. 
Make sure the delta is > 0.
This intends to fix bug 160, although with a capture file
to test it, I can't be totally sure.

svn path=/trunk/; revision=14322
 2005-05-06 01:56:40 +00:00
Jörg Mayer
b6db235c77 Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p 
svn path=/trunk/; revision=14321
 2005-05-05 17:07:58 +00:00
Guy Harris
fff7cd2f34 Change some data types, and add initializations, to squelch compiler 
warnings.

Fix indentation.

svn path=/trunk/; revision=14315
 2005-05-05 11:05:15 +00:00
Guy Harris
25443a7a87 Change data types to match those of "iconv()", at least on OS X. 
svn path=/trunk/; revision=14314
 2005-05-05 11:03:46 +00:00
Guy Harris
f98e6c2533 Squelch a compiler warning. 
svn path=/trunk/; revision=14313
 2005-05-05 11:02:31 +00:00
Guy Harris
f17c1822cc Re-parenthesize an expression, to squelch a compiler warning. 
svn path=/trunk/; revision=14312
 2005-05-05 10:00:29 +00:00
Guy Harris
73cad260c5 "oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid" 
argument points to, so make it a "const" pointer.

svn path=/trunk/; revision=14311
 2005-05-05 09:40:24 +00:00
Gerald Combs
fe5561715b Don't try to feed a null pointer to strncmp(). Fixes bug 158. 
Shouldn't the number of fuzz bugs decrease asymptotically at some
point?

svn path=/trunk/; revision=14306
 2005-05-04 17:02:56 +00:00
Gerald Combs
0b1b3d5716 From Lars Roland: 
Make sure a hash table exists before trying to access it.  Fixes bug 105.

svn path=/trunk/; revision=14305
 2005-05-04 16:40:30 +00:00
Gerald Combs
c2b4cd7993 Don't roll our own buffer-overflow-able string_to_hex() routine 
when there's a perfectly good tvb_bytes_to_str() lying around, just
_begging_ to be used.

Fix up white space.

svn path=/trunk/; revision=14304
 2005-05-04 15:35:21 +00:00
Uwe Girlich
c1c395dc2d Added RPC/ONC SYSTEM_ERROR accept state. 
svn path=/trunk/; revision=14303
 2005-05-04 13:09:46 +00:00
Anders Broman
be12da7f98 Dissect GPRS user data. 
svn path=/trunk/; revision=14302
 2005-05-03 20:53:21 +00:00
Gerald Combs
985f94ec24 In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw 
a hissy fit.  Fixes bug 157.

svn path=/trunk/; revision=14299
 2005-05-03 19:33:02 +00:00
Gerald Combs
9ab36a73a8 Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be 
neccessary any more, and were causing problems.

svn path=/trunk/; revision=14298
 2005-05-03 18:43:06 +00:00
Gerald Combs
2ab34cb095 Fix two places where we might loop infinitely, including the one found in 
bug 155.  Fix a couple of compiler warnings.

svn path=/trunk/; revision=14289
 2005-05-03 14:36:08 +00:00
Anders Broman
07e46b0c48 From Nils O. Sel?sdal: 
- Decodes all the remaining bitfields in 9P
- Tidies up display a bit (using more subtrees)
- Fixes a few fields that are better off displayed as decimal/octal.


svn path=/trunk/; revision=14287
 2005-05-03 05:22:43 +00:00
Ulf Lamping
4e3c0cde68 move the pn-dcp dissector into the profinet plugin 
svn path=/trunk/; revision=14285
 2005-05-03 01:39:00 +00:00
Gerald Combs
313d9105f3 From Rich Coe: 
- fix memory leak when Assoc packet is processed repeatedly in ethereal

 - removed unused partial packet flag

 - added better support for DICOM VR
     - sequences
     - report actual VR in packet display, if supplied by xfer syntax 
     - show that we are not displaying entire tag string with '[...]',
       some tags can hold up to 2^32-1 chars

 - remove my goofy attempt at trying to get access to the fragmented packets
   (anyone have an idea on how to fix this ???)

 - process all the data in the Assoc packet even if display is off

 - limit display of data in Assoc packet to defined size of the data even
   if reported size is larger

 - show the last tag in a packet as [incomplete] if we don't have all the data

 - added framework for reporting DICOM async negotiation (not finished)
   (I'm not aware of an implementation which currently supports this)

 - still need to fix display of continuation packets

svn path=/trunk/; revision=14280
 2005-05-02 21:56:40 +00:00
Michael Tüxen
b4af92846c Provide an indication to taps if the verification tag is reflected. 
svn path=/trunk/; revision=14278
 2005-05-02 20:45:22 +00:00
Gerald Combs
949a9da364 Break out of an infinite loop. Fixes bug 154. 
svn path=/trunk/; revision=14277
 2005-05-02 20:30:56 +00:00
Anders Broman
a105502f35 Dissect URLC correctly and add dissection of LCC PDU. 
svn path=/trunk/; revision=14276
 2005-05-02 20:26:56 +00:00
Anders Broman
5a2d87c586 Add dissection of q850 cause. 
svn path=/trunk/; revision=14273
 2005-05-02 18:32:00 +00:00
Anders Broman
be5db98edd Correct some AVP:s and minor updates from iana.org 
svn path=/trunk/; revision=14272
 2005-05-02 18:31:15 +00:00
Anders Broman
3f395aec51 Use the correct parameters in a function call. 
svn path=/trunk/; revision=14271
 2005-05-02 18:30:14 +00:00
Gerald Combs
f8765a5a28 From Cvetan Ivanov: 
1) dissect_isup_calling_party_number_parameter reported malformed packet
if the calling party number IE contains empty number (possibly with
presentation set to 'number not available')

I've basicly added if(length > 0) around the digits tree dissector,
which may not be obvious from the patch becase of the indenting of the
entire block.

2) As the tap_calling_number is static, if there is call with missing
calling_party_number IE, it gets assigned the calling party number of
the previuos call containing such IE.

fixed by adding tap_calling_number = NULL;
in the beginning of dissect_isup_message, and

tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");

in the end to avoid segfault

Those things may not happen too often in the telecom world, but happen
all the time with VoIP.


svn path=/trunk/; revision=14268
 2005-05-02 14:41:07 +00:00
Gerald Combs
bf48f8e4d4 Check for a few more integer overflows. Found during fuzz testing. 
svn path=/trunk/; revision=14266
 2005-05-02 14:12:42 +00:00
Michael Tüxen
23d022349d - Add support for libpcap files for MTP2 with a per packet header 
indicating the direction, narrowband/broadband, and interface number.
- Add support to display the direction and interface number.
- Add support to packet-mtp2.c to use the broadband/narrowband indication.

svn path=/trunk/; revision=14265
 2005-05-02 14:07:33 +00:00
Gerald Combs
2e0f4b9750 Fix a couple of infinite loops. Make similar changes elsewhere to keep the 
code consistent.

svn path=/trunk/; revision=14260
 2005-05-02 00:57:44 +00:00
Michael Tüxen
e0d7600bb5 Fix chunk length handling. Go back to initial concept that 
the chunk_length always is the length indicated in the packet header.

svn path=/trunk/; revision=14258
 2005-05-01 21:00:26 +00:00
Gerald Combs
17fa218ed5 Make sure we pass a positive length to proto_item_set_len(). 
svn path=/trunk/; revision=14254
 2005-05-01 13:52:15 +00:00
Ulf Lamping
48aee19b1a move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-) 
svn path=/trunk/; revision=14248
 2005-04-30 20:52:20 +00:00
Gerald Combs
6ba8b243b0 Fix a buffer overflow found during fuzz testing. 
svn path=/trunk/; revision=14247
 2005-04-30 19:37:03 +00:00
Gerald Combs
a416a4b6f5 Check for an integer overflow. Fixes bug 149. 
svn path=/trunk/; revision=14245
 2005-04-30 16:42:04 +00:00
Ronnie Sahlberg
75438b269f From Miklos Szurdi : 
update to GSM_A to display the maximum bit rate properly



svn path=/trunk/; revision=14244
 2005-04-30 16:29:03 +00:00
Ronnie Sahlberg
b19a303f3f once we know a conversation is iscsi, use conversation_set_dissector() 
so that we block any heuristic dissectors from attempring and mistaking this conversation from being it.

In particular:  DCERPC often mistakes iscsi DataOut PDUs for being DCERPC.



svn path=/trunk/; revision=14243
 2005-04-30 16:14:57 +00:00
Gerald Combs
01270e7e44 Don't call proto_item_set_len() with a negative length. Found during 
fuzz testing.

svn path=/trunk/; revision=14242
 2005-04-30 16:08:29 +00:00
Gerald Combs
6380ee9999 Make sure we don't recurse into oblivion. Fixes bug 147. 
svn path=/trunk/; revision=14238
 2005-04-30 04:30:32 +00:00
Gerald Combs
b41f8bfb2a Make sure we don't pass an invalid length to proto_tree_add_item(). Found 
during fuzz testing.

svn path=/trunk/; revision=14237
 2005-04-30 04:09:28 +00:00
Gerald Combs
89c4f03738 The previous changes were causing weird exception errors. Back them out, 
and simply check the length of each buffer.

svn path=/trunk/; revision=14236
 2005-04-30 00:28:05 +00:00
Gerald Combs
d11d3d6f8d Use GStrings instead of character arrays, so that we don't overflow any 
buffers.  Found during fuzz testing.

svn path=/trunk/; revision=14233
 2005-04-29 16:39:20 +00:00
Gerald Combs
08404a61be When printing an error message, make sure we're using a valid tree. Fixes 
bug 144.

svn path=/trunk/; revision=14232
 2005-04-29 14:52:45 +00:00
Gerald Combs
614a46f36e Make sure we're passing the proper lengths to proto_tree_add_item(). Fixes 
bug 142.

svn path=/trunk/; revision=14230
 2005-04-29 14:40:04 +00:00
Gerald Combs
c7dfef6321 Break out of another large-but-not-infinite loop. Fixes bug 143. 
svn path=/trunk/; revision=14229
 2005-04-29 14:25:07 +00:00
Ronnie Sahlberg
f905153266 add the missing MODE field in mover_get_state that was introduced in version 4. 
also change bytes_left_to_read to be a INT64 and not a UINT64.
It iss supposed to be an UINT64  but some implementations are buggy and it is easier to make sense of this field one for those buggy clients if it is printed as an INT64.
This change/violation will not affect any correct/valid NDMP implementation or how ethereal decodes its output  unless your entire backup is > 2**63 bytes in size.



svn path=/trunk/; revision=14228
 2005-04-29 08:02:44 +00:00
Gerald Combs
1b361d5c8a Force the query interval and robustness variable to be 2. Fixes bug 141. 
svn path=/trunk/; revision=14227
 2005-04-29 03:35:38 +00:00
Gerald Combs
e3a76369d1 Break out of a really large (but not infinite) loop. 
svn path=/trunk/; revision=14226
 2005-04-29 00:16:22 +00:00
Gerald Combs
601a4b61d7 Don't try to access past the end of an array. Fixes bug 140. 
svn path=/trunk/; revision=14224
 2005-04-28 22:02:05 +00:00
Gerald Combs
a7082d41b0 Break out of an infinite loop. Fixes bug 138. 
svn path=/trunk/; revision=14223
 2005-04-28 19:42:56 +00:00
Gerald Combs
0be67943e6 Force IAX_IE_CALLNO to be the proper length. 
svn path=/trunk/; revision=14222
 2005-04-28 19:16:54 +00:00
Gerald Combs
38db8769c9 In dissect_pipe_lanman(), return FALSE if p_tvb is null, no matter what. 
Fixes bug 132.

svn path=/trunk/; revision=14221
 2005-04-28 18:34:02 +00:00
Gerald Combs
618b8887dc Use tvb_ensure_bytes_exist() in tvb_get_string() instead of throwing an 
exception ourselves.  Fixes bug 130.

svn path=/trunk/; revision=14220
 2005-04-28 18:07:40 +00:00
Michael Tüxen
537fa72b22 Fix buffer overflow which is the cause of BUG 131. 
svn path=/trunk/; revision=14219
 2005-04-28 14:53:41 +00:00
Michael Tüxen
e107b8238b Add support for DUA dissection. Now all SIGTRAN protocols are supported... 
svn path=/trunk/; revision=14218
 2005-04-28 13:09:19 +00:00
Tomas Kukosa
46a168734a Usage of oid_to_str() in PER and BER helpers 
svn path=/trunk/; revision=14217
 2005-04-28 09:54:03 +00:00
Tomas Kukosa
3be38ac077 New oid_to_str() and oid_to_str_buf() functions 
svn path=/trunk/; revision=14216
 2005-04-28 09:51:55 +00:00
Ronnie Sahlberg
14cd9627b7 make dssetup an autogenerated dissector 
and cancel my checkins from an hour ago, but they show the evolvement of the dissector at least. :-)



svn path=/trunk/; revision=14215
 2005-04-28 09:50:03 +00:00
Ronnie Sahlberg
a4950dec86 rename lsa-ds to the real name of the interface dssetup 
svn path=/trunk/; revision=14214
 2005-04-28 08:57:23 +00:00
Ronnie Sahlberg
552ad50d69 The name of this interface is DSSETUP not LSA-DS 
Rename all references to the protocol name to DSSSETUP


svn path=/trunk/; revision=14213
 2005-04-28 08:55:17 +00:00
Gerald Combs
a80ebce3f2 Some dissectors apparently call proto_tree_add_*() with a null tvb. 
This makes tvb_ensure_bytes_exist() throw a fit, so just throw an
exception instead.

svn path=/trunk/; revision=14212
 2005-04-28 04:03:30 +00:00
Gerald Combs
338bf987f6 Don't try to g_strdup() a null value. Fixes bug 128. 
svn path=/trunk/; revision=14211
 2005-04-28 03:41:05 +00:00
Gerald Combs
e0224c5286 Check an AVP length. Fixes bug 128. 
svn path=/trunk/; revision=14210
 2005-04-28 03:31:20 +00:00
Gerald Combs
7323cb267c Back out the previous change, and use tvb_ensure_bytes_exist() instead of 
throwing an exception ourselves.

svn path=/trunk/; revision=14209
 2005-04-28 03:30:07 +00:00
Gerald Combs
5ec0554c24 In alloc_field_info, throw a ReportedBoundsError if we're passed an 
invalid length.

svn path=/trunk/; revision=14203
 2005-04-27 16:22:24 +00:00
Tomas Kukosa
130db4f23c Export of dissect_ber_null() and dissect_per_null() 
svn path=/trunk/; revision=14202
 2005-04-27 15:19:36 +00:00
Tomas Kukosa
94dffebd6c NULL type decoders for PER and BER 
svn path=/trunk/; revision=14201
 2005-04-27 14:17:14 +00:00
Ronnie Sahlberg
f229ab5733 fix for bug 107 from Greg Morris 
svn path=/trunk/; revision=14199
 2005-04-27 10:21:12 +00:00
Tomas Kukosa
3bb0b3a56b TFTP dissector registering 
svn path=/trunk/; revision=14198
 2005-04-27 06:50:04 +00:00
Gerald Combs
f5e9a4101b Fix a buffer overflow. Fixes bug 100. 
svn path=/trunk/; revision=14197
 2005-04-27 04:09:15 +00:00
Lars Roland
cac06c58a1 Reindent some parts of the sip dissector with tabs, as most parts of the dissector already use tabs. Remove also trailing white spaces. 
svn path=/trunk/; revision=14196
 2005-04-26 23:38:16 +00:00
Gerald Combs
380dfa0fde Add a bunch of tvb_ensure_bytes_exist() calls. Fixes bug 106. 
svn path=/trunk/; revision=14194
 2005-04-26 22:19:38 +00:00
Gerald Combs
310c8a8434 Add a slew of tvb_ensure_bytes_exist() calls. This should probably be 
converted to use the new-style ASN.1 code.  Fixes bug 102.

svn path=/trunk/; revision=14193
 2005-04-26 22:06:04 +00:00
Gerald Combs
e1a597eccf Add some tvb_ensure_bytes_exist() calls. Fixes bug 101. 
svn path=/trunk/; revision=14192
 2005-04-26 20:55:26 +00:00
Gerald Combs
38948db32b Add packet-bacapp.h to the distribution. 
svn path=/trunk/; revision=14191
 2005-04-26 14:08:30 +00:00
Ronnie Sahlberg
3a6778b8e7 fix for bug 91 
make the heuristics for detecting connection-less dce/rpc a bit sharper to reduce the number of false positives



svn path=/trunk/; revision=14190
 2005-04-26 09:03:30 +00:00
Ronnie Sahlberg
d8dcc36d93 from anders b 
diameter updates to add 3gpp vendor avp


svn path=/trunk/; revision=14189
 2005-04-26 08:15:45 +00:00
Ronnie Sahlberg
0f66df8509 BACAPP updates 
svn path=/trunk/; revision=14188
 2005-04-26 08:03:22 +00:00
Guy Harris
5c5f1fd4e6 Make the offsets of the source address length and source address match 
reality.

svn path=/trunk/; revision=14187
 2005-04-25 18:04:28 +00:00
Gerald Combs
53865bb046 Don't try to access a null pointer. Found during fuzz testing. 
svn path=/trunk/; revision=14186
 2005-04-25 16:54:18 +00:00
Gerald Combs
c993ffc6dc Add a tvb_ensure_bytes_exist(). Fixes a bug found during fuzz testing. 
svn path=/trunk/; revision=14185
 2005-04-25 16:23:00 +00:00
Gerald Combs
78a09d190b Fix another invalid item length. Fixes bug 98. 
svn path=/trunk/; revision=14184
 2005-04-25 15:28:32 +00:00
Gerald Combs
a9e9262981 Don't try to tell proto_tree_add_item() that FT_UINT32s are something other 
than 4 bytes.  It throws a fit when you do that.  Fixes bug 97.

svn path=/trunk/; revision=14183
 2005-04-25 15:21:37 +00:00
Gerald Combs
87772809f4 Fix an infinite loop. 
svn path=/trunk/; revision=14182
 2005-04-25 03:02:50 +00:00
Lars Roland
118ce715a7 From Alejandro Vaquero: 
improve dissection of Dynamic payload 
types used in conversations and the
codec list summary in the "Voip Calls Graph".

svn path=/trunk/; revision=14180
 2005-04-24 18:43:42 +00:00
Lars Roland
ca97aa1849 From Martin Mathieson: 
Fix dissection of the SIP Method in the CSeq header.

svn path=/trunk/; revision=14179
 2005-04-24 17:59:18 +00:00
Gerald Combs
af4696c98d Fix an infinite loop. 
svn path=/trunk/; revision=14178
 2005-04-24 01:15:53 +00:00
Gerald Combs
522e204d87 Don't try to free the same memory twice. 
svn path=/trunk/; revision=14176
 2005-04-24 00:36:11 +00:00
Gerald Combs
640a1fcd53 Force a bunch of protocol items to be the proper length. 
svn path=/trunk/; revision=14175
 2005-04-23 22:13:00 +00:00
Gerald Combs
a6cf86ce37 Add a few tvb_ensure_bytes_exist() calls. 
svn path=/trunk/; revision=14174
 2005-04-23 21:33:44 +00:00
Gerald Combs
46ebfe16b0 Don't try to free NULL. Don't overflow a buffer. 
svn path=/trunk/; revision=14173
 2005-04-23 21:31:25 +00:00
Gerald Combs
cf23c92003 Make sure we don't exhaust system memory. 
svn path=/trunk/; revision=14172
 2005-04-23 20:54:59 +00:00
Gerald Combs
50d0f95328 Add more tvb_ensure_bytes_exist() calls. 
svn path=/trunk/; revision=14171
 2005-04-23 13:24:57 +00:00
Gerald Combs
028075b673 Add a couple of tvb_ensure_bytes_exist() calls to avoid dissector bug 
exceptions.

svn path=/trunk/; revision=14170
 2005-04-23 04:06:45 +00:00
Gerald Combs
082651c83e Define a maximum OID string length, and use it in a lot of places. Fixes a 
buffer overflow found while fuzz testing.

svn path=/trunk/; revision=14169
 2005-04-22 21:17:13 +00:00
Gerald Combs
e8730eab95 Fix for the previous fix. 
svn path=/trunk/; revision=14168
 2005-04-22 18:06:39 +00:00
Gerald Combs
3ed50e1ae7 Don't pass a null format string to val_to_str(). 
svn path=/trunk/; revision=14167
 2005-04-22 15:18:56 +00:00
Gerald Combs
42f80d7478 Don't pass a null format string to val_to_str(). 
svn path=/trunk/; revision=14166
 2005-04-22 15:00:45 +00:00
Gerald Combs
f2695565b4 Fix an infinite loop in dissect_rsvp_gen_uni(). Fixes bug 90. Fix up a 
previous infinite loop fix.

svn path=/trunk/; revision=14165
 2005-04-22 14:55:27 +00:00
Ronnie Sahlberg
bf70d24df3 prettify portmapper GETPORT requests and responses 
svn path=/trunk/; revision=14164
 2005-04-22 05:00:02 +00:00
Gerald Combs
f0795da8d6 Add some tvb_ensure_bytes_exist() calls. 
svn path=/trunk/; revision=14163
 2005-04-22 04:26:23 +00:00
Gerald Combs
8d914c66fd Squelch a valgrind warning. 
svn path=/trunk/; revision=14162
 2005-04-22 04:10:44 +00:00
Gerald Combs
1906593816 Fix a buffer overflow in isis_dissect_nlpid_clv(). 
svn path=/trunk/; revision=14161
 2005-04-22 04:07:56 +00:00
Ronnie Sahlberg
b95490206d from Olivier J 
bugfix for IMPLICIT NULL in BER sequences
and gsmmap updates



svn path=/trunk/; revision=14160
 2005-04-21 21:37:23 +00:00
Gerald Combs
dfc96b3d23 In get_string(), throw an exception if the string is too long to 
process.  Hopefully this doesn't break anything.  Add a bunch of
tvb_ensure_bytes_exist() calls.  Fixes bugs 48 - 51.

svn path=/trunk/; revision=14159
 2005-04-21 18:19:38 +00:00
Gerald Combs
f907a1085b Add a tvb_ensure_bytes_exist(). Fixes bug 68 and its many duplicates. 
svn path=/trunk/; revision=14158
 2005-04-21 15:11:38 +00:00