Commit Graph

2765 Commits

Author SHA1 Message Date
Anders Broman 4a1213344d Updare Id, and a comment.
svn path=/trunk/; revision=14922
2005-07-15 20:26:36 +00:00
Tomas Kukosa 1374231148 - PER helper functions for SET/SEQUENCE OF dissection were changed to have prototype similar to BER (per_sequence_t is used as parameter)
- asn2eth was updated to support new PER helper functions for SET/SEQUENCE OF
- #.FN_PARS implemented for SET/SEQUENCE OF and REAL
- PER SET/SEQUENCE OF field can be FT_UINTxx to display number of items
- PER dissectors regenerated

svn path=/trunk/; revision=14921
2005-07-15 15:20:40 +00:00
Anders Broman a5e89b2793 Packet-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c
Packet-uma.c Let packet-gsm_a handle som IE dissection.
Packet-gsm.a add some IE dissection and export some routines.

svn path=/trunk/; revision=14918
2005-07-14 21:05:38 +00:00
Ronnie Sahlberg 98a0c9a590 ISAKMP version2 has changed the payload format of a CertificateRequest.
In version 2 this is just a concatenation of 20 byte SHA-1 hashes with no other encxapsulation.

this resolves bug 281




svn path=/trunk/; revision=14917
2005-07-14 08:10:30 +00:00
Luis Ontanon df4cce353b fix a string
svn path=/trunk/; revision=14915
2005-07-13 23:40:06 +00:00
Anders Broman 383564aff0 From Ilya Konstantinov :
fixes a tiny bug which caused the boolean fields not to refer to the same offset as their 
parent.

svn path=/trunk/; revision=14914
2005-07-13 21:38:07 +00:00
Ronnie Sahlberg 618724969c convert two other autogenerated dissectors to use FT_GUID
svn path=/trunk/; revision=14913
2005-07-13 08:24:05 +00:00
Ronnie Sahlberg 3905fca8bc make idl2eth generate FT_GUID hf fields for uuid_t and GUID types.
make dissect_dcerpc_uuid_t() accept eitehr FT_STRING (old style) and FT_GUID (new style) hf fields. once all dissectors are modified to use FT_GUID we can remove the FT_STRING support here.

regenerate the DRSUAPI interface with the new FT_GUID support.




svn path=/trunk/; revision=14912
2005-07-13 08:00:15 +00:00
Anders Broman 43c0144b8e From Ilya Konstantinov :
A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones.

svn path=/trunk/; revision=14911
2005-07-13 05:06:38 +00:00
Ulf Lamping 1788358c55 code cleanup: use "correct" proto_tree_add_... functions for li and tpdu code fields
svn path=/trunk/; revision=14910
2005-07-12 21:21:14 +00:00
Ulf Lamping 6424332af2 add some more textual explanations of the protocol and it's fields
svn path=/trunk/; revision=14909
2005-07-12 21:09:34 +00:00
Anders Broman 70522b125b Fix decoding of quintuplets.
svn path=/trunk/; revision=14907
2005-07-12 20:30:33 +00:00
Jörg Mayer 9806180700 Add value for FCS (no decoding).
Fix a signedness warning.

svn path=/trunk/; revision=14905
2005-07-12 17:06:09 +00:00
Jörg Mayer e7c4db81c1 Remove/replace SPACES at the beginning of Makefile.am/Makefile.common
files as not all make implementation work with this.

Found by running
grep '^ ' `find . -name "Makefile.am" -o -name "Makefile.common"`

Gerald: Maybe adding this to the buildbot would be a good idea after all.

svn path=/trunk/; revision=14904
2005-07-12 12:44:42 +00:00
Guy Harris 2fcce4b6c4 Fix some more signed vs. unsigned warnings.
svn path=/trunk/; revision=14903
2005-07-12 01:01:19 +00:00
Guy Harris ef1bfb6f9b In NTLMSP_AUTH messages, include the domain name and user name in the
Info column.

svn path=/trunk/; revision=14902
2005-07-11 22:48:51 +00:00
Anders Broman 1484c99e0f DIS dissection
svn path=/trunk/; revision=14900
2005-07-11 22:23:57 +00:00
Anders Broman a063532343 From Jeremy j Ouellette:
DIS dissection.

svn path=/trunk/; revision=14899
2005-07-11 22:23:15 +00:00
Anders Broman 43e9a11b11 Dissect some more fields
svn path=/trunk/; revision=14897
2005-07-11 19:25:25 +00:00
Guy Harris 79beab421d Put the data (print job contents) in LPD requests under the LPD protocol
item, rather than making it a top-level item.

svn path=/trunk/; revision=14893
2005-07-10 09:26:20 +00:00
Jörg Mayer 5b442f2279 After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.


svn path=/trunk/; revision=14891
2005-07-10 08:04:27 +00:00
Ronnie Sahlberg 85f38ef5fa For packets flagged as Retransmission
calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction).

while this is technically not the RTO  this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle  while waiting for an RTO.




It would be nice with a statistics tap for TCP where one couls see, seeion by session :
Length in time of the session.
Total bytes transferred
Number of retransmissions
Time spent waiting for an RTO
Time spent waiting for an RTO in % of the total time.




svn path=/trunk/; revision=14890
2005-07-10 05:27:38 +00:00
Guy Harris 8647bbf353 Make a bunch of items in encryption code arrays of guint8, and make some
pointers either "void *" or "guint8 *", to reduce the level of compiler
warnings (the data in question is largely binary in those cases).

svn path=/trunk/; revision=14886
2005-07-09 03:25:25 +00:00
Guy Harris 34ae8c850f Fix up a bunch of arguments to "dissect_ber_identifier()" to match its
current signature ("class" is a "gint8 *", not a "guint8 *", and "tag"
is a "gint32 *", not a "guint32 *").  Re-generate the dissectors from
the ASN.1 and the .cnf files in the cases where the arguments were fixed
in a .cnf file.

Give some dissectors the right svn:keywords and svn:eol-style settings.

svn path=/trunk/; revision=14885
2005-07-09 02:58:07 +00:00
Guy Harris 9cb86fda9c Squelch various signed vs. unsigned warnings by:
making pointers to byte data be "guint8 *" rather than "char *",
	and making buffers holding byte data arrays of "guint8" rather
	than arrays of "char";

	making pointers to text strings "char *" rather than "guchar *";

	appropriately casting pointers (cast to "guint8 *" when passing
	to routines expecting "guint8 *" or when assigning to "guint8
	*");

	making port-number preferences "guint";

	making enum preferences "gint";

	making hf_ variables "int".

Clean up white space.

svn path=/trunk/; revision=14884
2005-07-09 00:53:17 +00:00
Guy Harris da80656d0e MAC addresses are arrays of bytes, not strings; make the destination MAC
address an array of guint8 - that squelches some compiler warnings.

Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the
end of the tvbuff.

svn path=/trunk/; revision=14883
2005-07-09 00:47:57 +00:00
Guy Harris a05302b67a Find the BitTorrent dissector immediately after registering it, and save
the handle, rather than finding it every time we need it.

Just make a guint8 array with the BitTorrent magic string length
followed by the string, and use "tvb_memeql()" to test against that - it
handles checking to make sure there's enough data in the tvbuff (if
not, it returns -1 as a "no match" indication) and then checks all of
the first 20 bytes in one operation.

Clean up white space.

svn path=/trunk/; revision=14882
2005-07-09 00:44:44 +00:00
Guy Harris 68b1ab41d7 Use "tvb_get_string()" rather than duplicating its functionality by
hand.

Use "g_strdup()" rather than duplicating its functionality by hand.

Make the magic number an array of "guint8", as "tvb_memeql()" expects a
pointer to "guint8".

svn path=/trunk/; revision=14881
2005-07-09 00:35:13 +00:00
Ulf Lamping 2c30357c48 checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
svn path=/trunk/; revision=14880
2005-07-08 22:11:13 +00:00
Anders Broman c50d7e229e Add some missing IMPLICIT tags, and use FN_PARS directive.
Add disection of some RR elements and command Handover.

svn path=/trunk/; revision=14878
2005-07-08 20:01:11 +00:00
Guy Harris f64a0aa20b Get rid of most unused arguments and variables (including some that are
set but not used).  (Leave "pi" around so the warning acts as a reminder
that the tap structure stuff needs a cleanup - currently, the tap
structures aren't freed; perhaps the new memory allocation scheme
proposed by Ronnie could be used for tap structures.)

Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace
packets and return the packet type for actrace packets, so that we don't
need a global variable for the packet type.

Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned
warning.

Use "col_set_str()" rather than "col_add_str()" when setting the
Protocol column.

We don't recognized packets as CAS packets unless they're 48 bytes long,
so we don't need to test whether they're 48 bytes long in the CAS packet
dissection code.

Use the reported length, not the captured length, when doing length
checks.

svn path=/trunk/; revision=14874
2005-07-08 02:31:45 +00:00
Gerald Combs 5b7df3128b Make sure "which" is present before we verify our tools. Add "env" to
the list of programs to check.  Make sure our python scripts start with
"#!/usr/bin/env python" as recommended at

  http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix

svn path=/trunk/; revision=14871
2005-07-07 21:26:09 +00:00
Guy Harris e2d750eab5 Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

svn path=/trunk/; revision=14867
2005-07-07 04:03:35 +00:00
Ulf Lamping 2f2ab41ea4 fix *several* dissector bugs, found by private fuzz-tests
svn path=/trunk/; revision=14861
2005-07-05 22:33:22 +00:00
Gerald Combs 8434647836 Call proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274,
276, and 277.

svn path=/trunk/; revision=14859
2005-07-05 20:20:15 +00:00
Gerald Combs 276f179b0b Don't crash if we're handed a zero-length fragment. Fixes bug 272. Although
we don't crash now, we still don't handle zero-length fragments correctly.

svn path=/trunk/; revision=14858
2005-07-05 20:04:03 +00:00
Tomas Kukosa b579d77b9a GUID lowercase form seems to be preferred
svn path=/trunk/; revision=14855
2005-07-05 18:55:17 +00:00
Anders Broman 02a57cdfcc Add application/vnd.wv.csp.xml
svn path=/trunk/; revision=14854
2005-07-05 17:10:09 +00:00
Anders Broman 623f9057c1 From : David Frascone
These minor changes fix some errors, and add some messages to the LWAPP dissector.

svn path=/trunk/; revision=14851
2005-07-05 04:32:32 +00:00
Anders Broman 96389d268c Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
svn path=/trunk/; revision=14848
2005-07-04 19:07:02 +00:00
Tomas Kukosa cdb09b497a usage of FT_GUID field type in H.225 dissector
svn path=/trunk/; revision=14847
2005-07-04 13:19:58 +00:00
Tomas Kukosa b9703d0919 export of proto_tree_add_guid...() functions
svn path=/trunk/; revision=14846
2005-07-04 13:13:07 +00:00
Tomas Kukosa bab34b522b new field type FT_GUID
svn path=/trunk/; revision=14845
2005-07-04 13:04:53 +00:00
Tomas Kukosa 5f2fd433ab - use tvb instead of offset and length in dissect_per_octet_string() for value returning
- asn2eth: #.FN_PARS support for OCTET STRING
- usage of #.FN_PARS in h225 and h245
- h225: ParallelH245Control support
- h245: better support of NonStandardParameter
- usage of MAX_OID_STR_LEN constant
- all PER dissectors regenerated

svn path=/trunk/; revision=14844
2005-07-04 09:35:25 +00:00
Guy Harris 828641b2ad Mark stub data as such if no dissector claims it.
svn path=/trunk/; revision=14842
2005-07-04 03:45:29 +00:00
Anders Broman 8a448fade7 Add an exported value string
svn path=/trunk/; revision=14840
2005-07-03 21:20:27 +00:00
Anders Broman 2d264e4314 Add an exported value string
svn path=/trunk/; revision=14839
2005-07-03 21:19:49 +00:00
Anders Broman 6671c5b15d Change gsm_a.c to use value strings in some places in preparation to use it from packet-uma.c and gsm_map.
Some bug fixes to packet-uma.c

svn path=/trunk/; revision=14838
2005-07-03 20:33:06 +00:00
Anders Broman efc7044f35 Add packet-mms.h
svn path=/trunk/; revision=14837
2005-07-03 12:01:11 +00:00
Ronnie Sahlberg 3440ba76fc New protocol :
MMS    Manufacturing Message Specification


svn path=/trunk/; revision=14836
2005-07-03 06:08:53 +00:00