Commit Graph

8742 Commits

Author SHA1 Message Date
Guy Harris deff880da1 From Josef Korelus: fix reversed messages in true_false_string tables.
svn path=/trunk/; revision=8836
2003-10-30 19:43:15 +00:00
Guy Harris c25707861d From Michael Lum: dissect DTAP from RANAP NAS PDU fields.
svn path=/trunk/; revision=8835
2003-10-30 19:39:33 +00:00
Guy Harris ae389a9b32 From Michael Lum: step over unknown parameters.
svn path=/trunk/; revision=8834
2003-10-30 19:38:57 +00:00
Guy Harris 44590a655c "strchr()" and the like would be compared against NULL; "strcmp()",
however, is compared against 0.

svn path=/trunk/; revision=8833
2003-10-30 11:56:36 +00:00
Guy Harris 5560949b15 No zero-length arrays, please.
svn path=/trunk/; revision=8832
2003-10-30 11:54:21 +00:00
Guy Harris 305afc4e97 The quantities in the hcidump header are little-endian, not big-endian.
svn path=/trunk/; revision=8831
2003-10-30 11:53:48 +00:00
Guy Harris 611c971364 Definitions of arrays, with no length specified, are not legal C.
svn path=/trunk/; revision=8830
2003-10-30 11:21:26 +00:00
Guy Harris 75f3ee7ba2 Apply Anders Broman's changes to the Q.931 dissector to the Q.933
dissector:

	fix the offset when putting the cause code in a Cause IE into the
	protocol tree;

	in a Number IE, show the number type, numbering plan, and
	extension indicator as named-field bitfields.

svn path=/trunk/; revision=8829
2003-10-30 08:34:59 +00:00
Guy Harris b10a085434 From Anders Broman:
fix the offset when putting the cause code in a Cause IE into the
	protocol tree;

	in a Number IE, show the number type, numbering plan, and
	extension indicator as named-field bitfields.

svn path=/trunk/; revision=8828
2003-10-30 08:07:30 +00:00
Guy Harris 2494f0bf32 From Michael Lum: squelch a couple of compiler warnings.
svn path=/trunk/; revision=8827
2003-10-30 07:14:27 +00:00
Guy Harris 8e67a430e8 From Michael Lum:
GSM BSSMAP (GSM 08.08) support
	GSM DTAP (3GPP TS 24.008) support
	GSM SMS (3GPP TS 24.011) support
	GSM SS (3GPP TS 24.080) support
	GSM SMS TPDU (3GPP TS 23.040) support

svn path=/trunk/; revision=8826
2003-10-30 07:00:18 +00:00
Guy Harris 2a6b337ad8 #if 0 out the stuff to set the reported length, as it'd throw an
exception if it would increase the reported length.

svn path=/trunk/; revision=8825
2003-10-30 03:15:26 +00:00
Guy Harris 95c1f2f7c9 From Marcel Holtmann: support for reading Linux Bluez Bluetooth stack
"hcidump -w" traces.

Note that Jesper Peterson contributed support for reading Endace ERF
files.

svn path=/trunk/; revision=8824
2003-10-30 03:11:03 +00:00
Guy Harris c37d30442f From Dinesh Dutt:
- Dissector for FICON
	- Dissector for FC-SP (Security Protocol for Fibre Channel)
	- Patches to correct the reassembly of FC fragments.
	- Support for new MDS Port Analyzer Adapters that carry the
	  frame length for truncated frames.

svn path=/trunk/; revision=8823
2003-10-30 02:06:13 +00:00
Tim Potter 090dbfbcb2 Decorate higher level proto_item with NetFn and LUN values in hex.
svn path=/trunk/; revision=8822
2003-10-30 00:39:51 +00:00
Guy Harris 0c0ef44095 Make the "fvalue_set" methods for types whose value is allocated free
any previously-allocated version first, so that they don't leak memory.

From Olivier Biot: add a "proto_item_append_string()" routine, to append
to the string value a protocol tree item has.

svn path=/trunk/; revision=8821
2003-10-29 23:48:14 +00:00
Guy Harris b4bdaa5e9f Put quotes around values for FT_ABSOLUTE_TIME variables, and around
values with white space in them.

svn path=/trunk/; revision=8820
2003-10-29 23:15:35 +00:00
Guy Harris 5f01c7a082 Have the "edit display filters" button do the exact same thing as the
"Edit -> Display Filters..." menu item, as per Ulf Lamping - there's
apparently some problem wherein &args doesn't get passed properly to the
callback.

svn path=/trunk/; revision=8819
2003-10-29 22:39:49 +00:00
Guy Harris b9b73fe54c Plug that leak with a cleanup handler, so we don't leak the variable OID
if we throw an exception fetching the variable value.

svn path=/trunk/; revision=8818
2003-10-29 22:11:08 +00:00
Guy Harris 795ce752e9 ...and there's one leak we missed.
svn path=/trunk/; revision=8817
2003-10-29 22:04:57 +00:00
Guy Harris 596dfa55f0 Another leak that isn't.
svn path=/trunk/; revision=8816
2003-10-29 22:02:11 +00:00
Guy Harris e604b9e693 Actually, one of those *isn't* a leak; don't free something we haven't
allocated yet.

svn path=/trunk/; revision=8815
2003-10-29 22:00:54 +00:00
Guy Harris 04a5cb7737 Fix some memory leaks found by Steve Ford.
svn path=/trunk/; revision=8814
2003-10-29 21:54:45 +00:00
Guy Harris 7d27085948 From Steve Ford: "prefs_register_string_preference()" makes a copy of
any string pointed to by the preference variable - as the value we set
it to is allocated, we should free it after registering the preference.

The register routine is called only once - don't worry about whether
"gbl_diameterDictionary" is null or not.

Get rid of a duplicate credit entry in the man page.

svn path=/trunk/; revision=8813
2003-10-29 21:19:44 +00:00
Guy Harris ca1f1c7f2a From Matthijs Melchior: #ifdef out the GUI code, for now.
svn path=/trunk/; revision=8812
2003-10-29 10:54:17 +00:00
Guy Harris 4a7f74b7d1 There's no need to #define tvb_get_string or tvb_get_stringz - that's
done in Xplugin_api.h.

However, we do need to include "epan/filesystem.h", to declare
"get_datafile_path()".

svn path=/trunk/; revision=8811
2003-10-29 10:37:28 +00:00
Guy Harris fc43317556 Use "get_datafile_path()", rather than constructing the default ASN.1
file path by hand.

Set "default_asn1_filename", not "asn1_filename", to the default path.

svn path=/trunk/; revision=8810
2003-10-28 21:47:32 +00:00
Guy Harris ee2ddb83fc Export "get_datafile_path()", not "get_datafile_dir()" - most if not all
dissectors need only the former, which does the pathname-construction
work for you.

svn path=/trunk/; revision=8809
2003-10-28 21:46:26 +00:00
Guy Harris 8a3e69d832 "get_datafile_dir()" is now in the plugin table.
svn path=/trunk/; revision=8808
2003-10-28 21:04:16 +00:00
Guy Harris 70afd0c1dd Add "get_datafile_dir()" to the plugin API list, for the benefit of
plugins that might get configuration information from a file.

svn path=/trunk/; revision=8807
2003-10-28 21:03:01 +00:00
Guy Harris 7b0e35379f As we don't supply a default ASN.1 SNACC output file, if we get an
ENOENT when trying to open the SNACC file, and the file we're trying to
open is the default file, don't print a warning.

Fix some typoes.

svn path=/trunk/; revision=8806
2003-10-28 20:53:37 +00:00
Guy Harris dc1da82c41 This dissector uses GTK+ calls (which no dissector should); until that's
fixed, use GTK_CFLAGS and GTK_LIBS rather than GLIB_CFLAGS and
GLIB_LIBS.

svn path=/trunk/; revision=8805
2003-10-28 20:44:51 +00:00
Guy Harris 32975a11e6 Fix the Makefile to match other plugin Makefiles.
svn path=/trunk/; revision=8804
2003-10-28 19:27:49 +00:00
Guy Harris 67406fcfd2 From Michael Lum: fixed BCD decoding of filler nibble and fixed some
minor bugs.

svn path=/trunk/; revision=8803
2003-10-28 18:08:52 +00:00
Guy Harris 836f12e207 From Lo�c Minier: get rid of the second of a pair of identical checks.
As per a note by Olivier Biot, make the "multipart/XXX" items all lower
case.

svn path=/trunk/; revision=8802
2003-10-28 17:59:29 +00:00
Guy Harris fa3680223b "%.*" expects an "int" argument giving the precision.
svn path=/trunk/; revision=8801
2003-10-28 17:27:56 +00:00
Ronnie Sahlberg a185c70b18 Full duplex analyzers that capture each direction of a link with a separate NIC will lose the time integrity between the two NICs more often than one might expect.
It is thus relatively common that a data segment and its ACK being swapped in the capture file.

Therefore, drop the condition that a segment must not have been acked yet in the detection of OutOfOrder segments.

Second, fix a bug where we didnt keep track of the ack numbers properly for relative sequence number analysis.

svn path=/trunk/; revision=8800
2003-10-28 08:50:39 +00:00
Guy Harris c68a7d7cb1 From Matthias Melchior: plugin to decode BER-encoded ASN.1 messages,
given a type-table from "snacc" as a protocol description.

svn path=/trunk/; revision=8799
2003-10-28 07:02:38 +00:00
Guy Harris 9c3e2720da From Giles Scott: Alteon/Nortel Transparent Proxy Control Protocol
support.

svn path=/trunk/; revision=8798
2003-10-28 06:44:21 +00:00
Guy Harris 3de139644b Clarify the previous checkin - that applies to the 'value' argument.
svn path=/trunk/; revision=8797
2003-10-28 05:50:52 +00:00
Guy Harris 5900986044 As per a suggestion by Olivier Biot, note that objects pointed to by
pointer arguments to "proto_tree_add_XXX" functions are copied - if you
allocated a buffer for one of them (e.g., a string), and you don't free
that buffer when you're done with it, you'll leak memory.

svn path=/trunk/; revision=8796
2003-10-28 05:49:29 +00:00
Guy Harris 0c389cc678 From Dinesh Dutt:
Add dissection code for the following additional SCSI commands:
	     - Start/Stop Unit
	     - Write Buffer
	     - Send Diagnostics

	Don't copy the product serial number to a buffer before printing
	it.

svn path=/trunk/; revision=8795
2003-10-28 03:57:49 +00:00
Guy Harris 1c5ed66f45 From Lars Roland: H.225 message and reason tag counter taps.
svn path=/trunk/; revision=8794
2003-10-28 00:31:17 +00:00
Guy Harris a1f7d525b7 From a suggestion by Jim McDonough: support for the INITSHUTDOWN service.
svn path=/trunk/; revision=8793
2003-10-27 23:31:54 +00:00
Guy Harris 0a7b08c9e9 Don't draw a Y-axis label if you haven't constructed the label string.
svn path=/trunk/; revision=8792
2003-10-27 23:12:53 +00:00
Guy Harris 4b1fda78b9 Allow + and , in unparsed strings, so that you can use + as a sign in a
number or exponent and so that floating-point numbers can use , as well
as . as a decimal point.

svn path=/trunk/; revision=8791
2003-10-27 22:45:47 +00:00
Guy Harris c3c558a6c3 From Lars Roland: fix a typo.
svn path=/trunk/; revision=8790
2003-10-27 22:29:52 +00:00
Guy Harris 459f7323ca From Lars Roland: whitespace cleanups.
svn path=/trunk/; revision=8789
2003-10-27 22:28:48 +00:00
Guy Harris 99331c2fa8 Squelch some signed vs. unsigned comparison warnings.
Get rid of an unused variable.

svn path=/trunk/; revision=8788
2003-10-27 19:34:03 +00:00
Guy Harris d96ba04c52 From Dinesh Dutt: display the FC CRC for frames encapsulated with
MDSHDR, and show only the low-order 13 bits of the packet length field.

svn path=/trunk/; revision=8787
2003-10-27 19:30:55 +00:00