Commit graph

14915 commits

Author SHA1 Message Date
Chris Maynard
c6bf60f74b Fix Coverity CID 709738: Unused pointer value.
svn path=/trunk/; revision=44018
2012-07-25 22:48:14 +00:00
Martin Mathieson
1d1cc74e93 Zero a struct to avoid branching based upon uninitialised fields
(previousFrameNum & nextFrameNum).  Spotted by valgrind.

svn path=/trunk/; revision=44017
2012-07-25 22:02:29 +00:00
Jeff Morriss
bcfadcbace zbee.aps was renamed zbee_aps (in r43990).
svn path=/trunk/; revision=44015
2012-07-25 21:27:19 +00:00
Bill Meier
7b869feb85 Minor cleanup:
- col_clear() not needed;
- remove some unneeded initializers;
- reformat hf[] entries.

svn path=/trunk/; revision=44013
2012-07-25 20:46:36 +00:00
Bill Meier
840a58f1f3 Minor cleanup:
- Create/use extended value string to access value string array;
- col_clear() not needed;
- Remove some unneeded initializers.

svn path=/trunk/; revision=44012
2012-07-25 20:42:16 +00:00
Pascal Quantin
70ea1804d8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7524 :
8-PSK structure in GSM Classmark 3 is not properly dissected

svn path=/trunk/; revision=44008
2012-07-25 20:04:33 +00:00
Bill Meier
85e9ca3940 Create/use extended value strings as appropriate;
Remove unneeded initializers;
Do whitespace changes.

svn path=/trunk/; revision=44003
2012-07-25 17:38:05 +00:00
Bill Meier
ced3a6c006 Minor cleanup:
- Use col_...() fcns in the proper manner and order;
- proto_reg_handoff...() not needed (does nothing useful);
- remove some unneeded initializers;
- reformat hf[] entries.

svn path=/trunk/; revision=44000
2012-07-25 15:32:29 +00:00
Bill Meier
19000cbaf5 Minor cleanup:
- Remove some unneeded initializers & casts;
- whitespace.

svn path=/trunk/; revision=43997
2012-07-25 15:04:19 +00:00
Bill Meier
7dd0cf41ce Minor cleanup:
- col_clear() not required;
 - use #if 0/#endif to comment out code (iso /* ... */)
 - whitespace.

svn path=/trunk/; revision=43996
2012-07-25 14:39:32 +00:00
Bill Meier
0800534e66 #include <stdio.h> not needed.
svn path=/trunk/; revision=43995
2012-07-25 13:59:41 +00:00
Bill Meier
572b4dae32 Minor cleanup:
- col_clear() not required;
- ...

svn path=/trunk/; revision=43994
2012-07-25 13:57:22 +00:00
Michael Mann
32ef0a1a18 Converted scsi dissectors display filter format from scsi.<protocol> to scsi_<protocol> (matching their registered filter name)
svn path=/trunk/; revision=43993
2012-07-25 13:56:15 +00:00
Bill Meier
2516627cd5 Minor cleanup:
col_clear() not required;
  unneeded initializers;
  whitespace.

svn path=/trunk/; revision=43992
2012-07-25 13:38:31 +00:00
Michael Mann
6d06ea6062 Converted ZigBee dissectors display filter format from zbee.<protocol> to zbee_<protocol>
Also corrected zbee_afp filters as they were incorrectly using zbee.app

svn path=/trunk/; revision=43990
2012-07-25 12:19:21 +00:00
Michael Mann
cdee738998 Fix NULL deference (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7486).
I don't understand the relationship between the "frame data" and the "conversation" (to me they seem independent, but the code seems to put them together), but at least this fixes the crash 

svn path=/trunk/; revision=43985
2012-07-25 11:27:01 +00:00
Anders Broman
91763a17be From Johan Wåhl:
Make DNS ports configurable.

svn path=/trunk/; revision=43984
2012-07-25 09:40:18 +00:00
Anders Broman
e5d974ec6a From Jacob Nordgren and Rishie Sharma:
- FP: added payload CRC validation, RLC: some more error reporting 
- RLC: fixed an exotic LI bug, some cosmetic fixes.

svn path=/trunk/; revision=43983
2012-07-25 09:09:32 +00:00
Bill Meier
b63bb802ab (Trivial) Cleanup
svn path=/trunk/; revision=43975
2012-07-24 23:25:57 +00:00
Bill Meier
25336651ac (Minor) Create handle in proto_reg_handoff...() (where it's used);
Localize static variable to proto_reg_handoff...()

svn path=/trunk/; revision=43974
2012-07-24 22:57:25 +00:00
Bill Meier
3ef558ba7c (Minor) Localize a static variable;
svn path=/trunk/; revision=43973
2012-07-24 22:51:15 +00:00
Bill Meier
08c1114822 Move proto_register..() and proto_reg_handoff...() to the end of the file;
Do other minor cleanup.

svn path=/trunk/; revision=43971
2012-07-24 22:38:13 +00:00
Bill Meier
2be8004129 General cleanup, including:
- prevent potential array overflow: do some bounds checking;
- use emem_strbuf instead of buffers on the stack;
- check_col() not required;
- simplify code in several places;
- remove some boilerplate comments;
- ...

svn path=/trunk/; revision=43970
2012-07-24 21:30:25 +00:00
Martin Kaiser
295b919f5d MPEG PAT: set the tree item's length == number of bytes dissected
don't simply assume the PAT continues until the end of the input tvb

this is similar to packet_dvb_ait.c
I'll change this for other tables shortly

svn path=/trunk/; revision=43969
2012-07-24 21:24:33 +00:00
Bill Meier
05935f075a (Trivial) remove unneeded #include.
svn path=/trunk/; revision=43962
2012-07-24 15:11:18 +00:00
Bill Meier
0c8e6e8f90 Remove unneeded #include;
Create/use extended value strings for several value-string arrays;
Minor whitespace cleanup.

svn path=/trunk/; revision=43960
2012-07-24 14:47:19 +00:00
Bill Meier
ca154aad10 (Trivial) whitespace cleanup
svn path=/trunk/; revision=43959
2012-07-24 14:05:20 +00:00
Anders Broman
eceff8e0d4 H.248 cannot interpret value of Package 0x0022, Parameter 1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7519

svn path=/trunk/; revision=43958
2012-07-24 13:05:25 +00:00
Anders Broman
7f345354fe From Karsten Keil:
ISDN LAPD X.31 packet traffic can not be decoded

X.31 is X.25 over ISDN. It use SAPI 16 LAPD service.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7514

svn path=/trunk/; revision=43956
2012-07-24 11:47:23 +00:00
Anders Broman
6572a8e55c From Peng Di:
GIOP request_id used for sub dissectors is not assigned when decoding GIOP 1.2 Request message.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7516

svn path=/trunk/; revision=43955
2012-07-24 10:25:13 +00:00
Anders Broman
3743a01714 From Jacob Nordgren and Rishie Sharma:
- Added support for EDCH type 2 MAC-is reassembly and slightly improved RLC error reporting 

- RLC: fixed bug where complete sequences in the end of a trace where not reassembled

svn path=/trunk/; revision=43954
2012-07-24 07:31:46 +00:00
Ronnie Sahlberg
3b0eb70b23 SCSI: Add support for mode subpages
Add support for modepages that contain subpages and add
a simple subpage for the Control page.


svn path=/trunk/; revision=43952
2012-07-24 02:00:50 +00:00
Jeff Morriss
0a97a9c7d5 Get rid of non-ASCII chars. Also replace tabs with spaces and remove trailing white space.
svn path=/trunk/; revision=43940
2012-07-23 17:04:37 +00:00
Michael Mann
37ebb93a54 Added RFC 5285 functionality per https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5763
svn path=/trunk/; revision=43931
2012-07-23 15:52:17 +00:00
Anders Broman
533c63eed1 Fix reversed values for Bearer Context IE decodes Bearer Level Quality of Service (Bearer QoS) in ARP field the wireshark decoded preemption values.
As reported in
http://ask.wireshark.org/questions/12907/pre-emption-decoding-on-s11-interface

svn path=/trunk/; revision=43930
2012-07-23 15:27:52 +00:00
Martin Mathieson
248b758f82 Now check the first few bytes of the ftp-data segment to see if it looks
printable.  If binary, just show the number of bytes in summary.

Not that there are no items inside it, don't create ftp-data as a tree.
Also, fix the type of the variable 'ti'.

svn path=/trunk/; revision=43929
2012-07-23 14:40:05 +00:00
Jakub Zawadzki
d2ba441c57 Initial version of VNTAG dissector (bug #7496)
svn path=/trunk/; revision=43928
2012-07-23 14:09:41 +00:00
Anders Broman
227327a1e6 Mark pinfo as unused.
svn path=/trunk/; revision=43927
2012-07-23 13:27:16 +00:00
Michael Mann
a6af1fae2a Add dissector tables for RTCP extended feedback messages (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5764)
svn path=/trunk/; revision=43926
2012-07-23 11:58:51 +00:00
Michael Mann
abc177f5d6 added dissect_sprt() to dissect_sprt_heur() so that the heuristics actually do something
svn path=/trunk/; revision=43923
2012-07-23 00:30:00 +00:00
Evan Huus
daa0ff3ac8 The XMPP dissector was allocating a new parser for every packet and never
freeing them. This was slow and leaked gobs of memory.

Be like XML: allocate one parser during set-up and share it around.

svn path=/trunk/; revision=43920
2012-07-22 21:48:51 +00:00
Martin Mathieson
7abae04478 Calling tvb_format_text() for binary data segments (c1400 bytes) was
*very* slow (in a profiled run where FTP data is carried over LTE
MAC/RLC/PDCP/IP/TCP, this one function call was 20% of overall runtime).

Have limited to call to ITEM_LABEL_LENGTH, as that is all that
will be displayed anyway.  As per comment, I'm not convinced that doing
this for binary FTP data segments is worthwhile at all.  It doesn't
even display as hex.

svn path=/trunk/; revision=43908
2012-07-22 04:44:16 +00:00
Michael Mann
0d4eafb04d Update display filter names per Bug 2794. Part 1 of many.
svn path=/trunk/; revision=43907
2012-07-22 03:06:37 +00:00
Bill Meier
45f9935f04 Additional cleanup:
packet-sdp.c:
  Init 'proto_sprt' in proto_reg_handof..()
    [instead of using a registered init fcn];

packet-sprt.c:
  Fix some typos;
  Comment out dissect_sprt_heur() since it doesn't
   really do any dissection. Add an XXX comment re same.

packet-v150fw.c:
  Remove unused 'v150fw_handle' and thus unneeded proto_reg_handoff...();
  Add an XXX comment re the (commented out) dissect_v150fw() not actually
   doing any dissection.


svn path=/trunk/; revision=43902
2012-07-21 22:06:17 +00:00
Evan Huus
700524155d Fix mis-allocated key size as caught by valgrind.
We have to divide the 'length' field to work with guint32 pointer arithmetic,
but we still want to allocate and memcpy the original length value, since
both of those operate in raw bytes, not blocks of sizeof(guint32).

svn path=/trunk/; revision=43901
2012-07-21 19:18:12 +00:00
Evan Huus
4ddb02f6c1 Don't throw an assertion if we can't find certain XMPP attributes when
trying to track sessions for iq, jabber, et al. Just return, so we can
dissect whatever attributes we can find. An expert info already gets added
later on.

The other part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509


svn path=/trunk/; revision=43899
2012-07-21 16:29:48 +00:00
Evan Huus
2949d44b74 The se_tree_* functions are destructive to the key, so save and restore
the key around each call.

Fixes part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509

svn path=/trunk/; revision=43898
2012-07-21 16:10:16 +00:00
Bill Meier
67e3f64476 Move 99.9 % of packet-sprt.h to packet-sprt.c since it's used only there.
Convert "4 space tabs" to spaces (missed in previous commit).

svn path=/trunk/; revision=43897
2012-07-21 15:32:36 +00:00
Evan Huus
f9ec58ae1d Because storing the address of a stack variable seemed like such
a good idea at the time...

Allocate seasonal memory for it instead.

svn path=/trunk/; revision=43896
2012-07-21 15:31:35 +00:00
Martin Mathieson
8a8adffcf5 Initialise ext_len to avoid an "uninitialised use" error.
svn path=/trunk/; revision=43895
2012-07-21 15:21:43 +00:00