osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Fix reversed values for Bearer Context IE decodes Bearer Level Quality of Service (Bearer QoS) in ARP field the wireshark decoded preemption values. 

As reported in
http://ask.wireshark.org/questions/12907/pre-emption-decoding-on-s11-interface

svn path=/trunk/; revision=43930
This commit is contained in:
Anders Broman 2012-07-23 15:27:52 +00:00
parent 248b758f82
commit 533c63eed1
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
epan/dissectors/packet-gtpv2.c
View File

@ -5884,9 +5884,16 @@ void proto_register_gtpv2(void)
FT_BYTES, BASE_NONE, NULL, 0x0,
NULL, HFILL}
},
/* Bit 1 – PVI (Pre-emption Vulnerability): See 3GPP TS 29.212[29],
* clause 5.3.47 Pre-emption-Vulnerability AVP.
* 5.3.47 Pre-emption-Vulnerability AVP
* The following values are defined:
* PRE-EMPTION_VULNERABILITY_ENABLED (0)
* PRE-EMPTION_VULNERABILITY_DISABLED (1)
*/
{&hf_gtpv2_bearer_qos_pvi,
{"PVI (Pre-emption Vulnerability)", "gtpv2.bearer_qos_pvi",
FT_BOOLEAN, 8, TFS(&tfs_enabled_disabled), 0x01,
FT_BOOLEAN, 8, TFS(&tfs_disabled_enabled), 0x01,
NULL, HFILL}
},
{&hf_gtpv2_bearer_qos_pl,
@ -5894,9 +5901,16 @@ void proto_register_gtpv2(void)
FT_UINT8, BASE_DEC, NULL, 0x3c,
NULL, HFILL}
},
/* Bit 7 – PCI (Pre-emption Capability): See 3GPP TS 29.212[29], clause 5.3.46 Pre-emption-Capability AVP.
* clause 5.3.46 Pre-emption-Capability AVP.
* 5.3.46 Pre-emption-Capability AVP
* The following values are defined:
* PRE-EMPTION_CAPABILITY_ENABLED (0)
* PRE-EMPTION_CAPABILITY_DISABLED (1)
*/
{&hf_gtpv2_bearer_qos_pci,
{"PCI (Pre-emption Capability)", "gtpv2.bearer_qos_pci",
FT_BOOLEAN, 8, TFS(&tfs_enabled_disabled), 0x40,
FT_BOOLEAN, 8, TFS(&tfs_disabled_enabled), 0x40,
NULL, HFILL}
},
{&hf_gtpv2_bearer_qos_label_qci,

1
epan/tfs.c
View File

@ -37,6 +37,7 @@ const true_false_string tfs_true_false = { "True", "False" };
const true_false_string tfs_yes_no = { "Yes", "No" };
const true_false_string tfs_set_notset = { "Set", "Not set" };
const true_false_string tfs_enabled_disabled = { "Enabled", "Disabled" };
const true_false_string tfs_disabled_enabled = { "Disabled", "Enabled" };
const true_false_string tfs_ok_error = { "Ok", "Error" };
const true_false_string tfs_error_ok = { "Error", "Ok" };
const true_false_string tfs_success_fail = { "Success", "Fail" };

1
epan/tfs.h
View File

@ -44,6 +44,7 @@ WS_VAR_IMPORT const true_false_string tfs_true_false;
WS_VAR_IMPORT const true_false_string tfs_yes_no;
WS_VAR_IMPORT const true_false_string tfs_set_notset;
WS_VAR_IMPORT const true_false_string tfs_enabled_disabled;
WS_VAR_IMPORT const true_false_string tfs_disabled_enabled;
WS_VAR_IMPORT const true_false_string tfs_ok_error;
WS_VAR_IMPORT const true_false_string tfs_error_ok;
WS_VAR_IMPORT const true_false_string tfs_success_fail;