Commit Graph

32672 Commits

Author SHA1 Message Date
Martin Mathieson d96bda809e Try to cast away windows buildbot problems.
svn path=/trunk/; revision=34060
2010-09-03 16:05:01 +00:00
Martin Mathieson 055d654cc2 Add bandwidth figures to RLC stats (per-UE and per-channel).
svn path=/trunk/; revision=34059
2010-09-03 15:22:28 +00:00
Tomas Kukosa a974e115ce Fix start offset and length handling in SEQUNCE OF (caused Gtk crash for sequences at the end of frame)
svn path=/trunk/; revision=34058
2010-09-03 10:31:56 +00:00
Stig Bjørlykke 7ac2adc395 Increase maximum number of nodes to 40.
10 is in some situations too few.

svn path=/trunk/; revision=34057
2010-09-03 09:12:40 +00:00
Stig Bjørlykke d2a3935fb7 Code cleanup: Remove Begin/End comments on each and every code block,
this only makes the code hard to read.

svn path=/trunk/; revision=34056
2010-09-03 09:10:32 +00:00
Stig Bjørlykke 16db2dd4f5 Check if using tree before adding the octet string.
svn path=/trunk/; revision=34055
2010-09-03 08:44:00 +00:00
Anders Broman f92d65f0cb Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34054
2010-09-03 08:41:04 +00:00
Anders Broman 05642bcab3 Add doxygen coments.
svn path=/trunk/; revision=34053
2010-09-03 07:28:51 +00:00
Anders Broman 5cd5da38d2 Add doxygen coments.
svn path=/trunk/; revision=34052
2010-09-03 07:27:59 +00:00
Anders Broman 851d48863c Add a comment
svn path=/trunk/; revision=34051
2010-09-03 07:25:51 +00:00
Anders Broman 4e907d2a70 From Michael Lum:
ANSI-A dissector does not recognize service option 73
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5176

svn path=/trunk/; revision=34050
2010-09-03 06:18:29 +00:00
Anders Broman 956ddcb4b9 From Michael Lum:
The EVRC dissector does not handle service option 73 (EVRC-NW).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5177

svn path=/trunk/; revision=34049
2010-09-03 05:50:55 +00:00
Stig Bjørlykke 67a4451239 Apply the quick fix from bug 2952.
And it's true, this dissector really needs an overhaul!

svn path=/trunk/; revision=34048
2010-09-02 21:30:54 +00:00
Anders Broman 9ebaecb807 Add comments
svn path=/trunk/; revision=34047
2010-09-02 19:23:01 +00:00
Jeff Morriss 7d20440ff0 Introduce 2 new environment variables: WIRESHARK_EP_VERIFY_POINTERS and
WIRESHARK_SE_VERIFY_POINTERS that control whether or not we verify if a given
pointer is ep_ or se_ allocated, respectively.

Turn the behavior off by default for speed reasons (the speed difference isn't
huge, but...).

Turn the behavior on when fuzz testing.

Document these two new variables in the man pages.

svn path=/trunk/; revision=34046
2010-09-02 18:02:06 +00:00
Jeff Morriss 8ffbb8ade8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5173 :
Don't call col_set_str() on a string returned from val_to_str() (which may be
ep_ allocated).

svn path=/trunk/; revision=34045
2010-09-02 17:13:36 +00:00
Stephen Fisher de23882f07 Fix typo in comment: datat -> data
svn path=/trunk/; revision=34044
2010-09-02 17:11:48 +00:00
Anders Broman 3a5f906a72 Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34043
2010-09-02 15:39:15 +00:00
Anders Broman b6fc233757 Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34042
2010-09-02 15:38:04 +00:00
Anders Broman f32d9a570c Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34041
2010-09-02 06:34:04 +00:00
Anders Broman 9b8d6c102c Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34040
2010-09-02 06:22:12 +00:00
Stig Bjørlykke 0b7c31a5eb Ensure we always print the heading when dumping PSML and CSV.
svn path=/trunk/; revision=34039
2010-09-01 20:54:41 +00:00
Anders Broman 0df3d83670 1.4 version does not display the t.38 graph.
(init/remove tap_listener missing)

svn path=/trunk/; revision=34038
2010-09-01 19:42:59 +00:00
Guy Harris ca02af3248 Expand and update comments.
svn path=/trunk/; revision=34037
2010-09-01 17:49:27 +00:00
Anders Broman 5ed4941636 From Jaap Keuter:
Fix Wireshark don't show mgcp calls in "Telephony" => "VoIP calls"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5167

svn path=/trunk/; revision=34036
2010-09-01 12:39:29 +00:00
Anders Broman 136dec3980 From Pascal Quantin:
Patch that allows the dissection of the Feature Group Indicators bit string. I tested it with our UE and it works fine.

svn path=/trunk/; revision=34035
2010-08-31 20:03:46 +00:00
Stig Bjørlykke afd6761f46 A GString has it's own length.
svn path=/trunk/; revision=34034
2010-08-31 18:28:59 +00:00
Stig Bjørlykke f75b4ae02b Support space in list of hidden columns.
This fixes bug 5163.

svn path=/trunk/; revision=34033
2010-08-31 15:02:03 +00:00
Anders Broman fc87f4a4c1 Add stub code for future dissection of featureGroupIndicators.
svn path=/trunk/; revision=34032
2010-08-31 10:50:54 +00:00
Stig Bjørlykke 85b4d16277 Update the header length after dissecting the header.
This fixes bug 5162.

svn path=/trunk/; revision=34031
2010-08-31 10:24:08 +00:00
Stig Bjørlykke fe341f145a Ensure we always update the display filter when changing profile.
svn path=/trunk/; revision=34030
2010-08-31 07:53:51 +00:00
Anders Broman 761149722e Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34029
2010-08-31 05:48:12 +00:00
Bill Meier a35e5c72e9 Add #include <stdio.h> for fprintf
svn path=/trunk/; revision=34028
2010-08-30 23:58:19 +00:00
Anders Broman f51ed4d4c3 Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34027
2010-08-30 20:30:20 +00:00
Anders Broman 749c891a91 Switch to GTK UIManager.
svn path=/trunk/; revision=34026
2010-08-30 19:49:57 +00:00
Jeff Morriss 8016df02f1 Include stdio.h. Fixup indent some.
svn path=/trunk/; revision=34025
2010-08-30 19:14:54 +00:00
Jeff Morriss 16653c5a6c Fix the crash reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5157 :
If get_unicode_or_ascii_string() returns a NULL pointer, return a pointer to an
empty string back to our caller.

svn path=/trunk/; revision=34018
2010-08-30 17:05:37 +00:00
Jeff Morriss b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Jeff Morriss 05f5bf510b Use the top-level isprint.h instead of redefining isprint ourselves.
svn path=/trunk/; revision=34016
2010-08-30 15:33:32 +00:00
Anders Broman 6e5a0a481f Remove a redundant callback.
svn path=/trunk/; revision=34015
2010-08-30 14:32:38 +00:00
Anders Broman 60f258b4e5 Convert to GTKUIManager
svn path=/trunk/; revision=34014
2010-08-30 14:23:25 +00:00
Anders Broman e17efa574d Doxygen fix.
svn path=/trunk/; revision=34013
2010-08-30 14:22:49 +00:00
Stig Bjørlykke 4382dcffad Call dfilter_macro_uat->post_update_cb instead of using cfile.
svn path=/trunk/; revision=34012
2010-08-30 09:31:52 +00:00
Stig Bjørlykke 835a43312f Always update the display filter when changing a display filter macro
and when changing profile.  Not sure why I have to invalidate cfile.dfilter
in macro_update(), because this will be done in macros_post_update(),
but unless this we get a crash when renaming a macro...

This is a fix for bug 5002.

svn path=/trunk/; revision=34011
2010-08-30 08:47:26 +00:00
Stig Bjørlykke 4f6e546d4d Always call post_update_cb() in uat_load_str().
svn path=/trunk/; revision=34010
2010-08-30 08:43:03 +00:00
Anders Broman 6d1a0a2e86 Doxygen related changes.
svn path=/trunk/; revision=34009
2010-08-30 05:39:02 +00:00
Anders Broman 6d0780b8ba Make a note about how to "activare" the filter popup.
svn path=/trunk/; revision=34008
2010-08-30 05:12:27 +00:00
Bill Meier 7ebd25f59e Various:
1. Re-arrange proto_reg_handoff... code to follow the "standard idiom" for init/set of port prefs;
2. Define all fcns as static (except proto_register and proto_reg_handoff);
3. ethereal --> Wireshark;
4. Remove some uneeded/unused prototypes;
5. Fix a few function description comments.

svn path=/trunk/; revision=34006
2010-08-30 01:14:08 +00:00
Anders Broman 21107dff38 Switch to GTK UIManager.
svn path=/trunk/; revision=34002
2010-08-29 19:37:15 +00:00
Anders Broman 687eb5a2a6 Fix for Bug Packet details have errors when decode MAP V2 PRN_ACK msg
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5076

Use:
/*
 * Dissect Multiple Choice Message
 * This function is used to decode a message, when several encoding may be used.
 * For exemple, in the last MAP version, the Cancel Location is defined like this:
 * CancelLocationArg ::= [3] IMPLICIT SEQUENCE
 * But in the previous MAP version, it was a CHOICE between a SEQUENCE and an IMSI
 * As ASN1 encoders (or software) still uses the old encoding, this function allows
 * the decoding of both versions.
 * Moreover, some optimizations (or bad practice ?) in ASN1 encoder, removes the
 * SEQUENCE tag, when only one parameter is present in the SEQUENCE.
 * This explain why the function expects 3 parameters:
 * - a [3] SEQUENCE corresponding the recent ASN1 MAP encoding
 * - a SEQUENCE for old style
 * - and a single parameter, for old version or optimizations
 *
 * The analyze of the first ASN1 tag, indicate what kind of decoding should be used,
 * if the decoding function is provided (so not a NULL function)
 */

svn path=/trunk/; revision=34001
2010-08-29 17:34:44 +00:00