Commit graph

28438 commits

Author SHA1 Message Date
Bill Meier
d7ecb89489 Validate two tag field lengths before attempting to do proto_tree_add_item();
Fixes bug #3841.

svn path=/trunk/; revision=29371
2009-08-10 21:07:15 +00:00
Anders Broman
ca335d25cb From Kovarththanan Rajaratnam:
- Compute and cache color/custom filters dynamically.
- Delay column construction.

svn path=/trunk/; revision=29370
2009-08-10 20:52:56 +00:00
Anders Broman
72d8e6ad54 From Steve Osselton:
GIOP dissector update for MIOP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3847

svn path=/trunk/; revision=29369
2009-08-10 19:53:12 +00:00
Anders Broman
6c352a2959 From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3819

svn path=/trunk/; revision=29368
2009-08-10 19:48:42 +00:00
Bill Meier
41aa8b4ed7 (Quick) fix for bug #3836;
Allow the DIR ("direction") AVP to be of variable length
 (in the absence of any documentation for this protocol).
 See the source for further comments.

svn path=/trunk/; revision=29367
2009-08-10 18:45:47 +00:00
Guy Harris
93ad454c6a Update a comment - a bad packet size could also be the result of a file
not actually being an ERF file.

Don't compute the packet size until you know that rlen is valid.

svn path=/trunk/; revision=29366
2009-08-10 18:22:05 +00:00
Kovarththanan Rajaratnam
7702b8766d Use ! defined(EP_DEBUG_FREE) && ! defined(SE_DEBUG_FREE) to guard canary code to get things compiling after r29358.
svn path=/trunk/; revision=29365
2009-08-10 16:36:44 +00:00
Gerald Combs
c158c4ad69 Don't try to allocate more than WTAP_MAX_PACKET_SIZE. Fixes a crash
reported in bug 3849.

svn path=/trunk/; revision=29364
2009-08-10 16:12:55 +00:00
Gerald Combs
842d1be224 Fix the build.
svn path=/trunk/; revision=29363
2009-08-10 15:33:54 +00:00
Jörg Mayer
1e7031f1c0 Ivan Sy <ivan_jr@yahoo.com> via bug 3814
TTL-Check for local network group addresses: Normally the
only valid TTL is 1. Add a check for VRRP and GLBP, where
the only valid TTL is 255.

Me: change the logic so the funtion returns the valid ttl
    instead of true/false.


svn path=/trunk/; revision=29362
2009-08-10 14:55:47 +00:00
Kovarththanan Rajaratnam
3f4f8b0b94 Add unsigned int typecast
svn path=/trunk/; revision=29361
2009-08-09 21:10:04 +00:00
Kovarththanan Rajaratnam
39b1eb1015 g_error() requires a string literal.
svn path=/trunk/; revision=29360
2009-08-09 20:28:38 +00:00
Kovarththanan Rajaratnam
50c9dbca26 Split common parts of ep_free_all and se_free_all into emem_free_all.
svn path=/trunk/; revision=29359
2009-08-09 20:10:19 +00:00
Kovarththanan Rajaratnam
ecb5ee8e91 Split common parts of se_alloc and ep_alloc into emem_alloc.
svn path=/trunk/; revision=29358
2009-08-09 19:23:13 +00:00
Kovarththanan Rajaratnam
4e177a23c7 Use PITEM_FINFO.
svn path=/trunk/; revision=29357
2009-08-09 18:15:36 +00:00
Kovarththanan Rajaratnam
fa940d3366 Use PTREE_FINFO.
svn path=/trunk/; revision=29356
2009-08-09 18:05:44 +00:00
Kovarththanan Rajaratnam
083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Kovarththanan Rajaratnam
3512e485ca Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail.
svn path=/trunk/; revision=29354
2009-08-09 17:33:23 +00:00
Bill Meier
d3174f0d03 (Trivial): Remove uneeded #includes; make a few fcns static;
svn path=/trunk/; revision=29353
2009-08-09 16:48:28 +00:00
Bill Meier
dd2a488581 g_error() if registering a subtree item type already registered (or not initialized to -1).
svn path=/trunk/; revision=29352
2009-08-09 15:49:02 +00:00
Bill Meier
0a60e46adf 'if(proto_... == -1)' not req'd; Don't register ett[] more than once;
svn path=/trunk/; revision=29351
2009-08-09 15:07:35 +00:00
Gerald Combs
cdb8e2c6b7 [Automatic manuf and enterprise-numbers update for 2009-08-09]
svn path=/trunk/; revision=29348
2009-08-09 15:03:28 +00:00
Kovarththanan Rajaratnam
c1fea16295 Don't use DISSECTOR_ASSERT to check source/destination address type.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3825

svn path=/trunk/; revision=29347
2009-08-09 10:50:30 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam
0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
5d5a5442d6 Don't guard col_set_str (COL_RES_DL_SRC/COL_RES_DL_DST) with col_check
svn path=/trunk/; revision=29343
2009-08-09 07:14:16 +00:00
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
24ca3c44c9 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29341
2009-08-09 06:47:24 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Guy Harris
fc067ab910 Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug
3827.

svn path=/trunk/; revision=29339
2009-08-09 01:23:09 +00:00
Gerald Combs
53a24d94f9 Check TLV lengths before we try to add them to the tree. Fixes bug 3824.
svn path=/trunk/; revision=29338
2009-08-08 22:20:08 +00:00
Kovarththanan Rajaratnam
ca86991181 From Bahaa Naamneh via Bug 3538:
This patch ensures that the filter autocompletion code handles protocols (radius and wimaxasncp) which uses delayed initialisation of protocols fields.

svn path=/trunk/; revision=29337
2009-08-08 12:40:59 +00:00
Kovarththanan Rajaratnam
ced157e4b7 Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658

svn path=/trunk/; revision=29336
2009-08-08 09:57:07 +00:00
Kovarththanan Rajaratnam
d36637e8f5 Pass on WinPcap/MSVC redistributable executables to the WiresharkPortable launcher and not the extractor.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3547.

svn path=/trunk/; revision=29335
2009-08-08 09:22:58 +00:00
Jaap Keuter
4f501b3655 From Ivan Sy:
Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460.

svn path=/trunk/; revision=29334
2009-08-08 04:51:42 +00:00
Guy Harris
6b34dad7f2 Note that the new behavior matches what Wireshark does.
svn path=/trunk/; revision=29333
2009-08-08 01:23:15 +00:00
Guy Harris
643adf19e6 Move one comment before all of the code to which it refers.
Update another comment with information from the corresponding comment
in tshark.c

Move some code so that it's run only if its result is used.

Add an additional comment about logging on UN*X.

svn path=/trunk/; revision=29332
2009-08-08 01:21:55 +00:00
Gerald Combs
7cf4114654 If we have a format error, don't try adding something to the
tree. Fixes bug 3822.

svn path=/trunk/; revision=29331
2009-08-08 00:27:31 +00:00
Bill Meier
d6925b130e fuzz-test: Fix/change WIRESHARK_ABORT_ON_DISSECTOR_BUG handling:
1. If enabled: the variable must be exported to the env to take effect;
2. Upon reflection: disable this feature:
   tshark has been changed to output WARNING messages to stderr as a
    default; This means that DISSECTOR_BUGs and failed DISSECTOR_ASSERTs
     which cause WARNING log level messages will thus be output to stderr and 
     thus will be detected by the fuzz-test.

svn path=/trunk/; revision=29330
2009-08-07 22:36:14 +00:00
Gerald Combs
7110e957f6 From Matt P via bug 3774:
Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3()
routine to dynamically calculate the remaining payload length.  This is then
compared to the length included in the CCSDS header.

svn path=/trunk/; revision=29329
2009-08-07 21:53:40 +00:00
Bill Meier
2a6163ec32 tshark: console_log_level preference now controls which log msgs are sent to stderr;
Note: This is a behavior change: 
      Given the default value for the console_log_level preference
       tshark will now show ERROR, CRITICAL and WARNING level log messages.
      Prior to this change tshark was hardwired to show only
       ERROR and CRITICAL level messages.
      Time will tell whether this change results in too much noise
       in tshark output.

svn path=/trunk/; revision=29328
2009-08-07 21:22:54 +00:00
Jörg Mayer
b6cffe4050 - Add an AC macro to test linker flags.
- Test whether the linker supports --as-needed and if so,
  adds it to LDFLAGS

svn path=/trunk/; revision=29327
2009-08-07 18:49:24 +00:00
Jörg Mayer
952cbd7902 * Tue May 26 2009 cmorve69@yahoo.es
- made it compile with --as-needed

This patch was taken from the opensuse wireshark.spec file.
No thanks go to the author and the package maintainers of
this package for not sending this upstream - it would have
made it into 1.2.0.

svn path=/trunk/; revision=29326
2009-08-07 18:47:56 +00:00
Jörg Mayer
d9531723b5 - Add rfc number comments on not-yet-decoded options
- Decode autoconfigure option

svn path=/trunk/; revision=29325
2009-08-07 18:45:06 +00:00
Kovarththanan Rajaratnam
8bc2261d24 Back out r29323. The non fully qualified path seems to work for everyone else so don't mess with it.
svn path=/trunk/; revision=29324
2009-08-07 14:01:44 +00:00
Kovarththanan Rajaratnam
cdf7fda658 Use fully qualified path to bash
svn path=/trunk/; revision=29323
2009-08-07 13:18:02 +00:00
Kovarththanan Rajaratnam
d2b61c0297 Free frame data slice on file reset
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3813

svn path=/trunk/; revision=29322
2009-08-07 12:15:46 +00:00
Gerald Combs
367bcb7abd Clean up the last two DIRTY_DISSECTOR_SRC entries.
svn path=/trunk/; revision=29321
2009-08-07 00:15:35 +00:00
Bill Meier
3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0'
svn path=/trunk/; revision=29320
2009-08-06 23:51:45 +00:00