Stig Bjørlykke
377ea887bb
Improved a if-check to avoid a analyzis warning.
...
svn path=/trunk/; revision=41508
2012-03-12 17:18:54 +00:00
Stig Bjørlykke
da8cd5d5bd
Value can't be negative if no_of_bits == 0
...
svn path=/trunk/; revision=41507
2012-03-12 17:18:04 +00:00
Anders Broman
35bf2e9619
From Jose Pedro Oliveira:
...
Enforce the modelines in wiretap/pcapng.c
svn path=/trunk/; revision=41506
2012-03-12 15:43:59 +00:00
Anders Broman
cbde63643e
From Jose Pedro Oliveira:
...
Enforce the modelines in dumpcap.c and in pcapio.c
svn path=/trunk/; revision=41505
2012-03-12 15:40:57 +00:00
Bill Meier
0400088936
Minor reformatting, whitespace and style changes.
...
svn path=/trunk/; revision=41504
2012-03-12 15:15:39 +00:00
Bill Meier
3dd8ed0279
Use consistent indentation;
...
Do minor reformatting.
svn path=/trunk/; revision=41503
2012-03-12 14:40:09 +00:00
Bill Meier
ba2cda4ef0
Cleanup & minor bug fixes:
...
- Don't put a value_string array in a .h file (included in several .c files);
- 'if ((a!=NULL) && !b) {fail}' should be 'if ((a==NULL) || !b) {fail}' in a few cases;
- Use value_string_ext as appropriate;
- Use val_to_str_const() in place of val_to_str() as appropriate;
- Use tvb_new_subset_remaining(...) instead of tvb_new_subset(..., -1, -1);
- Use tvb_reported_length_remaining() in place of tvb_length_remaining() in some cases;
- tvb_reported_length_remaining() can return -1;
- Use of TFS(&true_false) not req'd since "True"/"False" is the default if no TFS provided;
- Reformat various (long lines, etc);
- Use consistent indentation.
svn path=/trunk/; revision=41502
2012-03-12 14:38:59 +00:00
Anders Broman
3394b453af
Free idb_inf and shb_hdr when done.
...
svn path=/trunk/; revision=41501
2012-03-12 14:18:04 +00:00
Martin Mathieson
d772d2acd2
Add checkboxes to filter for RACH attempts and SRs.
...
svn path=/trunk/; revision=41500
2012-03-12 13:19:28 +00:00
Martin Mathieson
9560aab8c2
Add a checkbox to filter for RACH attempts.
...
svn path=/trunk/; revision=41499
2012-03-12 13:18:56 +00:00
Anders Broman
b2515852f9
Add doxygen tags.
...
svn path=/trunk/; revision=41498
2012-03-12 12:18:02 +00:00
Anders Broman
755f8dc98d
From Tyson Key:
...
Dissector for the NXP PN532 protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6903
svn path=/trunk/; revision=41497
2012-03-12 08:55:14 +00:00
Anders Broman
8fa5ef33f9
From Jose Pedro Oliveira: Add Modlines
...
svn path=/trunk/; revision=41496
2012-03-12 06:42:47 +00:00
Anders Broman
1a8f3eddc7
From Jose Pedro Oliveira: Add Modlines
...
svn path=/trunk/; revision=41495
2012-03-12 06:39:45 +00:00
Guy Harris
3af7f28931
capture_opts_add_iface_opt() is not used outside capture_opts.c; make it
...
static.
svn path=/trunk/; revision=41494
2012-03-12 02:53:21 +00:00
Martin Mathieson
5a84afd814
Within a status report, check that NACK_SNs are not 'ahead' of ACK_SN.
...
svn path=/trunk/; revision=41493
2012-03-11 23:44:03 +00:00
Anders Broman
c00ca87104
From Steve Magnani: knock URB Setup out from under USB URB https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6934
...
svn path=/trunk/; revision=41492
2012-03-11 22:31:18 +00:00
Guy Harris
681c29c5d5
Don't close the currently loaded capture file in capture_start(), do so
...
in its callers; when starting a capture with "wireshark -k", there's no
capture file to close, and closing it might be provoking some UI actions
that cause crashes on Windows.
Don't copy the list of selected interfaces to the list of capture
interfaces in capture_start(), either, do that in the callers; we were
already doing that in one place and, in one of the remaining cases,
namely "wireshark -k", we should do so only if no capture interfaces
were supplied on the command line. (I.e., the set of interfaces on
which we want to capture depends on where in the UI the capture is being
started.)
svn path=/trunk/; revision=41491
2012-03-11 20:08:54 +00:00
Guy Harris
6f3ee54d62
Add a comment to indicate what collect_ifaces() does.
...
svn path=/trunk/; revision=41490
2012-03-11 20:01:11 +00:00
Guy Harris
7f6caeb730
If the length is bogus in a message received from the sync pipe, dump
...
out all 4 bytes we read, to provide more information about the message
that was sent so it's easier to see if something was spewing extra
output to the standard output or error in the child.
svn path=/trunk/; revision=41489
2012-03-11 20:00:39 +00:00
Guy Harris
6486942282
Fix function name in debugging message.
...
svn path=/trunk/; revision=41488
2012-03-11 19:59:08 +00:00
Anders Broman
b8fd91e8c1
Add a comments LED
...
svn path=/trunk/; revision=41487
2012-03-11 19:31:10 +00:00
Alexis La Goutte
55ca59ffb9
From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6787
...
Move Y.1711 out of MPLS dissector
ITU-T Y.1711 code was "embedded" into the MPLS dissector in 2006.
This patch moves it into its own dissector.
From me :
Fix a Clang warning
svn path=/trunk/; revision=41486
2012-03-11 19:05:32 +00:00
Gerald Combs
69b533085b
[Automatic manuf, services and enterprise-numbers update for 2012-03-11]
...
svn path=/trunk/; revision=41483
2012-03-11 14:03:34 +00:00
Stig Bjørlykke
b71ce5d268
Do not assign a value to itself.
...
svn path=/trunk/; revision=41482
2012-03-11 14:03:13 +00:00
Stig Bjørlykke
b049f8a976
Return a valid offset from process_app0_segment().
...
The return value is not used, but this removes a warning.
svn path=/trunk/; revision=41481
2012-03-11 14:02:59 +00:00
Stig Bjørlykke
3d8a2927a7
Remove extraneous parentheses around some comparisons to silence a warning.
...
svn path=/trunk/; revision=41480
2012-03-11 12:00:27 +00:00
Stig Bjørlykke
6a724c8d83
Free name string only when used.
...
svn path=/trunk/; revision=41479
2012-03-11 12:00:13 +00:00
Stig Bjørlykke
1301b98e25
Use _U_ for unused arguments.
...
svn path=/trunk/; revision=41478
2012-03-11 12:00:00 +00:00
Guy Harris
42df48aab0
capture_opts_add_opt() does just fine at adding an interface to the
...
capture options, so don't special-case the -i option.
svn path=/trunk/; revision=41477
2012-03-11 07:10:48 +00:00
Guy Harris
7676b02551
Reflect the rename of the Xylan RADIUS dictionary.
...
svn path=/trunk/; revision=41476
2012-03-10 19:05:46 +00:00
Alexis La Goutte
d14a0dad80
Fix QtShark build after the move of alert_box.c in ui folder
...
svn path=/trunk/; revision=41475
2012-03-10 19:00:34 +00:00
Alexis La Goutte
d23c469785
Rename the Xylan dictionnary to Alcatel-Lucent Xylan dictionnary
...
Alcatel (now Alcatel-Lucent) buy Xylan in 1999...
And now Attributs RADIUS is used in Alcatel-Lucent Omniswitch Product.
svn path=/trunk/; revision=41474
2012-03-10 18:30:20 +00:00
Alexis La Goutte
4c64d32a03
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41473
2012-03-10 17:51:47 +00:00
Alexis La Goutte
515612450e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41472
2012-03-10 17:51:32 +00:00
Alexis La Goutte
b60c478326
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41471
2012-03-10 17:51:18 +00:00
Alexis La Goutte
bce5a791fc
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41470
2012-03-10 17:50:28 +00:00
Alexis La Goutte
1dee4d224e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41469
2012-03-10 17:49:33 +00:00
Alexis La Goutte
63b9d7324e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41468
2012-03-10 17:49:17 +00:00
Alexis La Goutte
27f56dd47f
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41467
2012-03-10 17:49:00 +00:00
Alexis La Goutte
342c647ed4
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41466
2012-03-10 17:48:33 +00:00
Alexis La Goutte
2561aad178
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41465
2012-03-10 17:48:17 +00:00
Alexis La Goutte
bdbe07fe0a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41464
2012-03-10 17:47:28 +00:00
Alexis La Goutte
6ee4ab9692
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41463
2012-03-10 17:47:07 +00:00
Alexis La Goutte
5634cf10fd
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41462
2012-03-10 17:46:18 +00:00
Alexis La Goutte
ba19f72aab
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41461
2012-03-10 17:45:17 +00:00
Anders Broman
edbdf1b6de
Don't register the payload type unless it's in the dynamic range
...
svn path=/trunk/; revision=41460
2012-03-10 17:00:30 +00:00
Anders Broman
970272235d
From martijn: subdissectors for URB_INTERRUPT. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6929
...
svn path=/trunk/; revision=41459
2012-03-10 16:16:07 +00:00
Anders Broman
f030f799bd
From Steve Magnani: USB: centralize some common dissection code for class reuse. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6930
...
svn path=/trunk/; revision=41458
2012-03-10 16:09:28 +00:00
Guy Harris
5dc7d02ed8
Replace 4-space tabs (and one 8-space tab, the only remaining tab in the
...
file after replacing the 4-space tabs) with spaces.
svn path=/trunk/; revision=41457
2012-03-10 09:08:03 +00:00