(Additional instances requiring feedback from the dissector author have
been marked with XXX).
For 'hf_om2k_aop' use a bitmask in the hf[] entry rather than shifting & etc
in the proto_tree_add_uint() call.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792 Comment #8.
svn path=/trunk/; revision=41612
Error: the name for field "Initial Resource Locator Length " ("eiss.aid.irl.length") has trailing space in packet-eiss.c
Error: the name for field "Initial Resource Locator String " ("eiss.aid.irl.string") has trailing space in packet-eiss.c
svn path=/trunk/; revision=41601
make them apply to C++ as well as C. That seems to be what the autoconf
documentation suggests:
- Variable: CFLAGS
Debugging and optimization options for the C compiler. If it is not set
in the environment when configure runs, the default value is set when
you call AC_PROG_CC (or empty if you don't). configure uses this
variable when compiling or linking programs to test for C features.
If a compiler option affects only the behavior of the preprocessor
(e.g., -Dname), it should be put into CPPFLAGS instead. If it affects
only the linker (e.g., -Ldirectory), it should be put into LDFLAGS
instead. If it affects only the compiler proper, CFLAGS is the natural
home for it. If an option affects multiple phases of the compiler,
though, matters get tricky. One approach to put such options directly
into CC, e.g., CC='gcc -m64'. Another is to put them into both CPPFLAGS
and LDFLAGS, but not into CFLAGS.
...
- Variable: CPPFLAGS
Preprocessor options for the C, C++, Objective C, and Objective C++
preprocessors and compilers. If it is not set in the environment when
configure runs, the default value is empty. configure uses this variable
when preprocessing or compiling programs to test for C, C++, Objective
C, and Objective C++ features.
This variable's contents should contain options like -I, -D, and -U that
affect only the behavior of the preprocessor. Please see the explanation
of CFLAGS for what you can do if an option affects other phases of the
compiler as well.
svn path=/trunk/; revision=41593
description of existing menus must be accurate: if a name and action are
both specified then the to-be-added-XML must include both the name and the
action.
It appears that the formats given in stat_group_name()'s value_string were
designed to take this into account, but there was no code to separate the menu
name from its action. Adding that separation is complicated by the fact that
menus are separated by /'s and actions may also contain that character. To
deal with that, "escape" the /'s in actions by replacing them with #'s.
make_menu_xml() then un-escapes them back into /'s.
There has to be an easier way to do all of this...
svn path=/trunk/; revision=41591
In some cases:
Use val_to_str_const() instead of val_to_str();
Reformat long lines;
Do some general whitespace changes.
svn path=/trunk/; revision=41587
indicate whether the flag is C-only, C++-only, or for both compilers;
pass the appropriate value for C-only flags. Have the "Checking for..."
message indicate whether we're adding to CFLAGS, CXXFLAGS, or both.
(Yes, the macro should probably be renamed. "GCC" refers to the GNU
Compiler Collection, which includes a C++ compiler, although that's also
used for compilers that are more-or-less compatible with the ones from
the GNU Compiler Collection, such as the clang compilers.)
We set -Wformat-security whether or not --enable-extra-gcc-checks was
specified, so we don't need to do it again if it was specified.
svn path=/trunk/; revision=41586
FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;
General whitespace & formatting changes.
svn path=/trunk/; revision=41579
hf[] FT_BOOLEAN entry with 0 bitmask should have BASE_NONE as 'display' (benign);
Enforce modelines (Convert '4 space tabs' to spaces);
Do general formatting and whitespace cleanup.
svn path=/trunk/; revision=41569
Michael Tüxen