Commit Graph

49993 Commits

Author SHA1 Message Date
Martin Kaiser cc30b3597b dissect Operator Profile's delivery capability bytes
svn path=/trunk/; revision=53320
2013-11-14 21:40:59 +00:00
Bill Meier a3cb8fdf95 Create/use value_string_ext to reference certain value-string-arrays.
Define a char array as const.
Remove an unneeded initializer.
Add editor modelines.
Do some minor whitespace changes.

svn path=/trunk/; revision=53319
2013-11-14 21:32:47 +00:00
Chris Maynard d369ee8c05 Cast the return value of conversation_get_proto_data() to whois_transaction_t *.
svn path=/trunk/; revision=53318
2013-11-14 21:20:49 +00:00
Chris Maynard 2f523fd9fd Add a basic whois dissector.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9357

svn path=/trunk/; revision=53317
2013-11-14 21:04:05 +00:00
Bill Meier 87594e3124 Create/use value_string_ext for some value-string-arrays.
Define several char arrays as const.
Add editor modelines.
Do some minor whitespace changes.

svn path=/trunk/; revision=53316
2013-11-14 20:32:58 +00:00
Gerald Combs ccb6da1058 Fix automake compilation.
svn path=/trunk/; revision=53315
2013-11-14 18:55:50 +00:00
Gerald Combs 190bdc32de Add packet information and selection to the Follow Stream dialog.
Collect packet numbers when following streams so that we can correlate
text positions with packets. Add a FollowStreamText class so that we can
track mouse events. Add a hint label that shows the packet under the
cursor along with packet counts and the number of "turns".

Add the packet number to the C array dump. Note that dumping to YAML
might be useful for Scapy users.

svn path=/trunk/; revision=53314
2013-11-14 17:37:40 +00:00
Evan Huus 2809240ead Add a cast to try and fix the OSX buildbot.
svn path=/trunk/; revision=53313
2013-11-14 13:07:53 +00:00
Pascal Quantin 488cf801a2 Fix dissection of MBIM Extended Functional Descriptor MTU
svn path=/trunk/; revision=53312
2013-11-14 09:43:32 +00:00
Anders Broman a7e417bf24 Get rid of Warinings [-Wmissing-prototypes]
svn path=/trunk/; revision=53311
2013-11-14 06:21:02 +00:00
Evan Huus bfca717c45 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9303 based on patch and
help from Matthieu Patou.

If the DCE-RPC heuristic failed to identify a TVB, *but* we've already decoded
a DCE-RPC layer in this packet *and* the heuristic failed because we didn't have
enough data, make the reasonable assumption that it actually is another DCE-RPC
packet, and ask TCP to desegment more data for us and try again.

svn path=/trunk/; revision=53310
2013-11-14 03:34:01 +00:00
Evan Huus b13c1b7093 The kafka compression codec is only 2 bits, not 3.
svn path=/trunk/; revision=53309
2013-11-13 23:47:57 +00:00
Evan Huus fc08bf1143 Fix what appears to be a mistake during the conversion in r53036 from
dissector_try_uint to dissector_try_uint_new: protocols called due to TCP port
matching were not getting added to the list of protocols in the frame. The
"add_proto_name" parameter should be TRUE except in unusual circumstances.

svn path=/trunk/; revision=53308
2013-11-13 23:43:08 +00:00
Martin Kaiser 329873cf97 share service type descriptions between MPEG descriptor and DVB-CI
svn path=/trunk/; revision=53307
2013-11-13 23:10:01 +00:00
Gerald Combs b0063a025b Highlight selected sequence diagram items.
Create a new dialog each time the user follows a stream. A lot of the
follow code seems to assume one and only one dialog so there are likely
outstanding bugs.

Don't use the global cfile (should we deprecate its usage?). We want to
move closer to multiple documents, not further away.

Clean up after ourselves. Free our payload list and unlink our temp
file. Make a bunch of gchar*s QStrings. Make sure our destructor gets
called and use it.

Make member variable and method names more consistent.

svn path=/trunk/; revision=53306
2013-11-13 22:18:01 +00:00
Martin Kaiser 3e41e172db dissect Refresh Request Flag
svn path=/trunk/; revision=53305
2013-11-13 21:52:33 +00:00
Martin Kaiser ff7f1c80cf dissect Operator Profile's delivery system hint
svn path=/trunk/; revision=53304
2013-11-13 20:41:00 +00:00
Bill Meier 014bbf19b3 (Minor cleanup): unneeded initializers, whitespace, long-lines, typos
svn path=/trunk/; revision=53303
2013-11-13 19:29:37 +00:00
Pascal Quantin 53a29dee19 Add more GSM SIM Toolkit info to info column
svn path=/trunk/; revision=53302
2013-11-13 17:28:18 +00:00
Jeff Morriss 219fb7fa3e Fix CID 1113411: close the file descriptor and free the file name even in
error cases.

svn path=/trunk/; revision=53301
2013-11-13 17:11:21 +00:00
Jeff Morriss 6b7ab3bd33 Make subpackage Requires: more generic.
svn path=/trunk/; revision=53300
2013-11-13 16:16:06 +00:00
Jeff Morriss 38eac2f54f Wrap GCC pragma in an #ifdef to make it compile when we're not using GCC.
Again, change manually applied to the .h file.

svn path=/trunk/; revision=53299
2013-11-13 14:00:45 +00:00
Jeff Morriss 8893d3d960 Use a gcc pragma to stop the (pages of) warnings coming out of
x11-extensions-implementation.h .

This change was manually applied to the .h file as I can't currently rebuild
the X11 dissector.

svn path=/trunk/; revision=53298
2013-11-13 03:20:37 +00:00
Jeff Morriss 78f8757560 Add a (wireshark-)qt package that contains the Qt-based GUI (and the necessary
desktop-integration files); build it by default.

Use 'alternatives' to choose which GUI actually gets used; give the Gtk
GUI priority over the Qt one (for now).

svn path=/trunk/; revision=53297
2013-11-13 03:01:42 +00:00
Gerald Combs 3009823060 Simplify the CLI preinstall script a bit and hopefully get rid of an error.
svn path=/trunk/; revision=53296
2013-11-13 02:50:25 +00:00
Jeff Morriss a1a63baa7c Set SVN properties.
svn path=/trunk/; revision=53295
2013-11-13 01:52:06 +00:00
Gerald Combs fd81ae57a6 Highlight selected sequence diagram items.
svn path=/trunk/; revision=53294
2013-11-12 22:50:26 +00:00
Guy Harris 6461057a52 Now that fvalue_to_string_repr() returns NULL if the fvalue's ftype has
no val_to_string_repr method, we don't need to check whether it has such
a method, and thus don't need to include epan/ftypes/ftypes-int.h.

svn path=/trunk/; revision=53293
2013-11-12 22:22:23 +00:00
Pascal Quantin 3c22e05688 tabs -> spaces
svn path=/trunk/; revision=53292
2013-11-12 22:09:10 +00:00
Pascal Quantin 0e20c39cdc Fix a typo error
svn path=/trunk/; revision=53291
2013-11-12 22:07:11 +00:00
Guy Harris 409dd075c6 Replace fvalue_ftype() with a fvalue_type_ftenum() routine that returns
the ftenum_t for the fvalue's ftype, rather than a pointer to the ftype
(which isn't all that useful except as a handle, unless you import the
internal header).

Have fvalue_to_string_repr() return NULL, rather than failing, if the
fvalue's ftype has no val_to_string_repr method.

This lets us not include the ftypes internal header in
ui/cli/tap-diameter-avp.c.

svn path=/trunk/; revision=53290
2013-11-12 22:06:00 +00:00
Martin Kaiser 72f3c258a0 share the text description of service types between MPEG PMT and DVB-CI
svn path=/trunk/; revision=53289
2013-11-12 22:04:47 +00:00
Michael Mann 7221215cdc Add "rtp handle protection" inside srtp_add_address/rtp_add_address/bluetooth_add_address so dissectors calling it don't need to find "rtp" just for the handle check.
svn path=/trunk/; revision=53288
2013-11-12 22:04:03 +00:00
Martin Kaiser 99f0fc1d27 From Michal Labedzki
add forward declarations

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9333

svn path=/trunk/; revision=53287
2013-11-12 21:48:13 +00:00
Martin Kaiser 7221138871 From Michal Labedzki
change two local variables to gint16 so we can store
-1 for invalid value

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9333

svn path=/trunk/; revision=53286
2013-11-12 21:45:50 +00:00
Martin Kaiser bcf10a8b17 From robionekenobi
add expert info for invalid item length in mq pcf

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9411

svn path=/trunk/; revision=53285
2013-11-12 21:28:27 +00:00
Michael Mann 29ff6875d9 LMP dissector can't be called by anything but UDP, so no need to check that.
svn path=/trunk/; revision=53284
2013-11-12 21:22:37 +00:00
Michael Mann a661864f48 Add "T.38 handle protection" inside t38_add_address() so dissectors calling it don't need to find "t38" just for the handle check.
svn path=/trunk/; revision=53283
2013-11-12 21:10:20 +00:00
Jeff Morriss f56aa72157 Don't do our own line wrapping of the display filter, let GTK do it for us.
(With this change all the right-hand columns in this dialog will wrap if
necessary whereas before only the display filter would wrap lines.)

svn path=/trunk/; revision=53282
2013-11-12 20:47:03 +00:00
Gerald Combs 30bdf66b1f Fix permissions for installed OS X files and directories.
Add a cli-preinstall script that creates missing parts of the
installation path and sets their permissions. Simply copy
"utility-launcher" to "wireshark" instead of renaming it at install
time. Explicitly set its ownership and permissions. Pretty-print some of
the PackageMaker XML files via `xmllint --format --recover`.

svn path=/trunk/; revision=53281
2013-11-12 20:38:58 +00:00
Gerald Combs 4525c64797 Fix compilation on Windows.
svn path=/trunk/; revision=53280
2013-11-12 19:31:02 +00:00
Gerald Combs 4299d4e26a Try to fix compilation for GLib < 2.30.
svn path=/trunk/; revision=53279
2013-11-12 19:12:40 +00:00
Jeff Morriss a97460a39c Add an item for any unknown tags we come across (just as FT_BYTES).
svn path=/trunk/; revision=53278
2013-11-12 18:57:14 +00:00
Jeff Morriss 64f0cafbad De-duplicate some code by changing a while loop to a do-while loop.
svn path=/trunk/; revision=53277
2013-11-12 18:49:57 +00:00
Gerald Combs 1d8a895fa4 Try using UTF8_RIGHTWARDS_ARROW to indicate direction.
If this doesn't cause any problems we should probably move
utf8_entities.h from ui to wsutil.

svn path=/trunk/; revision=53276
2013-11-12 17:34:50 +00:00
Gerald Combs 89db79a6aa When we dump a sequence diagram to text, make sure labels are truncated.
svn path=/trunk/; revision=53275
2013-11-12 17:02:17 +00:00
Michael Mann 76bfa2ce1a Remove usb_conv_info_t from packet_info and pass the data directly into the subdissectors. Bug 9413 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9413)
svn path=/trunk/; revision=53274
2013-11-12 13:46:51 +00:00
Martin Kaiser 2b729ba554 From Michal Labedski
fix Logically Dead Code: allow cmd==0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9420

svn path=/trunk/; revision=53273
2013-11-12 11:53:05 +00:00
Irene Rüngeler ecad809645 Fix segfault bug and show the combo-box.
svn path=/trunk/; revision=53272
2013-11-12 10:22:27 +00:00
Irene Rüngeler 480869402d Use the right threshold.
svn path=/trunk/; revision=53271
2013-11-12 10:21:17 +00:00