Commit Graph

13843 Commits

Author SHA1 Message Date
Jeff Morriss 8ad4c4efdd Don't use g_strcmp0(): it only exists in glib > 2.16.
Make read_length() static.

Start function names at column 0.

svn path=/trunk/; revision=34565
2010-10-18 21:55:56 +00:00
Bill Meier be1a3f5a7e Try to fix compile errors on 64 bit systems.
svn path=/trunk/; revision=34561
2010-10-18 18:37:07 +00:00
Bill Meier 8832221ca4 Remove some unneeded #includes ...
svn path=/trunk/; revision=34560
2010-10-18 17:46:12 +00:00
Martin Mathieson 7e938c7071 Don't clear info column when showing MAC or RLC-level info.
svn path=/trunk/; revision=34559
2010-10-18 17:02:19 +00:00
Bill Meier 13b8efbf25 From Holger Grandy: ETCH dissector
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5095

From me: Fix a bug in add_symbol which caused occasional Wireshark crashes;
         Add additional checking during parse of symbol hash file;
         Improve "directory not found" error message;
         Do misc code cleanup and simplification.

svn path=/trunk/; revision=34558
2010-10-18 16:15:12 +00:00
Jeff Morriss b0ab72ac70 Use port range for SCTP too.
svn path=/trunk/; revision=34557
2010-10-18 15:56:06 +00:00
Jeff Morriss 418b9b2958 Add SVN:Id tag. Copy copyright notice to the header file.
svn path=/trunk/; revision=34555
2010-10-18 13:26:35 +00:00
Jeff Morriss 13c4798e8c Add SVN:Id tag.
svn path=/trunk/; revision=34554
2010-10-18 13:24:10 +00:00
Stig Bjørlykke dcbd634884 Remove blurbs equal to name.
svn path=/trunk/; revision=34551
2010-10-18 07:41:47 +00:00
Stig Bjørlykke 7e42c00c9c Added some length checks for integers.
This fixes bug 5305.

svn path=/trunk/; revision=34550
2010-10-18 07:13:45 +00:00
Jörg Mayer 6ab1662ca7 Add expert info if the eth src mac has the I/G bit set
svn path=/trunk/; revision=34548
2010-10-17 20:28:20 +00:00
Stig Bjørlykke df48a37c2e Use correct abbrev for fragment entries.
svn path=/trunk/; revision=34547
2010-10-17 18:33:50 +00:00
Stig Bjørlykke 54671a1ebe Removed unused entries.
svn path=/trunk/; revision=34546
2010-10-17 18:16:44 +00:00
Stig Bjørlykke 305748ea57 Removed unused hf_xcsl.
svn path=/trunk/; revision=34542
2010-10-17 16:38:15 +00:00
Stig Bjørlykke 2b32589942 Removed unused hf_sasp.
svn path=/trunk/; revision=34541
2010-10-17 16:36:32 +00:00
Stig Bjørlykke 6fd85b83a4 Fixed typo in "Reason" abbrev.
svn path=/trunk/; revision=34540
2010-10-17 16:33:28 +00:00
Gerald Combs 2e00350103 [Automatic manuf, services and enterprise-numbers update for 2010-10-17]
svn path=/trunk/; revision=34538
2010-10-17 15:03:47 +00:00
Stig Bjørlykke 18ddeb1de5 Fixed typo in "SSI Noise (dBm)" abbrev.
svn path=/trunk/; revision=34537
2010-10-17 14:30:11 +00:00
Stig Bjørlykke 2b37214674 From Pascal Quantin via bug 5301:
Make the PER constaints check like in the BER dissector.

svn path=/trunk/; revision=34536
2010-10-17 14:07:05 +00:00
Anders Broman fdb2192631 From Pascal Quantin:
[NAS EPS] Enhance dissection of APN-AMBR IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5304

svn path=/trunk/; revision=34535
2010-10-17 14:04:59 +00:00
Stig Bjørlykke 8b5bb7d7ce From Benjamin Roch via bug 3418:
Use eth.src, eth.dst and eth.type from the ethernet dissector.

From me:
Removed unused code inside #if 0.

svn path=/trunk/; revision=34534
2010-10-17 14:02:06 +00:00
Stig Bjørlykke 396d8e3e18 From Benjamin Roch via bug 3418:
Added string values to tte.pcf.type.

svn path=/trunk/; revision=34533
2010-10-17 13:59:46 +00:00
Stig Bjørlykke ce60782e08 coap_handle is only used in proto_reg_handoff_coap.
svn path=/trunk/; revision=34532
2010-10-17 12:20:25 +00:00
Stig Bjørlykke 38ba5119cd From Pascal Quantin via bug 5301:
Add expert info when ASN.1 PER constrained integer does not match range.

svn path=/trunk/; revision=34531
2010-10-17 11:59:10 +00:00
Stig Bjørlykke 9d253d77ad From Shoichi Sakane via bug 5270:
Added COAP protocol support.

From me:
Made the port number configurable.

svn path=/trunk/; revision=34530
2010-10-17 11:48:40 +00:00
Martin Mathieson 1077ec28f6 Improve info column when showing PHY info for MAC frames.
svn path=/trunk/; revision=34529
2010-10-15 21:32:35 +00:00
Martin Mathieson 52e5567b2e Track and give link back to frame containing previous NACK.
svn path=/trunk/; revision=34528
2010-10-15 21:07:45 +00:00
Jörg Mayer 2556852f9e Make the telnet data lines filterable elements.
svn path=/trunk/; revision=34527
2010-10-15 21:02:30 +00:00
Martin Mathieson 9d87437659 Add volatile in several places to gcc warnings.
svn path=/trunk/; revision=34526
2010-10-15 18:41:12 +00:00
Jeff Morriss 37b28dda16 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5295 :
Use macros for message type values and add an expert info for an incorrect
Magic Cookie.

svn path=/trunk/; revision=34525
2010-10-15 17:48:35 +00:00
Stig Bjørlykke 2b34ed288b Avoid getting BoundsError when trying to decode OCTET STRING or
unknown primitive as constructed ASN.1 BER encoded data.

svn path=/trunk/; revision=34520
2010-10-15 11:10:20 +00:00
Stig Bjørlykke 8b9c15d68f Added info column descriptions for AARQ and AARE.
svn path=/trunk/; revision=34519
2010-10-15 08:39:48 +00:00
Stig Bjørlykke e91a7ad6f7 Added packet-radiotap-iter.c
svn path=/trunk/; revision=34517
2010-10-14 18:13:39 +00:00
Gerald Combs dc46e7db50 Tighten up our data rate check. This should fix bug 5280 (mostly).
svn path=/trunk/; revision=34516
2010-10-14 18:09:57 +00:00
Gerald Combs ea4ca0524b From Johannes Berg via bug 4421:
radiotap: new parser

The current parser has a number of bugs, most
importantly not being able to parse radiotap
files with multiple presence bitmaps. It is
also rather hard extend. Use a generic library
for parsing radiotap that can be extended very
easily.


From me:

Dumb down some initializers and add some casts to make Visual C++ happy.

svn path=/trunk/; revision=34515
2010-10-14 17:56:06 +00:00
Bill Meier 15851701e8 Rework "extended value strings":
- Allow direct access when a range of values begins with a value other than 0;
- Provide value_string_ext_new() for creating extended value strings at runtime;
- Do access to value_string_ext members via a macro (all but value_string.c);
- Update documentation.

svn path=/trunk/; revision=34514
2010-10-14 17:50:35 +00:00
Stig Bjørlykke 6ead8f1ae5 Support multiple header fields with the same abbreviation in custom columns.
We have some different fields using the same abbreviation (e.g "eth.dst"
used in both eth and tte), and this patch will fetch values from all fields.
When using occurrences the entries listed first is from the field registered
last when starting Wireshark, and not ordered from the occurrence in the
packet, but I don't see how we can easily fix this.

svn path=/trunk/; revision=34513
2010-10-14 13:11:03 +00:00
Bill Meier ce887cb60d Fix crash for 'tshark -G values' when printing "extended value string" value.
Fixes bug #5296 [ https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5296 ]

svn path=/trunk/; revision=34507
2010-10-14 04:53:07 +00:00
Jeff Morriss ebc190645f From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4615 :
The attached patch adds the missing decoded fields
by moving the proto_tree_add_item() call so that it
is no longer within an error handler and will be
called under normal circumstances (as well as error conditions.


From me: Apply the change to the ASN.1 source.  Also some white space
indentation cleanup.

svn path=/trunk/; revision=34505
2010-10-14 01:44:27 +00:00
Jeff Morriss aa749665c5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5295 :
Hi a patch to enchance the PPTP Dissector
It is a rework of PPTP dissector 
- Replace proto_tree_add_text by proto_tree_add_item 
- Replace not standard table and function by standard value_string
- ....

The code is checked and fuzzed (more 200 pass) ! with personnal PPTP Sample and
PPTP Sample from pcapr.net

svn path=/trunk/; revision=34504
2010-10-14 01:10:51 +00:00
Gerald Combs fc260f7967 From Johannes Berg via bug 4421:
radiotap: re-indent

The current file has very strange mix of various
indentation sometimes using spaces and sometimes
using tabs which is rather hard to keep intact,
so reindent it completely.

svn path=/trunk/; revision=34503
2010-10-13 21:30:27 +00:00
Bill Meier 05168e614f Access several large value-string arrays via extended value-string functions.
svn path=/trunk/; revision=34501
2010-10-13 18:51:23 +00:00
Bill Meier 5ed532268f Use extended value string functions to access dce_error_vals (which has 4397 entries)
svn path=/trunk/; revision=34500
2010-10-13 17:56:05 +00:00
Bill Meier 45da078b7d Use val_to_str_ext_const for refs to the extended value strings;
Extern the extended value strings struct (not the value_string arrays themselves) so
 any external use of these arrays is via the extended value string functions.

svn path=/trunk/; revision=34499
2010-10-13 16:47:13 +00:00
Guy Harris f2f1023487 Fix comments (not all platforms on which we run support dlopen(), but
GLib handles that with g_module_open() as a platform-independent "load a
module at run time" wrapper).

svn path=/trunk/; revision=34491
2010-10-12 18:25:42 +00:00
Bill Meier c78221d4ce Rename g_resolv_flags --> gbl_resolv_flags; Also: cleanup some whitespace & indentation.
svn path=/trunk/; revision=34487
2010-10-12 13:15:08 +00:00
Jeff Morriss 0267a5293d Fix an error in a comment I added last week.
svn path=/trunk/; revision=34480
2010-10-11 20:16:35 +00:00
Bill Meier e7568712ef Define some fcns & vars as static;
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
2010-10-11 19:00:55 +00:00
Jeff Morriss 074e49fd41 hf variables can be copied/passed by value, not by reference.
svn path=/trunk/; revision=34467
2010-10-11 01:52:41 +00:00
Jeff Morriss 6deff94555 Add comments indicating that the DISSECTOR_ASSERT() routines should not be used to report malformed packets.
svn path=/trunk/; revision=34466
2010-10-11 01:28:22 +00:00
Bill Meier 0b9a803e45 #include <string.h> apparently req'd on OSX ...
svn path=/trunk/; revision=34465
2010-10-10 23:48:16 +00:00
Bill Meier 93b94a23ca Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
Bill Meier 09d718f723 Rename vals_status & vals_pdu_type to wsp_vals_status & wsp_vals_pdu_type
svn path=/trunk/; revision=34463
2010-10-10 20:45:19 +00:00
Bill Meier 4ae8d25300 Minor code cleanup:
- define some vars & fcns as static;
- remove an unused var;
- use tfs_set_notset in tfs.c;
- slightly simplify reg_handoff.

svn path=/trunk/; revision=34462
2010-10-10 20:39:00 +00:00
Bill Meier 4d56c5b57b Define a variable as static; Minor code simplification.
svn path=/trunk/; revision=34461
2010-10-10 20:28:22 +00:00
Bill Meier 6486e8b781 Combine packet-opsi.h with packet-opsi.c (since not used elsewhere); Define some fcns as static.
svn path=/trunk/; revision=34460
2010-10-10 20:19:05 +00:00
Bill Meier acccf6a77c Define some fcns & vars as static...
svn path=/trunk/; revision=34459
2010-10-10 20:14:34 +00:00
Bill Meier 209109c2fd Define some fcns & vars as static ...
svn path=/trunk/; revision=34458
2010-10-10 20:07:06 +00:00
Bill Meier 219877f1d3 #include <epan/tfs.h> not req'd.
svn path=/trunk/; revision=34457
2010-10-10 20:03:39 +00:00
Gerald Combs cca5e071af [Automatic manuf, services and enterprise-numbers update for 2010-10-10]
svn path=/trunk/; revision=34448
2010-10-10 15:03:38 +00:00
Stig Bjørlykke ccfe41300c Added "Edit Column Details" functions to the packet list heading popup.
Removed "Rename Column Title" as this is moved to "Edit Column Details".

svn path=/trunk/; revision=34444
2010-10-09 15:22:53 +00:00
Jeff Morriss 161a233392 Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

svn path=/trunk/; revision=34437
2010-10-08 18:11:31 +00:00
Jeff Morriss 33f116a46d Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

Remove check_col().

svn path=/trunk/; revision=34436
2010-10-08 17:48:22 +00:00
Jeff Morriss 7321549932 Don't use a TRY/CATCH block just to ignore any exceptions thrown by
tvb_get_ntohs(): check the remaining tvb length instead.

svn path=/trunk/; revision=34435
2010-10-08 17:37:19 +00:00
Martin Mathieson f6ee7d8d4f From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)
epan/dissectors/packet-umts_fp.c
* Added mac subdissector (MAC) call to HSDSCH TYPE2 frames

epan/dissectors/packet-umts_mac.c
* Added support for HSDSCH TYPE2 frames by means of
        not nibble-shifting (4 bits) the SDU if MAC-ehs is used

epan/dissectors/packet-rlc.c
* Added support for "Use special value of the HE field" (3gpp 25.332-7a0 
9.2.2.7) commonly used for Release 7 HSDPA.
        REMARK: although the specification mandates that the
        special value is only allowed when activated by higher
        layers (RRC), it is interpreted unconditionally. We assume
        this is OK, because a different use in future specifications
        is very unlikely.

epan/dissectors/packet-fp_hint.c
* Added decoding of MAC-ehs indicator for HSDSCH frames
* Bumped fpi->release from 6 to 7 to enable proper
        HSDSCH TYPE2 frame decoding in the UTMS MAC parser.
        In general, this appears not to affect decoding
        of (conformant) FP frames of pevious releases.

svn path=/trunk/; revision=34433
2010-10-08 11:03:08 +00:00
Jeff Morriss fae45ea6a1 Remove check_col()
svn path=/trunk/; revision=34426
2010-10-08 01:50:50 +00:00
Jeff Morriss 8d9ed7f963 Restore private_data even if there was an exception
svn path=/trunk/; revision=34424
2010-10-08 01:36:20 +00:00
Jeff Morriss f8402031c5 Don't use a TRY/CATCH block just to ignore any exceptions thrown by
tvb_get_ntohs(): check the remaining tvb length instead.

svn path=/trunk/; revision=34421
2010-10-08 01:17:04 +00:00
Jeff Morriss a179cfb90a Catch exceptions from subdissectors, even when we're not handing the
subdissector the first fragment of a fragmented message so that an exception
in the first chunk doesn't abort dissection of subsquent chunks in the frame.

Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

svn path=/trunk/; revision=34420
2010-10-08 01:05:33 +00:00
Bill Meier 695aff26f9 (Minor) Rename a few variables in the global namespace to be a bit more unique;
Also: rename additional (static) variables to be consistent with the above renames.

svn path=/trunk/; revision=34412
2010-10-07 21:23:36 +00:00
Bill Meier 54ed1b0bc7 Define a few global variables as static.
svn path=/trunk/; revision=34411
2010-10-07 21:16:52 +00:00
Bill Meier c41f229fdd Define 3 global variables as static; Whitespace cleanup.
svn path=/trunk/; revision=34410
2010-10-07 21:13:36 +00:00
Bill Meier 49c9059157 Define a global variable as static.
svn path=/trunk/; revision=34409
2010-10-07 21:11:18 +00:00
Jeff Morriss 96164ee15f Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

svn path=/trunk/; revision=34408
2010-10-07 21:10:51 +00:00
Bill Meier 626b802ba3 Define global variables ROWS, COLS, MAXROWS, MAXCOLS as static;
Also: Define a few functions as static.

svn path=/trunk/; revision=34407
2010-10-07 21:09:29 +00:00
Jeff Morriss db75605ffb White space cleanup
svn path=/trunk/; revision=34402
2010-10-07 14:50:45 +00:00
Martin Mathieson 62e6b6aceb Add more CRC failure codes.
svn path=/trunk/; revision=34401
2010-10-07 14:44:00 +00:00
Tomas Kukosa 5fbdb1c378 Generate proper extension flags for empty constructed types SEQUENCE { ... } and CHOICE { ... }
svn path=/trunk/; revision=34400
2010-10-07 14:24:04 +00:00
Martin Mathieson 9f65e2a9c7 From Tobias Witek (bug 5282):
In some cases, the UMTS FP dissector currently calls upper-layer dissectors
(e.g. UMTS MAC) only when a proto-tree is present. Effectively, this causes the
RLC reassembly to fail in certain cases.

The attached patch solves the problem by slightly moving the calls to
'call_dissector()'.

svn path=/trunk/; revision=34399
2010-10-07 10:17:18 +00:00
Jeff Morriss b151952474 Change a couple of hf abbreviations so they're not the name of the hf variable.
Use . as the separator (after PROTOABBREV) in the hf abbreviations.

svn path=/trunk/; revision=34397
2010-10-06 21:51:07 +00:00
Jeff Morriss ccb7996ed1 hf cleanup: delete a whole bunch of unused entries and make up unique names and abbreviations for others. These could undoubtedly be improved by someone who knows the protocol.
svn path=/trunk/; revision=34396
2010-10-06 21:19:34 +00:00
Bill Meier affd5e0207 From Alexis La Goutte: MYSQL: Fix FIELD_PACKET dissection;
From me: Two additional fixes for FIELD_PACKET dissection;
         Revision of the original patch from Alexis to
          properly dissect a SHOW_FIELDS response message.

svn path=/trunk/; revision=34395
2010-10-06 14:59:19 +00:00
Anders Broman c522f01e2b From Pascal Quantin:
[NAS EPS] Add dissection of special conformance testing functions

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278

svn path=/trunk/; revision=34394
2010-10-06 14:33:27 +00:00
Gerald Combs fff19c8383 Improve the ND flag display.
svn path=/trunk/; revision=34388
2010-10-05 22:16:29 +00:00
Stig Bjørlykke 710f41b085 Avoid printing double p_mul.pdu_type in custom columns.
svn path=/trunk/; revision=34387
2010-10-05 20:46:34 +00:00
Jeff Morriss 1a322b6955 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5277 :
Don't pass a NULL pointer to a string to ssl_debug_printf() (which eventually
calls vfprintf()): Solaris doesn't like it when you do that.

svn path=/trunk/; revision=34386
2010-10-05 19:53:37 +00:00
Anders Broman 23c4983424 From Pascal Quantin:
[NAS EPS] Fix TFT decoding when having several Packet Filters defined
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5274

svn path=/trunk/; revision=34385
2010-10-05 17:58:58 +00:00
Gerald Combs a0b284c5db Add more information to the Info column for some ICMPv6 messages. Add a
small comment to addr_resolv.c.

svn path=/trunk/; revision=34384
2010-10-05 17:57:23 +00:00
Gerald Combs 0e64b1749c Enable "Support packet-capture from IP TSO-enabled hardware" by default.
Like checksum offloading this seems to be common on modern systems.

svn path=/trunk/; revision=34383
2010-10-05 16:32:12 +00:00
Bill Meier e27e9c5e49 From Giuliano Fabris: Enhanced DVB Simulcrypt protocol dissector:
"Implemented EIS <-> SCS support, (P)SIG <-> MUX support, MUX <-> CiM support
  and (P) <-> CiP support."
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5212

From me: (Trivial) Whitespace/indentation cleanup.

svn path=/trunk/; revision=34376
2010-10-04 22:03:07 +00:00
Bill Meier 32ef48510d From Yasuyuki Tanaka: Fix PANA (RFC 5191) packets are dissected incorrectly.
(AVP length as being interpreted incorrectly).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5183

From me: General dissector code cleanup & bug fixing:
 - Show/dissect AVP "value" for non-vendor-specific AVPs;
 - Tighten & cleanup heuristic;
 - Fix some potential overflow issues;
 - #include <stdio.h>  #include <stdlib.h> not req'd;
 - Fix some whitespace & formatting;

svn path=/trunk/; revision=34366
2010-10-04 16:46:39 +00:00
Bill Meier bd4da13134 #if 0 an used function
svn path=/trunk/; revision=34355
2010-10-03 19:49:15 +00:00
Bill Meier 107e909761 Make a number of functions static;
Rename two g_... functions so as to not be in GLib namespace;
Move proto_register... to just before proto_reg_handoff...
Reformat some lines;
More Whitespace cleanup.

svn path=/trunk/; revision=34354
2010-10-03 19:43:14 +00:00
Bill Meier f5962f094e Whitespace & formatting cleanup;
Use #if 0/#endif instead of /* */ to comment out code in a few places.

svn path=/trunk/; revision=34351
2010-10-03 18:51:38 +00:00
Bill Meier 8af9d02b8c Refactor dissection of CHALLENGE target-info & AUTHENTICATE ntlmv2-response attributes:
- decode all attributes as specified in MS-NLMP;
 - use common code for target-info and ntlmv2 attribute dissection;
Add filter for the "version" field;
Remove some obsolete #if 0'd code.

svn path=/trunk/; revision=34350
2010-10-03 18:23:46 +00:00
Gerald Combs bf32b6df61 [Automatic manuf and enterprise-numbers update for 2010-10-03]
svn path=/trunk/; revision=34341
2010-10-03 15:03:33 +00:00
Bill Meier ea1a3de5fc Minor cleanup:
- packet-cfm.h not used elsewhere: incorporate into packet-cfm.c;
- Move proto_register and proto_reg_handoff to the end of the file;
- Localize some variables;
- Remove some unneeded initializers;
- Cleanu some whitesace.

svn path=/trunk/; revision=34334
2010-10-02 14:54:09 +00:00
Bill Meier a7cc9f5358 Add col_clear; Also: Small reformatting and whitespace changes
svn path=/trunk/; revision=34332
2010-10-02 13:40:43 +00:00
Jeff Morriss 3bdab149af Replace a couple of blurbs (that match the field name) with NULL.
svn path=/trunk/; revision=34322
2010-10-02 01:33:02 +00:00
Jeff Morriss 18444502e8 Remove trailing spaces from a couple of hf names
svn path=/trunk/; revision=34321
2010-10-02 01:27:45 +00:00
Sake Blok 433dcf1f82 Changing the flag bitmasks to their proper values (see http://www.faqs.org/rfcs/rfc2741.html). This fixes part of bug 5269.
svn path=/trunk/; revision=34316
2010-10-01 19:13:56 +00:00
Stig Bjørlykke 371de294df Export is_default_profile().
svn path=/trunk/; revision=34314
2010-10-01 17:06:04 +00:00
Stig Bjørlykke 98f6aa9311 Add a new right-click popup menu for the statusbar profiles for easy functions
to create new, copy, delete and rename configuration profiles.

svn path=/trunk/; revision=34312
2010-10-01 16:29:37 +00:00
Jörg Mayer 34c7218d1a - Reorder how packagetests are run
- Add packet-reload.c
- Make most packages not-required (not tested)
- Does *not* (yet) add an optional/whatever case to enable_


svn path=/trunk/; revision=34307
2010-10-01 08:40:52 +00:00
Anders Broman 5d10ffdef5 Add a couple of casts to make it compile.
svn path=/trunk/; revision=34306
2010-10-01 08:14:03 +00:00
Jaap Keuter 4f8753574b Adding new error code.
svn path=/trunk/; revision=34305
2010-10-01 06:26:58 +00:00
Jaap Keuter 7057b9203a Try to fix the Mac build.
svn path=/trunk/; revision=34304
2010-10-01 06:26:26 +00:00
Guy Harris 6df40b067c From Chris Maynard:
don't add a source address field if it's zero-length (fixes bug
	2519);

	the source address length field is 8 octets long; if the
	purported length is > 8, only include the first 8 octets.

svn path=/trunk/; revision=34303
2010-10-01 01:49:02 +00:00
Stig Bjørlykke d65b82db44 Make it compile.
svn path=/trunk/; revision=34301
2010-09-30 21:38:52 +00:00
Bill Meier 8cd2038a8b Fix some mangled comments (apparently mangled so that code could be commented out by an
enclosing comment). The code is now commented out with #if 0.

svn path=/trunk/; revision=34300
2010-09-30 21:32:42 +00:00
Bill Meier e6eec902f0 Fix compilation error.
svn path=/trunk/; revision=34298
2010-09-30 21:14:44 +00:00
Jaap Keuter d571d1431a From Stéphane Bryant:
New Dissector for the ReLOAD dissector.

svn path=/trunk/; revision=34297
2010-09-30 20:34:12 +00:00
Jeff Morriss 71f132e34c Get reassemble_test building again (after 34285).
svn path=/trunk/; revision=34296
2010-09-30 20:33:05 +00:00
Bill Meier 8d6dbc5677 More fixes and comments:
- NEGOTIATE: dissect version field (if present) when empty Workstation domain & name fields;
- AUTHENTICATE: Use flags from message if no previous CHALLENGE seen to determine 
                character set encoding; Fixes Bug #5251
                https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5251


svn path=/trunk/; revision=34295
2010-09-30 20:26:13 +00:00
Jaap Keuter add282a338 From Colin O'Flynn
Add 6lowpan-nd-13 Support.
This brings the 6lowpan dissector up to the latest revision, nd-13.

svn path=/trunk/; revision=34294
2010-09-30 19:43:33 +00:00
Stig Bjørlykke 8d3bde0f49 Initialize length.
svn path=/trunk/; revision=34293
2010-09-30 19:41:44 +00:00
Stig Bjørlykke e7a8e117fc Cleanup reassembly hf entries.
svn path=/trunk/; revision=34292
2010-09-30 19:40:02 +00:00
Stig Bjørlykke f5a210b2e8 Cleanup reassembly hf entries.
svn path=/trunk/; revision=34291
2010-09-30 19:35:51 +00:00
Jaap Keuter 733183a170 From Colin O'Flynn / Owen Kirby:
The 6LoWPAN dissector had as a TODO the 'stateful address compression' mode.
This patch fixes that TODO, up to HC-13.
This patch also updates to HC-08, where the PANID is no longer used in forming
the short address.

svn path=/trunk/; revision=34290
2010-09-30 19:23:31 +00:00
Stig Bjørlykke 7c3f2513ee Remove unneeded includes.
svn path=/trunk/; revision=34289
2010-09-30 19:20:59 +00:00
Stig Bjørlykke 46749e843c Use the name from hf_fragment instead of hf_fragments when we only have
one fragment to reassemble.

svn path=/trunk/; revision=34285
2010-09-30 09:53:51 +00:00
Stig Bjørlykke 65e0721f71 Constructed octet strings may contain zero encodings.
(X.690 chapter 8.7.3)

svn path=/trunk/; revision=34284
2010-09-30 06:19:32 +00:00
Balint Reczey 6094889963 Fix the libsmi workaround by adding missing brackets.
From Grzegorz Głowacki <g.glowacki@wasko.pl>

svn path=/trunk/; revision=34280
2010-09-29 15:46:35 +00:00
Anders Broman 72ac77046f From Pascal Quantin:
[NAS EPS] Add dissection of EPS network feature support IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5264

svn path=/trunk/; revision=34279
2010-09-29 15:41:27 +00:00
Jaap Keuter fc1cf15ea4 Let the protocol column show we're having Secure RTCP when we do.
svn path=/trunk/; revision=34278
2010-09-28 21:22:35 +00:00
Jaap Keuter f0428e7d0b Add the missing Signature-capable flag to the Hello message.
Add missing SRT(C)P setup information to Conf2ACK message.

svn path=/trunk/; revision=34277
2010-09-28 21:20:57 +00:00
Bill Meier e5bb2e0541 Oops: remove a // comment (note to myself)
svn path=/trunk/; revision=34272
2010-09-28 15:26:58 +00:00
Bill Meier 9dcccb0e6a Improve dissection:
1. Negotiation/Challenge/Authoriation messages:
   - dissect Version field (if present);
2. Authorization messages:
   - Dissect fields following session-key (flags/... if present) even 
     when session key is empty;
   - Dissect "MIC" field (if present);
3. Challenge message:
   - Rename "Domain" field to "Target Name" as per Microsoft spec (MS-NLMP).

svn path=/trunk/; revision=34271
2010-09-28 14:14:12 +00:00
Ronnie Sahlberg 888227b0d2 update the RQUOTA dissector and add support for version 2 of the protocol
svn path=/trunk/; revision=34270
2010-09-28 05:50:54 +00:00
Stig Bjørlykke 6bf3129f17 Fix the offset errors reported in bug 5261.
svn path=/trunk/; revision=34267
2010-09-27 21:01:54 +00:00
Anders Broman d7e6928096 Add PDUs to value_string.
svn path=/trunk/; revision=34266
2010-09-27 20:09:08 +00:00
Jeff Morriss 22475e4bce Some hf cleanup: make the field names different from the hf variable name
and/or the abbreviation.

svn path=/trunk/; revision=34264
2010-09-27 19:31:36 +00:00
Jeff Morriss 3f92ed92c7 Some hf cleanup: make the field names different from the hf variable name
and/or the abbreviation.

svn path=/trunk/; revision=34263
2010-09-27 19:05:43 +00:00
Anders Broman 0d4a4542ba From Vincent Helfre:
Display the bits for 
.... .00. = PCID_Pattern: 0

svn path=/trunk/; revision=34262
2010-09-27 12:53:42 +00:00
Anders Broman a498b71098 Initialize subtree.
svn path=/trunk/; revision=34261
2010-09-27 10:11:40 +00:00
Anders Broman 415691da9d From Vincent Helfre:
Release 8 june 2010 parameters decoding for SI2quater and Measurement Information messages.

svn path=/trunk/; revision=34260
2010-09-27 08:45:16 +00:00
Anders Broman 8fef9edf1c Add a link to the protocol description.
svn path=/trunk/; revision=34259
2010-09-27 06:16:29 +00:00
Anders Broman f1bdb63766 From Yaniv Kaul:
[PATCH] Add specific names to 'Flags' in packet-scsi.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5259

svn path=/trunk/; revision=34258
2010-09-27 06:05:24 +00:00
Gerald Combs 138b249153 [Automatic manuf and enterprise-numbers update for 2010-09-26]
svn path=/trunk/; revision=34253
2010-09-26 15:03:40 +00:00
Sake Blok 7ec231f7f1 Fix the output of columns with "show resolved" disabled when all occurrences are displayed.
Limit the input field for occurrence to 4 characters to prevent an overflow.
Make sure "... as filter" does not result in an invalid filter string if all occurrences are displayed.


svn path=/trunk/; revision=34247
2010-09-25 09:33:29 +00:00
Stephen Fisher 4bb182799a Add option to generate MD5 hash for payload in data dissector. Useful for
tracking the same data when the headers are different (NAT, TCP seq #
randomization, etc).  Copied from packet-frame.c.


svn path=/trunk/; revision=34245
2010-09-24 23:05:30 +00:00
Jeff Morriss 9238e29ae3 Don't use an abbreviation as the name of an hf entry.
svn path=/trunk/; revision=34241
2010-09-24 20:28:00 +00:00
Jörg Mayer c749fe000c Comparing type II and III traces of the same packet
indicate that the last 4 bytes of both types are similar.
So the extra bytes in type III are inserted before those
last bytes.

svn path=/trunk/; revision=34238
2010-09-24 18:12:45 +00:00
Stig Bjørlykke 21319003d5 Added an extra validity check for cust_format_info.
svn path=/trunk/; revision=34235
2010-09-24 13:19:03 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 3edbdc151d Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34229
2010-09-24 01:34:45 +00:00
Jeff Morriss 72516cc39e Replace another blurb that matches the name (case insensitive) with NULL.
svn path=/trunk/; revision=34228
2010-09-24 01:32:27 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jörg Mayer 72c3e35672 - trunkated -> truncated
- Print "Type II" and "Type III" as versionstrings.
- Make sure that version = 1 or 2

svn path=/trunk/; revision=34222
2010-09-23 20:44:11 +00:00
Jörg Mayer 320de7eb14 Jason Masker:
- Add decoding of direction bit for version 2 (type III) erspan.

Me:
- Decode the original direction bit as unknown in case of version 2.
- The original unknown3 value seems to indicate whether the packet
  was too long to fit into a single mtu (trunkated).
- "Timestamp(s)" -> "Timestamp"


svn path=/trunk/; revision=34221
2010-09-23 19:42:20 +00:00