Commit Graph

13843 Commits

Author SHA1 Message Date
Chris Maynard fd2c5fbccc Should be a "new-style" dissector because its caller expects it to be now, but
need to create the dissector handle using new_create_dissector_handle().
(Similar to SVN #34707).

svn path=/trunk/; revision=34708
2010-10-30 04:29:19 +00:00
Guy Harris 19ac4ab745 The ASF dissector should be a new-style dissector, so its caller knows
how much of the packet data it's consumed - but that means the dissector
handle for it must be created with new_create_dissector_handle().

svn path=/trunk/; revision=34707
2010-10-30 03:34:29 +00:00
Bill Meier 5c0ce795b3 It never rejects a packet, so it's not a "new-style" dissector.
(Similar to SVN #34704).

svn path=/trunk/; revision=34706
2010-10-30 02:38:44 +00:00
Chris Maynard bc2a15d93c Fixed checkAPIs.pl warning, which I forgot to run earlier. Ugh.
svn path=/trunk/; revision=34705
2010-10-30 01:09:17 +00:00
Guy Harris 97b0de2fe8 It never rejects a packet, so it's not a "new-style" dissector.
svn path=/trunk/; revision=34704
2010-10-29 23:58:38 +00:00
Chris Maynard a12e86f59f Fixes bug 974 by adding RSP trailer. Also resolves packet-asp "FIXME" for
IANA Enterprise ID as well as extended packet-asp decoding of authentication
and integrity payloads using the sample capture file attached to the bug.
Fuzz tested ~500 passes on that 3 packet capture file.

svn path=/trunk/; revision=34701
2010-10-29 22:37:31 +00:00
Bill Meier 28402479cc Use value_string_ext fcns to access two value-string arrays;
Reorder value-string arrays slightly so they are in ascending order.

svn path=/trunk/; revision=34699
2010-10-29 22:18:44 +00:00
Jeff Morriss 6eba069093 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 :
Return an error if the user specifies a value in a range in excess of the
range-specified maximum.

Except when reading in preferences files which might have ranges that exceed
the maximum (because we didn't use to check): in that case silently lower the
out-of-range values.

svn path=/trunk/; revision=34698
2010-10-29 22:09:31 +00:00
Bill Meier e21ca35116 Improve g_warning text slightly.
svn path=/trunk/; revision=34697
2010-10-29 22:01:29 +00:00
Stig Bjørlykke c5bebaa771 One more:
Make the third argument to a UAT copy callback a size_t.

svn path=/trunk/; revision=34696
2010-10-29 21:55:04 +00:00
Stig Bjørlykke 340d64e780 Make the third argument to a UAT copy callback a size_t.
svn path=/trunk/; revision=34695
2010-10-29 21:51:59 +00:00
Guy Harris 17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
Bill Meier f543357d14 Use value_string_ext fcns to access certain value_string arrays.
svn path=/trunk/; revision=34692
2010-10-29 20:22:02 +00:00
Bill Meier 1a365d735c Use value_string_ext to access 'commands' value_string.
svn path=/trunk/; revision=34690
2010-10-29 18:33:21 +00:00
Bill Meier 4a43e13976 Use value_string_ext to access several "relatively large" value-strings.
svn path=/trunk/; revision=34689
2010-10-29 17:48:39 +00:00
Bill Meier 46416bddda (Trivial) Do 'find_dissector("data");' only once.
svn path=/trunk/; revision=34688
2010-10-29 17:42:24 +00:00
Jeff Morriss aac7d5596e From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 :
RequestID and ResponseID are unsigned.  Show them in hex and decimal.

svn path=/trunk/; revision=34686
2010-10-29 15:44:11 +00:00
Anders Broman f01cbcd296 Add cause values.
svn path=/trunk/; revision=34685
2010-10-29 15:19:47 +00:00
Jeff Morriss 3971cb5d13 Copy hf variables by value, not by reference.
svn path=/trunk/; revision=34682
2010-10-28 18:49:40 +00:00
Jeff Morriss 54e10cb509 Use ENC_LITTLE_ENDIAN and ENC_NA.
svn path=/trunk/; revision=34681
2010-10-28 18:37:41 +00:00
Jeff Morriss e257f75449 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 :
A patch to add support of Mongo Wire Protocol (Used by MongoDB)

From me: use ENC_xxx in proto_tree_add_item() calls.

svn path=/trunk/; revision=34680
2010-10-28 17:33:18 +00:00
Jeff Morriss 336adde8df Use ENC_NA too
svn path=/trunk/; revision=34679
2010-10-28 16:54:04 +00:00
Jeff Morriss 772edf8fb5 Use ENC_BIG_ENDIAN and ENC_LITTLE_ENDIAN
svn path=/trunk/; revision=34677
2010-10-28 16:46:38 +00:00
Anders Broman fe71cbcc99 From Pascal Quantin:
[NAS EPS] Fix TFT decoding in case of "delete packet filters from existing TFT" operation

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5347

svn path=/trunk/; revision=34666
2010-10-28 15:06:48 +00:00
Jaap Keuter e942385e06 From Matt Parrisimo:
Calculate packet length and checksum.

svn path=/trunk/; revision=34664
2010-10-27 21:11:46 +00:00
Jeff Morriss 505fbf012a Fix the disssector assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3877 :
The rest of the code assumes that sip can be NULL, so don't assert when it's
not.

Also make fid_cmp() static since it's only used in this module.

svn path=/trunk/; revision=34663
2010-10-27 21:08:49 +00:00
Jeff Morriss 4a120508d6 Fix the reassembly assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3881 :
Ensure the fragment bytes exist before passing them to the reassembly code.

svn path=/trunk/; revision=34662
2010-10-27 18:26:54 +00:00
Stig Bjørlykke 321188339e Added two new functions: nstime_diff() and nstime_subtract().
svn path=/trunk/; revision=34660
2010-10-27 07:44:26 +00:00
Jaap Keuter b4d195f256 Try to decode the unknown multipart subtype anyway.
svn path=/trunk/; revision=34659
2010-10-27 06:49:39 +00:00
Jaap Keuter 3db66ff53e Try to decode the unknown multipart subtype anyway.
svn path=/trunk/; revision=34658
2010-10-27 06:49:18 +00:00
Jaap Keuter b67c9b05cb Supply an entry to use for unknown multipart subtype.
svn path=/trunk/; revision=34657
2010-10-27 06:48:39 +00:00
Anders Broman f8ba652b62 From Fred Fierling:
Found a bug in the changes from sizeof -> numeric.

svn path=/trunk/; revision=34656
2010-10-27 05:30:01 +00:00
Jeff Morriss 710a96470f If we get a syntax error reading the preferences file, tell which preference we were reading when we got the error.
svn path=/trunk/; revision=34655
2010-10-27 01:43:24 +00:00
Jeff Morriss 945d917122 From Thomas Boehne via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324 :
As mentioned before, the heuristics used by packet-adwin-config were weak for
UDP packets. This patch creates a stronger heuristic by checking if one of the
MAC addresses in the UDP packets is in the range assigned to the manufacturer
of the devices that use this protocol (or if it is a broadcast).

That should be relatively safe to do because the protocol is rarely used in
routed networks.

svn path=/trunk/; revision=34654
2010-10-27 00:42:02 +00:00
Anders Broman 758ee054ab Follow up on:
You may not use g_int64_hash() or g_int64_equal(), as they are not  present in the minimum version of GLib that we support.  Create a  ieee802154_long_addr structure for long addresses, create hash  routines for those addresses, and use them.

Export and use those routines.

svn path=/trunk/; revision=34653
2010-10-26 12:43:40 +00:00
Anders Broman fbb65b97b6 - Get rid of check_col and sizeof
svn path=/trunk/; revision=34652
2010-10-26 11:26:28 +00:00
Guy Harris 0f96301a3e You may not use g_int64_hash() or g_int64_equal(), as they are not
present in the minimum version of GLib that we support.  Create a
ieee802154_long_addr structure for long addresses, create hash
routines for those addresses, and use them.

svn path=/trunk/; revision=34651
2010-10-26 08:31:16 +00:00
Anders Broman a3eff92edc g_int64_hash is first available in Glib 2.22 (This needs a proper fixr) This is just to get the build going again.
svn path=/trunk/; revision=34650
2010-10-26 07:38:22 +00:00
Anders Broman 30d27cfb05 g_int64_hash is first available in Glib 2.22
(This needs a proper fixr)
This is just to get the build going again.

svn path=/trunk/; revision=34649
2010-10-26 06:48:09 +00:00
Anders Broman 809984a493 Try to fix the build
svn path=/trunk/; revision=34648
2010-10-26 06:13:42 +00:00
Anders Broman 26f0f7bc7a From Fred Fierling:
Multi-key Support and Extended Address Mapping for ZigBee Dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5331

svn path=/trunk/; revision=34647
2010-10-26 05:42:24 +00:00
Anders Broman 161076b23b Minor cleanup, use proto_add_item().
svn path=/trunk/; revision=34646
2010-10-25 20:13:00 +00:00
Jeff Morriss f7b3c16320 From Pascal Quantin: don't accept packets unless they're over TCP or UDP.
svn path=/trunk/; revision=34644
2010-10-25 17:17:52 +00:00
Bill Meier 1b01709034 Change "4 space tabs" to spaces.
svn path=/trunk/; revision=34643
2010-10-25 16:43:48 +00:00
Bill Meier a8de0b1f76 From Jouni Malinen: preliminary version of Wi-Fi P2P (Wi-Fi Direct) dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5196

From me: Add packet-wifi-p2p.h to Makefile.common DISSECTOR_INCLUDES
         Add dissectors/packet-wifi-p2p.c to epan/CMakelists.txt

svn path=/trunk/; revision=34642
2010-10-25 16:40:45 +00:00
Jeff Morriss 36390c306f From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5336 :
Attached patch:
1. Adds port 5985 as a HTTP traffic port (used by MS Powershell remoting over
HTTP)
2. Adds dissection of Kerberos authentication to HTTP.


svn path=/trunk/; revision=34641
2010-10-25 02:17:41 +00:00
Jeff Morriss 0f93035b15 From Thomas Boehne via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324 :
The company I work for uses two proprietary protocols, for which I initially
developed  wireshark plugins. Now we would like to integrate them into the
public wireshark repository. 

I followed the READMEs and converted the plugins into a static dissectors. I
cleaned up the code until checkAPI.pl was silent, translated all terms to
english and ran randpkt and fuzz-testing for a long time. All that I found was
a bug in a different dissector.

From me:
- Fold the header files into the dissectors
- Clean up some memory leaks
- Strengthen the heuristics of adwin-config (the TCP heuristics are still pretty
  weak)
- Make packet-adwin.c a "new style" dissector 
- Use find_or_create_conversation()
- Remove most of the check_col()'s

svn path=/trunk/; revision=34640
2010-10-25 01:43:54 +00:00
Jeff Morriss 8c7c46d0fc Remove trailing space in field name.
svn path=/trunk/; revision=34639
2010-10-25 00:57:41 +00:00
Bill Meier af4db6059a (Minor) Some whitespace cleanup.
svn path=/trunk/; revision=34634
2010-10-24 15:39:36 +00:00
Anders Broman b1e852cf70 Back out 34627 and friends again.
svn path=/trunk/; revision=34633
2010-10-24 15:22:44 +00:00