common parts to common.nsh. Creating an installer now requires two
NSIS runs:
- uninstaller.nsi, which creates an installer (uninstall_installer.exe)
that only writes uninstall.exe to ../../wireshark-gtk2.
- wireshark.nsi, which bundles uninstall.exe along with the rest of
our installation files.
If we ever get around to signing our executables this will let us sign
all of them. It also cleans up the .nsi file contents a bit.
Instead of keeping separate list of file extensions, manage them from
a single macro. Print the extensions we register / deregister in the
detail pane.
svn path=/trunk/; revision=43236
length bugfix + proto_tree_add_text() cleanup
Fixed the Web-Cache Identity Info dissection. Also converted many of the
proto_tree_add_text() to "more filterable" APIs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5141
svn path=/trunk/; revision=43231
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).
svn path=/trunk/; revision=43228
- remove 'if (tree)' around code which (eventually) calls col_...() functions;
- remove unneeded check_col() usage;
- use extended value-strings where appropriate;
- use col_set_str() instead of col_add_fstr();
- fix mismatch between proto_tree_add_item() size arg and the FT type in the
referenced hf[] entry (in a few cases);
- FT_STRING fields should have ENC_ASCII|ENC_NA as the 'encoding' arg
in the corresponding proto_tree_add_item() call;
- do whitespace cleanup.
Note: 1 issue remains:
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260#c12
svn path=/trunk/; revision=43217
Also:
- don't use val_to_str_const() with a "format" default string;
- rename 'opt_len_type' enumeration identifiers to be less generic.
svn path=/trunk/; revision=43210
- remove some redundant code;
- use ep_strdup_printf() instead of g_snprintf() to a static buffer;
- create and use extended-value-strings as appropriate;
- define a value_string array as static (not as an automatic);
- use val_to_str_const() instead of val_to_str() as appropriate;
- reformat hf[] array entries;
- do general formatting cleanup;
- do whitespace cleanup (e.g., indentation & 4-space tabs).
svn path=/trunk/; revision=43207
Implemented RFC 4954 within the SMTP dissector. On principle, the decryption
is disabled by default (making this feature not obviously present). However I
don't think there will ever be enough data that the performance would be an
issue if the default was changed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349
svn path=/trunk/; revision=43197
When building current data for packet details treeview we store two things.
- Generated string with item label
- Pointer to node field_info structure
After epan_dissect_{free, cleanup} pointer to field_info node is no longer
valid so we should clear GtkTreeStore before freeing.
svn path=/trunk/; revision=43188
There is a difference between the UDP and UDP-Lite pseudo header that wasn't realized when r40387 was committed. Details of the difference in http://tools.ietf.org/html/rfc3828#section-3.2
svn path=/trunk/; revision=43187
Gerald Combs