Commit Graph

10733 Commits

Author SHA1 Message Date
Ulf Lamping b964421aec added changed some comments to better reflect current "behaviour"
svn path=/trunk/; revision=10833
2004-05-09 09:26:31 +00:00
Olivier Biot 72388f6dfd Move the creation of the de-chunked data source to the place where the data
is being dechunked; this will highlight the correct bytes when selecting the
compressed data from the protocol tree.

Add comments for explaining what happens where.

Strip trailing white space.

svn path=/trunk/; revision=10832
2004-05-09 09:07:33 +00:00
Guy Harris 62f5077dc3 From Graeme Hewson:
Fix off-by-one errors in slice_func

svn path=/trunk/; revision=10831
2004-05-09 08:29:48 +00:00
Guy Harris 35cf424c08 From Graeme Hewson:
"aim.fnac.ssi.buddyname==ab" caused segmentation fault.  Fix
     handling of unparsed value as byte string.

svn path=/trunk/; revision=10830
2004-05-09 08:25:52 +00:00
Guy Harris af3885bcf1 From Graeme Hewson:
Error if protocol specified on RHS of display filter comparison.
     If user specified "fc", they probably intended a byte value rather than
     the fibre channel protocol; fix makes mistake clear.

     Fix assertion failure with range on LHS of display filter comparison
     and field on RHS.

svn path=/trunk/; revision=10829
2004-05-09 08:17:32 +00:00
Ulf Lamping 09962ebb64 make notebook tabs scrollable, if not all fits into the pane,
enable a popup menu on the notebook tabs, with the tab labels

svn path=/trunk/; revision=10828
2004-05-09 07:01:07 +00:00
Guy Harris 4befb390d1 From Graeme Hewson: get rid of unnecessary check (it's necessary for
octal, as the maximum of 3 octal digits can be more than 0377, but not
necessary for hex, as the maximum of 2 hex digits can't be more than
0xff).

svn path=/trunk/; revision=10827
2004-05-08 22:03:43 +00:00
Gerald Combs ca78495f89 Don't try to include epan/config.h.win32 in the distribution.
svn path=/trunk/; revision=10826
2004-05-08 21:43:38 +00:00
Olivier Biot e0a8f5e492 From Richard Coe: only create a conversation on the first packet of a DICOM
conversation.

svn path=/trunk/; revision=10825
2004-05-08 21:31:52 +00:00
Michael Tüxen e8a1272aff Fixed problems of handling PkTDRP chunks.
svn path=/trunk/; revision=10824
2004-05-08 17:54:54 +00:00
Olivier Biot 04aec13970 The DICOM dissector assumed that any existing conversation was a DICOM
conversation. Fix this by checking whether there is conversation data for
the DICOM dissector. If not, the conversatioj is not a DICOM conversation,
and we do not attempt at dissecting it as DICOM.

svn path=/trunk/; revision=10823
2004-05-08 13:39:36 +00:00
Olivier Biot 51aebd3ba7 D'oh - remove leading '+' marks from manually applying a patch.
svn path=/trunk/; revision=10822
2004-05-08 12:59:02 +00:00
Olivier Biot 9cce7b3e27 From Jerry Talkington:
* Add comments on why we may not use tvb_free() at some places.

* Add a new data source for a reassembled chunked entity.

svn path=/trunk/; revision=10821
2004-05-08 12:54:24 +00:00
Olivier Biot 9ee716dfb5 Add the valuable input from Gilbert Ramirez in reply to questions I had when
thinking at implemeting an "in" display filter operation.

svn path=/trunk/; revision=10820
2004-05-08 11:40:29 +00:00
Olivier Biot 538fdc83b5 Fix a tvb_free() of a tvbuffer created as a tvb_new_subset(), which caused
double freeing of memory. Add a comment at the tvb_new_subset() call so
future developers will be warned.

Always add the compressed entity as an item in the protocol tree, so it can
be exported by selecting the packet bytes.

svn path=/trunk/; revision=10819
2004-05-08 10:28:47 +00:00
Guy Harris 8968956aa1 From Rich Coe: DICOM support.
svn path=/trunk/; revision=10818
2004-05-08 08:49:02 +00:00
Olivier Biot 463597f54a Memory management of tvb_uncompress() needs tvb_set_free_cb().
svn path=/trunk/; revision=10817
2004-05-07 18:15:24 +00:00
Olivier Biot ea0912b2c6 Add Uncompressed/Compressed to the compressed data source label for clarity.
svn path=/trunk/; revision=10816
2004-05-07 17:36:46 +00:00
Tim Potter dcdbb14920 Compile fixes for change to dcerpc_info structure.
svn path=/trunk/; revision=10815
2004-05-07 12:29:03 +00:00
Ulf Lamping bd96071d8c rename context menu items:
Match -> Apply as Filter
Prepare -> Prepare a Filter
and prepended a ... at appropriate submenu items

svn path=/trunk/; revision=10814
2004-05-07 12:15:24 +00:00
Ulf Lamping b0fdecd698 did some code cleanup, added some comments from value_string.c
svn path=/trunk/; revision=10813
2004-05-07 11:34:10 +00:00
Ulf Lamping 5d950ffaf4 replace info field "gboolean request" by "guint8 ptype",
so the packet type can be better detected

svn path=/trunk/; revision=10812
2004-05-07 11:25:15 +00:00
Ulf Lamping 8ef8186f5d tag some protocol items as generated
svn path=/trunk/; revision=10811
2004-05-07 11:07:53 +00:00
Ulf Lamping a7f4c971c5 removed obsolete comments
svn path=/trunk/; revision=10810
2004-05-07 08:12:33 +00:00
Guy Harris 7cb69aab55 From Thomas Anders:
- support vendor-specific DHCP option 43 interpretation per CableLabs
   standards (for compliant cable devices, identified by option 60)
- support DHCP option 122 with all suboptions (RFC 3495: CableLabs
   Client Configuration; RFC 3594: PacketCable Security Ticket Control)
- update DHCP options list: add options 117-122
   (see http://www.iana.org/assignments/bootp-dhcp-parameters)
- minor enhancements for DHCP options 2, 82
- minor code cleanup

svn path=/trunk/; revision=10809
2004-05-07 08:02:23 +00:00
Olivier Biot 461fd185f0 Get rid of epan/config.h.win32.
svn path=/trunk/; revision=10808
2004-05-06 20:50:39 +00:00
Olivier Biot 388aaadcb7 Get rid of epan/config.h.win32.
Fix a missing ZLIB_CFLAGS in epan/Makefile.nmake.

svn path=/trunk/; revision=10807
2004-05-06 20:48:36 +00:00
Olivier Biot 77449b1085 From Kendy Kutzner: a char should be compared with '\0', not NULL.
svn path=/trunk/; revision=10806
2004-05-06 17:40:52 +00:00
Ronnie Sahlberg 99467f6e89 add tcp reassembly to isns
also make isns not dump core just because someone has encoded an integer in 0 bytes.

still need to add reassembly of fragmented pdus (first fragment/last fragment)
but have example captures of that so thats for tomorrow.

svn path=/trunk/; revision=10805
2004-05-06 10:24:32 +00:00
Ulf Lamping 2085e656e8 various context menu related changes
svn path=/trunk/; revision=10804
2004-05-05 20:12:50 +00:00
Olivier Biot 3189f7d868 From Kendy Kutzner: use the tvb_uncompress() routines instead of the own
SLSK decompression routine.

svn path=/trunk/; revision=10803
2004-05-05 17:28:12 +00:00
Guy Harris 85fe1e6dee Use "tvb_reported_length_remaining()" in "until the end of the packet"
loops, so we mark frames as short if they've been cut short by a
snapshot length.

The user class in buddy list TLVs appears to be 2 bytes, in at least
some captures; make "dissect_aim_userclass()" take the user class value,
and the length of the user class field, as arguments, and have the
caller fetch the value.  Also, display the numerical value of the user
class in hex, as it's a bitset.

Fix the messaging dissector to put stuff under the top-level item rather
than at the top level.

Fix a typo.

Clean up indentation.

svn path=/trunk/; revision=10802
2004-05-05 09:30:56 +00:00
Guy Harris b42f088ae5 Note that hiding panes in the paned widgets doesn't do what we want with
GTK+ 1.2[.x], although it does so with GTK+ 2.x.

svn path=/trunk/; revision=10801
2004-05-05 08:49:24 +00:00
Guy Harris acb752726d Use an enum when initializing "prefs.gui_layout_type".
Add an entry to that enum at the end and use that to generate the value
of LAYOUT_QTY.

svn path=/trunk/; revision=10800
2004-05-05 07:31:05 +00:00
Olivier Biot 659ac78357 From Jerry Talkington:
- Helper functions for uncompressing compressed tvbuffers.

	- Compressed content coding dissection in HTTP.

svn path=/trunk/; revision=10799
2004-05-05 06:55:09 +00:00
Gerald Combs ed22e7941f Check the value length in get_encoded_strval(), so that we don't feed a
length less than 1 to tvb_get_string().

svn path=/trunk/; revision=10798
2004-05-05 03:05:52 +00:00
Anders Broman 4b4298b6fd Fixed a copy-paste error
svn path=/trunk/; revision=10797
2004-05-04 21:12:24 +00:00
Guy Harris 70e4f7ff87 Use "main_widgets_show_or_hide()" to control the visibility of all the
main window widgets, rather than requiring a relayout if the visibility
of the main toolbar, filter toolbar, or statusbar is changed.

Clean up indentation.

svn path=/trunk/; revision=10796
2004-05-04 21:08:03 +00:00
Guy Harris 76574b554b If all we're doing is changing the visibility of a pane, we don't have
to re-lay-out the main window, we just need to change the visibility of
the appropriate widgets - that reduces the amount of drawing done,
speeding things up a little and reducing flicker.

svn path=/trunk/; revision=10795
2004-05-04 20:49:33 +00:00
Guy Harris 6ae8786e94 Display "main_second_pane" if, and only if, both widgets in it are
displayed; otherwise, if you hide both of them (e.g., hiding the packet
details and packet data panes in the default layout), "main_second_pane"
remains but as a gray blob, rather than having the remaining pane take
over the entire window.

svn path=/trunk/; revision=10794
2004-05-04 20:40:08 +00:00
Guy Harris 3e331f08f0 Put the coloring rules back under View.
svn path=/trunk/; revision=10793
2004-05-04 20:04:26 +00:00
Michael Tüxen a65a63a85e Clean up some variable names.
svn path=/trunk/; revision=10792
2004-05-04 17:46:44 +00:00
Guy Harris ff06acb94f Get rid of a trailing comma.
svn path=/trunk/; revision=10791
2004-05-04 09:12:26 +00:00
Guy Harris 55e563e1ac Fix some typos, and get rid of an inapplicable boilerplate comment.
Get rid of some trailing commas.

Show the SAPI symbolically in the top-level item for the address field.

svn path=/trunk/; revision=10790
2004-05-04 09:03:57 +00:00
Guy Harris 8b92f812b0 We don't need to save the challenge values as per-conversation or
per-packet information.

svn path=/trunk/; revision=10789
2004-05-04 08:30:36 +00:00
Guy Harris 64c18ee4ac Add the RFC 3023 XML media types.
svn path=/trunk/; revision=10788
2004-05-04 07:24:33 +00:00
Guy Harris 6c13cf033e Chunked data reassembly *is* done in "req_resp_hdrs_do_reassembly()".
That means that the description of the "desegment HTTP bodies"
preference setting shouldn't speak of it causing the dissector to trust
the content length (which makes it somewhat long anyway), as it also
desegments chunked bodies that lack a Content-Length header; expand the
tooltip for the preference to speak of that.

svn path=/trunk/; revision=10787
2004-05-04 07:12:03 +00:00
Guy Harris 0dd6ee92de "tvb_get_string()" returns a pointer to "g_malloc()"ed data, so you have
to free it when you're done with it.

It never returns a null pointer, however, so there's no need to check
for that.

Clean up the code to process Transfer-Encoding a bit.

svn path=/trunk/; revision=10786
2004-05-04 06:53:47 +00:00
Guy Harris eecdd42293 Note that the way we currently handle the chunked encoding doesn't work
if the HTTP data takes more than one packet.

svn path=/trunk/; revision=10785
2004-05-04 06:21:17 +00:00
Guy Harris 3621c52cc4 Display a server boot time of 0 as "Unknown" (as that's what's sent when
the client sends its first PDU to the server, and when the endpoint
mapper sends back an error PDU on behalf of the server, because they
don't know the server's boot time - it's unlikely that the server was
booted precisely at January 1, 1970, 00:00:00 GMT).

Clean up some white space.

svn path=/trunk/; revision=10784
2004-05-04 06:14:51 +00:00