Commit Graph

37929 Commits

Author SHA1 Message Date
João Valverde b801ea0191 MinGW: Fix -Wclobbered 2023-01-17 15:04:40 +00:00
Alexis La Goutte 3504b423b9 MySQL: Fix Dead Store Found by Clang Analyzer
Line 3728 Value stored to 'offset' is never read
2023-01-17 14:18:31 +00:00
Pascal Quantin 2dd8345895 NR RRC: upgrade dissector to v17.3.0 2023-01-17 14:47:25 +01:00
Joris Peeraer 918c9c5d5c PFCP: add Nokia proprietary IEs 2023-01-17 10:17:24 +00:00
Martin Mathieson 30ef9d38cd Make a couple of functions static 2023-01-16 18:17:59 +00:00
Martin Mathieson 2f1493316a ORAN FH CUS: Round ext11 bundle to next byte 2023-01-16 17:35:48 +00:00
Martin Mathieson 4dd78f11c9 Fix various issues seen with tools/check_typed_item_calls.py 2023-01-16 15:35:04 +00:00
Pascal Quantin da0c933aa8 LTE RRC: upgrade dissector to v17.3.0 2023-01-16 13:59:13 +00:00
Pascal Quantin 84f3a094d4 LPP: upgrade dissector to v17.3.0 2023-01-16 12:31:55 +00:00
John Thacker 1e1e733d8c iSCSI: Handle invalid opcodes inside Reject message
Allow dissect_iscsi_pdu to handle iSCSI messages with invalid
opcodes, so that it does not crash when receiving them in Reject
messages.

Fix #18796
2023-01-15 19:58:29 -05:00
Stig Bjørlykke c0dd9620c5 lwm2mtlv: Fix resource id lookup
The LwM2M object instance and resource id may be given in both the
CoAP Uri-Path and the LwM2M TLV header, and in this case the created
uri_path is wrong and resource id lookup will fail.

Change the logic to get object id from CoAP Uri-Path and resource id
from either Uri-Path or LwM2M TLV header.
2023-01-14 15:39:54 +00:00
João Valverde 6870449734 MinGW: Fix -Wbool-compare
The return of -1 for negative infinity is glibc specific and
non-portable.

/epan/dissectors/packet-synphasor.c:1634:62: error: comparison of constant '-1' with boolean expression is always false [-Werror=bool-compare]
 1634 |                 if ((isinf(pmu_lat) == 1) || (isinf(pmu_lat) == -1)) {
      |                                                              ^~
2023-01-13 22:41:04 +00:00
Gerald Combs 9754448044 CoAP+RTPS: Initialize some variables
Fix

    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x81514B4: get_hfi_length (epan/proto.c:5981)
    ==10365==    by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953)
    ==10365==    by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542)
    ==10365==    by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462)
    ==10365==    by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656)
    ==10365==    by 0x813511A: call_dissector_through_handle (epan/packet.c:757)
    ==10365==    by 0x8130E58: call_dissector_work (epan/packet.c:850)
    ==10365==    by 0x8131604: dissector_try_string_new (epan/packet.c:1751)
    ==10365==    by 0x8131686: dissector_try_string (epan/packet.c:1776)
    ==10365==    by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115)
    ==10365==    by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403)
    ==10365==    by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526)
    ==10365==
    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x81517EC: get_hfi_length (epan/proto.c:6115)
    ==10365==    by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953)
    ==10365==    by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542)
    ==10365==    by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462)
    ==10365==    by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656)
    ==10365==    by 0x813511A: call_dissector_through_handle (epan/packet.c:757)
    ==10365==    by 0x8130E58: call_dissector_work (epan/packet.c:850)
    ==10365==    by 0x8131604: dissector_try_string_new (epan/packet.c:1751)
    ==10365==    by 0x8131686: dissector_try_string (epan/packet.c:1776)
    ==10365==    by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115)
    ==10365==    by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403)
    ==10365==    by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526)

and

    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x748EB90: hash_by_guid (epan/dissectors/packet-rtps.c:6006)
    ==10365==    by 0xC522FD5: wmem_map_lookup (wsutil/wmem/wmem_map.c:264)
    ==10365==    by 0x74A2E33: rtps_util_detect_coherent_set_end_empty_data_case (epan/dissectors/packet-rtps.c:3294)
    ==10365==    by 0x74A1054: dissect_RTPS_DATA (epan/dissectors/packet-rtps.c:10829)
    ==10365==    by 0x748E606: dissect_rtps_submessage_v2 (epan/dissectors/packet-rtps.c:12064)
    ==10365==    by 0x748DFBE: dissect_rtps_submessages (epan/dissectors/packet-rtps.c:12439)
    ==10365==    by 0x74A3FC9: dissect_rtps (epan/dissectors/packet-rtps.c:12357)
    ==10365==    by 0x748EDD2: dissect_rtps_udp (epan/dissectors/packet-rtps.c:12459)
    ==10365==    by 0x81334CA: dissector_try_heuristic (epan/packet.c:2864)
    ==10365==    by 0x76A8FF6: decode_udp_ports (epan/dissectors/packet-udp.c:712)
    ==10365==    by 0x76AB875: dissect (epan/dissectors/packet-udp.c:1267)
    ==10365==    by 0x76A9DAD: dissect_udp (epan/dissectors/packet-udp.c:1273)

Fixes #18785
2023-01-13 13:21:24 -08:00
João Valverde d902cabd3f MinGW: Fix -Wformat 2023-01-13 15:48:03 +00:00
Dr. Lars Völker 566292435f DoIP/UDS: Allow mixing with OBD-II
This patch allows users to dissect UDS and OBD-II messages on the same
ISO15765 or DoIP connection without changing manually changing the
config.
2023-01-13 13:04:09 +00:00
Martin Mathieson 9baefc3d5d eCPRI/ORAN: Various changes while looking at captures 2023-01-13 12:49:03 +00:00
Dr. Lars Völker ea0f20e993 OBD-II: Fixing Service/Mode 0x04 dissection
The current code assumes that the Service 0x04 has at least 1 parameter
byte in the request and 1 parameter byte in the response, which is
wrong.
2023-01-13 09:40:30 +00:00
Louis Scalbert 764890d159 BGP: fix BGP-LS IPv6 Neighbor Address TLV s length 2023-01-13 09:02:02 +00:00
Joris Peeraer 6281ad450b PFCP: refactor dissecting of enterprise IEs
The code for dissecting enterprise IEs has been reworked.

Previously, each enterprise was registered by its enterprise-ie in a
dissector-table. The per-enterprise dissector would index into an array
of IEs in order to find the correct IE-dissector.

Using this method has following drawbacks:
- IEs had to be defined in two arrays (value_string and dissector),
  possibly causing these two arrays becoming out-of-sync,
- the array only can be indexed if all IE-types are contiguous or gaps
  are maintained, which would be wasteful in case of bigger gaps
- individual IEs cannot easily be added outside of the source of this
  file

This commit implements a new approach that addresses above drawbacks by:
- defining all IE information together in one array,
- using per-vendor dissector_tables containing per-IE dissector handles,
  allowing both for arbitrary ie-types and adding individual
  enterprise-IEs separately from external code

This method does a two-level lookup for the IES:
- first looking up a vendor-dissector in the pfcp.enterprise_ies table
- if using the generic-ie-dissector a lookup in the per-vendor table to
  find the IE-dissector

A vendor-dissector receives the whole IE including header and has to do
all the work. An IE-dissector receives only the data-part and
a tree + header-fields have already been created.

The code for registering the per-IE tree-types has been modified as
well, because these tree-types are now stored together with the
IE-definitions. (Getting rid of the hardcoded indexes is also a plus.)

The 3GPP example enterprise dissector has been removed, as there are two
other enterprises which can serve as example.
2023-01-13 08:57:58 +00:00
Ivan Stanoev cc9f5aed2b PFCP: Fix QFI bitmask
QFI field is 6-bit long but in PFCP dissector bitmask was set to 0x7f.
It needs to be 0x3f
2023-01-13 08:05:07 +00:00
Tomasz Moń 500b514b59
USBLL: Dissect USB 2.0 LPM Extended Transaction
Implement USB 2.0 Extension Transaction specified in USB Engineering
Change Notice: USB 2.0 Link Power Management Addendum.

Display Best Effort Service Latency (BESL) instead of Host Initiated
Resume Duration (HIRD) when dissecting LPM Token to align with USB 2.0
ECN Errata for Link Power Management.
2023-01-12 21:03:02 +01:00
Gerald Combs c14eb1767c E2AP: Use tvb_memcpy instead of memcpy(...tvb_get_ptr()) 2023-01-12 18:09:07 +00:00
Gerald Combs 9700b8cf8b LoRaWAN: Use tvb_memcpy instead of memcpy(...tvb_get_ptr()) 2023-01-12 18:09:07 +00:00
YDKK b0cb719672 opus: Fix TOC configuration parameter definitions 2023-01-12 12:41:56 +00:00
Martin Mathieson a88545ae95 Mysql: fix a couple of typos 2023-01-12 10:40:26 +00:00
Marius David 25311c6cfa netflow: Update Keysight netflow fields - pick up new fields added in Appstack 4.4 release 2023-01-12 09:34:47 +00:00
Joakim Karlsson 02894b1cb9 Diameter: correction of copy-paste error 2023-01-11 16:16:29 +00:00
Pascal Quantin ce9689da01 F1AP: upgrade dissector to v17.3.0 2023-01-11 16:57:49 +01:00
Pascal Quantin b1482084b3 E1AP: upgrade dissector to v17.3.0 2023-01-11 15:24:47 +00:00
Pascal Quantin c15189981e NRPPa: upgrade dissector to v17.3.0 2023-01-11 16:06:33 +01:00
Daniël van Eeden 3e4d6a59aa MySQL: Complete dissection of zlib compressed 2023-01-11 14:50:59 +00:00
Pascal Quantin 56dfcccc48 XnAP: upgrade dissector to v17.3.0 2023-01-11 15:06:06 +01:00
Pascal Quantin 20a8a8eb0f NGAP: upgrade dissector to v17.3.0 2023-01-11 10:42:15 +00:00
Pascal Quantin f2cdd8bbc3 M2AP: upgrade dissector to v17.0.1 2023-01-11 10:17:49 +00:00
Pascal Quantin 4f7c3ab16a X2AP: upgrade dissector to v17.3.0 2023-01-11 09:50:18 +01:00
Pascal Quantin 0611f92317 S1AP: upgrade dissector to v17.3.0 2023-01-11 09:06:10 +01:00
Sergey V. Lobanov 8a4f22be61 ALP: fix issue #18795 (memory management issues)
This patch replaces memcpy to tvb_memcpy, also fixes while() loop over numts
2023-01-10 22:37:11 +00:00
Pascal Quantin 5e3dba3da0 NAS 5GS: upgrade dissector to v17.9.0 2023-01-10 22:01:32 +00:00
Sergey V. Lobanov 42f7ee88c6 LLS: fix msvc warning: possible loss of data 2023-01-10 22:07:57 +01:00
Sergey V. Lobanov 60912daef9 LLS: add dissector for ATSC3 Low Level Signalling (LLS) Protocol
LLS dissector is implemented according to A/331:2022-11.
.pcap sample: https://wiki.wireshark.org/SampleCaptures#lls-low-level-signalling-protocol
2023-01-10 09:49:18 +01:00
Kevin Albertson 988d4585bc ipsec: fix comment 2023-01-10 01:34:44 +00:00
Kevin Albertson 005ea28d27 sip: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Kevin Albertson 0150297d55 rtps: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Kevin Albertson 01fda90a45 mcpe: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Kevin Albertson 39ee45a069 multipart: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Kevin Albertson 8461440f4a gelf: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Kevin Albertson f7290f2cb6 mysql: fix leak in uncompress 2023-01-10 01:34:44 +00:00
Sergey V. Lobanov e80b2ab560 ALP: add decoders for Link Mapping Table (LMT) and Sony header extensions
LMT decoder is implemented according to A/330:2022-03.
.pcap sample: https://wiki.wireshark.org/SampleCaptures#alp-protocol

Sony header extensions are not documented publicly, but implemented in libatsc3.
This implementation is based on libatsc3 (src/test_sony/atsc3_sony_ts_alp_reader_reflector_test.c)
Libatsc3 home: https://github.com/jjustman/libatsc3
Use cases for sony extenstions can be found in: https://www.sony.com/content/dam/sony/landing-pages/whitepaper-atsc30_automotive_field_tests_.pdf
.pcap samples: https://wiki.wireshark.org/SampleCaptures#alp-protocol
2023-01-09 22:21:41 +00:00
PMcL 1fc516739e mako: Updated Metamako trailer dissection
packet-metamako.c: Made heuristic variables available for the user to change via the UI, updated the display strings of the Clause 49 BTF value and the Original FCS status, simplified the heuristic function, added UI options to force trailer dissection (override heuristics), and allow for user specification of whether an FCS is present in the capture, fixed TLV walking bug if the heuristic picks up an invalid TLV length, appends the Info column with a message if the trailer is found, added a generated timestamp field to display the epoch seconds, added total-frame FCS display if total-frame FCS is detected, along with its status.
2023-01-09 20:08:02 +00:00
Joakim Karlsson 56deed1c15 GTPv2: correction of IE MM Context EPS QQ 2023-01-09 15:50:42 +01:00