Commit Graph

61851 Commits

Author SHA1 Message Date
glores b77ffb9d36 GTPv2 command messages conversation
Change-Id: I2faa01b3c461269e5c8ed88ef44157fbc33758b9
Reviewed-on: https://code.wireshark.org/review/13980
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-18 00:05:20 +00:00
Pascal Quantin 20fcb6c2e1 Fix compilation of extcap programs with NMake
Change-Id: I80e17aeeab5bf747c6ba06168245d38d6d78efa9
Reviewed-on: https://code.wireshark.org/review/13986
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-18 00:01:00 +00:00
Dario Lombardo 7382b02625 cip: fix a leak
Change g_list into wmem_list to solve the leak. Leak found by valgrind.

==14755== 3,384 (504 direct, 2,880 indirect) bytes in 21 blocks are definitely lost in loss record 3,380 of 3,418
==14755==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14755==    by 0xA806610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
==14755==    by 0xA81C22D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
==14755==    by 0xA7FD4F3: g_list_append (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
==14755==    by 0x67CD825: build_get_attr_all_table (packet-cip.c:5402)
==14755==    by 0x67CD825: proto_register_cip (packet-cip.c:8067)
==14755==    by 0x71C83F9: register_all_protocols (register.c:229)
==14755==    by 0x65F14D7: proto_init (proto.c:521)
==14755==    by 0x65CF961: epan_init (epan.c:126)
==14755==    by 0x1153F0: main (tshark.c:1220)

Change-Id: I9c25ee5b5bf04b9afb8b0bf22bb6f3d7022bf4d3
Reviewed-on: https://code.wireshark.org/review/13969
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-17 14:14:40 +00:00
Christian Lamparter 6671b0dea8 usb: cleanup idProduct dissection
The current code which dissects the idProduct (and to some extend the
idVendor) item for USB devices is overly complicated. A better method
to format the product string in the right way is using:
proto_tree_add_uint_format_value.

This gets rid of the additinal string and item manipulation altogether.

Change-Id: Iadd69b7dc284e62039402de53418f41460d88a5d
Reviewed-on: https://code.wireshark.org/review/13973
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-17 13:16:42 +00:00
Stig Bjørlykke 2d133d62ab Qt: Validate FindLineEdit regexp
Check if regexp is valid and set valid/invalid background color.

Change-Id: Ibf4d3fa84463afbd7c68631cfaddec8261807b8f
Reviewed-on: https://code.wireshark.org/review/13962
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-17 08:41:46 +00:00
João Valverde cb962ca3e5 autotools: Remove extra space from output
Change-Id: If50c6b5d15d44ed3d99a82bd0ca08f93ee059ce3
Reviewed-on: https://code.wireshark.org/review/13979
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-17 04:35:51 +00:00
Guy Harris 707298c680 Cast away a warning.
The argument to the resize method for QByteArray is an int, not a
size_t.

Change-Id: Id30bc03daec6d6ead8669794b5cb0247718be66b
Reviewed-on: https://code.wireshark.org/review/13977
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-16 22:26:29 +00:00
Martin Kaiser d4ee4a9c94 iso14443: fix the NAK/ACK bit of an R-block
if the bit is set, it's an R(NAK) block

Change-Id: I0e44bd72d1c2a69a582792d08bf450e6ef2d163b
Reviewed-on: https://code.wireshark.org/review/13976
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-02-16 22:24:49 +00:00
Stig Bjørlykke 989739c4fc Qt: Add Decode as in Show Packet Bytes
Add an option to decode the packet bytes from base64 or zlib compressed.
Also add configurable start byte and end byte to make it possible to
decode a subset of bytes.  It's also possible to select a range in ASCII
view and select "Show selected" from the context menu to make a subset.

In ASCII view a null terminator is replaced by UTF8 symbol for NULL,
and a CR is replaced by UTF8 symbol for carriage return.  This is done
to make it possible to "Show selected" from the context menu.

Change-Id: Ie03c9912c304c121af6ca9e998a6e8445b5382c5
Reviewed-on: https://code.wireshark.org/review/13958
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-16 21:43:14 +00:00
Pascal Quantin a6118997ff Add packet-usbip.h to epan/dissectors/Makefile.common file
Change-Id: Idb9dc545da7b1a1957facd243806f0459ffb7e0b
Reviewed-on: https://code.wireshark.org/review/13972
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-16 19:27:25 +00:00
Christian Lamparter 360349c002 USBIP: add USBIP Protocol dissector
This patch adds support for the USBIP protocol [0]. A document
describing the protocol in detail is available from the linux
kernel source [1].

The USBIP protocol mimics a USB HCD on a client PC that tunnels
USB data over TCP/IP between the client and the host where the
physical USB device is connected.

A testcase has been submitted to bug.wireshark.org [2].

[0] <http://usbip.sourceforge.net/>
[1] <https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/usbip/usbip_protocol.txt>
[2] <https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12127>

Bug: 12127
Change-Id: I4e557dc274017eb029c7af2717a62be4b00aebda
Reviewed-on: https://code.wireshark.org/review/13797
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-16 18:52:49 +00:00
AndersBroman 878d724c52 Update Debian symbols.
Change-Id: I7ca826d247ea7e073ce9454a22b053d90ea8b2fa
Reviewed-on: https://code.wireshark.org/review/13966
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 11:52:23 +00:00
Mikael Kanstrup 9c0b5a9538 ws80211: Replace some whitespaces with tabs
File had both whitespaces and tabs for indentation. Replace
whitespace indentation with tabs. This is the same indentation
mode as ws80211.c file uses.

Change-Id: I46bbd675f5089eb502b489fdfd70f30510bc95ef
Reviewed-on: https://code.wireshark.org/review/13963
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 09:58:47 +00:00
Juanjo Martin c97a97aa9e RTPS: Added new locator kinds and upgraded to latest set of ids
The standard says that UDPv6 is the index 2. However, the dissector
contained the old implementation of RTI DDS (which had SHMEM = 2
and UDPv6 = 5). I have updated the dissector to be compliant with
the standard and indirectly be compliant with the new version of
RTI DDS which now implements the standard in this aspect.

Change-Id: Iaade0e457fda35362c04a7658d62242cf8868127
Reviewed-on: https://code.wireshark.org/review/13922
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 07:16:50 +00:00
João Valverde d1474f1ce8 IRDP: Use integer arithmetic to round-up [-Wbad-function-cast]
Change-Id: Idef58b23b7ec0b52ca10c0ce5304bf840252e043
Reviewed-on: https://code.wireshark.org/review/13935
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 05:58:32 +00:00
D. Ulis 416ca6b9c9 CIP/ENIP: Attribute updates
1. More Identity attributes
2. Port attributes
3. Set Attribute List request highlighted too much attribute data
4. TCP/IP object, Attr 5 needs padding
5. Switch most attributes to use wrappers instead of dissect_epath() directly.
6. Change new Volume 8 attributes to treat path size as words instead of bytes, when parsing size+EPATH formats.

Change-Id: I1b8c476475c6fbb9c7cdb99ec4a6c28934631a19
Reviewed-on: https://code.wireshark.org/review/13898
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 05:56:14 +00:00
João Valverde 95dee44a77 const gpointer -> gconstpointer
'const gpointer' is the same as 'void *const'. Replace with gconstpointer
where straightforward (assuming that was the intent) and use gpointer everywhere
else for clarity (that does not change *API* constness contract; it just means
a variable is not declared immutable inside the called funtion).

Change-Id: Iad2ef13205bfb4ff0056b2bce056353b58942267
Reviewed-on: https://code.wireshark.org/review/13945
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16 05:10:49 +00:00
Martin Kaiser 076784cdae iso14443: fix the order of the ATS bytes
TL and T0 are followed by TA(1), TB(1) and TC(1), in this order

Change-Id: I356da8bb475d55f36e5b9ff02d35fcf35c457223
Reviewed-on: https://code.wireshark.org/review/13961
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-02-15 20:58:24 +00:00
Martin Kaiser 338a0c74e3 iso14443: dissect FWI in the ATS
use the same hf as for ATQB's FWI

Change-Id: I2c1db117688e16e91fc4072d9b6f4bba46f64fd6
Reviewed-on: https://code.wireshark.org/review/13960
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-02-15 20:56:51 +00:00
Martin Kaiser 458d598279 iso14443: move ATS dissection to a separate function
Change-Id: I04d9b610aac0f5387870be63b1d0dde9940bfa5b
Reviewed-on: https://code.wireshark.org/review/13959
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-02-15 20:56:33 +00:00
Guy Harris 4e85b62ae5 Allow test of the -D and -L options to succeed or fail with a permissions error.
We cannot easily predict what will happen, given the configuration of
the OS, the permissions on files, the availability of extcap devices,
the version of libpcap/WinPcap/NPcap (present or future), etc., etc.,
etc..  Allow those tests to succeed (as would be the case if you have
the necessary permissions) or fail with a non-command-line-syntax error
(as would be the case if you don't have the necessary permissions), but
not to fail with a command-line syntax error.

Change-Id: I76af898d5f146fcf3507c06f101acb578085e6fa
Reviewed-on: https://code.wireshark.org/review/13957
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 20:17:54 +00:00
Stig Bjørlykke 44f74e7b26 Qt: Add FindLineEdit with regex search option
Add settings to the QLineEdit context menu to use textual or regular
expression search.  Use this in Follow Stream and Show Packet Bytes.

Change-Id: I3a9f5a923f616629aa40a334921871f98b518f30
Reviewed-on: https://code.wireshark.org/review/13942
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-15 19:44:27 +00:00
João Valverde 8e1ade8516 Use cast to char for explicit conversion [-Woverflow]
Change-Id: If33cf41f46f2be9c66fc4a626af6a2c010fba7d3
Reviewed-on: https://code.wireshark.org/review/13931
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-15 18:36:14 +00:00
Stig Bjørlykke a6a358ef96 multipart: Add Content-Description header
Change-Id: I10432e813832cf6facc33bf3c06872bd9611a4c5
Reviewed-on: https://code.wireshark.org/review/13954
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-15 17:45:51 +00:00
AndersBroman 614751da53 [UMTS-FP] Try to fix Bug 12121 out of bounds access by expanding an array.
Bug: 12121
Change-Id: Ie7dc2a27ba3ad1ad81b301ca4d41fa2d6c485206
Reviewed-on: https://code.wireshark.org/review/13955
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-15 16:28:14 +00:00
Guy Harris 3d732269c1 More changes reflecting the extcap binaries being built in extcap.
Change-Id: I1b14a160f3c9a48811ae68ade31969231dd1a627
Reviewed-on: https://code.wireshark.org/review/13953
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 13:36:55 +00:00
Guy Harris 2345a2b27c Some more randpkt_core.
Change-Id: I62181a2b2664095a818e9adefce79b59b4510a34
Reviewed-on: https://code.wireshark.org/review/13952
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 12:26:27 +00:00
Guy Harris 143ce94713 Correctly set the "short GI" flag in the generic radio information structure.
For 802.11n, if the GI length is present in the MCS field and is "short
GI", "gi_length" is equal to 1, not to 0, so set the "short GI" flag in
the generic radio information to "gi_length".

Bug: 12123
Change-Id: Ica2c5794698a643a6393f0468cdbfe025aa90074
Reviewed-on: https://code.wireshark.org/review/13950
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 10:58:06 +00:00
Guy Harris ec863197d9 Fix name of librandpkt_core.
Also, add it to the list of dependencies.

Change-Id: I424c0657c87ab97d704b86a3b0722fb7f33b9f49
Reviewed-on: https://code.wireshark.org/review/13949
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 10:42:28 +00:00
Guy Harris 65d3d6abb1 Generate randpkt_core/doxygen.cfg.
Change-Id: I22417f39f124ffdfd9fd0304605d7a301752c2a3
Reviewed-on: https://code.wireshark.org/review/13948
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 09:37:23 +00:00
Guy Harris f6dc74598b Add randpkt_core to the list of libraries for randpkt.
Also, get rid of the stuff for the extcap programs, as that's now
handled by extcap/Makefile.nmake.

Change-Id: Ide94c1cfc97d50e5d9fabbb923d9c52cccb62fa0
Reviewed-on: https://code.wireshark.org/review/13947
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 09:29:07 +00:00
Guy Harris 58d00bad1a Build the extcap programs in the extcap directory.
That lets the version of Wireshark built with autotools find the extcap
programs.

Don't install the extcap programs under ${datadir} - that puts it under
a share directory, and share directories are for platform-independent
files, which executable images aren't (they're instruction-set
dependent, hence platform-dependent).

Change-Id: I992eeb984bdbe6b3476777f7114628c83df6080f
Reviewed-on: https://code.wireshark.org/review/13943
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-15 08:31:06 +00:00
João Valverde 21ab9b2cbe IMAP: Indentation
Change-Id: Ie5cacd1e058cffd5518dcad049731b27989c0e79
Reviewed-on: https://code.wireshark.org/review/13944
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-15 05:37:25 +00:00
Jonas Falkevik 780f886d29 editcap: flag for ignore vlan duplication removal
Add additional --novlan flag for removing vlan tag info before checking for duplicates.
When capturing with -i any you could see packets more than once and some drivers include vlan info.
With the --novlan the vlan info is removed from the packet so that checksum duplication detection can be used,
if the rest of the packets are the same.

Change-Id: I5dca6e20259a0a396875919e9e60cc42291579d3
Reviewed-on: https://code.wireshark.org/review/13414
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-15 05:33:14 +00:00
João Valverde 82bb9ebc01 Add some casts to void * to fix (pedantic) argument mismatch notes
Change-Id: I63e46285b4c6676d4ae57196b85fbad89964898c
Reviewed-on: https://code.wireshark.org/review/13933
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-15 00:00:34 +00:00
João Valverde 5066cf8690 Fix format string warnings [-Wformat=]
Change-Id: I266c7d422f6ade965b42a4e2e8dc01966f8eb5f8
Reviewed-on: https://code.wireshark.org/review/13932
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-14 23:47:43 +00:00
João Valverde b846e487ff LWM: Fix "Assigned value is garbage or undefined"
From scan-build:
  packet-lwm.c:466:33: warning: Assigned value is garbage or undefined

Change-Id: Ib9e1cfd3f9462d0bbb5a87ae4d323c333878323d
Reviewed-on: https://code.wireshark.org/review/13937
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-14 22:21:31 +00:00
João Valverde 7f520c352d Fix two warnings for semcheck.c
semcheck.c:986:24: warning: cast from function call of type 'sttype_id_t' to non-matching type 'int' [-Wbad-function-cast]
semcheck.c:986:5: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'struct stnode_t *' [-Wformat=]

Change-Id: I83031251c83f6597eb7c31f35e02c5a95bd2dabb
Reviewed-on: https://code.wireshark.org/review/13930
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-14 22:10:22 +00:00
Alexis La Goutte 5dbc727ae9 tango_color(.h): avoid ‘tango_butter_3’ defined but not used [-Werror=unused-const-variable] found by gcc6
Change-Id: I5500c7228003358421d2aa40808213ef739e765b
Reviewed-on: https://code.wireshark.org/review/13906
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-14 18:28:40 +00:00
Stig Bjørlykke 52deda15ee Sort UTF8 entities
Change-Id: I804dc16c3dd04e57556e095bf82a81afe257f03c
Reviewed-on: https://code.wireshark.org/review/13941
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-14 18:08:59 +00:00
Gerald Combs 40739389ce [Automatic update for 2016-02-14]
Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I85afd74e86c8e38f9ddc73ec92c26d7f24776743
Reviewed-on: https://code.wireshark.org/review/13938
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-14 16:06:21 +00:00
Guy Harris c3d8ac6d9b Register Q.931 in the osinl.incl dissector table.
Have the Frame Relay dissector first check the fr.osinl table and then
the osinl.incl table, so that it finds Q.933 rather than Q.931 for an
NLPID of 0x08.

Change-Id: I1582482003c2ff96100f6c3e1eb77917ab04c9ee
Reviewed-on: https://code.wireshark.org/review/13929
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-14 00:00:07 +00:00
João Valverde 2e85975fee Just #include wsutil/inet_aton.h
No need for platform-specific system header boilerplate.

Change-Id: I5387a0005ddb0d7aab3c5b9f28d6282053c1b0fd
Reviewed-on: https://code.wireshark.org/review/13865
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
2016-02-13 23:51:53 +00:00
Guy Harris d55f176a24 Don't define EXTCAP_DIR as "${datadir}/wireshark/extcap".
If you hand that string to a UNIX API, it'll probably fail; you need to
expand ${datadir} in the *build* process.

Do it the same way we handle PLUGIN_INSTALL_DIR.

Change-Id: I09e8a8467ab7b0e912a174be3335ee1faff91abb
Reviewed-on: https://code.wireshark.org/review/13928
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-13 20:26:54 +00:00
Michael Tüxen 088f57fa9b Add support for libssh.
Change-Id: Iffb0ea15c76659f5c1f73e2b7b11bcfdeb859c6a
Reviewed-on: https://code.wireshark.org/review/13925
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2016-02-13 20:06:41 +00:00
Joerg Mayer c0bdaf15e2 Fix an indentation to get rid of
text2pcap.c:1254:17: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]

Change-Id: Ifa031f5faad3445bcd3ab893d83c5dc6386fe3a2
Reviewed-on: https://code.wireshark.org/review/13927
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-02-13 19:54:02 +00:00
Alexis La Goutte 137358a404 androiddump: fix logical ‘or’ of equal expressions [-Werror=logical-op] found by gcc6
EAGAIN and EWOULDBLOCK is the same value (now)
http://www-numi.fnal.gov/offline_software/srt_public_context/WebDocs/Errors/unix_system_errors.html

Change-Id: Ia8101d05194910f306e8439507ae5bde3ccd00ce
Reviewed-on: https://code.wireshark.org/review/13905
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-13 14:46:27 +00:00
Joerg Mayer b550c33d4a Dissection of SSAPs is a bit weird. 0x1 would be displayed as ">Unknown (0x01)"
on my particular trace. This duplicates the value with the C/R-bit set. Needs
a proper fix eventually.
Small indentation fix.

Change-Id: I6bf7c560b5161994b8d90d7ae70724c03c6df73b
Reviewed-on: https://code.wireshark.org/review/13926
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-02-13 14:04:17 +00:00
Martin Kaiser 378c59bfae iso14443: verify the CRC of all messages
define a function to dissect the CRC depending on the card type

add a circuit for an activated card to keep track of the card type

define a new circuit type CT_ISO1443 for this purpose, the circuit ID is
always 0 as we support only a single active card

Change-Id: I7250f834301612ba50743258ca7bdbe0199de3ea
Reviewed-on: https://code.wireshark.org/review/13908
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-02-13 13:28:41 +00:00
Francois Schneider 8a2b3bc898 packetbb: Add some descriptions for message and TLV types
Change-Id: I2f1455cf50d9a90a516194ed09d7f6d6932e3afe
Reviewed-on: https://code.wireshark.org/review/13912
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-13 12:32:36 +00:00