Commit Graph

84 Commits

Author SHA1 Message Date
Constantine Gavrilov 01de470856 NVMe: fix for parsing data for logpage NVMeOF Discovery.
Take into acoount reported number of records.
Thus, discard extra payload, it target has not truncated response.
2021-06-15 17:01:01 +03:00
Constantine Gavrilov 6ba703cba7 MVMe: append command names for commands, responses and transfers to Info column. 2021-06-15 08:27:16 +00:00
Martin Mathieson d9c150169d NVME: fix typo 2021-06-14 09:22:17 +01:00
Constantine Gavrilov 74a3fac004 NVMeOF: rename fields to pass code validation. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov 5d35e28e45 NVMeOF: complete decoding of fabric commands.
Add support for:
* Authentication Send
* Authentication Receive
* Disconnect
2021-06-14 06:21:46 +00:00
Constantine Gavrilov c7e082c6de NVMe: use common block for decoding CQEs for fabric and IO commands. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov 8bc0924c25 NVMeOF fabric commands: simplify decoding code using field definitions. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov 45201049e0 NVMeOF fabric commands: switch TCP dissect to common NVMe code. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov 0b101d54da NVMeOF fabric commands: support offset in commands and completions dissectors. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov d576719df4 NVMeOF: move handling of NVMeOF fabric commands, fabric completions and fabric command transfers to packet-nvme.c.
RMDA implementation is moved to packet-nvme.c, will become common implementation.
2021-06-14 06:21:46 +00:00
Constantine Gavrilov 7874e01686 NVMeOF Connect command decoding fixes. 2021-06-14 06:21:46 +00:00
Constantine Gavrilov 8d60d8c4f2 NVMe: decode Set Fatures data transfers.
This closes #17407.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov e75998cded NVMe: decode Set Fatures response (DWORD0) in CQE. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov d5c1bd9d93 NVMe: refactor CQE decoding to decode all fields and decode comand status. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov 12ddec82bf NVMe: decode Set Features DWORD11 and DWORD12 for each feature. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov f0b83585c1 NVMe: decode Set Features command. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov 6755309958 NVMe: refactor command parsing to always print DWORD10-DWORD15. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov 88e792b376 NVMe: fix test build warnings.
** 'nvme.cmd.identify.ctrl.lpa' exists multiple times with incompatible types: FT_UINT8 and FT_BOOLEAN
** 'nvme-rdma.cmd.prop_attr.set.csts.rsvd' exists multiple times with incompatible types: FT_BYTES and FT_UINT8
** 'nvme-rdma.cqe.status.pget.csts.rsvd' exists multiple times with incompatible types: FT_BYTES and FT_UINT8
2021-05-25 03:48:12 +00:00
Alexis La Goutte 00c4056670 nvme: Fix Dead Store
Value stored to 'bytes' is never read
2021-05-23 19:06:48 +00:00
Constantine Gavrilov 81511a5f98 NVMe: fix parsing ANA Get LogPage response. 2021-05-23 16:29:59 +03:00
Alexis La Goutte 8aec509a22 nvme: Fix Dead Store (unused variable) 2021-05-06 07:18:22 +00:00
Martin Mathieson aed3f61175 NVME: try to fix a value_string value
N.B. Didn't find the spec for this, but the pipeline warning is as follows
Field 'RDMA Provider Type (RDMA_PRTYPE)' (nvme.cmd.get_logpage.identify.rcrd.tsas.rdma_prtype) has a conflicting entry in its value_string: 3 is at indices 2 (RoCE (v1)) and 4 (iWARP)
2021-05-03 07:56:47 +00:00
Pascal Quantin 40bc53a129 NVMe: do not use packet scope memory for BASE_CUSTOM fields
As the fallback string is not formated, use val_to_str_const() instead
Fixes #17364
2021-04-28 21:49:16 +00:00
Joakim Karlsson 1bd0cf5fbd NVMe: fix build error
packet-nvme.c:2396:8: error: ‘grp’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
     ti = proto_tree_add_item(grp, hf_nvme_get_logpage_lba_status_nel,
cmd_tvb, poff, len, ENC_NA);
        ^
packet-nvme.c:2378:17:
note: ‘grp’ was declared here
     proto_tree *grp;
                 ^
2021-04-23 08:04:58 +00:00
Constantine Gavrilov 4d72ce1a4a NVMe: Get LogPage: Sanitize Response.
This closes #17327
2021-04-20 17:47:13 +00:00
Constantine Gavrilov 59d81aa02a NVMe: Get LogPage: Reservation Response. 2021-04-20 17:47:13 +00:00
Constantine Gavrilov 6b80b58506 NVMe: Get LogPage: Endurance Group Aggregate Response. 2021-04-20 17:47:13 +00:00
Constantine Gavrilov 01e32eaa20 NVMe: Get LogPage: LBA Status Response. 2021-04-20 17:47:13 +00:00
Martin Mathieson d75e9f95eb More trivial spellings. 2021-04-20 08:46:16 +00:00
Martin Mathieson 53c67e31e7 NVME: Fix some spellings
Also added some of its words to wireshark_words.txt
2021-04-19 09:24:38 +01:00
Constantine Gavrilov 4959389fc3 NVMe: Windows compiler support. 2021-04-19 07:14:51 +00:00
Constantine Gavrilov f19298d2e1 NVMe: Get LogPage: ANA Response. 2021-04-19 07:14:51 +00:00
Constantine Gavrilov d24d62ea0e NVMe: Get LogPage: Predictable Latency Agrregate Response. 2021-04-19 07:14:51 +00:00
Constantine Gavrilov fa07609955 NVMe: Get LogPage: Predictable Latency Response. 2021-04-19 07:14:51 +00:00
Constantine Gavrilov d3c5eb2a71 NVMe: Get LogPage: Endurance Group Response. 2021-04-19 07:14:51 +00:00
Constantine Gavrilov b5d770fc5f NVMe: Get LogPage: Telemetry Response. 2021-04-19 07:14:50 +00:00
Constantine Gavrilov 2ca3707be1 NVMe: Get LogPage: Device Self-test Log. 2021-04-19 07:14:50 +00:00
Constantine Gavrilov bb5ec812fe NVMe: Get LogPage: Commands Supported and Effects 2021-04-19 07:14:50 +00:00
Constantine Gavrilov 4ea25fc41a NVMe: Get LogPage: dissect Changed NS List Response 2021-04-19 07:14:50 +00:00
Constantine Gavrilov d30bbbb7e8 NVMe: Get LogPage: dissect FW Slot Response 2021-04-19 07:14:50 +00:00
Constantine Gavrilov 582319d33a NVMe: Get LogPage: dissect Smart Response 2021-04-19 07:14:50 +00:00
Constantine Gavrilov 732d30ffa1 NVMe: Get LogPage: dissect Error Information Response 2021-04-19 07:14:50 +00:00
Constantine Gavrilov b856762463 NVMe: Get LogPage dissect.
* the command is decoded
* response data is decoded for Identify (NVMEoF)
2021-04-19 07:14:50 +00:00
Constantine Gavrilov cf827f248d NVMe: Decode all fields of Identify Controller Reply.
Closes #17282.
2021-03-30 12:11:46 +00:00
Martin Mathieson e5916d1fc9 NVME: Fix some spellings 2021-03-13 12:01:11 +00:00
Guy Harris f99bd01cee nvme: don't assume "%lu" is the right format to use for a guint64.
The right format to use is "%" G_GUINT64_FORMAT.  A guint64 might be an
unsigned long or it might be an unsigned long long; do not assume which
one it will be on all platforms.
2021-03-13 03:31:12 -08:00
Constantine Gavrilov 272ff625f5 NVME Identify Controller: decode TNVMCAP, UNVMCAP, RPMBS fields.
Also, undo a3000150a6 changes, per review comments.
2021-03-13 07:18:47 +00:00
Constantine Gavrilov d509e7e872 NVME Identify Controller: decode MTFA, HMPRE, HMMIN fields. 2021-03-13 07:18:47 +00:00
Constantine Gavrilov b7f3a922e0 NVME Identify Controller: decode AVSCC, APSTA, WCTEMP, CCTEMP fields. 2021-03-13 07:18:47 +00:00
Constantine Gavrilov 6b9adc46de NVME Identify Controller: Error Log Page Entries and Number of Power States decoding. 2021-03-13 07:18:47 +00:00