Commit graph

30852 commits

Author SHA1 Message Date
Guy Harris
add4e4dfbd Squelch some warnings.
svn path=/trunk/; revision=31959
2010-02-23 03:23:46 +00:00
Guy Harris
0cc33d4c98 Move some dissectors to the "clean" category - the Ubuntu buildbot
cranks up the warnings, with the side-effect of turning off -Werror, and
none of the other GCC buildbots complains about them.

svn path=/trunk/; revision=31958
2010-02-23 02:49:28 +00:00
Guy Harris
41b012403e Squelch some compiler warnings (some of which indicate potential
problems, and some of which are, at least, incorrect casts).

svn path=/trunk/; revision=31957
2010-02-23 02:11:52 +00:00
Guy Harris
9845a10325 Don't use C++ keywords as variable names - prepend "ber_" in front of
variables with BER metadata.

svn path=/trunk/; revision=31956
2010-02-23 02:10:54 +00:00
Guy Harris
dda82be58c Squelch some (valid) warnings.
svn path=/trunk/; revision=31955
2010-02-23 01:23:39 +00:00
Guy Harris
2d1e27dddb Fix cast.
svn path=/trunk/; revision=31954
2010-02-23 01:23:07 +00:00
Guy Harris
ef418305f0 Attempt to squelch some compiler warnings.
svn path=/trunk/; revision=31953
2010-02-23 01:16:48 +00:00
Gerald Combs
32f439b8a5 Add Yves Geissbuehler.
svn path=/trunk/; revision=31952
2010-02-23 01:11:22 +00:00
Stig Bjørlykke
0991ef8cae Handle FT_PROTOCOL as ByteArray when used in a Field extractor.
svn path=/trunk/; revision=31951
2010-02-22 19:22:28 +00:00
Bill Meier
2b3fd5ba4e GtkOptionMenu --> GtkComboBox
svn path=/trunk/; revision=31950
2010-02-22 18:50:56 +00:00
Bill Meier
644d7d41bf GtkOptionMenu --> GtkComboBox
svn path=/trunk/; revision=31949
2010-02-22 18:47:44 +00:00
Bill Meier
ae40c9021c GtkOPtionMenu ==> GtkComboBox: V2: use ws_combo_box_new_text_and_pointer & etc
svn path=/trunk/; revision=31948
2010-02-22 18:43:36 +00:00
Bill Meier
59dbaca913 Add ws_combo_box_new_text_and_pointer() and related which provides a
variant of gtk_combo_box which stores a pointer along as well as text for
each combo_box entry. 

svn path=/trunk/; revision=31947
2010-02-22 18:39:55 +00:00
Stephen Fisher
b62d27c43d Minor cosmetic changes:
- Display "Asynchronous Transfer Mode" instead of "ATM" in the protocol tree
 - Highlight the rest of the packet when the user selects ATM in the
   packet details pane.


svn path=/trunk/; revision=31946
2010-02-22 09:06:41 +00:00
Gerasimos Dimitriadis
c79b4e5473 Fix for bug 4509:
Make sure that the length addition results have not wrapped.

svn path=/trunk/; revision=31945
2010-02-22 00:04:51 +00:00
Martin Mathieson
5ebfb767a6 Include dialag filter in generated channel filters.
svn path=/trunk/; revision=31944
2010-02-21 22:07:41 +00:00
Bill Meier
b96c45d391 Enable command-line wildcard expansion when invoking mergecap and capinfos
by linking those executables with setargv.obj.
See http://www.wireshark.org/lists/wireshark-users/201002/msg00194.html
  (and preceeding messages in the thread).


svn path=/trunk/; revision=31943
2010-02-21 22:06:50 +00:00
Martin Mathieson
e3283446cc Allow multiple instances to be created, with filters.
svn path=/trunk/; revision=31942
2010-02-21 21:46:37 +00:00
Martin Mathieson
3ddadbc740 - include given filter in generated filter expressions.
- reselect UE after retapping.
- move some vars from top-level to be locals in _init().

svn path=/trunk/; revision=31941
2010-02-21 18:48:26 +00:00
Gerald Combs
f88c985811 [Automatic manuf and enterprise-numbers update for 2010-02-21]
svn path=/trunk/; revision=31938
2010-02-21 16:02:21 +00:00
Martin Mathieson
d28b51b15a Allow multiple instances of LTE MAC statistics windows, each with own filter.
This makes it easier to work with traces including multiple sectors...

svn path=/trunk/; revision=31937
2010-02-21 15:08:50 +00:00
Guy Harris
6105fcc8d5 Squelch some uninitialized-variable warnings (they're false positives).
svn path=/trunk/; revision=31936
2010-02-20 18:51:56 +00:00
Guy Harris
4a44d2c3dd Cast away some implicit-narrowing-conversion warnings.
svn path=/trunk/; revision=31935
2010-02-20 18:36:01 +00:00
Bill Meier
e81b0d3f7c Fix a gcc -Wshadow warning
svn path=/trunk/; revision=31934
2010-02-20 17:44:52 +00:00
Bill Meier
f7440d43e4 Add note about not using C99 features.
svn path=/trunk/; revision=31933
2010-02-20 17:36:18 +00:00
Martin Mathieson
f2944322f6 Add missing SIP response codes from iana sip-parameters
svn path=/trunk/; revision=31932
2010-02-20 17:19:16 +00:00
Martin Mathieson
6a0c3ecaaf Include detected DL retx in stats.
Each row is now a uniqe RNTI/UEId pair.
Added a filter button to filter by selected RNTI + UEId

svn path=/trunk/; revision=31931
2010-02-20 16:58:48 +00:00
Anders Broman
cb427754aa Add a protocol reference.
svn path=/trunk/; revision=31930
2010-02-20 11:53:36 +00:00
Anders Broman
85b2749d36 From Mithun Roy:
DTN Dissector Bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4500

svn path=/trunk/; revision=31929
2010-02-20 11:06:16 +00:00
Guy Harris
13c971dde3 We don't call assert() (and shouldn't - dissectors should use
DISSECTOR_ASSERT(), so the dissection stops, but the app continues to
run), so we don't need to include <assert.h>.

svn path=/trunk/; revision=31928
2010-02-19 23:45:31 +00:00
Jaap Keuter
f7e082ad35 Add expert items for missing end option in:
- vendor option field
- overloaded sname field
- overloaded file name field

Improve the overload determination of sname and file name field.

svn path=/trunk/; revision=31927
2010-02-19 22:46:07 +00:00
Guy Harris
2adab81fba Get rid of C++-style comments (even inside "#if 0"/"#endif", the API
checks fail).

Clean up indentation.

svn path=/trunk/; revision=31926
2010-02-19 19:50:23 +00:00
Anders Broman
4f7dfb6981 Commit #if 0'd out code:
"Start of converting the clist to a gtk_list_store"
If some one whant's to continue on it...

svn path=/trunk/; revision=31925
2010-02-19 19:00:06 +00:00
Guy Harris
9a5521a819 Fix tpyo.
svn path=/trunk/; revision=31924
2010-02-19 17:51:36 +00:00
Gerald Combs
07d078896d Fix a version number.
svn path=/trunk/; revision=31923
2010-02-19 17:23:54 +00:00
Guy Harris
1b59a2446f Clean up decryption; have it return various indications for whether it
was able to decrypt and, if it wasn't, why it wasn't, and put that
information into an expert information indication.

svn path=/trunk/; revision=31922
2010-02-19 10:24:13 +00:00
Jaap Keuter
4ab14bc71e Ditch the last direct indexed character array.
And some minor formatting updates.

svn path=/trunk/; revision=31921
2010-02-19 07:43:26 +00:00
Guy Harris
fba3da4f99 Fix compilation with pre-2.6 GTK+.
svn path=/trunk/; revision=31920
2010-02-19 01:51:27 +00:00
Guy Harris
980ac5960e Don't say "Checking for broken pcap-config" if we don't have a
pcap-config to check for brokenness.

svn path=/trunk/; revision=31919
2010-02-19 00:15:29 +00:00
Guy Harris
88035881c3 There's an echo in here....
svn path=/trunk/; revision=31918
2010-02-19 00:05:34 +00:00
Bill Meier
21f1d8e49a GtkOPtionMenu ==> GtkComboBox;
Also:
 - Remove some unneeded #includes;
 - It's now OK to use gtk_text_buffer_select_range() since GTK .ge. 2.4 is now required;
   (This reverts SVN #18750). 

svn path=/trunk/; revision=31917
2010-02-18 22:04:50 +00:00
Martin Mathieson
7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set.
svn path=/trunk/; revision=31916
2010-02-18 21:24:47 +00:00
Jaap Keuter
6e795990fb The evil bit IS a security issue.... ;)
svn path=/trunk/; revision=31915
2010-02-18 20:58:04 +00:00
Anders Broman
48746a9fe7 Add a protocol reference.
svn path=/trunk/; revision=31914
2010-02-18 06:32:23 +00:00
Anders Broman
d8684d1d8d Cleanup of DECT dissector INFO column.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4502
- remove check_col()

svn path=/trunk/; revision=31913
2010-02-18 06:18:34 +00:00
Guy Harris
f919a5c1b4 To check for GLib 2.14.0 or later, just check with pkg-config, don't use
AM_PATH_GLIB_2_0.  We don't need all the mechanism of AM_PATH_GLIB_2_0
to check for pkg-config sanity etc., as we've already used
AM_PATH_GLIB_2_0 and have thus already done that, and not doing it again

	1) means we don't get a bunch of configure-script whining if we
	   have GLib >= 2.4 and GLib < 2.14;

	2) means we can get rid of stuff to compensate for
	   AM_PATH_GLIB_2_0 failing with GLib < 2.14.

svn path=/trunk/; revision=31912
2010-02-18 02:32:13 +00:00
Guy Harris
ba7d64b1a6 Fix a warning from pod2man.
svn path=/trunk/; revision=31911
2010-02-18 01:36:30 +00:00
Guy Harris
c5651b3ccc Fix/update some comments.
Save the setting of GLIB_LIBS before testing for GLib 2.14-or-later, and
restore it afterwards, in case the test fails; that might fix the
Solaris build fails we're having (the Solaris buildbot has an older
version of GLib).

svn path=/trunk/; revision=31910
2010-02-18 01:27:19 +00:00
Gerald Combs
d122243892 Another Laura bug: Don't reset the file load time in the status bar when
we apply a display filter. Display the load time as "Load time:
M:SS.SSS" instead of "Time: HH:MM:SS.SSS".

svn path=/trunk/; revision=31909
2010-02-17 23:03:41 +00:00
Bill Meier
3e85c03c9d gtk_option_menu() --> gtk_combo_box();
(Commit based upon discussion with and input from Jaap Keuter).
(On Windows replacing the deprecated gtk_option_menu() 
with gtk_combo_box() has the effect of addressing a dropdown widget behavior
change seen when going from Windows Gtk 2.16 to Gtk 2.18).
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4487). 

svn path=/trunk/; revision=31908
2010-02-17 22:26:30 +00:00