ad6640344f
From Jose Pedro Oliveira: Fix typos
...
svn path=/trunk/; revision=41330
2012-03-03 16:17:20 +00:00
104bab54f1
Use 'wireshark' icon from theme
...
This makes Wireshark able to use SVG icon when it is installed
svn path=/trunk/; revision=41329
2012-03-03 15:40:38 +00:00
25ae6ac329
Use wtap_dump_open_ng(), so we preserve all the interfaces in pcap-NG
...
files.
svn path=/trunk/; revision=41328
2012-03-03 00:14:16 +00:00
b18a5f9805
Don't look at the interface_id field of the packet header if
...
WTAP_HAS_INTERFACE_ID isn't set in the presence flags.
svn path=/trunk/; revision=41327
2012-03-03 00:13:25 +00:00
9d1c2ec81d
Make SVG images useable as icons
...
svn path=/trunk/; revision=41326
2012-03-02 23:31:48 +00:00
4289f6d7be
Don't add an FT_BYTES with proto_tree_add_uint().
...
svn path=/trunk/; revision=41325
2012-03-02 22:24:12 +00:00
9bd0312661
Fix a few bugs found by Clang analysis:
...
packet-ieee17221.c:3123:10: warning: Value stored to 'mr_offset' is never read
- Put the offset increment inside the loop
packet-ieee17221.c:2888:10: warning: Value stored to 'mr_subtree' is never read
- Use the newly-created subtree (instead of the parent tree)
packet-ieee17221.c:2692:13: warning: Value stored to 'next_tvb' is never read
- Use next_tvb (instead of the main tvb which doesn't start at the
correct offset)
svn path=/trunk/; revision=41324
2012-03-02 20:17:36 +00:00
464ec2dcb1
Typo
...
svn path=/trunk/; revision=41323
2012-03-02 13:53:30 +00:00
ff47bdf96c
Use the expert system to show packet comments.
...
The packet comment widget should be replaced by a ListView with two columns, packet no and Comment.
svn path=/trunk/; revision=41322
2012-03-02 13:31:16 +00:00
15a88e695f
Update comment - now that we support adding comments to files, a capture
...
that we've saved to a particular path, or that we've read in, could
still be unsaved if we add comments to it.
svn path=/trunk/; revision=41321
2012-03-02 11:41:50 +00:00
b77a0b3827
Fix indentation.
...
svn path=/trunk/; revision=41320
2012-03-02 11:36:44 +00:00
6b3c0cd4f8
Remove now unused variables.
...
svn path=/trunk/; revision=41319
2012-03-02 11:25:17 +00:00
a270eef82c
Fix typo and add Modelines information
...
svn path=/trunk/; revision=41318
2012-03-02 11:11:59 +00:00
cc7151b1b9
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41317
2012-03-02 11:10:08 +00:00
f1723b8c1d
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41316
2012-03-02 11:09:47 +00:00
aa4a11af37
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41315
2012-03-02 11:09:34 +00:00
8179474093
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41314
2012-03-02 11:09:15 +00:00
ba4c8fdbc3
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41313
2012-03-02 11:08:49 +00:00
92896f46b8
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41312
2012-03-02 11:07:50 +00:00
168c540f65
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41311
2012-03-02 11:07:36 +00:00
c6fc195c47
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41310
2012-03-02 11:06:52 +00:00
2e79d142c7
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41309
2012-03-02 11:06:37 +00:00
056fa6a57a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41308
2012-03-02 11:06:17 +00:00
af2910972a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41307
2012-03-02 11:05:50 +00:00
eebaffcc5c
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41306
2012-03-02 11:05:23 +00:00
77afe2d93d
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41305
2012-03-02 11:05:08 +00:00
49d2d91818
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41304
2012-03-02 11:04:51 +00:00
08006ac943
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41303
2012-03-02 11:04:31 +00:00
3063f260ce
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41302
2012-03-02 11:04:09 +00:00
65edc0dc95
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41301
2012-03-02 11:03:46 +00:00
62de88285d
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41300
2012-03-02 11:02:46 +00:00
7857dc50fb
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41299
2012-03-02 11:02:02 +00:00
8e968adb2c
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41298
2012-03-02 11:00:24 +00:00
8cc44ff4f0
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41297
2012-03-02 10:58:29 +00:00
c1ff84a632
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41296
2012-03-02 10:57:48 +00:00
a66252358c
From Francesco Fondelli
...
Fix indent (use 80 columns) in MPLS PM dissector
svn path=/trunk/; revision=41295
2012-03-02 10:56:31 +00:00
57839d9e4a
Flag mp2t file as really having only relative time stamps. Put the
...
comment on its own line in mpeg.c as well.
svn path=/trunk/; revision=41294
2012-03-02 10:17:36 +00:00
0475f29216
The additional_file_extensions member of struct file_type_info need not
...
and should not contain the extension in the default_file_extension
member - that's why the name starts with "additional".
svn path=/trunk/; revision=41293
2012-03-02 10:09:23 +00:00
17dff5f3c4
Get rid of no-longer-needed argument to pcapng_write_section_header_block().
...
svn path=/trunk/; revision=41292
2012-03-02 09:38:43 +00:00
10337e0ca4
Skip an intermediating wtapng_block_t in the code path to write
...
Interface Description Blocks.
Fix a typo (if_fcslen was meant rather than opt_comment when writing the
FCS length).
svn path=/trunk/; revision=41291
2012-03-02 09:30:10 +00:00
bfcf193d2f
Increase the size of the preallocated area for hf fields.
...
svn path=/trunk/; revision=41290
2012-03-02 09:28:30 +00:00
334a807e14
Simplify the code path for writing pcap-NG packets, and remove some
...
no-longer-needed elements from the wtapng_packet_t structure.
svn path=/trunk/; revision=41289
2012-03-02 09:03:26 +00:00
e82ad19e58
From Weston Schmidt: Add mpeg-ts capture file format support. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6894
...
svn path=/trunk/; revision=41286
2012-03-02 06:02:28 +00:00
c58bbe0ad7
Fix proto_tree_add_item() 'encoding' args.
...
svn path=/trunk/; revision=41285
2012-03-02 05:10:02 +00:00
44528a6437
Fill in the wtap_pkthdr fields in pcap_read_packet_block() and
...
pcap_read_simple_packet_block(), not in pcap_read() - the way the fields
are filled in differs between simple and non-simple packet blocks.
Clean up white space.
svn path=/trunk/; revision=41284
2012-03-02 05:03:06 +00:00
bb9b8880af
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6893 :
...
The attached patches fix the following issues:
1. CIP-Motion shouldn't be a heuristic dissector. CIP-Motion packets are
determined by specific fields in a CIP ForwardOpen. I ran into situations
where CIP-Motion's "vague" heuristics incorrectly dissected packets meant for
CIP-Safety. Of course this requires the ForwardOpen to be in the trace, but it
is the most deterministic way to have CIP-Motion packets.
2. Minor bugfix to the CIP-Safety dissector. A couple of fields were
"missing", causing errant malformed packets.
svn path=/trunk/; revision=41283
2012-03-02 03:39:16 +00:00
1ff7c5d916
From Tom Bottom and Chris Pane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887 :
...
A new dissector for IEEE 1722.1.
From me: some code cleanup, including:
- Get rid of some unnecessary local variable initializations.
- Put all of 1722.1 under one subtree.
- Just put if(tree)s in the top-level function rather than scattered throughout.
- Remove a couple "set but not used" warnings (a couple are #if'd out).
- Don't use deprecated functions.
svn path=/trunk/; revision=41282
2012-03-02 03:30:30 +00:00
f2c1c108f5
AFAIKT there's no reason to #include <wsutil/crc32.c>; Include crc32.h like everyone else...
...
Also: Do some whitespace and indentation cleanup.
svn path=/trunk/; revision=41281
2012-03-02 00:31:30 +00:00
a146f5a2e2
(After a couple of years of warning about this), assert out if someone tries
...
to register an hf with an empty-string abbreviation.
svn path=/trunk/; revision=41280
2012-03-01 22:00:33 +00:00
7e85674577
Various Changes:
...
- Use proper 'encoding' arg (iso TRUE/FALSE) for proto_tree_add_item();
- Use correct value for tvb_new_subset() 'reported_length' arg;
- For proto_tree_add_protocol_format(): Use a length no greater than
that actually available in the tvb. This allows dissection to attempt to
proceed even if the length as obtained from the packet is too large.
- Remove 'set not not used' variable;
- Do minor reformatting and whitespace changes.
svn path=/trunk/; revision=41279
2012-03-01 21:04:04 +00:00
Anders Broman