Jakub Zawadzki
6dc698ca27
Dissector for YAMI protocol.
...
svn path=/trunk/; revision=43110
2012-06-05 14:17:50 +00:00
Anders Broman
28098ed4ab
From Roland Knall:
...
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335
svn path=/trunk/; revision=43109
2012-06-05 13:12:28 +00:00
Anders Broman
aa4e655696
Set SVN properties.
...
svn path=/trunk/; revision=43108
2012-06-05 11:19:33 +00:00
Anders Broman
189ea54f0b
from Alex Lindberg:
...
Update to packet-h248.c and associated h248 dissecorts.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332
svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Anders Broman
5bd0c263f2
From Andrew Kampjes:
...
SDH support for wireshark.
- Added GPL license.
- Removed not needed includes.
- Skipped th .h file as it wasn't used.
svn path=/trunk/; revision=43106
2012-06-05 10:42:38 +00:00
Anders Broman
1d27ce5d99
From Adam Langley: Add support for decrypting ECDHE-RSA-RC4-SHA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7331
...
svn path=/trunk/; revision=43100
2012-06-05 05:27:06 +00:00
Anders Broman
75319f09a9
From Adam Langley: Add support for CLIENT_RANDOM lines in SSL keylog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7330
...
svn path=/trunk/; revision=43099
2012-06-05 05:22:41 +00:00
Anders Broman
cec562ddd2
From Alex Lindberg: Add preference to packet-ber.c to toggle BER warning on leading zero bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7328
...
svn path=/trunk/; revision=43098
2012-06-05 05:16:06 +00:00
Anders Broman
6c85e092cf
From Adam Langley: Clean up code for handling keylog files. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7329
...
svn path=/trunk/; revision=43097
2012-06-05 05:10:18 +00:00
Gerald Combs
7186d034f0
Fix compilation.
...
svn path=/trunk/; revision=43094
2012-06-04 23:47:11 +00:00
Alexis La Goutte
167b8c6cba
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
With the dissector....
svn path=/trunk/; revision=43092
2012-06-04 22:34:27 +00:00
Alexis La Goutte
42451447b1
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43091
2012-06-04 22:26:40 +00:00
Alexis La Goutte
e2cec4bb63
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
(Manual Fix, not found how to fix the generator...)
svn path=/trunk/; revision=43090
2012-06-04 22:26:18 +00:00
Alexis La Goutte
c7e8a39966
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43089
2012-06-04 22:25:27 +00:00
Alexis La Goutte
cb2000b9f3
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43087
2012-06-04 22:24:46 +00:00
Alexis La Goutte
7ec2d11b9b
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
svn path=/trunk/; revision=43086
2012-06-04 22:22:32 +00:00
Jakub Zawadzki
11e584f4cf
packet-gadu-gadu: set COL_INFO in undissected/unknown packet types.
...
svn path=/trunk/; revision=43068
2012-06-04 14:37:24 +00:00
Anders Broman
a90e1a353a
Try to make the buildbot happy.
...
svn path=/trunk/; revision=43067
2012-06-04 14:31:53 +00:00
Anders Broman
b69547925f
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
Anders Broman
2a30b1eff9
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43065
2012-06-04 13:21:44 +00:00
Anders Broman
a0910557c7
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43064
2012-06-04 12:20:37 +00:00
Anders Broman
131334481d
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43063
2012-06-04 11:44:52 +00:00
Anders Broman
81a7df91dd
Revert previous change as it did not compile.
...
svn path=/trunk/; revision=43062
2012-06-04 11:18:17 +00:00
Anders Broman
920ad0bcee
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43061
2012-06-04 10:36:43 +00:00
Pascal Quantin
f275aeadd9
Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2
...
svn path=/trunk/; revision=43059
2012-06-04 10:02:08 +00:00
Anders Broman
85972d91c7
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43058
2012-06-04 09:04:36 +00:00
Anders Broman
10fe76d8a0
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43057
2012-06-04 08:56:48 +00:00
Pascal Quantin
ebbaf7f820
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7325 :
...
Add support for the Gluster CLI RPC-protocol
svn path=/trunk/; revision=43055
2012-06-04 08:42:12 +00:00
Chris Maynard
4902b4d857
Remove a few of "if (tree)" checks surrounding expert_add_info_format().
...
svn path=/trunk/; revision=43054
2012-06-04 06:22:50 +00:00
Pascal Quantin
6a4606b1f1
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7324 :
...
Add support for the Gluster Handshake and Callback RPC-protocols
svn path=/trunk/; revision=43035
2012-06-03 17:15:21 +00:00
Pascal Quantin
3201d56f05
Convert space to tab
...
svn path=/trunk/; revision=43033
2012-06-03 16:49:58 +00:00
Alexis La Goutte
6c8174a1a8
Make checkhf tools Happy, Remove hf_ieee80211_chan*
...
svn path=/trunk/; revision=43032
2012-06-03 16:49:01 +00:00
Alexis La Goutte
44d7c7fb73
Add 802.11 AP Channel Report IE (51)
...
svn path=/trunk/; revision=43031
2012-06-03 16:47:15 +00:00
Alexis La Goutte
588fd3e761
Enhance 802.11 Secondary Channel Offset (62)
...
svn path=/trunk/; revision=43030
2012-06-03 16:45:30 +00:00
Alexis La Goutte
9a7409589a
Enhance 802.11 HT Info 1.1 (60)
...
svn path=/trunk/; revision=43029
2012-06-03 16:43:19 +00:00
Alexis La Goutte
7852f04531
Cleanup Header (Remove e-mail of original author to report bugs...)
...
svn path=/trunk/; revision=43028
2012-06-03 16:41:11 +00:00
Alexis La Goutte
8f94d6a813
Enhance 802.11 (Vendor Specific) HT Capability (45)
...
And fix last Dead Store warning found by Clang
svn path=/trunk/; revision=43027
2012-06-03 16:39:55 +00:00
Alexis La Goutte
3899295893
Enhance 802.11 (vendor specifiq) HT Info 1.0 (Draft)
...
svn path=/trunk/; revision=43025
2012-06-03 16:37:56 +00:00
Pascal Quantin
8edc336db6
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7323 :
...
Add support for the Gluster Portmapper and DUMP RPC-protocols
svn path=/trunk/; revision=43024
2012-06-03 16:17:38 +00:00
Pascal Quantin
b3f2c794e2
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7315 :
...
Initial support for the GlusterD RPC-protocol
svn path=/trunk/; revision=43023
2012-06-03 15:52:15 +00:00
Pascal Quantin
aa95f6b73d
Revert files committed by error in revision 43007
...
svn path=/trunk/; revision=43008
2012-06-02 19:20:04 +00:00
Pascal Quantin
797b83c838
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7322 :
...
Add a missing break in packet-bpkmattr.c (CID 280484)
svn path=/trunk/; revision=43007
2012-06-02 19:15:07 +00:00
Anders Broman
96beb44145
From Evan Huus Useless null check in packet-ssh.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7319
...
svn path=/trunk/; revision=42996
2012-06-02 13:25:02 +00:00
Balint Reczey
7ef7aae265
Fix header file includes to allow make dumpabi run without errors
...
svn path=/trunk/; revision=42994
2012-06-02 12:57:26 +00:00
Anders Broman
d4e17555ad
Put more mesage names in info col
...
svn path=/trunk/; revision=42993
2012-06-02 10:11:46 +00:00
Jeff Morriss
d4fdd6ad52
Only propose decoding PPID 0 if that PPID is in the currently-selected frame.
...
(I used PPID 0xffffffff as an end-of-list marker so that PPID can no longer
be used in this dialog; if someone starts using that PPID then we'll have
to put a count of PPIDs in pinfo.)
svn path=/trunk/; revision=42991
2012-06-01 21:18:59 +00:00
Gerald Combs
c408151a80
Try to be a bit more clear that "lost" is from Wireshark's perspective,
...
not necessarily one of the TCP endpoints.
svn path=/trunk/; revision=42990
2012-06-01 20:54:04 +00:00
Pascal Quantin
2256e71cc5
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7316 :
...
Use correct field type for OUI
svn path=/trunk/; revision=42989
2012-06-01 20:32:15 +00:00
Jeff Morriss
e83180023e
Clean up some indentation (get rid of 4-space tabs) and white space.
...
svn path=/trunk/; revision=42988
2012-06-01 19:46:53 +00:00
Jeff Morriss
a2fe7eabbb
Remember the 'lower' UDP port information even if we got the UDP packet
...
non-heuristically. This prevents us from trying to decode the user's UDP
payload as FP.
(This is a followup/revision to r31113/bug 4218.)
svn path=/trunk/; revision=42987
2012-06-01 19:22:01 +00:00
Jeff Morriss
9e3b598e30
Some code/white space cleanup.
...
svn path=/trunk/; revision=42985
2012-06-01 18:35:20 +00:00
Guy Harris
6a43200ee9
Squelch warning about uninitialized variable (the dataflow analysis
...
isn't sophisticated enough to know that can't happen).
svn path=/trunk/; revision=42983
2012-06-01 18:01:42 +00:00
Pascal Quantin
b9917a1248
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310 :
...
Initial support for the GlusterFS RPC-protocol
svn path=/trunk/; revision=42979
2012-06-01 17:10:03 +00:00
Anders Broman
a8e8234831
Make packet-coseventcomm.c a bultin dissector
...
svn path=/trunk/; revision=42974
2012-06-01 15:57:05 +00:00
Anders Broman
6e3d56f039
For RLC re-assembly to work we need to fake urnti.
...
svn path=/trunk/; revision=42970
2012-06-01 13:01:32 +00:00
Anders Broman
a2f13cad70
Don't call subdissectors if the CRCI bit is set.
...
svn path=/trunk/; revision=42969
2012-06-01 12:28:05 +00:00
Anders Broman
c8625796f1
Make the cosnaming dissector a builtin dissector.
...
svn path=/trunk/; revision=42968
2012-06-01 12:27:04 +00:00
Anders Broman
b42bbc2cd6
Make the tango dissector a builtin dissector.
...
svn path=/trunk/; revision=42967
2012-06-01 10:31:34 +00:00
Anders Broman
5ef6c6d08a
Make the parlay dissector a buil tin dissector.
...
svn path=/trunk/; revision=42964
2012-06-01 08:48:31 +00:00
Anders Broman
728584510b
Fix a couple of warnings
...
svn path=/trunk/; revision=42957
2012-06-01 05:55:20 +00:00
Anders Broman
6a505b4cce
Fix a couple of warnings
...
svn path=/trunk/; revision=42956
2012-06-01 05:36:52 +00:00
Gerald Combs
5690373d48
g_snprintf → ep_strbuf. I can't find an ERF file with a virtual
...
container but the conversion seemed be straightforward enough.
svn path=/trunk/; revision=42951
2012-05-31 21:30:40 +00:00
Pascal Quantin
b83080f5b6
From Erwin Rol via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7311 :
...
Fix a cut and paste error in packet-dmx.c
svn path=/trunk/; revision=42949
2012-05-31 20:40:07 +00:00
Gerald Combs
ae6e4d6dd3
Fix a possible zero division found by scan-build. While we're at it replace
...
occurrences of g_snprintf+strlen with ep_strbuf.
svn path=/trunk/; revision=42948
2012-05-31 20:24:04 +00:00
Anders Broman
b9e5955f46
Set dir if we don't have it.
...
svn path=/trunk/; revision=42945
2012-05-31 13:23:42 +00:00
Pascal Quantin
08c7db0421
Display hf_smb_server_guid, hf_smb_volume_guid and hf_smb_dfs_referral_server_guid as FT_GUID
...
svn path=/trunk/; revision=42944
2012-05-31 13:22:52 +00:00
Pascal Quantin
4d1abc7bbb
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7306 :
...
RPC: show the AUTH_GLUSTERFS/lk_owner as hex
svn path=/trunk/; revision=42940
2012-05-31 08:56:19 +00:00
Pascal Quantin
48fee70339
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7307
...
svn path=/trunk/; revision=42939
2012-05-31 08:25:00 +00:00
Anders Broman
867de6145e
From Sheetal Kshirsagar and Andrew Williams:
...
Updating the RPL SRH dissector and implementing RPL Options header dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986
svn path=/trunk/; revision=42937
2012-05-31 07:25:11 +00:00
Anders Broman
fc19f32931
Try to squelch a couple of warnings
...
svn path=/trunk/; revision=42936
2012-05-31 05:42:02 +00:00
Jakub Zawadzki
14bfedccd9
Revert r42853, cleanup packet-jxta which might really fix CID 280210
...
References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00226.html
svn path=/trunk/; revision=42932
2012-05-30 22:39:56 +00:00
Jeff Morriss
6341191d72
From Richard Sharpe on -dev:
...
Attached is a patch that fixes (I think) the handling of extended
responses on NTCreate&X requests.
svn path=/trunk/; revision=42923
2012-05-30 18:29:37 +00:00
Pascal Quantin
59b621e67b
Prefix TransportFormatSet_type_enum values with NBAP_ to avoid a clash with 'PCH' in <WinNT.h>
...
svn path=/trunk/; revision=42922
2012-05-30 18:27:40 +00:00
Chris Maynard
b35b911748
Mark pinfo as unused. Change args to proto_tree_add_text().
...
svn path=/trunk/; revision=42921
2012-05-30 17:26:00 +00:00
Chris Maynard
39d4fbeb52
PPP CCP improvements. And yay, checkAPIs no longer complains about the number of useless add_text()'s since the ratio is finally below 50%. This ratio should continue to drop as more and more fields become filterable.
...
svn path=/trunk/; revision=42920
2012-05-30 17:02:44 +00:00
Anders Broman
79e91685b7
Stab at DCH 31 dissection.
...
svn path=/trunk/; revision=42915
2012-05-30 14:04:45 +00:00
Anders Broman
a307c8318d
Dissect non segmented MiB and SiB:s
...
svn path=/trunk/; revision=42914
2012-05-30 11:48:05 +00:00
Pascal Quantin
d9b845534d
Use ett variable for proto_item_add_subtree function call
...
svn path=/trunk/; revision=42913
2012-05-30 08:49:56 +00:00
Jakub Zawadzki
4c3735771a
Fix bug #5077 in IPv6.
...
svn path=/trunk/; revision=42909
2012-05-30 05:39:39 +00:00
Jakub Zawadzki
a2dac52152
Cleanup geoip support in ipv6.
...
svn path=/trunk/; revision=42908
2012-05-30 05:33:37 +00:00
Pascal Quantin
86dd3248f6
Avoid using C99 '%hh' length modifier
...
svn path=/trunk/; revision=42904
2012-05-29 21:51:52 +00:00
Pascal Quantin
3f07cc05bc
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7301 :
...
Dissector for DVB Application Information Table (AIT)
svn path=/trunk/; revision=42903
2012-05-29 21:36:39 +00:00
Pascal Quantin
0e557f4421
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7302 :
...
Small updates to ISO 7816 dissector
svn path=/trunk/; revision=42902
2012-05-29 21:09:46 +00:00
Pascal Quantin
8b72c6506e
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7303
...
Remove unnecessary null checks before calling proto_item_set_len() in DVB-CI dissector
svn path=/trunk/; revision=42901
2012-05-29 20:28:41 +00:00
Jakub Zawadzki
dfa5a78130
Fix bug #7304 , stupid mistake.
...
svn path=/trunk/; revision=42900
2012-05-29 20:27:22 +00:00
Jakub Zawadzki
e5be60bc81
Fix bug #5735
...
dissect_attribute_value_pairs() should be also called with NULL tree.
Broken from r29964.
svn path=/trunk/; revision=42899
2012-05-29 20:01:25 +00:00
Anders Broman
2a7bef2cb0
Handle E-DCH
...
svn path=/trunk/; revision=42898
2012-05-29 14:34:34 +00:00
Ronnie Sahlberg
5f04a8404b
SCSI SBC: Add dissection of GET_LBA_STATUS command
...
svn path=/trunk/; revision=42897
2012-05-29 11:25:38 +00:00
Anders Broman
8d6b6f58d6
From Deepti Ragha:
...
Additions to the ARP dissector as per the IANA specifications for ARP
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7216
svn path=/trunk/; revision=42895
2012-05-29 08:00:35 +00:00
Anders Broman
7aa5527274
From Aditya Ambadkar and Diana Chris:
...
Enhancement to LDP dissector to support changes proposed in RFC6391 - flow aware transport of PW over an MPLS PSN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7046
svn path=/trunk/; revision=42894
2012-05-29 07:45:40 +00:00
Anders Broman
859f794544
From Evan Huus:
...
Fix to
BACapp item length causes Buildbot crash output: randpkt-2011-04-13-1899.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5825
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7296
svn path=/trunk/; revision=42893
2012-05-29 07:31:38 +00:00
Guy Harris
1020c20d9e
From Erwin Rol: fix a copy-and-paste leftover.
...
svn path=/trunk/; revision=42890
2012-05-29 00:05:39 +00:00
Pascal Quantin
a891f54067
Keep backward compatibility with UDP framing format for UMTS RLC dissector
...
Fix a few typo errors while we are at it
svn path=/trunk/; revision=42889
2012-05-28 20:34:27 +00:00
Anders Broman
091138dafe
Use C/T as rbid
...
svn path=/trunk/; revision=42888
2012-05-28 20:11:59 +00:00
Anders Broman
1c9920ada6
Use ett instead of hf variable
...
svn path=/trunk/; revision=42887
2012-05-28 20:09:00 +00:00
Anders Broman
b74438e41d
Set but not used variable
...
svn path=/trunk/; revision=42885
2012-05-28 17:55:47 +00:00
Anders Broman
4312a9dd61
Remove C++ style comments initilize some variables.
...
svn path=/trunk/; revision=42884
2012-05-28 16:00:20 +00:00
Jakub Zawadzki
5020a3f170
While iterating over string characters don't use strlen(), but check for NUL.
...
svn path=/trunk/; revision=42883
2012-05-28 15:59:00 +00:00
Anders Broman
bb08a70594
Set SVN properties.
...
svn path=/trunk/; revision=42882
2012-05-28 15:30:09 +00:00
Anders Broman
136ad63adf
Set SVN properties.
...
svn path=/trunk/; revision=42881
2012-05-28 15:29:36 +00:00
Anders Broman
14eb5154ac
From Erwin Rol:
...
Artnet, RDM and DMX dissector updates
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7286
svn path=/trunk/; revision=42880
2012-05-28 15:24:54 +00:00
Anders Broman
55261641d9
Extend the switch statement.
...
svn path=/trunk/; revision=42879
2012-05-28 15:09:33 +00:00
Anders Broman
d52a12c60e
Move defenition of rlc_mode.
...
svn path=/trunk/; revision=42878
2012-05-28 14:50:54 +00:00
Anders Broman
2a412f000b
Try to pacify the Ubuntu buildbot.
...
svn path=/trunk/; revision=42877
2012-05-28 13:53:33 +00:00
Anders Broman
d8ddd39c3d
Enhance CHANNEL_HSDSCH dissection.
...
svn path=/trunk/; revision=42876
2012-05-28 13:38:40 +00:00
Ronnie Sahlberg
4baba1c684
Sometimes you might have plaintext LDAP for a SASL LDAP connection if the handshake never occured.
...
Observed with exchange in some configurations.
From Matthieu Patou <mat@matws.net>
svn path=/trunk/; revision=42875
2012-05-28 09:40:54 +00:00
Gerald Combs
3e24d3bbce
Add a null check to fix Coverity CID 280210. It doesn't look like we'd
...
run into this in the wild.
svn path=/trunk/; revision=42853
2012-05-25 18:25:31 +00:00
Chris Maynard
cd7c8f671b
Fix Coverity CID 700177 Unused pointer value.
...
svn path=/trunk/; revision=42849
2012-05-25 02:51:23 +00:00
Chris Maynard
22415dc211
The rest of the fix for Coverity CID's 280507 and 280508. (There were multiple occurrences grouped into the 2 CID's, but I hadn't noticed them all.)
...
svn path=/trunk/; revision=42848
2012-05-25 02:43:39 +00:00
Chris Maynard
c0b55e486a
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280507 and 280508.
...
svn path=/trunk/; revision=42847
2012-05-25 02:18:49 +00:00
Chris Maynard
814682d0d8
Fix Coverity CID 701035: Dereference after null check of hfinfo.
...
svn path=/trunk/; revision=42843
2012-05-25 01:14:29 +00:00
Chris Maynard
3445d93bf2
Fix Coverity CID 700201: Dereference after null check, by ensuring "decoder" is not NULL before passing it to ssl_decrypt_record().
...
svn path=/trunk/; revision=42842
2012-05-25 00:54:49 +00:00
Chris Maynard
8fd9342f7d
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID 281367.
...
svn path=/trunk/; revision=42840
2012-05-25 00:29:46 +00:00
Chris Maynard
0c49176411
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280233-280235.
...
svn path=/trunk/; revision=42839
2012-05-24 23:35:23 +00:00
Chris Maynard
b7e5cce721
Update asn1-generated dissector.
...
svn path=/trunk/; revision=42838
2012-05-24 23:31:38 +00:00
Chris Maynard
06606bb68f
tvb_reported_length_remaining() can return a negative number. In dissect_gadu_gadu_userlist80_compressed(), bail out if it does. Fixes Coverity CID 703085. In dissect_gadu_gadu_stringz_cp1250(), be sure to compare against its return value as being only positve rather than non-zero. Also, fixed a couple of typos.
...
svn path=/trunk/; revision=42837
2012-05-24 23:14:30 +00:00
Jakub Zawadzki
c09a95a0e3
Fix bug #7283
...
When Engine ID is 128 we should only break when we know the enterprise id.
svn path=/trunk/; revision=42825
2012-05-24 12:26:34 +00:00
Anders Broman
d40cb34ba9
From Martin Kaiser:
...
RVALS() needs BASE_RANGE_STRING
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7282
svn path=/trunk/; revision=42823
2012-05-24 09:17:11 +00:00
Anders Broman
a51cd8a036
From Mayuresh Raut.
...
Addition of DDMAP TLV and Downstream FEC stack change sub-TLV to DDMAP [RFC 6424]
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7006
svn path=/trunk/; revision=42819
2012-05-24 06:55:18 +00:00
Pascal Quantin
25e70c04d7
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7275 :
...
iso7816: dissect ATR (answer to reset)
svn path=/trunk/; revision=42814
2012-05-23 20:51:38 +00:00
Jakub Zawadzki
401dba8987
Fix bug #7277
...
Check tvb length before fetching data.
svn path=/trunk/; revision=42812
2012-05-23 12:20:15 +00:00
Anders Broman
551dcff815
Dissect MAC and RLC for CHANNEL_FACH_FDD
...
svn path=/trunk/; revision=42811
2012-05-23 10:47:52 +00:00
Anders Broman
0832853fa8
From Robert Bullen:
...
The Wireshark and tshark TCP conversations stats tables aggregate reused connections into a single line item
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7248
svn path=/trunk/; revision=42806
2012-05-23 06:36:47 +00:00
Anders Broman
a6deef666c
Fix a typo
...
svn path=/trunk/; revision=42805
2012-05-23 06:26:46 +00:00
Anders Broman
ab58c26ff3
From Jim Wright:
...
Enhance the DTN dissector so that it understands ECOS blocks (Extended Class of Service)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7242
svn path=/trunk/; revision=42804
2012-05-23 06:25:00 +00:00
Bill Meier
8f5f906146
All:
...
- whitespace cleanup;
- Remove redundant code;
packet-ymsg.c:
- Check if bytes available before doing tvb fetch for heuristic check;
- Required tcp pdu "fixed part length" is 10 (not 8);
- Use val_to_str_const() as appropriate;
- Remove some unneeded initializations.
svn path=/trunk/; revision=42802
2012-05-23 03:26:35 +00:00
Bill Meier
e72c6574ef
From Evan Huus: "Fix Potential padding issues in Yahoo dissectors"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7276
svn path=/trunk/; revision=42801
2012-05-23 03:22:51 +00:00
Chris Maynard
509917229b
Fix Coverity CID 703086: Dereference after null check in decode_tcp_ports().
...
svn path=/trunk/; revision=42798
2012-05-23 00:56:15 +00:00
Jeff Morriss
a59aa64da4
Fix: packet-gsm_a_gm.c:3965:6: error: comparison is always true due to limited range of data type [-Werror=type-limits]
...
svn path=/trunk/; revision=42797
2012-05-22 23:59:41 +00:00
Guy Harris
dba158c167
Suppress a (legitimate) compiler warning for now, and leave a comment
...
indicating that we should do *something* about nanoseconds values >= 1
billion.
svn path=/trunk/; revision=42796
2012-05-22 23:57:54 +00:00
Jakub Zawadzki
261fb63ec4
nflog dissector:
...
- dissect NFULA_TIMESTAMP as 16B time.
- fix byte_order_types (selecting BE selected little endian)
svn path=/trunk/; revision=42793
2012-05-22 22:34:57 +00:00
Anders Broman
4e7d87caa2
Fix PCH dissection
...
svn path=/trunk/; revision=42791
2012-05-22 21:12:59 +00:00
pascal
9746c22630
Dissect Operator Specific Use container in Protocol Configuration Options IE
...
Put protocol and container ID in a subtree
svn path=/trunk/; revision=42790
2012-05-22 20:34:20 +00:00
Anders Broman
e460267b82
Set paging indication and start fixing TFI list.
...
svn path=/trunk/; revision=42783
2012-05-22 15:39:12 +00:00
Jeff Morriss
913455d3b3
Get rid of non-ASCII chars. Remove a few trailing commas.
...
svn path=/trunk/; revision=42782
2012-05-22 14:00:19 +00:00
Anders Broman
ec5ec34f1f
Collect and use E-DCH data.
...
svn path=/trunk/; revision=42779
2012-05-22 11:53:12 +00:00
Ronnie Sahlberg
2a2dc8c5f3
TCP: Some protocols running ontop of TCP needs the PDUs to be delivered in order. for example decryption of DCERPCoverHTTP.
...
For such protocols, hte state gets out of sync of for example the same PDU is invoked twice in a row, which sometimes can happen if there is tcp retransmission and we see the same PDU twice. First for hte original segment and a second time for the tcp retransmission.
These protocols might lack an easy way to detect that a PDU is seen twice or out of order.
To handle this a little better, offer a TCP option that defaults to being disabled but when enabled skips invoking any subdissector for retransmitted or out of order packets.
(For some virtualization environments it sometimes becomes VERY common to see false tcp retransmissions due to segments being captured twice making this even worse)
We dont want this option to default to ON because for most cases we do want the current behaviour where the subdissector is called twice, or more, for any PDU that is retrasnmitted on the TPC layer.
For example, assume a SMB response packet is retransmitted on the TCP level.
This may result in a capture file that looks like
1 -> SMB request
2 <- SMB response to 1
... 1 second ...
3 <- SMB response to 1 TCP retransmission
For this case we definitely want packet 3 to be passed to the SMB layer so that
the request/respons ematching will detect that the response time for this transaction was > 1.0 second
We want smb.time to indicate the delta betwenn packets 1 and 3
as well as the SMB Service Response Time to indicate that this command took very long.
svn path=/trunk/; revision=42774
2012-05-22 07:51:12 +00:00
Ronnie Sahlberg
b3bfefd03c
packet-smb2: dissect the channel sequence in the SMB 2.2 header
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42772
2012-05-22 05:56:39 +00:00
Ronnie Sahlberg
ba54127556
SMB: Add dissection of TRANS2_REQUEST_TRANSPORT_ENCRYPTION messages
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42771
2012-05-22 05:55:05 +00:00
Ronnie Sahlberg
50b992d139
SMB: Dissect TRANS2_SET_FS_INFORMATION infolevel
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42770
2012-05-22 05:53:28 +00:00
Ronnie Sahlberg
920b760f15
SMB: Call dissect_nt_quota() via a new dissect_sfsi_request/response()
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42769
2012-05-22 05:51:16 +00:00
Ronnie Sahlberg
4ded3c7fe0
SMB2: Add dissection of the encrypted SMB2 headers
...
From Matthieu Patou <mat@matws.net>
svn path=/trunk/; revision=42768
2012-05-22 05:48:55 +00:00
Ronnie Sahlberg
cf0a6d0b96
SMB2: Add support for the "encrypted" flag for shares
...
From Michael Adam <obnox@samba.org>
svn path=/trunk/; revision=42767
2012-05-22 05:46:47 +00:00
Ronnie Sahlberg
0882a858c4
SMB2: Fix, the flag is called PERSISTENT_HANDLES, not LARGE_MTU
...
From Michael Adam <obnox@samba.org>
svn path=/trunk/; revision=42766
2012-05-22 05:45:30 +00:00
Ronnie Sahlberg
b5b00d5654
SMB2: Add support for SMB2_GLOBAL_CAP_ENCRYPTION flag
...
From Michael Adam <obnox@samba.org>
svn path=/trunk/; revision=42765
2012-05-22 05:44:07 +00:00
pascal
a65518fe55
Fix indentation
...
svn path=/trunk/; revision=42760
2012-05-21 21:49:11 +00:00
pascal
6a1470ffc9
From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7267 :
...
Add dissector function for SPB link metric sub tlv (type 29)
svn path=/trunk/; revision=42759
2012-05-21 20:51:22 +00:00
pascal
0ba1ab2909
Display Element ID in hexadecimal (like in 3GPP specs)
...
Display EPS bearer ID in decimal
svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
Bill Meier
bc55ee0616
Fix "Function call argument is an uninitialized value" issue found by scan-build.
...
(It seems to me that this issue would rarely, if ever, actually occur).
Also:
- Use val_to_str_const() as appropriate;
- Localize some variables;
- Remove unneeded initializers;
- Do some parenthesizing;
- Use a consistent formatting style;
- Do whitespace cleanup.
svn path=/trunk/; revision=42754
2012-05-21 18:25:29 +00:00
Bill Meier
b2b8fae93c
Init a pointer to prevent a (not actually valid) scan-build "Function call argument is an uninitialized value" msg
...
Also:
- #if 0 out some unused hf[] entries;
- use val_to_str_const() in a few places;
- remove some unneeded initializers;
- do col_set_str()/col_clear() before referencing tvb;
- reformat hf[] entries;
- Fix whitespace (4-space tabs, etc).
svn path=/trunk/; revision=42746
2012-05-21 15:06:24 +00:00
Bill Meier
78f3be74bf
Additional cleanup:
...
- use #if 0/#endif to comment out code(instead of /* ...*/
- remove unused #define
- replace col_clear()/col_add() by col_set()
svn path=/trunk/; revision=42745
2012-05-21 14:25:27 +00:00
Bill Meier
6718bfd047
From Evan Huus: Unused Prefs registration;
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7273
From me: whitespace cleanup;
svn path=/trunk/; revision=42744
2012-05-21 14:02:40 +00:00
Jakub Zawadzki
1d510f0616
Improve Gadu-Gadu dissector (part III)
...
svn path=/trunk/; revision=42742
2012-05-21 13:07:33 +00:00
pascal
d6381b4123
From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7271 :
...
Remove useless null check
svn path=/trunk/; revision=42741
2012-05-21 09:37:58 +00:00
Anders Broman
26d431148c
From David Wei:
...
fix for Higher bitrates than 16 Mbps flag.
svn path=/trunk/; revision=42739
2012-05-21 08:21:26 +00:00
Anders Broman
35dd3b052e
Use new_register_dissector.
...
svn path=/trunk/; revision=42737
2012-05-21 07:34:20 +00:00
Anders Broman
36cd403381
From Michael Mann:
...
Check for enabled XML dissecto.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6625
xmpp decoder crashes when xml is disabled
svn path=/trunk/; revision=42736
2012-05-21 07:28:13 +00:00
Anders Broman
4684cb30f4
From David Wei:
...
New dissector for MBMS synchronisation protocol.
svn path=/trunk/; revision=42735
2012-05-21 07:11:36 +00:00
Bill Meier
7d3f69262d
Whitespace cleanup;
...
svn path=/trunk/; revision=42734
2012-05-21 02:20:53 +00:00
Bill Meier
e3ea682270
General cleanup:
...
- 4-space tabs, trailing whitespace, etc
- use a consistent formatting style
- ...
svn path=/trunk/; revision=42733
2012-05-21 02:13:49 +00:00
Bill Meier
ca4a51873e
Prevent (what seems to me to be) a possible null pointer dereference.
...
svn path=/trunk/; revision=42732
2012-05-21 01:00:12 +00:00
Jörg Mayer
d40cea2e7b
Two cases where gcc has problems to detect that a specific specific
...
variable may not be used uninitialized.
svn path=/trunk/; revision=42731
2012-05-21 00:23:13 +00:00
Bill Meier
0b6c88942b
Fix 'unused parameter' warning.
...
svn path=/trunk/; revision=42730
2012-05-21 00:20:09 +00:00
Anders Broman
c5d3f8c2ba
Set up conversations for more channel types
...
svn path=/trunk/; revision=42729
2012-05-20 21:24:18 +00:00
pascal
254fcdfe19
Upgrade NAS dissector to Release 10 (v10.6.1)
...
svn path=/trunk/; revision=42728
2012-05-20 20:56:42 +00:00
Michael Tüxen
2250389193
Make the compiler happy.
...
svn path=/trunk/; revision=42723
2012-05-20 10:57:12 +00:00
pascal
774748914f
Upgrade NAS EPS dissector to Release 10 (10.6.1)
...
svn path=/trunk/; revision=42722
2012-05-20 09:50:34 +00:00
pascal
acc2a3706b
Fix RVALS() macro usage
...
svn path=/trunk/; revision=42720
2012-05-19 19:05:36 +00:00
pascal
cf0d560849
Use col_append_sep_str instead of col_append_str
...
svn path=/trunk/; revision=42716
2012-05-19 16:06:12 +00:00
Bill Meier
91e5923458
Fix some "warning: Value stored to '...' is never read" clang scan-build warnings.
...
Also; Do some whitespace cleanup in a few cases.
svn path=/trunk/; revision=42715
2012-05-19 14:20:55 +00:00
pascal
7bbbb88068
From Thomas Loockx via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7269 :
...
Add BGP MDT-SAFI dissection (RFC6037)
svn path=/trunk/; revision=42713
2012-05-19 12:32:10 +00:00
pascal
20793cc947
From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7262 :
...
Digest details display issue in SPB Digest subtlv (ISIS hello pdu)
svn path=/trunk/; revision=42712
2012-05-19 10:35:43 +00:00
Jakub Zawadzki
aaa9b34c86
Improve Gadu-Gadu dissector and fix some comments.
...
svn path=/trunk/; revision=42711
2012-05-19 07:57:45 +00:00
Anders Broman
8499bf8b8e
Fix the DCH data collection for conversation setup
...
svn path=/trunk/; revision=42710
2012-05-19 06:20:05 +00:00
Jakub Zawadzki
3bb88a972b
Improve Gadu-Gadu dissector.
...
svn path=/trunk/; revision=42709
2012-05-18 17:43:48 +00:00
Jeff Morriss
5c0dfb9e8e
There's no need to include Custom.common here; it gets pulled in by Makefile.common
...
svn path=/trunk/; revision=42708
2012-05-18 17:19:50 +00:00
Jeff Morriss
af87b31852
Allow custom dissectors in automake too.
...
svn path=/trunk/; revision=42707
2012-05-18 16:20:36 +00:00
pascal
b3dec16072
Tabs -> spaces
...
svn path=/trunk/; revision=42691
2012-05-17 21:24:48 +00:00
pascal
8f789f7ee2
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7255 :
...
dissector for generic ISO 7816 messages (atr and apdus)
svn path=/trunk/; revision=42689
2012-05-17 21:11:22 +00:00
Bill Meier
b315490d01
Fix an "unused variable" warning....
...
svn path=/trunk/; revision=42686
2012-05-17 20:41:46 +00:00
Bill Meier
e332a8de56
Fix the fix ....
...
svn path=/trunk/; revision=42685
2012-05-17 20:36:23 +00:00
Bill Meier
47828c3170
Silence a "may be used uninitialiuzed" warning.....
...
svn path=/trunk/; revision=42684
2012-05-17 20:30:59 +00:00
Bill Meier
bab856a504
General cleanup including as appropriate:
...
- Remove unneeded #include files (string.h, addr_resolv.h);
- Remove unneeded 'if(!initialized){...}' in proto_reg_handoff();
- Reformat hf[] entries;
- Remove unneeded variable initializations;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
(in one case: re-order code slightly to not do col_set_str() & etc until
after initial "frame acceptance testing" by dissector.
svn path=/trunk/; revision=42683
2012-05-17 20:13:22 +00:00
Jakub Zawadzki
b4624651e9
Fix copy&paste: hf variable name in hfi->abbrev
...
svn path=/trunk/; revision=42682
2012-05-17 19:41:19 +00:00
Michael Tüxen
24fa3fb59a
No leading whitespaces in the INFO column.
...
svn path=/trunk/; revision=42679
2012-05-17 15:31:15 +00:00
Bill Meier
6fbb09d50b
General Cleanup including:
...
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);
svn path=/trunk/; revision=42678
2012-05-17 14:35:11 +00:00
Michael Tüxen
6526ea3751
Add support for specifying an SCTP port number.
...
svn path=/trunk/; revision=42677
2012-05-17 14:34:09 +00:00
pascal
b607964f1f
Fix spice.common_cap_byte1 filter I changed by mistake in r42664
...
svn path=/trunk/; revision=42675
2012-05-17 08:22:34 +00:00
Gerald Combs
9e3487a953
Use BASE_DEC for spice.common_cap_byte1. (Hopefully that's correct.)
...
svn path=/trunk/; revision=42668
2012-05-16 22:05:47 +00:00
pascal
4a1de290f8
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7264 :
...
Enhance the Spice dissector to deal with sized data streams and playback data
From me: fix a few hf entries
svn path=/trunk/; revision=42664
2012-05-16 21:20:16 +00:00
pascal
f400e647b8
From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 :
...
GTP Extension headers are dissected incorrectly
svn path=/trunk/; revision=42663
2012-05-16 20:59:56 +00:00
Chris Maynard
ff667657e8
Largely, whitespace and formatting changes. Added modelines to match.
...
Other misc. changes:
-> Delete useless, duplicate assignment of offset to 0 in dissect_vsnp().
-> Change short seq # display filter so it's not the same as the seq # filter.
-> pppoe.dump.gz looks to be malformed, so remove unnecessary "remlen" code in
dissect_cp() and let the packets be displayed as malformed since they are.
-> Remove if (check_col()) checks.
-> Fix copy-and-paste of filter name for ipcp.opt.max_header.
svn path=/trunk/; revision=42661
2012-05-16 19:55:49 +00:00
Gerald Combs
bdb614e264
Fix a bunch of uninitialized variables found by Coverity Scan. CIDs
...
702403, 702404, 702405, 702406, 702407, 702408, 702409, 702410, 702411,
and 702412.
svn path=/trunk/; revision=42658
2012-05-16 16:29:12 +00:00
Anders Broman
46e202503a
se_allocate and store per packet data.
...
svn path=/trunk/; revision=42657
2012-05-16 14:56:34 +00:00
pascal
e5f3a74723
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7186 :
...
Link together access-request and access-challenge messages
svn path=/trunk/; revision=42656
2012-05-16 13:24:10 +00:00
Anders Broman
3e2ea7b812
Handle DCH information in RadioLinkReconfigurationPrepareFDD
...
svn path=/trunk/; revision=42655
2012-05-16 13:05:27 +00:00
Anders Broman
dc8224653e
Only do HS-DSCH Control frames for now as something is broken.
...
svn path=/trunk/; revision=42653
2012-05-16 08:35:53 +00:00
Anders Broman
e65a6548bf
From David Wei:
...
Corrected info column for piggybacked GTPv2 messages.
svn path=/trunk/; revision=42652
2012-05-16 07:47:15 +00:00
Anders Broman
7918984efc
Bug fixes and add HSDSCH
...
svn path=/trunk/; revision=42650
2012-05-16 05:58:30 +00:00
Anders Broman
ce6e224b5b
Bug fixes and add HSDSCH
...
svn path=/trunk/; revision=42649
2012-05-16 05:57:41 +00:00