osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
41347 commits 26 branches 0 tags 795 MiB
Commit graph

14746 commits

Author SHA1 Message Date
Jeff Morriss
4fdc3c3cc2 Create, and start using, file name preferences. 
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).

svn path=/trunk/; revision=43228
 2012-06-13 01:13:12 +00:00
Pascal Quantin
f0a74f3a5c Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0) 
svn path=/trunk/; revision=43227
 2012-06-12 21:36:55 +00:00
Bill Meier
1b17369504 Fix: code under 'if(tree)' (in)directly calls sub-dissector/col_...()/expert...() fcns 
svn path=/trunk/; revision=43226
 2012-06-12 21:22:46 +00:00
Jörg Mayer
f679b89649 Revert r41952 
BACKPORT to 1.8

svn path=/trunk/; revision=43222
 2012-06-12 10:44:57 +00:00
Jörg Mayer
9228ece476 Manually revert r41953 
BACKPORT to 1.8

svn path=/trunk/; revision=43221
 2012-06-12 10:38:22 +00:00
Bill Meier
4f47eefa79 Fix bugs and other issues: 
- remove 'if (tree)' around code which (eventually) calls col_...() functions;
- remove unneeded check_col() usage;
- use extended value-strings where appropriate;
- use col_set_str() instead of col_add_fstr();
- fix mismatch between proto_tree_add_item() size arg and the FT type in the
   referenced hf[] entry (in a few cases);
- FT_STRING fields should have ENC_ASCII|ENC_NA as the 'encoding' arg
   in the corresponding proto_tree_add_item() call;
- do whitespace cleanup.

Note: 1 issue remains:
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260#c12


svn path=/trunk/; revision=43217
 2012-06-11 20:51:47 +00:00
Bill Meier
bdebbb9bdf Re-order 2 value_string arrays so that entries are in ascending order by value. 
svn path=/trunk/; revision=43216
 2012-06-11 20:35:00 +00:00
Pascal Quantin
aa0ebee47c From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7361 : 
Add BSS supported Codec list dissection to Assigment Complete message

svn path=/trunk/; revision=43215
 2012-06-11 20:28:31 +00:00
Pascal Quantin
653f74bfcf From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7360 : 
Service handover IE is not correctly dissected

svn path=/trunk/; revision=43214
 2012-06-11 20:12:17 +00:00
Bill Meier
5e3066f006 Use dscp_vals_ext everyplace (instead of dscp_vals); 
(dscp_vals is now a static array in packet-ip.c)

svn path=/trunk/; revision=43211
 2012-06-11 19:07:53 +00:00
Bill Meier
70cc6362fe Don't define value_string arrays in a .h file (included in multiple places). 
Also:
 - don't use val_to_str_const() with a "format" default string;
 - rename 'opt_len_type' enumeration  identifiers to be less generic.

svn path=/trunk/; revision=43210
 2012-06-11 18:47:42 +00:00
Bill Meier
afab63c34c Fix another compiler warning 
svn path=/trunk/; revision=43209
 2012-06-11 16:53:49 +00:00
Bill Meier
332f743f6c Fix a compiler warning 
svn path=/trunk/; revision=43208
 2012-06-11 16:44:42 +00:00
Bill Meier
8469651f54 General cleanup: 
- remove some redundant code;
- use ep_strdup_printf() instead of g_snprintf() to a static buffer;
- create and use extended-value-strings as appropriate;
- define a value_string array as static (not as an automatic);
- use val_to_str_const() instead of val_to_str() as appropriate;
- reformat hf[] array entries;
- do general formatting cleanup;
- do whitespace cleanup (e.g., indentation & 4-space tabs).

svn path=/trunk/; revision=43207
 2012-06-11 16:33:56 +00:00
Bill Meier
df07bfeba4 Create dscp_vals_ext value_str_ext (based upon dscp_vals); Use it as appropriate. 
Also:
 - use val_to_str_const() [instead of val_to_str()] in a few cases;
 - do some trivial formatting cleanup.

svn path=/trunk/; revision=43204
 2012-06-11 15:47:50 +00:00
Pascal Quantin
a923c28ede Use restricted character string decoding for IA5String type 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6246

svn path=/trunk/; revision=43203
 2012-06-11 13:54:06 +00:00
Anders Broman
4f2c3a8e86 len is no longer used. 
svn path=/trunk/; revision=43200
 2012-06-11 08:07:48 +00:00
Anders Broman
8456dcbceb From Michael Mann: 
Implemented RFC 4954 within the SMTP dissector.  On principle, the decryption
is disabled by default (making this feature not obviously present). However I
don't think there will ever be enough data that the performance would be an
issue if the default was changed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349

svn path=/trunk/; revision=43197
 2012-06-11 07:10:18 +00:00
Anders Broman
34cb6f96d3 From Michael Mann: 
NUL terminate the decoded string.  
Updated only dissector that uses epan_base64_decode() (packet-http.c) to assume
NULL termination.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349

svn path=/trunk/; revision=43196
 2012-06-11 07:09:11 +00:00
Bill Meier
7b94cadffd From Evan Huus: Missing breaks in packet-rsvp.c 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7353

svn path=/trunk/; revision=43194
 2012-06-11 03:36:04 +00:00
Chris Maynard
339bedb75c Fix UDP-Lite checksum verification bug introduced with r40387 and reported by "answer" via http://ask.wireshark.org/questions/11798/is-udp-lite-checksum-correct-ipv6 
There is a difference between the UDP and UDP-Lite pseudo header that wasn't realized when r40387 was committed.  Details of the difference in http://tools.ietf.org/html/rfc3828#section-3.2

svn path=/trunk/; revision=43187
 2012-06-10 19:43:40 +00:00
Chris Maynard
ebe8ed3a3e Fix the other part of Coverity CID 703086. I thought I got it with r42798, but apparently that was only 1/2 the fix as sometimes they group more than one bug into a single CID. 
svn path=/trunk/; revision=43185
 2012-06-10 19:02:03 +00:00
Anders Broman
912ba5d00b From Michael Mann: Added dissection of IceP over UDP as well as a few preferences mentioned in the TODO. Also replaced a few proto_tree_add_text with expert_add_info_format. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1646 
svn path=/trunk/; revision=43182
 2012-06-10 08:24:18 +00:00
Bill Meier
4b4bb7acf5 Fix compiler error 
svn path=/trunk/; revision=43181
 2012-06-09 18:42:20 +00:00
Bill Meier
61d278c921 str_to_ipaddr() had a bug; use inet_pton() instead; 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844#c27

Also: Improve handling of an invalid value for the 'proxy IP Address'
preference. If the address is invalid, setting the preference
to "" in proto_reg_handoff...() doesn't work well.
Instead, issue a g_warning for an invalid IP address when it'
s processed in proto_reg_handoff...()
(AFAIK, there's not a way for a dissector to validate the semantic
value of a preference and report an error).

svn path=/trunk/; revision=43180
 2012-06-09 18:24:09 +00:00
Chris Maynard
951b5b9c54 Do not use BASE_NONE for FT_*INT* types. 
svn path=/trunk/; revision=43179
 2012-06-09 17:56:08 +00:00
Chris Maynard
0169f77ac6 Do not use BASE_NONE for FT_*INT* types. 
svn path=/trunk/; revision=43178
 2012-06-09 17:51:30 +00:00
Chris Maynard
d9a5e3a1d2 Do not use BASE_NONE for FT_*INT* types. 
svn path=/trunk/; revision=43177
 2012-06-09 17:47:58 +00:00
Chris Maynard
365139b5cf Do not use BASE_NONE for FT_UINT8 types. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).

svn path=/trunk/; revision=43176
 2012-06-09 17:08:46 +00:00
Chris Maynard
8fe8287a39 Add sip.to.tag and sip.from.tag filters. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5226

svn path=/trunk/; revision=43175
 2012-06-09 15:54:15 +00:00
Chris Maynard
bf35ccfbce Allow syslog to work with "Decode As" for TCP. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5241

svn path=/trunk/; revision=43174
 2012-06-09 15:43:08 +00:00
Jeff Morriss
be965bff75 Don't register 3 (IPAddress) hf's with the same abbreviation but with 3 
different types; instead use different abbreviations (filters).

This is in order to prevent running into

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

and seg-faulting when someone applies a filter of, for example,
diameter.Framed-IP-Address .

svn path=/trunk/; revision=43166
 2012-06-08 22:23:11 +00:00
Bill Meier
836ed4ccfc Fix bug I introduced in SVN #43129. 
Fixes fuzz crash reported in Bug #7346.


svn path=/trunk/; revision=43164
 2012-06-08 21:17:42 +00:00
Jeff Morriss
b4f3ea200c Thinking about it more, how we're storing the application ID isn't a problem. 
svn path=/trunk/; revision=43163
 2012-06-08 20:08:43 +00:00
Jeff Morriss
c75657ad14 Don't call val_to_str() only to then compare the result with "Uknown": use 
match_strval() instead.

Also, don't retrieve the application ID 3 more times; we've already got it
in a variable...

Point out a bug regarding how we're storing the application ID for use by
subdissectors (from r34570).

svn path=/trunk/; revision=43162
 2012-06-08 19:59:33 +00:00
Gerald Combs
39dbd45c9f Fix some dead assignments. 
svn path=/trunk/; revision=43157
 2012-06-08 17:20:44 +00:00
Anders Broman
ae43364681 Only dissect as SDp if it's IPBCP (text encoded). 
svn path=/trunk/; revision=43152
 2012-06-08 11:50:52 +00:00
Anders Broman
98b74816ae From Stefan Hoffmeister: 
ActiveSync WBXML CodeSpace updated to match official documentation.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7345

svn path=/trunk/; revision=43151
 2012-06-08 06:26:55 +00:00
Bill Meier
fabd558ffe Fix invalid hf[] entry 'display' field value. 
result: incorect display of value (and, incidentally,
        a crash in 'tshark -G values'

svn path=/trunk/; revision=43147
 2012-06-07 17:39:11 +00:00
Anders Broman
059d407e19 From Niels de Vos: GlusterFS: Display SETATTR attribute valid as a list of flags https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7341 
svn path=/trunk/; revision=43144
 2012-06-06 20:44:21 +00:00
Anders Broman
7881fe8493 From Stephen Donnelly: Correct ERF name, add WTAP_ENCAP string display https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7313 
svn path=/trunk/; revision=43141
 2012-06-06 20:35:37 +00:00
Pascal Quantin
2f035a3c0f From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 : 
FPSpotlightRPC dates structure can contain multiple dates

svn path=/trunk/; revision=43133
 2012-06-06 16:55:48 +00:00
Bill Meier
027b57b472 Fix compiler error (I hope) 
svn path=/trunk/; revision=43131
 2012-06-06 05:58:42 +00:00
Bill Meier
e18d46784f Fix compiler error 
svn path=/trunk/; revision=43130
 2012-06-06 05:36:43 +00:00
Bill Meier
57c6467b81 Fix some bugs & do extensive cleanup; 
Bugs fixed:
 - Calling col_...() fcns or dissectors under 'if (tree)'
 - Potential buffer overflows (if bad data)
 - Misc incorrect data display issues
Cleanup including;
 - Remove unneeded #includes
 - Fix excessive use of value_strings
 - Use extended value_strings & val_to_str_(ext_)const as appropriate
 - Optimize repeated fetches of the same data from a tvb
 - Do general code simplification
 - Remove or #if 0 unused code;
 - Add XXX comments for code which may be incorrect
 - Remove unneeded prefs callback to proto_reg_handoff...()
 - Remove unneeded use of check_col()
 - Define several functions as static
 - Move proto_reg_handoff...() to the end of the file
 - Fix whitespace (including "4 space tabs")
 - ...

svn path=/trunk/; revision=43129
 2012-06-06 04:54:47 +00:00
Jörg Mayer
f554994823 Just fix some clang analysis warnings 
svn path=/trunk/; revision=43126
 2012-06-05 23:03:13 +00:00
Jakub Zawadzki
cf25f08af0 yami: dissect header messages, add parameter names to parent tree item. 
svn path=/trunk/; revision=43117
 2012-06-05 15:52:08 +00:00
Jeff Morriss
49c359bf2d Fix Coverity 703495: reference fpinf *after* checking that it is not NULL. 
Also replace some 4 space tabs with spaces.

svn path=/trunk/; revision=43113
 2012-06-05 15:05:17 +00:00
Jakub Zawadzki
97d51ce67f packet-yami: cleanup, remove non-ASCII character. 
svn path=/trunk/; revision=43112
 2012-06-05 15:02:49 +00:00
Jakub Zawadzki
7d075658b1 packet-wreth: cleanup 
- make function and arrays static
- comment out unused hf-entry.
- comment out unused variable.

svn path=/trunk/; revision=43111
 2012-06-05 14:50:37 +00:00
Jakub Zawadzki
6dc698ca27 Dissector for YAMI protocol. 
svn path=/trunk/; revision=43110
 2012-06-05 14:17:50 +00:00
Anders Broman
28098ed4ab From Roland Knall: 
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335

svn path=/trunk/; revision=43109
 2012-06-05 13:12:28 +00:00
Anders Broman
aa4e655696 Set SVN properties. 
svn path=/trunk/; revision=43108
 2012-06-05 11:19:33 +00:00
Anders Broman
189ea54f0b from Alex Lindberg: 
Update to packet-h248.c and associated h248 dissecorts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332

svn path=/trunk/; revision=43107
 2012-06-05 10:54:21 +00:00
Anders Broman
5bd0c263f2 From Andrew Kampjes: 
SDH support for wireshark.

- Added GPL license.
- Removed not needed includes.
- Skipped th .h file as it wasn't used.

svn path=/trunk/; revision=43106
 2012-06-05 10:42:38 +00:00
Anders Broman
1d27ce5d99 From Adam Langley: Add support for decrypting ECDHE-RSA-RC4-SHA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7331 
svn path=/trunk/; revision=43100
 2012-06-05 05:27:06 +00:00
Anders Broman
75319f09a9 From Adam Langley: Add support for CLIENT_RANDOM lines in SSL keylog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7330 
svn path=/trunk/; revision=43099
 2012-06-05 05:22:41 +00:00
Anders Broman
cec562ddd2 From Alex Lindberg: Add preference to packet-ber.c to toggle BER warning on leading zero bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7328 
svn path=/trunk/; revision=43098
 2012-06-05 05:16:06 +00:00
Anders Broman
6c85e092cf From Adam Langley: Clean up code for handling keylog files. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7329 
svn path=/trunk/; revision=43097
 2012-06-05 05:10:18 +00:00
Gerald Combs
7186d034f0 Fix compilation. 
svn path=/trunk/; revision=43094
 2012-06-04 23:47:11 +00:00
Alexis La Goutte
167b8c6cba From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260 
New dissector for WSE Remote Ethernet protocol

 From me :
 * Fix Compilation under linux
 * Use proto_tree_add_item*
 * Make build-in dissector
 * Include Status.* and Codef.* in dissector
 * Reorder function (to respect Wireshark Codelines)
 * Add Modelines Info and fix indent (use 4 spaces)
 * Fix check* tools
 * Add Clement to AUTHORS

With the dissector....

svn path=/trunk/; revision=43092
 2012-06-04 22:34:27 +00:00
Alexis La Goutte
42451447b1 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=43091
 2012-06-04 22:26:40 +00:00
Alexis La Goutte
e2cec4bb63 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
(Manual Fix, not found how to fix the generator...)

svn path=/trunk/; revision=43090
 2012-06-04 22:26:18 +00:00
Alexis La Goutte
c7e8a39966 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=43089
 2012-06-04 22:25:27 +00:00
Alexis La Goutte
cb2000b9f3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=43087
 2012-06-04 22:24:46 +00:00
Alexis La Goutte
7ec2d11b9b From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260 
New dissector for WSE Remote Ethernet protocol

From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS

svn path=/trunk/; revision=43086
 2012-06-04 22:22:32 +00:00
Jakub Zawadzki
11e584f4cf packet-gadu-gadu: set COL_INFO in undissected/unknown packet types. 
svn path=/trunk/; revision=43068
 2012-06-04 14:37:24 +00:00
Anders Broman
a90e1a353a Try to make the buildbot happy. 
svn path=/trunk/; revision=43067
 2012-06-04 14:31:53 +00:00
Anders Broman
b69547925f Get rid of a couple of warnings. 
svn path=/trunk/; revision=43066
 2012-06-04 13:52:46 +00:00
Anders Broman
2a30b1eff9 Get rid of a couple of warnings. 
svn path=/trunk/; revision=43065
 2012-06-04 13:21:44 +00:00
Anders Broman
a0910557c7 Get rid of a couple of warnings. 
svn path=/trunk/; revision=43064
 2012-06-04 12:20:37 +00:00
Anders Broman
131334481d Get rid of a couple of warnings. 
svn path=/trunk/; revision=43063
 2012-06-04 11:44:52 +00:00
Anders Broman
81a7df91dd Revert previous change as it did not compile. 
svn path=/trunk/; revision=43062
 2012-06-04 11:18:17 +00:00
Anders Broman
920ad0bcee Try to get rid of a couple of warnings. 
svn path=/trunk/; revision=43061
 2012-06-04 10:36:43 +00:00
Pascal Quantin
f275aeadd9 Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2 
svn path=/trunk/; revision=43059
 2012-06-04 10:02:08 +00:00
Anders Broman
85972d91c7 Try to get rid of a couple of warnings. 
svn path=/trunk/; revision=43058
 2012-06-04 09:04:36 +00:00
Anders Broman
10fe76d8a0 Get rid of a couple of warnings. 
svn path=/trunk/; revision=43057
 2012-06-04 08:56:48 +00:00
Pascal Quantin
ebbaf7f820 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7325 : 
Add support for the Gluster CLI RPC-protocol

svn path=/trunk/; revision=43055
 2012-06-04 08:42:12 +00:00
Chris Maynard
4902b4d857 Remove a few of "if (tree)" checks surrounding expert_add_info_format(). 
svn path=/trunk/; revision=43054
 2012-06-04 06:22:50 +00:00
Pascal Quantin
6a4606b1f1 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7324 : 
Add support for the Gluster Handshake and Callback RPC-protocols

svn path=/trunk/; revision=43035
 2012-06-03 17:15:21 +00:00
Pascal Quantin
3201d56f05 Convert space to tab 
svn path=/trunk/; revision=43033
 2012-06-03 16:49:58 +00:00
Alexis La Goutte
6c8174a1a8 Make checkhf tools Happy, Remove hf_ieee80211_chan* 
svn path=/trunk/; revision=43032
 2012-06-03 16:49:01 +00:00
Alexis La Goutte
44d7c7fb73 Add 802.11 AP Channel Report IE (51) 
svn path=/trunk/; revision=43031
 2012-06-03 16:47:15 +00:00
Alexis La Goutte
588fd3e761 Enhance 802.11 Secondary Channel Offset (62) 
svn path=/trunk/; revision=43030
 2012-06-03 16:45:30 +00:00
Alexis La Goutte
9a7409589a Enhance 802.11 HT Info 1.1 (60) 
svn path=/trunk/; revision=43029
 2012-06-03 16:43:19 +00:00
Alexis La Goutte
7852f04531 Cleanup Header (Remove e-mail of original author to report bugs...) 
svn path=/trunk/; revision=43028
 2012-06-03 16:41:11 +00:00
Alexis La Goutte
8f94d6a813 Enhance 802.11 (Vendor Specific) HT Capability (45) 
And fix last Dead Store warning found by Clang


svn path=/trunk/; revision=43027
 2012-06-03 16:39:55 +00:00
Alexis La Goutte
3899295893 Enhance 802.11 (vendor specifiq) HT Info 1.0 (Draft) 
svn path=/trunk/; revision=43025
 2012-06-03 16:37:56 +00:00
Pascal Quantin
8edc336db6 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7323 : 
Add support for the Gluster Portmapper and DUMP RPC-protocols

svn path=/trunk/; revision=43024
 2012-06-03 16:17:38 +00:00
Pascal Quantin
b3f2c794e2 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7315 : 
Initial support for the GlusterD RPC-protocol

svn path=/trunk/; revision=43023
 2012-06-03 15:52:15 +00:00
Pascal Quantin
aa95f6b73d Revert files committed by error in revision 43007 
svn path=/trunk/; revision=43008
 2012-06-02 19:20:04 +00:00
Pascal Quantin
797b83c838 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7322 : 
Add a missing break in packet-bpkmattr.c (CID 280484)

svn path=/trunk/; revision=43007
 2012-06-02 19:15:07 +00:00
Anders Broman
96beb44145 From Evan Huus Useless null check in packet-ssh.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7319 
svn path=/trunk/; revision=42996
 2012-06-02 13:25:02 +00:00
Balint Reczey
7ef7aae265 Fix header file includes to allow make dumpabi run without errors 
svn path=/trunk/; revision=42994
 2012-06-02 12:57:26 +00:00
Anders Broman
d4e17555ad Put more mesage names in info col 
svn path=/trunk/; revision=42993
 2012-06-02 10:11:46 +00:00
Jeff Morriss
d4fdd6ad52 Only propose decoding PPID 0 if that PPID is in the currently-selected frame. 
(I used PPID 0xffffffff as an end-of-list marker so that PPID can no longer
be used in this dialog; if someone starts using that PPID then we'll have
to put a count of PPIDs in pinfo.)

svn path=/trunk/; revision=42991
 2012-06-01 21:18:59 +00:00
Gerald Combs
c408151a80 Try to be a bit more clear that "lost" is from Wireshark's perspective, 
not necessarily one of the TCP endpoints.

svn path=/trunk/; revision=42990
 2012-06-01 20:54:04 +00:00
Pascal Quantin
2256e71cc5 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7316 : 
Use correct field type for OUI

svn path=/trunk/; revision=42989
 2012-06-01 20:32:15 +00:00
Jeff Morriss
e83180023e Clean up some indentation (get rid of 4-space tabs) and white space. 
svn path=/trunk/; revision=42988
 2012-06-01 19:46:53 +00:00
Jeff Morriss
a2fe7eabbb Remember the 'lower' UDP port information even if we got the UDP packet 
non-heuristically.  This prevents us from trying to decode the user's UDP
payload as FP.

(This is a followup/revision to r31113/bug 4218.)

svn path=/trunk/; revision=42987
 2012-06-01 19:22:01 +00:00
Jeff Morriss
9e3b598e30 Some code/white space cleanup. 
svn path=/trunk/; revision=42985
 2012-06-01 18:35:20 +00:00
Guy Harris
6a43200ee9 Squelch warning about uninitialized variable (the dataflow analysis 
isn't sophisticated enough to know that can't happen).

svn path=/trunk/; revision=42983
 2012-06-01 18:01:42 +00:00
Pascal Quantin
b9917a1248 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310 : 
Initial support for the GlusterFS RPC-protocol

svn path=/trunk/; revision=42979
 2012-06-01 17:10:03 +00:00
Anders Broman
a8e8234831 Make packet-coseventcomm.c a bultin dissector 
svn path=/trunk/; revision=42974
 2012-06-01 15:57:05 +00:00
Anders Broman
6e3d56f039 For RLC re-assembly to work we need to fake urnti. 
svn path=/trunk/; revision=42970
 2012-06-01 13:01:32 +00:00
Anders Broman
a2f13cad70 Don't call subdissectors if the CRCI bit is set. 
svn path=/trunk/; revision=42969
 2012-06-01 12:28:05 +00:00
Anders Broman
c8625796f1 Make the cosnaming dissector a builtin dissector. 
svn path=/trunk/; revision=42968
 2012-06-01 12:27:04 +00:00
Anders Broman
b42bbc2cd6 Make the tango dissector a builtin dissector. 
svn path=/trunk/; revision=42967
 2012-06-01 10:31:34 +00:00
Anders Broman
5ef6c6d08a Make the parlay dissector a buil tin dissector. 
svn path=/trunk/; revision=42964
 2012-06-01 08:48:31 +00:00
Anders Broman
728584510b Fix a couple of warnings 
svn path=/trunk/; revision=42957
 2012-06-01 05:55:20 +00:00
Anders Broman
6a505b4cce Fix a couple of warnings 
svn path=/trunk/; revision=42956
 2012-06-01 05:36:52 +00:00
Gerald Combs
5690373d48 g_snprintf → ep_strbuf. I can't find an ERF file with a virtual 
container but the conversion seemed be straightforward enough.

svn path=/trunk/; revision=42951
 2012-05-31 21:30:40 +00:00
Pascal Quantin
b83080f5b6 From Erwin Rol via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7311 : 
Fix a cut and paste error in packet-dmx.c

svn path=/trunk/; revision=42949
 2012-05-31 20:40:07 +00:00
Gerald Combs
ae6e4d6dd3 Fix a possible zero division found by scan-build. While we're at it replace 
occurrences of g_snprintf+strlen with ep_strbuf.

svn path=/trunk/; revision=42948
 2012-05-31 20:24:04 +00:00
Anders Broman
b9e5955f46 Set dir if we don't have it. 
svn path=/trunk/; revision=42945
 2012-05-31 13:23:42 +00:00
Pascal Quantin
08c7db0421 Display hf_smb_server_guid, hf_smb_volume_guid and hf_smb_dfs_referral_server_guid as FT_GUID 
svn path=/trunk/; revision=42944
 2012-05-31 13:22:52 +00:00
Pascal Quantin
4d1abc7bbb From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7306 : 
RPC: show the AUTH_GLUSTERFS/lk_owner as hex

svn path=/trunk/; revision=42940
 2012-05-31 08:56:19 +00:00
Pascal Quantin
48fee70339 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7307 
svn path=/trunk/; revision=42939
 2012-05-31 08:25:00 +00:00
Anders Broman
867de6145e From Sheetal Kshirsagar and Andrew Williams: 
Updating the RPL SRH dissector and implementing RPL Options header dissection.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986

svn path=/trunk/; revision=42937
 2012-05-31 07:25:11 +00:00
Anders Broman
fc19f32931 Try to squelch a couple of warnings 
svn path=/trunk/; revision=42936
 2012-05-31 05:42:02 +00:00
Jakub Zawadzki
14bfedccd9 Revert r42853, cleanup packet-jxta which might really fix CID 280210 
References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00226.html

svn path=/trunk/; revision=42932
 2012-05-30 22:39:56 +00:00
Jeff Morriss
6341191d72 From Richard Sharpe on -dev: 
Attached is a patch that fixes (I think) the handling of extended
responses on NTCreate&X requests.

svn path=/trunk/; revision=42923
 2012-05-30 18:29:37 +00:00
Pascal Quantin
59b621e67b Prefix TransportFormatSet_type_enum values with NBAP_ to avoid a clash with 'PCH' in <WinNT.h> 
svn path=/trunk/; revision=42922
 2012-05-30 18:27:40 +00:00
Chris Maynard
b35b911748 Mark pinfo as unused. Change args to proto_tree_add_text(). 
svn path=/trunk/; revision=42921
 2012-05-30 17:26:00 +00:00
Chris Maynard
39d4fbeb52 PPP CCP improvements. And yay, checkAPIs no longer complains about the number of useless add_text()'s since the ratio is finally below 50%. This ratio should continue to drop as more and more fields become filterable. 
svn path=/trunk/; revision=42920
 2012-05-30 17:02:44 +00:00
Anders Broman
79e91685b7 Stab at DCH 31 dissection. 
svn path=/trunk/; revision=42915
 2012-05-30 14:04:45 +00:00
Anders Broman
a307c8318d Dissect non segmented MiB and SiB:s 
svn path=/trunk/; revision=42914
 2012-05-30 11:48:05 +00:00
Pascal Quantin
d9b845534d Use ett variable for proto_item_add_subtree function call 
svn path=/trunk/; revision=42913
 2012-05-30 08:49:56 +00:00
Jakub Zawadzki
4c3735771a Fix bug #5077 in IPv6. 
svn path=/trunk/; revision=42909
 2012-05-30 05:39:39 +00:00
Jakub Zawadzki
a2dac52152 Cleanup geoip support in ipv6. 
svn path=/trunk/; revision=42908
 2012-05-30 05:33:37 +00:00
Pascal Quantin
86dd3248f6 Avoid using C99 '%hh' length modifier 
svn path=/trunk/; revision=42904
 2012-05-29 21:51:52 +00:00
Pascal Quantin
3f07cc05bc From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7301: 
Dissector for DVB Application Information Table (AIT)

svn path=/trunk/; revision=42903
 2012-05-29 21:36:39 +00:00
Pascal Quantin
0e557f4421 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7302: 
Small updates to ISO 7816 dissector

svn path=/trunk/; revision=42902
 2012-05-29 21:09:46 +00:00
Pascal Quantin
8b72c6506e From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7303 
Remove unnecessary null checks before calling proto_item_set_len() in DVB-CI dissector

svn path=/trunk/; revision=42901
 2012-05-29 20:28:41 +00:00
Jakub Zawadzki
dfa5a78130 Fix bug #7304, stupid mistake. 
svn path=/trunk/; revision=42900
 2012-05-29 20:27:22 +00:00
Jakub Zawadzki
e5be60bc81 Fix bug #5735 
dissect_attribute_value_pairs() should be also called with NULL tree.
Broken from r29964.

svn path=/trunk/; revision=42899
 2012-05-29 20:01:25 +00:00
Anders Broman
2a7bef2cb0 Handle E-DCH 
svn path=/trunk/; revision=42898
 2012-05-29 14:34:34 +00:00
Ronnie Sahlberg
5f04a8404b SCSI SBC: Add dissection of GET_LBA_STATUS command 
svn path=/trunk/; revision=42897
 2012-05-29 11:25:38 +00:00
Anders Broman
8d6b6f58d6 From Deepti Ragha: 
Additions to the ARP dissector as per the IANA specifications for ARP

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7216

svn path=/trunk/; revision=42895
 2012-05-29 08:00:35 +00:00
Anders Broman
7aa5527274 From Aditya Ambadkar and Diana Chris: 
Enhancement to LDP dissector to support changes proposed in RFC6391 - flow aware transport of PW over an MPLS PSN.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7046

svn path=/trunk/; revision=42894
 2012-05-29 07:45:40 +00:00
Anders Broman
859f794544 From Evan Huus: 
Fix to
BACapp item length causes Buildbot crash output: randpkt-2011-04-13-1899.pcap

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5825

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7296

svn path=/trunk/; revision=42893
 2012-05-29 07:31:38 +00:00
Guy Harris
1020c20d9e From Erwin Rol: fix a copy-and-paste leftover. 
svn path=/trunk/; revision=42890
 2012-05-29 00:05:39 +00:00
Pascal Quantin
a891f54067 Keep backward compatibility with UDP framing format for UMTS RLC dissector 
Fix a few typo errors while we are at it

svn path=/trunk/; revision=42889
 2012-05-28 20:34:27 +00:00
Anders Broman
091138dafe Use C/T as rbid 
svn path=/trunk/; revision=42888
 2012-05-28 20:11:59 +00:00
Anders Broman
1c9920ada6 Use ett instead of hf variable 
svn path=/trunk/; revision=42887
 2012-05-28 20:09:00 +00:00
Anders Broman
b74438e41d Set but not used variable 
svn path=/trunk/; revision=42885
 2012-05-28 17:55:47 +00:00
Anders Broman
4312a9dd61 Remove C++ style comments initilize some variables. 
svn path=/trunk/; revision=42884
 2012-05-28 16:00:20 +00:00
Jakub Zawadzki
5020a3f170 While iterating over string characters don't use strlen(), but check for NUL. 
svn path=/trunk/; revision=42883
 2012-05-28 15:59:00 +00:00
Anders Broman
bb08a70594 Set SVN properties. 
svn path=/trunk/; revision=42882
 2012-05-28 15:30:09 +00:00
Anders Broman
136ad63adf Set SVN properties. 
svn path=/trunk/; revision=42881
 2012-05-28 15:29:36 +00:00