Commit Graph

85702 Commits

Author SHA1 Message Date
João Valverde 92e1357bb4 Rename ws_label_strcat() to ws_label_strcpy()
The semantics of ws_label_strcat() are closer to g_strlcpy() so
rename the function to reflect that.
2022-10-26 13:12:35 +01:00
João Valverde f55cb116a0 Remove memset() from ws_label_str()
In the interests of efficiency with multiple small writes avoid
doing a memset on the whole remaining length.
2022-10-26 13:12:31 +01:00
João Valverde c149e4112f epan: Rename a test 2022-10-26 13:12:12 +01:00
João Valverde 8920effd27 FiveCo Legacy: Fix raw bytes as UTF-8 2022-10-26 11:58:15 +01:00
João Valverde 62d6fb85c7 Netrom: Fix string truncation
Fixes #18532.
2022-10-26 11:57:09 +01:00
João Valverde 0157d74c44 epan: Fix bogus string truncations found with a search
Fix some unnecessary string truncations that look bogus to me.

Forcing a given UTF-8 byte length for no reason will in most cases
produce encoding errors.

Fixes #18548.
2022-10-26 11:14:06 +01:00
João Valverde 40ec1adfb0 S7Comm: Fix invalid UTF-8 value string chars
Fixes #18533.
2022-10-26 01:42:43 +01:00
João Valverde 56ee77d525 DNS: Do not truncate string arbitrarily
Truncating the decoded string to the encoded packet length is
the wrong thing to do.

Fixes #18535.
2022-10-26 00:37:37 +00:00
João Valverde 549e194e7c MPEG2 Descriptors: Validate ASCII strings
Fixes #18536.
2022-10-26 00:37:05 +00:00
John Thacker 5a144e6010 synergy: Format unknown packet types as UTF-8
Also fix an issue where the wrong bytes were being looked at
to determine if it was a handshak.

Fix #18528
2022-10-25 19:42:46 -04:00
Gerald Combs 23f206c8b8 GitLab CI: Build RPMs in parallel.
Our RPM spec runs `cmake --build ... -j1` on Fedora and Rocky. Set
RPM_BUILD_NCPUS, which increases the `-j` value so that ninja can make
full use of the system.

[skip ci]
2022-10-25 19:35:43 +00:00
Gtker 3a19d97867 woww: Make enums use biggest size occurrance 2022-10-25 19:08:09 +00:00
Gtker 71e989a0f4 woww: Make types have the FT of their largest type instead of smallest 2022-10-25 19:08:09 +00:00
Gtker da8a0e64f3 woww: Remove _guid from some HFs 2022-10-25 19:08:09 +00:00
Gtker f88027a1ef woww: Remove _guid from item and player in SMSG_ITEM_NAME_QUERY_RESPONSE 2022-10-25 19:08:09 +00:00
Gtker b2ee0f32d1 woww: Add underscore to buy_bank_slot_result 2022-10-25 19:08:09 +00:00
Gtker c77b972edc woww: Make SMSG_TURN_IN_PETITION_RESULTS use petition_results 2022-10-25 19:08:09 +00:00
Gtker bc433b41ce woww: Remove incorrect field from SMSG_PETITION_SHOWLIST 2022-10-25 19:08:09 +00:00
Gtker 302117823b woww: Update SMSG_PETITION_SIGN_RESULTS 2022-10-25 19:08:09 +00:00
Gtker ba1edd97e8 woww: Add SMSG_GUILD_ROSTER 2022-10-25 19:08:09 +00:00
Gtker 8e3d587421 woww: Remove skip fields and add gm_ticket_queue_status 2022-10-25 19:08:09 +00:00
Gtker 226ee2e242 woww: Add change NECK_OR_RELIC to RELIC and fix SPLINE_FLAG_UNKNOWN31
For 1.12 0x02 is just NECK and RELIC is 0x1C.
2022-10-25 19:08:09 +00:00
Gtker d6e47936a4 woww: Fix warnings about values being out of scope for int 2022-10-25 19:08:09 +00:00
Gtker 478fddaec4 woww: Split GM_TICKET_STATUS enumerators with underscores 2022-10-25 19:08:09 +00:00
Gtker c9f1d411a4 woww: Add gm_ticket_type to CMSG_GMTICKET_UPDATETEXT 2022-10-25 19:08:09 +00:00
Gtker c3630bc0e9 woww: Remove compressed field from CMSG_GMTICKET_CREATE 2022-10-25 19:08:09 +00:00
Gtker 25403e9f15 woww: Add comment field to CMSG_GMSURVEY_SUBMIT 2022-10-25 19:08:09 +00:00
Gtker 1996a520ec woww: Remove compressed CMSG_AUTH_SESSION field 2022-10-25 19:08:09 +00:00
Gtker 24b4c703c4 woww: Add battleground related updates 2022-10-25 19:08:09 +00:00
Gtker aa1ff9f57d woww: Update incorrect messages 2022-10-25 19:08:09 +00:00
Gtker ec659dc177 woww: Add more fields for SMSG_ATTACKERSTATEUPDATE 2022-10-25 19:08:09 +00:00
Gtker e561372278 woww: Update SMSG_ADDON_INFO, fix endless array looping
The arrays would previously loop for the amount of bytes left, not the
amount of objects left.
2022-10-25 19:08:09 +00:00
Gtker 53fa582c92 woww: Rename compressed_addon_info to addon_info 2022-10-25 19:08:09 +00:00
Gtker 75b312c659 woww: Make message direction detection be more flexible 2022-10-25 19:08:09 +00:00
Gtker 7f46c9fc56 woww: Register with decode_as instead of _with_preference
Feedback in PR
https://gitlab.com/wireshark/wireshark/-/merge_requests/8356#note_1121741591
2022-10-25 19:08:09 +00:00
Gtker 1fa99c5f0d woww: Update release-notes.adoc with more information 2022-10-25 19:08:09 +00:00
Gtker 15a7cfc943 Add WOWW to docbook/release-notes.adoc
As requested
https://gitlab.com/wireshark/wireshark/-/merge_requests/8356#note_1122847782
2022-10-25 19:08:09 +00:00
Gtker 238a49fcc5 woww: Add update mask 2022-10-25 19:08:09 +00:00
Gtker 2c921dd098 woww: Add Aura Mask 2022-10-25 19:08:09 +00:00
Gtker 81c2c29f7f woww: Auto generate implementation from wowm
This has been autogenerated from `wowm` descriptions of the messages at
https://github.com/gtker/wow_messages/tree/main/wow_message_parser/wowm/world
The generator is written in Rust and located at
https://github.com/gtker/wow_messages/tree/main/wow_message_parser/src/wireshark_printer
2022-10-25 19:08:09 +00:00
Gtker 460ad699bf woww: Make preparations for auto generating dissector 2022-10-25 19:08:09 +00:00
Chuck Craft 978def5b51 tools/compress-png: migration to python typos
Allow --list to run with no other options
Loop through all compressors checking if they exist
Add filename for searching in IDE
2022-10-25 17:52:28 +00:00
Jakub Pawlowski 974123c507 Bluetooth: add Volume Control Service characteristics parsing 2022-10-25 17:30:00 +00:00
Gerald Combs 708da48526 IEEE 802.11: Fix a length check.
Fix a length check issue introduced in 85a9e05c52.
2022-10-25 09:06:33 -07:00
Alexis La Goutte e7a4f4b2e3 H224: Fix typo (Sequence -> Segment)
Close #18514
2022-10-24 20:19:26 +00:00
AndersBroman 92d58f297d PER: Fix call_per_oid_callback() open type length is in bytes.
tvb_new_octet_aligned() expects the length in bits.
2022-10-24 20:18:34 +00:00
Gerald Combs 85a9e05c52 IEEE 802.11: Fix DSCP string handling
Replace looped snprintfs with wmem_strbuf_append_printfs.
2022-10-24 18:53:09 +00:00
Gerald Combs 39910654d3 IEEE 802.11: Fix SCIDX string handling
Appending to a string using snprintf inside a loop can be problematic
because you have to ensure that your start offset stays within the
bounds of your buffer and that your size (which is unsigned) doesn't
overflow. Switch to a wmem_strbuf.

Fixes #18527
2022-10-24 11:23:34 -07:00
Alexis Gryta ce2b9a046a .gitlab-ci's variables: as string 2022-10-24 18:14:26 +00:00
Brian Sipos c4b30942d0 epan: Fix build errors about try/catch block on some compilers
The original error was identified in a comment on !8583
2022-10-24 15:29:15 +00:00