Commit Graph

42945 Commits

Author SHA1 Message Date
Anders Broman 9d37b98748 Set fence after finishing writing to the info col in order to show
info from more than one (SIP) message in the frame.

svn path=/trunk/; revision=45429
2012-10-09 15:07:46 +00:00
Anders Broman cba1bb8278 As ths SDP dissector adds /SDP to the protocol column I think that
col_append_str(pinfo->cinfo, COL_INFO, ", with session description"); is redundant if some one has a different opinion fel free to revert.

svn path=/trunk/; revision=45428
2012-10-09 15:00:39 +00:00
Anders Broman f0472792e2 - Add Nokai Siemens Networks AVP.
- Add a few enums to Event-Trigger
- Reformat the Nokia file a bit.

svn path=/trunk/; revision=45427
2012-10-09 14:10:31 +00:00
Anders Broman 76c746b16d From Andrew Kampjes:
Correcting a few fields in SDH dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7708

svn path=/trunk/; revision=45426
2012-10-09 10:57:04 +00:00
Pascal Quantin 00e6a66e4d Fix dissection of Get Response when not in SIMtrace mode
svn path=/trunk/; revision=45425
2012-10-09 10:48:59 +00:00
Anders Broman 8dec6cccb9 From Michal Labedzki:
[PATCH 17] Bluetooth: Add GNSS services to SDP

Based on https://www.bluetooth.org/Technical/AssignedNumbers/home.htm

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=45424
2012-10-09 10:45:14 +00:00
Anders Broman c75bca343a From Michal Labedzki:
[PATCH 16] Bluetooth: Add SYNC and BPP service handles to OBEX
Also fix typo.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=45423
2012-10-09 10:41:30 +00:00
Anders Broman 3805f354a4 From Michal Labedzki:
[PATCH 15] Bluetooth: Add modelines 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=45422
2012-10-09 10:36:04 +00:00
Anders Broman 4209300f48 Replace non ASCII chars.
svn path=/trunk/; revision=45421
2012-10-09 10:26:43 +00:00
Anders Broman 5f9709ad8c Comment out unused variable remoce C++ style comments etc.
svn path=/trunk/; revision=45420
2012-10-09 10:24:15 +00:00
Anders Broman de222a1b5a From Chris Wulff:
Minor bugfixes to packet-msrp.c and packet-mrp-mvrp.c

Major updates to packet-ieee17221.c

Changes to ieee17221.c update dissector from draft revision 18 / 19 code to
draft revision 21.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7779

svn path=/trunk/; revision=45419
2012-10-09 08:49:40 +00:00
Anders Broman eb618abad9 From Bill Parker:
Explicitly declare/cast 'unsigned <variable>' as 'unsigned int <variable>'

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7810

svn path=/trunk/; revision=45418
2012-10-09 08:40:02 +00:00
Pascal Quantin 41ad59d6a7 Fix dissection of Bearer parameters for E-UTRAN / mapped UTRAN packet service
svn path=/trunk/; revision=45417
2012-10-09 07:40:06 +00:00
Jaap Keuter d08697130f Add initial support for three new RTCP packet types: AVB, RSI and TOKEN.
svn path=/trunk/; revision=45416
2012-10-09 06:41:32 +00:00
Pascal Quantin f8b81a6f5f Check if Bearer Parameters field is present before displaying it
svn path=/trunk/; revision=45415
2012-10-09 05:34:48 +00:00
Evan Huus af9da8bf6e Add syntax_line_edit.h to CMakeLists to fix CMake qtshark build.
svn path=/trunk/; revision=45414
2012-10-09 00:54:40 +00:00
Pascal Quantin 924f9663fd Enhance dissection of Open Channel proactive command
svn path=/trunk/; revision=45413
2012-10-08 22:30:47 +00:00
Evan Huus b01f1d3762 Actually destroy chunks in emem_free_all. We lose the efficiency of re-using
them, but until I can figure out the correct logic for that (3rd try and
counting...) this at least plugs the leak.

svn path=/trunk/; revision=45412
2012-10-08 22:27:03 +00:00
Pascal Quantin 1bed23e6d0 Add "gsm_sim.command" and "gsm_sim.response" dissectors and call them in btsap dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715

svn path=/trunk/; revision=45411
2012-10-08 21:46:30 +00:00
Martin Kaiser 5ff09963ab fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7800
use correct data types in eigrp dissector to prevent overflow

svn path=/trunk/; revision=45408
2012-10-08 20:43:06 +00:00
Gerald Combs 34b3dc498b Add a cast.
svn path=/trunk/; revision=45407
2012-10-08 20:22:21 +00:00
Gerald Combs ce4967bfec Remove a debugging #include.
svn path=/trunk/; revision=45406
2012-10-08 20:04:38 +00:00
Gerald Combs 445148ac0e Add a PacketRangeGroupBox widget. Use it to implement "Export Selected
Packets". Not yet tested on Windows. "Ignore Packet" hasn't been
implemented so we can't test that either.

Create a SyntaxLineEdit widget from the QLineEdit code in
DisplayFilterEdit. Use it in the file import and export dialogs and the
PacketRangeGroupBox widget. This lets us provide instant feedback
instead of popping up an error dialog.

Expand the Tango color list based on
http://emilis.info/other/extended_tango .

Rearrange QtShark.pro to (hopefully) work better with Qt Creator.

svn path=/trunk/; revision=45405
2012-10-08 20:01:59 +00:00
Evan Huus 693ed306d3 Try to clarify some of the ifdefs in emem.c.
svn path=/trunk/; revision=45404
2012-10-08 19:43:03 +00:00
Evan Huus d0183357dc From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7796
Add summary information to USB isodesc trees to make interesting descriptors
obvious to the user.

svn path=/trunk/; revision=45403
2012-10-08 19:31:17 +00:00
Martin Kaiser 9b78939cb3 expert.h needs packet_info.h
(trying to ensure that the order in which files are included
 does not matter)

svn path=/trunk/; revision=45402
2012-10-08 19:30:34 +00:00
Evan Huus 3c57a48598 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7807
Fix dissection of some GlusterFS procedures.

From me:

Use TRUE/FALSE instead of 1/0 for boolean literals.

svn path=/trunk/; revision=45401
2012-10-08 19:23:50 +00:00
Guy Harris e6616b7c2f Rename emem_header_t to emem_pool_t to better indicate what it can be
used for - it represents a memory pool that parcels out memory from
larger allocated chunks (reducing the number of individual malloc-style
calls that are made) and that can be freed in its entirety.

svn path=/trunk/; revision=45400
2012-10-08 18:33:00 +00:00
Gerald Combs 4f1eb84444 Log the time we spend waiting for the capture child to exit.
Add breadcrumbs so that we can switch from g_get_current_time to
g_get_real_time when our minimum GLib version is >= 2.28.

svn path=/trunk/; revision=45399
2012-10-08 18:11:30 +00:00
Alexis La Goutte 3e602ee281 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=45398
2012-10-08 17:55:12 +00:00
Alexis La Goutte 8d6260628e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=45397
2012-10-08 17:54:39 +00:00
Gerald Combs 98d7549953 We've already typedef'ed emem_header_t in emem.h. We don't have to do it
again in emem.c.

svn path=/trunk/; revision=45396
2012-10-08 17:52:42 +00:00
Guy Harris 4ab12fb640 col_cleanup is used outside libwireshark, so it needs to be exported.
svn path=/trunk/; revision=45395
2012-10-08 17:08:52 +00:00
Guy Harris 5c26eba9ea There's no longer a ep_free_all() routine.
svn path=/trunk/; revision=45394
2012-10-08 17:07:23 +00:00
Guy Harris 9d4d1a5794 col_cleanup() is undoing the allocations that col_init() does, so it's
freeing the allocated array of pointers, not what the pointers ported
to, so it should free col_data.  Note that it does that, and put it
after col_init() in the source file and header file.

Put in a comment explaining the MSVC bug that we're working around with
the casts.

svn path=/trunk/; revision=45393
2012-10-08 17:04:37 +00:00
Evan Huus 7c5f2ec024 Write a short essay in a comment explaining the weirdness that is now the
ephemeral allocation logic.

svn path=/trunk/; revision=45392
2012-10-08 16:42:54 +00:00
Guy Harris 2ab082faca col_data is not necessarily set to point to something g_malloc()ated,
and, if it is, it might be set to point to col_buf, which gets g_free()d
in the next statement, so we shouldn't g_free() it.

svn path=/trunk/; revision=45391
2012-10-08 16:28:13 +00:00
Evan Huus fef6b09666 Explicitly cast away const-ness to fix windows build-bots.
svn path=/trunk/; revision=45390
2012-10-08 15:39:02 +00:00
Evan Huus b6f0d11c6f EDT structures now own their ep_ memory pools. This should finally clean
up the last little bits of:
- https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284
- https://www.wireshark.org/lists/wireshark-dev/201208/msg00128.html

and possibly part of:
- https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7775

This is a fairly invasive change that required some funky work with linked
lists to avoid changing any of the public ep_* APIs, so if something breaks
blame me :)

svn path=/trunk/; revision=45389
2012-10-08 15:23:36 +00:00
Evan Huus 92c3bc0228 Don't leak all of our column data in packet_list_recreate (I think we still leak
some of it?).

Maybe part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7775

svn path=/trunk/; revision=45388
2012-10-08 15:12:45 +00:00
Anders Broman 2c181db864 Fix unused parameters.
svn path=/trunk/; revision=45387
2012-10-08 15:10:24 +00:00
Anders Broman 4856bcfd40 Let ISUP national settings be valid for BICC too.
Extend dissection of Japan ISUP.

svn path=/trunk/; revision=45386
2012-10-08 14:22:24 +00:00
Anders Broman 9f38a46974 From GeorgiaK:
Add Nokia AVP:s

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7799

svn path=/trunk/; revision=45385
2012-10-08 14:20:34 +00:00
Alexis La Goutte 576d1fb8db Update French translations !
svn path=/trunk/; revision=45384
2012-10-08 12:25:23 +00:00
Alexis La Goutte 579eb18a6d Make new text translatable (for QtShark:file_set_dialog.cpp)
and lupdate qtshark.pro (update translation file)
Updating 'qtshark_de.ts'...
    Found 243 source text(s) (45 new and 198 already existing)
Updating 'qtshark_fr.ts'...
    Found 243 source text(s) (45 new and 198 already existing)
    Number heuristic provided 1 translation(s)


svn path=/trunk/; revision=45383
2012-10-08 12:16:54 +00:00
Jakub Zawadzki bf77a26b3f Patch from Florian Fainelli via bug #7772
Cleans up the mask used for the "High" part of the sub-carrier modulation 
to match (modulus the 4-bits shifting) the one used for the "Low" part.

svn path=/trunk/; revision=45382
2012-10-08 12:06:16 +00:00
Jakub Zawadzki cef1e32ede Patch from Florian Fainelli
Fix bug #7772: dissect only the number of active HomePlug AV subcarriers

The dissector currently dissects all 1156 sub-carriers available in the Tone
Map Characteristisc Confirmation frame no matter what is the number of active
ones. 

This is not valid, because the frame only contains the number of active
sub-carriers, even though it is padded to 1156 sub-carriers. This is also an
issue for newest HomePlug AV devices with a 500Mbits/sec PHY rate, because
those will have up to 2690 sub-carriers, and we would only dissect the first
1156 active ones.


svn path=/trunk/; revision=45381
2012-10-08 12:05:14 +00:00
Jakub Zawadzki da00b4089e Continuation of r43335
- ipv6.traffic_class.dscp use ext string so and need BASE_EXT_STRING flag (fix SIGSEGV)
- dscp_vals was removed from .h file, so make it static
- export dscp_vals_ext

svn path=/trunk/; revision=45380
2012-10-08 09:50:47 +00:00
Jakub Zawadzki d6d3e59660 RFC 4627 allows upper case hex digits as well
svn path=/trunk/; revision=45379
2012-10-08 09:48:38 +00:00
Pascal Quantin e835a6f205 Fix crash when exporting packet dissection as plain text on Windows (regression introduced in r45333)
svn path=/trunk/; revision=45378
2012-10-08 09:22:46 +00:00