Use a couple of hf_ entries that were supposed to be used (reported in
comment 3).
I've also fixed two other small bugs I've found :
- Invalid checking of mpeg1_only_flag in the video stream descriptor
- Avoid processing descriptor data if reported length is 0
svn path=/trunk/; revision=41758
This patch adds support for DVB Network Information Table as documented in
ETSI EN 300 468.
The patch also contains additional mpeg descriptors usually found in NIT plus
a few minor bugfix for other descriptors.
svn path=/trunk/; revision=41754
The Group Address (GADDR) TLV, IS-IS TLV type 142, is carried only in an LSP
PDU and carries sub-TLVs that in turn advertise multicast group listeners. It
also contains the Group MAC address Sub TLV. The Group MAC Address (GMAC-ADDR)
sub-TLV is sub-TLV type number 1 within the GADDR TLV. In TRILL, it is used to
advertise multicast listeners.
Reference --- http://tools.ietf.org/html/rfc6326#section-2.1
svn path=/trunk/; revision=41751
popup should also be available through a regular menu. So, make the
"Manually resolve address" function availble in under View->Name Resolution .
(Yes, technically this is an "Edit"-like action, but it just fits so well
under Name Resolution.)
While there, move "Resolve Name" from main_menu_bar_toggle_action_entries[]
into main_menu_bar_entries[] so it doesn't get a (useless) toggle indicator.
(At least as I understand this function, it's supposed to allow you to tell
Wireshark to go off and try to resolve the names in the current frame;
unfortunately it doesn't seem to actually work.)
svn path=/trunk/; revision=41747
Address comments in the bug: fix up some hf issues and use
proto_item_set_len() when necessary.
Added status field dissection to AEM packets.
From me: hf_aem_frequency is an FT_FLOAT and appears to have a length of 4 so
use that length (instead of 5).
svn path=/trunk/; revision=41742
In the packet-slowprotocols dissector, there is a bug in the event notification
dissector. The code uses the incorrect value to skip past the data of a vendor
specific notification.
The attached patch file sets the offset to increment by raw_octet, which
corrects the issue.
svn path=/trunk/; revision=41741
Add support for ETV Data processing & simple MPEG DSM-CC handling.
Witha a change of the name of dissect() in packet-etv.c to dissect-etv_common().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6978
svn path=/trunk/; revision=41735
The attached (trivial) patch adds some missing breaks in switch-case blocks.
This fixes coverity defects #445, #446, #1316 and #1380.
svn path=/trunk/; revision=41727
Fix
Coverity has 3 complaints about this dissector, reported in CID's 1450-1451
CONSTANT_EXPRESSION_RESULT:
Event result_independent_of_operands: (crid & 3) >> 2 is 0 regardless of the
values of its operands [non-specific operand of assignment].
1385 crid_type = (crid &
MPEG_DESCR_CONTENT_IDENTIFIER_CRID_LOCATION_MASK) >> 2;
Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical operand of if).
1512 if (flags & MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK) {
Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical second operand of '&&').
1544 if (offset < end && (flags &
MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK)) {
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6960
svn path=/trunk/; revision=41722
are present. However, still only create the graph for the first/only
one.
LTE MAC or RLC frames often contain multiple SDUs that are segments of
the same TCP conversation - this avoids the need to find a frame with
only one SDU.
svn path=/trunk/; revision=41721
ISAKMP : VendorID CheckPoint : Malformed Packet
Wrong minimum length when there is not CheckPoint "Data" after VendorID
svn path=/trunk/; revision=41718
IKE: Life-Duration wrong displayed in LTV format
The Fix commit in Revision 38387 is wrong
Get the following error message : ISAKMP dissector bug: failed assertion proto.c:2957
use a HF by type (uint32, uint64, bytes...) for life duration
svn path=/trunk/; revision=41717
capture_opts.h. (It arguably belongs somewhere other than in a file in
ui/gtk, but, if so, move it there, e.g. to something in ui.)
svn path=/trunk/; revision=41712
having something in wireshark_LDADD that's filled in by the configure
script means that the items referred to by that string aren't treated as
dependencies.
svn path=/trunk/; revision=41709
Martin Mathieson