Commit Graph

39862 Commits

Author SHA1 Message Date
Guy Harris 9c781b0939 Work around WinPcap bug wherein pcap_open() returns -1 without putting
an error message into errbuf (the bug has been reported to
winpcap-bugs).

Should fix bug 6922.

svn path=/trunk/; revision=41937
2012-04-04 19:13:39 +00:00
Gerald Combs f2977b2f97 Add more protocols and bug 6077 (Rearranging columns on Win64).
svn path=/trunk/; revision=41936
2012-04-04 18:43:37 +00:00
Jeff Morriss fb207b5d5e Fix CID 613: item_str can't be NULL here so don't check for it being NULL.
svn path=/trunk/; revision=41935
2012-04-04 17:16:16 +00:00
Jeff Morriss 6c4697bc93 Fix CID 614: callsinfo can't be NULL here so don't check for it being NULL.
svn path=/trunk/; revision=41934
2012-04-04 16:57:31 +00:00
Jeff Morriss a95dd5cda7 Fix CID 615: strinfo can't be NULL here so don't check for it being NULL.
svn path=/trunk/; revision=41933
2012-04-04 16:55:14 +00:00
Jeff Morriss cc9f72e246 Fix CID 616: callsinfo can't be NULL here so don't check for it being NULL.
svn path=/trunk/; revision=41932
2012-04-04 16:52:18 +00:00
Jeff Morriss 6610b449b0 Fix CID 617: te can't be NULL here (unless si is NULL in which case we've
got bigger problems) so there's no need to check for it being NULL.

svn path=/trunk/; revision=41931
2012-04-04 16:42:48 +00:00
Gerald Combs f934bcd42c Fix compilation on Win64.
svn path=/trunk/; revision=41930
2012-04-04 16:13:35 +00:00
Jeff Morriss df9a7a0b1c Fix CID 1287: rdp_info can't be NULL here so there's no need to check for it
being NULL.

svn path=/trunk/; revision=41929
2012-04-04 15:54:19 +00:00
Anders Broman 6c902761a8 Revert
svn path=/trunk/; revision=41928
2012-04-04 15:42:46 +00:00
Anders Broman 1d60842c59 Update to a version which have getopt_long(). + one file
svn path=/trunk/; revision=41927
2012-04-04 15:24:23 +00:00
Anders Broman 82913779e4 Update to a version which have getopt_long().
svn path=/trunk/; revision=41926
2012-04-04 15:23:47 +00:00
Jeff Morriss e41643f34a Avoid false-positive CID 621: if str is non-NULL, idx should be positive
(so idx won't be negative when used in the else statement).  To avoid
this false positive, add a check if idx is negative to the if(str) check.

Also remove some trailing commas.

svn path=/trunk/; revision=41925
2012-04-04 14:42:25 +00:00
Anders Broman e1233a19b0 Try to fix:
packet-eap.c: At top level:
packet-eap.c:150: error: static declaration of ‘eap_sim_subtype_vals’ follows non-static declaration
../../epan/eap.h:62: note: previous declaration of ‘eap_sim_subtype_vals’ was here
packet-eap.c:159: error: static declaration of ‘eap_aka_subtype_vals’ follows non-static declaration
../../epan/eap.h:72: note: previous declaration of ‘eap_aka_subtype_vals’ was here
packet-eap.c: In function ‘dissect_eap’:
packet-eap.c:668: warning: request for implicit conversion from ‘void *’ to ‘struct conv_state_t *’ not permitted in C++
packet-eap.c:673: warning: request for implicit conversion from ‘void *’ to ‘struct conv_state_t *’ not permitted in C++
packet-eap.c:866: warning: request for implicit conversion from ‘void *’ to ‘struct frame_state_t *’ not permitted in C++
packet-eap.c:927: warning: request for implicit conversion from ‘void *’ to ‘struct frame_state_t *’ not permitted in C++
packet-eap.c:1048: warning: request for implicit conversion from ‘void *’ to ‘struct frame_state_t *’ not permitted in C++
packet-eap.c:1067: warning: request for implicit conversion from ‘void *’ to ‘struct frame_state_t *’ not permitted in C++

svn path=/trunk/; revision=41924
2012-04-04 12:49:09 +00:00
Chris Maynard 523cbecd1a Avoid some potential divide by zero errors that Clang reports.
svn path=/trunk/; revision=41923
2012-04-04 12:47:08 +00:00
Anders Broman a42cb82d65 From Nick Lowe:
- Update eap header file to include SIM and AKA definitions.
- Change the SIM and AKA EAP types to use proto_tree_add_item(). 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020

svn path=/trunk/; revision=41922
2012-04-04 12:32:44 +00:00
Anders Broman 68224296e3 Change to use eap. in filter names isof eap_
svn path=/trunk/; revision=41921
2012-04-04 10:35:48 +00:00
Alexis La Goutte ea2990f586 Add Openwire dissector to CMake too...
svn path=/trunk/; revision=41920
2012-04-04 09:41:03 +00:00
Alexis La Goutte 0b276d3f38 From Metatech via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7014
Here is a dissector for ActiveMQ OpenWire protocol.

A few words about the protocol : 
OpenWire has two wire formats :
- "loose" : more verbose, less CPU-intensive, less network-intensive (1-pass)
- "tight" : more compact, more CPU-intensive, more network-intensive (2-pass)
This dissector only supports the "loose" syntax, which is not the default.
This dissector only supports version 6 of the protocol.
It can be changed on the broker in the activemq.xml file by specifying
"tightEncodingEnabled=false" :


svn path=/trunk/; revision=41919
2012-04-04 09:37:19 +00:00
Anders Broman c9a6e6ec59 From Nick Lowe:
Convert EAP-IDENTITY, EAP-NOTIFY and EAP-MD5 to use proto_tree_add_item().

From me consistently use "proto abbr"_"name".

svn path=/trunk/; revision=41918
2012-04-04 08:04:25 +00:00
Anders Broman 654c3e3fc2 From Pascal Quantin:
Upgrade LTE RRC dissector to v10.5.0.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7032

svn path=/trunk/; revision=41917
2012-04-04 07:47:54 +00:00
Anders Broman 045b55d881 From Martin Kaiser:
DVB-CI: check APDUs against resource id.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7031

svn path=/trunk/; revision=41916
2012-04-04 07:40:20 +00:00
Anders Broman 77b67c7456 From Rolf Fiedler:
Patch to add V5.2 tracing capability on E1 links using EyeSDN probes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7027

Removed preference related stufff as it's not needed.

svn path=/trunk/; revision=41915
2012-04-04 07:33:39 +00:00
Gerald Combs 16a4af2d67 Add and update a bunch of Programs and Features-related registry
keys. Sort the keys by name. Calculate the installation size after all
of the files have been installed and add that in the "EstimatedSize"
key. Fix the display icon. Add a hint about our target platform. Add
version information.

We now look like a grown-up application in the Programs and Features
control panel.

svn path=/trunk/; revision=41914
2012-04-04 00:47:21 +00:00
Jeff Morriss 65a42ddd9a From Nick Lowe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020 :
First patch to start the conversion of the EAP dissector from its use of
proto_tree_add_text() to proto_tree_add_item().

svn path=/trunk/; revision=41913
2012-04-03 21:52:03 +00:00
Jeff Morriss db64559972 From Martin Kaiser (on -dev): initialize an uninitialized variable. From me: also clean up some indentation.
svn path=/trunk/; revision=41912
2012-04-03 21:38:59 +00:00
Graham Bloice 1894786916 Implement spoolss function GetPrinterDriverDirectory (opnum 12).
Also renamed "Architecture" field to "Environment" as per MS docs.

Fix bug #2279

svn path=/trunk/; revision=41911
2012-04-03 20:05:36 +00:00
Jeff Morriss 5adc2792e4 Fix CID 620: since we're checking if the given hf index is positive (since
r15662), move the proto_tree_add_boolean() call (which uses the hf index)
inside the check.

svn path=/trunk/; revision=41910
2012-04-03 17:37:27 +00:00
Gerald Combs e16ff04578 Remove fixed or no-longer-relevant bugs.
svn path=/trunk/; revision=41909
2012-04-03 17:18:34 +00:00
Gerald Combs 794b2ca691 Add a to-do list for more decryption tests.
svn path=/trunk/; revision=41908
2012-04-03 16:10:55 +00:00
Gerald Combs 29917a3181 Fill in the list of new protocols (87 of them!) and new & updated
capture file support.

svn path=/trunk/; revision=41907
2012-04-03 16:03:42 +00:00
Bill Meier 900c2412cd Improve the text of some value_strings.
svn path=/trunk/; revision=41906
2012-04-03 15:38:27 +00:00
Anders Broman 759607c7cc Comment out unused define.
svn path=/trunk/; revision=41905
2012-04-03 14:46:02 +00:00
Anders Broman e8e5d6aa26 Update to V11.1.0 (2012-03)
svn path=/trunk/; revision=41904
2012-04-03 14:12:07 +00:00
Jakub Zawadzki 83adc2d745 Fix off by one shift error introduced in r39531.
In tvb_get_ephemeral_unicode_string() length is number of bytes (not characters).

svn path=/trunk/; revision=41903
2012-04-03 09:28:58 +00:00
Jakub Zawadzki 189b255ddf Fix dependent_frames memleak.
Reviewed-By: Jeff Morriss (http://www.wireshark.org/lists/wireshark-dev/201204/msg00013.html)

svn path=/trunk/; revision=41902
2012-04-03 09:18:16 +00:00
Jeff Morriss cf58e2bd83 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7023 :
For each message, the DVB-CI dissector checks the message size against the
buffer size negotiated at startup. If the buffer size negotation was not
captured, a warning is flagged up for each packet saying its size is too big. 

Obviously, the check only makes sense if we know the negotiated buffer size...

svn path=/trunk/; revision=41901
2012-04-03 01:52:44 +00:00
Martin Mathieson f0798dabd1 Set up table to help with ascii-hex -> hex conversion in advance to
avoid testing static for every conversion.

svn path=/trunk/; revision=41900
2012-04-03 01:49:27 +00:00
Jeff Morriss b4f42921bb Fix a couple of CIDs related to missing breaks: both are intentional[1] so add
comments to that effect.

[1] Based on comment from Lars Roff via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

svn path=/trunk/; revision=41899
2012-04-03 01:25:24 +00:00
Gerald Combs 4326f8de55 Add a test for Zigbee. Compress the 802.11 capture. Fix an error message.
svn path=/trunk/; revision=41898
2012-04-02 18:48:56 +00:00
Michael Tüxen 937df7af18 From Irene Ruengeler: Fix a warning when capturing.
svn path=/trunk/; revision=41897
2012-04-02 17:15:58 +00:00
Gerald Combs 95bd0745b9 Add a test for DTLS decryption.
svn path=/trunk/; revision=41896
2012-04-02 16:37:40 +00:00
Anders Broman e12df043a7 If a comment is cleared, remove it from fdata->opt_comment.
svn path=/trunk/; revision=41895
2012-04-02 15:20:54 +00:00
Anders Broman a24133d747 Fix a couple of typos and missing return for GTK 3.
svn path=/trunk/; revision=41894
2012-04-02 12:23:33 +00:00
Anders Broman 0c481e3e96 Introduce utility function to ease GTK3 depcrecated funktion removal.
svn path=/trunk/; revision=41893
2012-04-02 11:35:53 +00:00
Anders Broman a52545a4c1 From Nick Lowe:
Negate version bits in flags for PEAP, TTLS, FAST.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7019

svn path=/trunk/; revision=41892
2012-04-02 08:00:43 +00:00
Bill Meier 02b9c6460c Use correct values for "alt screen size" for 327x-3 and 327x-4 terminals.
Slightly improve code which tries to keep track of "screen size".
Add a comment as to what is really required to properly keep track
 of the screen size "state".


svn path=/trunk/; revision=41891
2012-04-01 23:06:21 +00:00
Bill Meier 3052f47326 Remove a bad (unterminated) comment; Fixes Buildbot compile error.
svn path=/trunk/; revision=41890
2012-04-01 21:48:17 +00:00
Bill Meier b27ca5bf7e Fix some bugs related to the use of proto_tree_add_bits_item();
Improve details pane display of a few TN3270 fields.

svn path=/trunk/; revision=41889
2012-04-01 21:31:51 +00:00
Michael Tüxen 16421a31cc More whitespace changes...
svn path=/trunk/; revision=41888
2012-04-01 18:16:15 +00:00