osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34873 commits 26 branches 0 tags 795 MiB
Commit graph

14928 commits

Author SHA1 Message Date
Chris Maynard
4d20bdd60d Conversation tracking must be handled whether "tree" is NULL or not. 
svn path=/trunk/; revision=36168
 2011-03-08 18:33:45 +00:00
Jörg Mayer
cf8c877d0d Add support for the pre-rfc DAE port 1700 
svn path=/trunk/; revision=36167
 2011-03-08 18:29:30 +00:00
Bill Meier
d9beb8fcb0 From Martin Kaiser: initialize hdr_tag with NO_TAG 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

svn path=/trunk/; revision=36163
 2011-03-08 13:52:16 +00:00
Sake Blok
f28084f772 Fix for bug 5743 : tshark incorrectly calculates tcp stream for SYN packets when port numbers are re-used 
svn path=/trunk/; revision=36162
 2011-03-08 11:26:34 +00:00
Sake Blok
307c0d70fb Removal of the old packet-list in favor of the new packet list. 
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)


svn path=/trunk/; revision=36161
 2011-03-08 01:52:25 +00:00
Jeff Morriss
e6ce1793e2 Don't pass retransmitted chunks to subdissectors. Instead just mark them as 
retranmissions (in COL_INFO).  (Obviously this only works if TSN analysis is
enabled.)

This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).

svn path=/trunk/; revision=36159
 2011-03-07 19:23:55 +00:00
Anders Broman
aac7fca686 From Alexis La Goutte: 
enhance tag Power Constraint/Capability, TPC Request/Report, Supported Channel, csa 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36158
 2011-03-07 17:46:30 +00:00
Stephen Fisher
664916ad64 Squelch compiler warning: 
packet-dvbci.c: In function 'dissect_dvbci_lpdu':
packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this function
packet-dvbci.c:1153: note: 'hdr_tag' was declared here

By setting hdr_tag = 0, but see question on bug #5654 on whether 0 is a 
good default value or not.


svn path=/trunk/; revision=36157
 2011-03-07 17:01:55 +00:00
Bill Meier
523d4d1cbe From Stefan Metzmacher: smb2 multi-credit / large mtu support 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5729

From me: Update a comment re the "epoch" field: It's now called "credit charge".

svn path=/trunk/; revision=36156
 2011-03-07 16:43:55 +00:00
Anders Broman
24133413b9 Remove a no longer needed struct. 
svn path=/trunk/; revision=36155
 2011-03-07 12:31:49 +00:00
Anders Broman
840b816f05 Remove more obsolete code. 
svn path=/trunk/; revision=36154
 2011-03-07 11:56:21 +00:00
Anders Broman
6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used 
svn path=/trunk/; revision=36153
 2011-03-07 10:01:24 +00:00
Anders Broman
a7e379499d Remove the old code. 
svn path=/trunk/; revision=36152
 2011-03-07 09:36:24 +00:00
Bill Meier
3e92ea5c2f Fix compiler error on Windows 64: cast strlen() to (int); 
Also: Apparently the length of an address of type AT_STRINGZ must include the NULL.

svn path=/trunk/; revision=36151
 2011-03-07 03:10:51 +00:00
Bill Meier
16b528aaf1 From Martin Kaiser: dissector for DVB-CI (Common Interface) 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

From me:
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_...() for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
- (Other minor tweaks);
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;


svn path=/trunk/; revision=36149
 2011-03-07 02:22:48 +00:00
Martin Mathieson
4d3d029e09 Remove some instances of _U_ where the parameter is now used. 
svn path=/trunk/; revision=36148
 2011-03-06 23:10:28 +00:00
Martin Mathieson
d36178cd5d Improve expert info output when detect Scheduling Request 'state machine' problem. 
svn path=/trunk/; revision=36147
 2011-03-06 22:52:33 +00:00
Stig Bjørlykke
3e261511ab Mark value_string_ext bssgp_cause_vals_ext as WS_VAR_IMPORT. 
svn path=/trunk/; revision=36144
 2011-03-06 16:37:21 +00:00
Gerald Combs
c7990056c2 [Automatic manuf, services and enterprise-numbers update for 2011-03-06] 
svn path=/trunk/; revision=36143
 2011-03-06 16:03:46 +00:00
Anders Broman
b4941ca580 Prepare to remove old bssgp code by changing exports. 
svn path=/trunk/; revision=36142
 2011-03-06 09:42:41 +00:00
Anders Broman
9a7ad380af From Alexis La Goutte: 
Enhance tag fh_hopping_.., tclas, tspec, challenge_text...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36141
 2011-03-04 17:40:32 +00:00
Bill Meier
f7be370643 From Stefan Metzmacher: Patch that fixes false positives and allows large smb1/2 pdus 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914



svn path=/trunk/; revision=36140
 2011-03-04 15:09:29 +00:00
Tomas Kukosa
0b9c645150 Fix warning 
svn path=/trunk/; revision=36139
 2011-03-04 14:36:27 +00:00
Tomas Kukosa
3f8b9e87a9 Check only first 14 digits of GeneralizedTime which are fixed, next parts are optional 
svn path=/trunk/; revision=36138
 2011-03-04 14:01:57 +00:00
Anders Broman
7e17176c39 All messages converted to the "GSM style" dissection. 
svn path=/trunk/; revision=36137
 2011-03-04 12:57:55 +00:00
Stephen Fisher
eec3e70821 Change descriptions of NTP Reference Identifier Codes for stratum 1 
servers to match IANA assignment / RFC 5905.  A number of codes already
in Wireshark that aren't assigned were left intact.


svn path=/trunk/; revision=36136
 2011-03-04 00:25:56 +00:00
Stephen Fisher
47b9a1235e Correct the usage of tvb_memeql() after r35558: it doesn't return true 
if the values are the same; we have to check for "== 0" to see if they
are the same. 


svn path=/trunk/; revision=36135
 2011-03-04 00:17:01 +00:00
Stephen Fisher
ed9de27ba1 Change "Reference Clock ID" to "Reference ID" to match RFC5905 (also 
mention this RFC in the comments).


svn path=/trunk/; revision=36134
 2011-03-03 23:48:56 +00:00
Stephen Fisher
4c6e0d3604 Clarify / add explanations for the fields 
svn path=/trunk/; revision=36133
 2011-03-03 23:47:05 +00:00
Jeff Morriss
62edb47987 Add more duplicate fragment tests. 
svn path=/trunk/; revision=36132
 2011-03-03 23:28:32 +00:00
Jeff Morriss
4ed0e07ef0 When reassembling fragments, don't stop looking at fragments just because the 
current fragment pushes us past the reassembled size: it may be that the
current fragment is a duplicate/retransmission and will be ignored.

Also, if we detect a conflict between a previous and the current fragment,
flag the current (conflicting) fragment as FD_OVERLAPCONFLICT.  Do *not* flag
the fragment that got us into the reassembly routine (probably the final
fragment): it is not (may not be) the guilty fragment.

Clean up some spacing.

Also add reassembly tests for duplicate/retransmitted fragments.

svn path=/trunk/; revision=36131
 2011-03-03 20:22:45 +00:00
Anders Broman
675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID 
svn path=/trunk/; revision=36130
 2011-03-03 07:20:34 +00:00
Jeff Morriss
2ea51a7ad2 There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

Remove some unnecessary includes.

svn path=/trunk/; revision=36129
 2011-03-03 03:28:38 +00:00
Jeff Morriss
ad99181031 There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

svn path=/trunk/; revision=36128
 2011-03-03 03:09:21 +00:00
Jeff Morriss
609b1b1e1f Use tvb_memcpy() instead of tvb_get_ptr() + memcpy(). 
Remove a few unnecessary includes.

svn path=/trunk/; revision=36127
 2011-03-03 03:02:03 +00:00
Jeff Morriss
559c1e0d53 Use tvb_ether_to_str(). 
svn path=/trunk/; revision=36126
 2011-03-03 02:41:22 +00:00
Jeff Morriss
212a0274f7 Use tvb_get_guint8() instead of tvb_get_ptr(). 
Remove a few unnecessary includes.

svn path=/trunk/; revision=36125
 2011-03-03 02:32:18 +00:00
Jeff Morriss
26789f5d00 Use tvb_ether_to_str(). 
svn path=/trunk/; revision=36124
 2011-03-03 02:24:44 +00:00
Jeff Morriss
ab2b947088 Make the _to_str() functions in here take a pointer to a TVB and an offset 
rather than (generally) a pointer into the TVB.

Replace some tabs with spaces (for consistency).

Remove a couple unnecessary includes.

svn path=/trunk/; revision=36123
 2011-03-03 02:18:57 +00:00
Anders Broman
6db5c9387b Fix Error: Found non-ASCII characters in packet-ieee80211.c 
svn path=/trunk/; revision=36121
 2011-03-02 16:25:33 +00:00
Anders Broman
3ccb1950a4 From Alexis La Goutte: 
* Add 802.11 Standard Reference
* Reorder IE (Information Element) and define in decimal (the standard use
decimal...) 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36120
 2011-03-02 15:23:38 +00:00
Martin Mathieson
2f6486166f Allow linking back to previous UL tx 32 ms ago. 
svn path=/trunk/; revision=36119
 2011-03-02 11:33:46 +00:00
Martin Mathieson
c5c0195362 Don't overwrite isPhyRetx field for UL frames with DL check. 
svn path=/trunk/; revision=36118
 2011-03-02 11:16:28 +00:00
Martin Mathieson
3fac9089cb After SR failure, allow for another attempt in SR state machine (presumably with a subsequent RACH happening in-between...) 
svn path=/trunk/; revision=36109
 2011-03-01 14:58:51 +00:00
Tomas Kukosa
16bdcb2fbe QSIG: decoding of PSS1InformationElement 
svn path=/trunk/; revision=36108
 2011-03-01 13:01:26 +00:00
Martin Mathieson
0b2e755182 Tweak the way we setup FP R8 info. 
svn path=/trunk/; revision=36107
 2011-03-01 10:54:57 +00:00
Martin Mathieson
aa9102b72f Was reading F in mac-is descriptors the wrong way around... 
svn path=/trunk/; revision=36106
 2011-03-01 10:53:58 +00:00
Gerald Combs
91fe31c9b4 If we encounter an excessively long filter string or one with too many 
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
 2011-03-01 00:50:17 +00:00
Bill Meier
16097406f4 Define some globals as static; Remove uneeded #includes; Whitespace cleanup. 
svn path=/trunk/; revision=36100
 2011-02-28 23:50:01 +00:00
Bill Meier
ef997f2290 Remove unneeded #includes; Add #includes to packet-gsm_rlcmac.c 
svn path=/trunk/; revision=36099
 2011-02-28 23:46:07 +00:00
Bill Meier
093e8f25c4 Define global vars as static; Whitespace cleanup. 
svn path=/trunk/; revision=36098
 2011-02-28 23:09:02 +00:00
Stephen Fisher
191f6622e1 Display the NTP version in COL_INFO so tshark output (without -V) looks 
more like tcpdump.


svn path=/trunk/; revision=36097
 2011-02-28 18:00:34 +00:00
Stig Bjørlykke
002cac81c2 Close UAT file after loading. 
Open files may prevent deleting a used profile with UAT files.

svn path=/trunk/; revision=36096
 2011-02-28 16:11:20 +00:00
Anders Broman
9a7dbb4182 From Pascal Quantin: 
the attached patch should hopefully please the buildbots

svn path=/trunk/; revision=36095
 2011-02-28 15:42:58 +00:00
Anders Broman
4c26d6ccb3 From Pascal Quantin: 
patch to fix the various issues

svn path=/trunk/; revision=36094
 2011-02-28 14:54:22 +00:00
Anders Broman
6eaae55c79 - RE apply checkapi patch. 
- Mark unused parameters (From Pascal Quantin).

svn path=/trunk/; revision=36093
 2011-02-28 14:17:52 +00:00
Anders Broman
7f604b779d From Vincent Helfre: 
I change the void * descr field as an union to either store a pointer or a value.

Hope it solves the problem.

svn path=/trunk/; revision=36092
 2011-02-28 13:55:47 +00:00
Martin Mathieson
ee5202f2d8 When doing sequence analysis, allow for the first SN to be seen not to be 0. 
This will happen if the capture doesn't include the start of this channel.

svn path=/trunk/; revision=36091
 2011-02-28 12:26:26 +00:00
Martin Mathieson
93333d8fa1 Make UL retx use warning, rather than error, expert level. 
svn path=/trunk/; revision=36090
 2011-02-28 12:24:45 +00:00
Anders Broman
e761ed7206 Add private extensions under the right tree. 
svn path=/trunk/; revision=36089
 2011-02-28 11:34:59 +00:00
Anders Broman
6820a81354 Fix checkapi detected errors. 
Missing log message:
From Vincent Helfre:
GSM RLC MAC dissector

There are 2 things remaining to do:

-  Update to Rel 8 the control messages such as Packet Measurement Order, Packet Measurement Report, Packet Cell Change Order, Packet Cell Change Notification…

-  Improve the display by replacing the strings describing the type by a hf field

svn path=/trunk/; revision=36088
 2011-02-28 11:33:27 +00:00
Anders Broman
eec32e9cbc svn path=/trunk/; revision=36087 2011-02-28 09:43:22 +00:00
Anders Broman
8ec8d3fcc3 Export: 
SONtransferRequestContainer
SONtransferResponseContainer
SONtransferCause

svn path=/trunk/; revision=36086
 2011-02-27 21:55:35 +00:00
Anders Broman
da8918838e Add dissection of SonTransfer-IEs. 
svn path=/trunk/; revision=36084
 2011-02-27 19:40:30 +00:00
Anders Broman
a1e94e7e68 Export SourceCellID. 
svn path=/trunk/; revision=36083
 2011-02-27 19:39:07 +00:00
Gerald Combs
1afc546580 [Automatic manuf, services and enterprise-numbers update for 2011-02-27] 
svn path=/trunk/; revision=36080
 2011-02-27 16:03:40 +00:00
Anders Broman
f9a0795e3a Export dissect_gsm_map_ISDN_AddressString_PDU(); 
svn path=/trunk/; revision=36079
 2011-02-27 14:54:26 +00:00
Ronnie Sahlberg
2c7c20667d iSCSI REJECT PDU contains the full header of the offending command as payload. 
Add dissection of this header.


svn path=/trunk/; revision=36078
 2011-02-27 01:11:24 +00:00
Stig Bjørlykke
d188988e83 Added functionality for handling global profiles. 
Global profiles can be installed in a "profiles" directory in the
Global configuration directory, and a global profile will be copied
to the users profiles on first time usage.

svn path=/trunk/; revision=36077
 2011-02-26 17:23:24 +00:00
Anders Broman
2ea4267951 - Add a dissector table for Private Extensions. 
- Use ENC_BIG_ENDIAN.

svn path=/trunk/; revision=36075
 2011-02-26 09:37:43 +00:00
Bill Meier
bec1c07788 From Herbert Oppmann: Fix "RTMP dissector unknown audio codec" 
"
The [...] variable rtmpt_audio_codecs should be enhanced.

According to [Flash Developer's Guide]
10 = HE-AAC and 11 = Speex are missing.

There is also [Adobe "RTMP Specification V1.0]
which additionally lists 3 = INTEL (not used), 7 = G711A, 8 = G711U
and 9 = NellyMoser 16kHz.
"

From me: All but 'Intel (not used)' added to the list of audio codecs


svn path=/trunk/; revision=36073
 2011-02-25 19:17:17 +00:00
Jeff Morriss
06aaf02fba Clean up comments: canaries are also used to pad allocations to an 8-byte boundary. 
svn path=/trunk/; revision=36071
 2011-02-25 15:49:28 +00:00
Anders Broman
ff2bbd35b2 Revert file commited by misstake. 
svn path=/trunk/; revision=36070
 2011-02-25 15:14:12 +00:00
Anders Broman
1b02abc1eb Verify tools fails if wireshark-win32-libs does not exist. 
svn path=/trunk/; revision=36068
 2011-02-25 15:09:05 +00:00
Jeff Morriss
16f704d831 Add a comment explaining what the canary between allocations looks like. 
svn path=/trunk/; revision=36065
 2011-02-25 03:18:02 +00:00
Anders Broman
527942b05a Add exports. 
svn path=/trunk/; revision=36049
 2011-02-24 15:06:16 +00:00
Jeff Morriss
f91b39b686 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5724 : 
Fix a possible bug/crash with rev 36045.

svn path=/trunk/; revision=36048
 2011-02-24 14:49:10 +00:00
Jeff Morriss
f2cd4937bc Initialize option_len to avoid a (false positive) unitialized variable warning. 
svn path=/trunk/; revision=36047
 2011-02-24 14:40:01 +00:00
Jaap Keuter
f75eaab39f From Wade Hennessey: 
Add support for new header options in the KDP protocol.

svn path=/trunk/; revision=36045
 2011-02-24 06:46:47 +00:00
Jaap Keuter
39d38636d1 From Håkon Nessjøen 
Additions:
  More correct way of checking direction of packets
  Support for two new packet types: ping, pingreply

svn path=/trunk/; revision=36042
 2011-02-24 06:22:52 +00:00
Bill Meier
74bc83a85a Fix Bug #5624: "Unknown MMS multipart media is shown in the wrong subtree" 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5624

Do ti = proto_tree_add_text(...,...); yyy=proto_item_add_subtree(ti,...) in the usual manner.

svn path=/trunk/; revision=36039
 2011-02-24 03:46:30 +00:00
Gerald Combs
3de62b03c6 Forward port r36036 from trunk-1.4: Make sure we ep_allocate enough 
memory.

svn path=/trunk/; revision=36037
 2011-02-23 22:49:59 +00:00
Jeff Morriss
2f82a2ee2c From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5708 : 
The ERF record format defines several error flags.

This patch exposes ERF error flags using 'Expert Infos' for highlighting and
counting.

svn path=/trunk/; revision=36035
 2011-02-23 17:54:00 +00:00
Jeff Morriss
cd99f0aef8 From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5709 : 
When Wireshark receives an AgentX Ping-PDU that contains a zero length
'context' identifier it emits the following warning:

14:30:20          Warn Dissector bug, protocol AgentX, in packet 1066:
tvbuff.c:2571: failed assertion "bufsize != 0"


The attached patch prevents the warning message from appearing under that
circumstance.  Note:  This patch will also prevent the warning under all other
conditions where a zero length string is specified anywhere in the protocol
dissector.

svn path=/trunk/; revision=36034
 2011-02-23 17:45:03 +00:00
Jeff Morriss
d8a2cf3c4d From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713 : 
Enhance RIPng
* Replace tvb_memcpy/proto_tree_add_text by proto_tree_add_item
* Remove dependency to packet-ipv6.h
* Remove packet-ripng.h (not needed)

Also update AUTHORS file

From me:
Put a check_col() back and reword (shorten) a couple of the new blurbs.

svn path=/trunk/; revision=36033
 2011-02-23 17:31:03 +00:00
Jeff Morriss
02d491eed9 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713 : 
Enhance PIM 
* Replace struct ip6_hdr/tvb_m by tvb_ip6_to_str
* Remove dependency to packet-ipv6.h

svn path=/trunk/; revision=36032
 2011-02-23 17:00:20 +00:00
Anders Broman
ed66081a4d From Alexis La Goutte: 
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
 2011-02-23 13:51:49 +00:00
Gerald Combs
4783795690 Split get_dns_name() into get_dns_name() and expand_dns_name(). 
In dissect_ms_compressed_string() dissect_mscldap_string() simply call
expand_dns_name() instead of using duplicate (and insecure) code. This
*might* break CLDAP and SMB dissection. If that's the case we should
probably revert get_dns_name() and simplify expand_dns_name().

Fixes infinite recursion errors found by joernchen of Phenoelit.

svn path=/trunk/; revision=36029
 2011-02-23 00:51:02 +00:00
Jaap Keuter
740c1c4aeb Fix for bug 5702: 
In RFC 5102 (for IPFIX), id=128 is defined as "bgpNextAdjacentAsNumber" which
is DST_AS_PEER and id=129 as "bgpPrevAdjacentAsNumber" which is SRC_AS_PEER.

svn path=/trunk/; revision=36028
 2011-02-22 21:19:13 +00:00
Anders Broman
a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Stig Bjørlykke
d9ef8f9ad1 Ensure we always have a valid top_tree for p1.content. This fixes a problem 
with other dissectors using p1.content, such as p7.

Reset global content_type_id so this will be correct in more cases.
This is still not a good solution, because ContentType and Content are
generic objects which may occur individual in P7.

Indicate when to report invalid content-type.

svn path=/trunk/; revision=36025
 2011-02-22 10:23:44 +00:00
Jaap Keuter
af7e7f1004 From Yaniv Kaul: 
This one parses the extended desktop size pseudo-encoding, as specified in
http://www.tigervnc.com/cgi-bin/rfbproto#extendeddesktopsize-pseudo-encoding

svn path=/trunk/; revision=36022
 2011-02-21 21:12:21 +00:00
Martin Mathieson
1660ed63ab Previous UL frame may be 8 OR 16 subframes ago. 
svn path=/trunk/; revision=36020
 2011-02-21 14:43:16 +00:00
Stig Bjørlykke
4428535e56 Added enclosure_item_flags assignment cast. 
svn path=/trunk/; revision=36019
 2011-02-21 11:36:50 +00:00
Stig Bjørlykke
0803f27f23 Added reassembly of segmented SES packages. 
X.225 7.37.1 states that an end SSDU may or may not contain User Data.

This is a fix for bug 5678.

svn path=/trunk/; revision=36018
 2011-02-21 11:00:19 +00:00
Anders Broman
c51faaa9c6 From: Holger Hans Peter Freyther 
The protocol has a simple addition to provide the InService and
OutOfService notification for a MTPL2 link inside the protocol. This
patch adds these types to the type field, stops handing empty packages
to the MTPL3 dissector and fills out the COL_INFO with the type of
the packet.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5706

svn path=/trunk/; revision=36017
 2011-02-20 18:56:52 +00:00
Anders Broman
84a712d07a From Alexis La Goutte: 
Patch 3 : 

Enhance "Header" Tag Element (replace value_string tag_num_vals[] by
range_string tag_num_vals[]...)
Enhance TIM, IBSS, Country Info, (Q)BSS Load, FH Hopping Parameter...



https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36016
 2011-02-20 18:51:59 +00:00
Stig Bjørlykke
5868c7d026 Renamed x411 to p1, x420 to p22 and s4406 to p772 to be consistent 
on the naming policy for X.400 protocols.

svn path=/trunk/; revision=36013
 2011-02-20 17:03:29 +00:00
Gerald Combs
ba1138eb93 [Automatic manuf, services and enterprise-numbers update for 2011-02-20] 
svn path=/trunk/; revision=36012
 2011-02-20 16:03:38 +00:00
Stig Bjørlykke
393a8d83fb Capitalize protocol name. 
svn path=/trunk/; revision=36011
 2011-02-20 16:02:59 +00:00
Stig Bjørlykke
2025f2e5f5 Add changes in r35546 to template and conformation file. 
svn path=/trunk/; revision=36010
 2011-02-20 15:05:21 +00:00
Stig Bjørlykke
632dcd0d77 Add changes in r35384 to template file. 
svn path=/trunk/; revision=36009
 2011-02-20 15:03:09 +00:00
Gerald Combs
46865581e5 Fix Visual C++ code analysis warnings. 
svn path=/trunk/; revision=36007
 2011-02-19 00:05:12 +00:00
Gerald Combs
a6bbdaa849 Fix some dead code and zero division issues found by Clang scan-build. 
In convert_string_case() use g_utf8_strup() instead of converting each
character by hand. Hopefully this won't cause any unexpected changes in
behavior.

svn path=/trunk/; revision=36006
 2011-02-18 22:43:48 +00:00
Gerald Combs
aaeca955a5 Try to fix more Clang scan-build warnings. 
svn path=/trunk/; revision=36005
 2011-02-18 21:44:06 +00:00
Stephen Fisher
e1afac1b89 From Roberto Morro via bug #5701: Change the PCEP dissector's port 
from 1010 to the IANA assigned value of 4189.  From me: Add RFC 5440
to the list of references.


svn path=/trunk/; revision=36004
 2011-02-18 20:48:49 +00:00
Gerald Combs
3e13ddbadc Fix a few errors found by Clang scan-build. 
svn path=/trunk/; revision=36002
 2011-02-18 19:46:05 +00:00
Anders Broman
0e6aa74d54 From Pascal Quantin: 
NAS EPS] Fix display of Authentication (Failure) Parameter IEs

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5704

svn path=/trunk/; revision=36001
 2011-02-18 18:40:29 +00:00
Jeff Morriss
34dc101fcb #if out some (currently) unused functions. 
svn path=/trunk/; revision=36000
 2011-02-18 17:38:46 +00:00
Jaap Keuter
133cbe7581 From Ivan Lawrow: 
The Final CAP Slot field "wpan.cap" in the Superframe Specification for a
beacon is always displayed as zero.

svn path=/trunk/; revision=35999
 2011-02-18 08:02:53 +00:00
Anders Broman
29ddaec6a6 Add more MSG dissection. 
svn path=/trunk/; revision=35998
 2011-02-18 07:00:03 +00:00
Guy Harris
eef8820ab6 Nope, the __declspec(noreturn) didn't suffice - either abort() isn't 
declared as a noreturn function or declaring except_throw() as a
noreturn function isn't good enough.

svn path=/trunk/; revision=35997
 2011-02-18 02:49:46 +00:00
Guy Harris
ed86bc8023 Just for fun, see whether using __declspec(noreturn) on the exception 
routines is sufficient to convince the Visual Studio code analyzer that
REPORT_DISSECTOR_BUG() never returns.  (That would probably require that
abort() be tagged with __declspec(noreturn); let's hope Microsoft did
the right thing there.)

svn path=/trunk/; revision=35996
 2011-02-18 01:28:18 +00:00
Gerald Combs
c223ebe718 Fix more Visual C++ analysis errors. 
svn path=/trunk/; revision=35995
 2011-02-18 01:18:44 +00:00
Gerald Combs
d60527b94f Put WS_MSVC_NORETURN back. 
svn path=/trunk/; revision=35993
 2011-02-18 00:08:03 +00:00
Guy Harris
e654a29b1c config.h is now included, and it defines _WIN32_WINNT. 
svn path=/trunk/; revision=35992
 2011-02-17 23:36:39 +00:00
Gerald Combs
301a4ac9de Fix compilation on Windows. 
svn path=/trunk/; revision=35991
 2011-02-17 23:35:46 +00:00
Gerald Combs
33819c43c8 Add a hint for Visual C++ to DISSECTOR_ASSERT. Hopefully this will 
reduce some of the /analyze false positives.

svn path=/trunk/; revision=35990
 2011-02-17 23:21:07 +00:00
Guy Harris
b4f663a29b On Windows, try putting __declspec(noreturn) in front of declarations of 
routines that don't return.  (This requires that some files include
config.h to get WS_MSVC_NORETURN declared properly.)

svn path=/trunk/; revision=35989
 2011-02-17 23:11:49 +00:00
Gerald Combs
dae5200002 Fix some Visual C++ analysis warnings. 
svn path=/trunk/; revision=35988
 2011-02-17 23:00:34 +00:00
Gerald Combs
da198b3083 Fix gcc compilation errors. 
svn path=/trunk/; revision=35986
 2011-02-17 20:31:11 +00:00
Gerald Combs
1b0516a27e Fix various Visual C++ analysis warnings. 
svn path=/trunk/; revision=35985
 2011-02-17 19:43:16 +00:00
Gerald Combs
51e5e75373 Don't allocate a bunch of memory on the stack for strings that will be 
fed to col_append_fstr; columns have a maximum length of 240 characters
(ITEM_LABEL_LENGTH). Make sure our column text is properly formatted.

svn path=/trunk/; revision=35984
 2011-02-17 19:28:30 +00:00
Stephen Fisher
56d74752d1 Fix dead initialization error found by clang: 
"Value stored to 's' during its initialization is never read"

(it's assigned by a later g_hash_table_lookup call)


svn path=/trunk/; revision=35983
 2011-02-17 18:53:35 +00:00
Guy Harris
b32b4d08bd It wasn't complaining about that null pointer reference. 
svn path=/trunk/; revision=35981
 2011-02-17 18:43:38 +00:00
Stig Bjørlykke
17485dbd86 Fixed no_sua_assoc init. 
svn path=/trunk/; revision=35980
 2011-02-17 11:00:54 +00:00
Anders Broman
31f1c264fb - Introduce association tracking(might not work well with multihoming). 
- prefix hf variables with sua ( hf_sua...)

svn path=/trunk/; revision=35979
 2011-02-17 10:13:05 +00:00
Guy Harris
0b229a4202 Is there an SAL tag that says "this function never returns"? 
svn path=/trunk/; revision=35978
 2011-02-17 09:13:38 +00:00
Guy Harris
d36684f364 Can we reassure Microsoft's static analyzer that 0 <= mask <= 48? 
svn path=/trunk/; revision=35977
 2011-02-17 09:08:11 +00:00
Guy Harris
71b71d920e Oops, wrong pointer comparison. 
svn path=/trunk/; revision=35976
 2011-02-17 08:39:41 +00:00
Guy Harris
8eb8623b15 OK, let's try a couple more explicit checks against NULL, to see whether 
that de-confuses Microsoft's code analyzer.

svn path=/trunk/; revision=35975
 2011-02-17 08:15:05 +00:00
Jaap Keuter
3884e987b6 From Alexis La Goutte : 
A patch to add Vendor ID of VIA Client & Remote AP (from Aruba Networks)
Also add ett_ value for rohc, ike & ike2.

svn path=/trunk/; revision=35974
 2011-02-17 08:03:48 +00:00
Gerald Combs
7b254f46fb Fix some Visual C++ static analyzer complaints. 
svn path=/trunk/; revision=35971
 2011-02-17 01:11:05 +00:00
Gerald Combs
69901e8eba Fix Visual C++ code analysis errors. 
svn path=/trunk/; revision=35970
 2011-02-16 22:57:36 +00:00
Stephen Fisher
64666812e9 Change protocol column from "IEEE 802.11" to "802.11" so it fits in 
the default column width.


svn path=/trunk/; revision=35969
 2011-02-16 21:56:28 +00:00
Guy Harris
ae86d3b411 Put the "MCS known information" field into the protocol tree; yes, it's 
somewhat redundant, as items aren't displayed if they're not known, but
it can make it a little clearer to people who aren't familiar with the
gory details of radiotap (which people just looking at network traffic
might not be).

Clean up some capitalization of field names.

svn path=/trunk/; revision=35968
 2011-02-16 21:08:40 +00:00
Stig Bjørlykke
d3051fa55d Generate correct type (FT_OID) for "x420.compression_algorithm_id". 
I suspect this should have been fixed in asn2wrs...

svn path=/trunk/; revision=35965
 2011-02-16 11:04:28 +00:00
Jeff Morriss
edb9220dee Make swap_mac_addr() take a pointer to a TVB and an offset rather than 
(generally) a pointer into the TVB.

svn path=/trunk/; revision=35964
 2011-02-16 03:36:49 +00:00
Jeff Morriss
45f7c05411 Use tvb_ether_to_str() 
svn path=/trunk/; revision=35963
 2011-02-16 03:30:59 +00:00
Jeff Morriss
feeafce765 Use tvb_ether_to_str(). 
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

svn path=/trunk/; revision=35962
 2011-02-16 03:26:57 +00:00
Jeff Morriss
66b6391c6b Use tvb_ip_to_str() when it can eliminate a tvb_get_ptr() call. 
svn path=/trunk/; revision=35961
 2011-02-16 03:08:45 +00:00
Jeff Morriss
fb99707fa5 Use tvb_ether_to_str() when it can eliminate a tvb_get_ptr() call. 
svn path=/trunk/; revision=35960
 2011-02-16 03:05:13 +00:00
Jeff Morriss
deabd5ce3a Use tvb_ether_to_str() 
svn path=/trunk/; revision=35959
 2011-02-16 03:01:19 +00:00
Jeff Morriss
76edd1b8f5 Rename the _to_str() functions in this dissector to tvb_*_to_str() and make 
the functions take a pointer to a TVB and an offset rather than (generally)
a pointer into a TVB.

Use NULL as the value_ptr in proto_tree_add_bytes_format() since the bytes are
coming straight from the TVB anyway.

Remove unnecessary include file.

svn path=/trunk/; revision=35958
 2011-02-16 02:55:58 +00:00
Jörg Mayer
77047f4ea4 Previously 1 byte TCP payload to port 2000 got interpreted as malformed Skinny 
svn path=/trunk/; revision=35950
 2011-02-15 12:06:39 +00:00
Jaap Keuter
1be49d98a5 From Matthew Parris: 
Display "Day of Year" for January 1 as 1, not 0.

svn path=/trunk/; revision=35949
 2011-02-15 07:14:22 +00:00
Jaap Keuter
bc1832599b From Ania: 
Patch enables decoding CM 7.1(3b) messages and CM5 CallInfoMessage (0x14A).

svn path=/trunk/; revision=35948
 2011-02-14 22:52:14 +00:00
Jaap Keuter
fdca1ea223 Make sure RTP conversations are created. 
svn path=/trunk/; revision=35947
 2011-02-14 20:51:40 +00:00
Stig Bjørlykke
0ac8e7cc8d Put error messages and expert info for illegal UTCTime elements as a 
subtree on the UTCTime element.

svn path=/trunk/; revision=35945
 2011-02-14 10:18:03 +00:00
Jaap Keuter
3c54ea00a9 From Fulko Hew: 
The 'upper bound field is not being displayed in Register and Unregister PDU's.

svn path=/trunk/; revision=35943
 2011-02-13 21:19:26 +00:00
Gerald Combs
5a7ac9140e [Automatic manuf, services and enterprise-numbers update for 2011-02-13] 
svn path=/trunk/; revision=35940
 2011-02-13 16:03:49 +00:00
Anders Broman
f9b379bab5 Advance offsets in the "default" branch to avoid infinite loops. 
** (tshark.exe:4392): WARNING **: Dissector bug, protocol GSM BSSMAP, in packet
194520: More than 1000000 items in the tree -- possible infinite loop
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5688

svn path=/trunk/; revision=35939
 2011-02-13 15:43:17 +00:00
Anders Broman
fcec56cd31 Register BICC by name. 
svn path=/trunk/; revision=35938
 2011-02-13 15:01:34 +00:00
Anders Broman
d8a87d589b Update standard references. 
svn path=/trunk/; revision=35937
 2011-02-13 13:56:30 +00:00
Guy Harris
adfedf3600 Use the p2p_dir names for the direction values, and also list 
P2P_DIR_UNKNOWN as "Unspecified" (to distinguish it from "Unknown" as in
"I don't know what that value means").

svn path=/trunk/; revision=35936
 2011-02-12 20:59:43 +00:00
Anders Broman
35bde0d589 Update dissection of 
3.2.2.103 Speech Codec List
3.2.2.104 Speech Codec
to 3GPP TS 48.008 version 9.4.0 Release 9.

svn path=/trunk/; revision=35935
 2011-02-12 20:17:47 +00:00
Guy Harris
38c6d248e8 When generating the Info column, don't assume the direction is either 
P2P_DIR_SENT or P2P_DIR_RECV - it might be unknown.

Use some #defines for SDP data element IDs, and rename the routine that
gets data elements tor reflect what it does.

svn path=/trunk/; revision=35934
 2011-02-12 20:08:47 +00:00
Guy Harris
a595f69ce4 The lack of _WITH_PHDR in WTAP_ENCAP_BLUETOOTH_H4 means there's no 
pseudo-header, and hence there's no direction indication. Don't set
pinfo->p2p_dir for it.  Use WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR, not
WTAP_ENCAP_BLUETOOTH_H4, for capture files where we have the direction.

Don't assume pinfo->p2p_dir is either P2P_DIR_SENT or P2P_DIR_RECV when
setting the info column in various Bluetooth dissectors; it might be
unknown.

In the HCI H4 dissector, put the direction into the info column
regardless of whether we have a type match or not; the dissectors for
HCI packet types appear to assume it's been set (as they put a blank at
the beginning of the stuff they append to the direction).

svn path=/trunk/; revision=35933
 2011-02-12 19:59:41 +00:00
Jeff Morriss
ba3f31d873 Register an ett_ variable. 
svn path=/trunk/; revision=35928
 2011-02-12 03:52:05 +00:00
Jeff Morriss
21cf6ff3ce Remove an unused ett_ variable. 
svn path=/trunk/; revision=35927
 2011-02-12 03:51:12 +00:00
Jeff Morriss
e92dd56b71 Register a bunch of ett_ variables. 
Use gint (instead of int) for ett_ variables (for consistency only).

svn path=/trunk/; revision=35922
 2011-02-11 21:27:46 +00:00
Anders Broman
5fbe65d670 Update 8.12 Indication IE to 3GPP TS 29.274 version 9.4.0 Release 9 
svn path=/trunk/; revision=35921
 2011-02-11 21:21:45 +00:00
Jeff Morriss
947ca59731 Register a couple of ett_ variables. 
Move the declaration of all the ett_ variables after the hf_ variables
(instead of in between some of them).

svn path=/trunk/; revision=35920
 2011-02-11 21:15:41 +00:00
Jeff Morriss
fc45d04c22 Register a couple ett_ variables. Declare all the ett_ variables together. 
svn path=/trunk/; revision=35919
 2011-02-11 21:13:38 +00:00
Guy Harris
ab15a35f65 Don't assume we're on port 631. 
svn path=/trunk/; revision=35916
 2011-02-11 09:28:05 +00:00
Jaap Keuter
ff7eeffdb9 From Joe McEachern: 
Add support the 6RD DHCP option defined in RFC 5969.

svn path=/trunk/; revision=35915
 2011-02-11 08:00:21 +00:00
Guy Harris
0d9152e782 Register for the media type "application/ipp", so *any* HTTP request or 
response with that content type will be dissected as IPP.

svn path=/trunk/; revision=35914
 2011-02-11 05:54:34 +00:00
Jeff Morriss
be81bc949a Rename arphrdaddr_to_str() to tvb_arphrdaddr_to_str() and make it take a pointer a TVB 
and an offset instead of (generally) a pointer into a TVB.

svn path=/trunk/; revision=35913
 2011-02-11 03:33:11 +00:00
Jeff Morriss
0f59bc7c45 Rename vines_to_str() to tvb_vines_to_str() and make it take a pointer a TVB 
and an offset instead of (generally) a pointer into a TVB.

Move most of the contents of packet-vines.h into packet-vines.c: the moved
content is only needed in that file.

svn path=/trunk/; revision=35912
 2011-02-11 03:13:24 +00:00
Jeff Morriss
d8659693ef Check for places where tvb_bytes_to_str() or tvb_get_bytes_to_str_punct() 
should be used (instead of the non-tvb functions with a call to tvb_get_ptr()).

Use those functions in a bunch of places.

svn path=/trunk/; revision=35911
 2011-02-11 02:43:07 +00:00
Martin Mathieson
f30d00e00a Show subheaders summary in subheader root item. 
svn path=/trunk/; revision=35908
 2011-02-11 00:29:40 +00:00
Jeff Morriss
b1d4ef8851 Use tvb_ip_to_str() and tvb_ether_to_str(). 
svn path=/trunk/; revision=35905
 2011-02-10 22:14:05 +00:00
Jeff Morriss
b58b5b5c67 Pass NULL as the value_ptr to proto_tree_add_bytes_format(). 
Simplify the code a bit since tvb_ensure_bytes_exist() was already throwing
an exception if all the bytes weren't there.

Use tvb_ether_to_str().

svn path=/trunk/; revision=35904
 2011-02-10 22:07:29 +00:00
Anders Broman
61515ab830 From Alexis La Goutte: 
Cleanup 802.11 Dissector :Enhance SSID, Supported Rates, DS, FH, CFP.. Information Element sub dissector 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=35903
 2011-02-10 21:45:36 +00:00
Chris Maynard
8d47cebd00 Declare ett's as gint, not guint. 
svn path=/trunk/; revision=35902
 2011-02-10 20:55:26 +00:00
Jeff Morriss
50e1634f4c Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value() 
so that if the start_ptr is NULL the bytes are extracted from the given TVB
using the given offset and length.

Replace a bunch of:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...])

with:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...])

svn path=/trunk/; revision=35896
 2011-02-10 16:31:00 +00:00
Michael Tüxen
7154ed5689 Obtained from Thomas Dreibholz: Update SCTP PPIDs. 
svn path=/trunk/; revision=35895
 2011-02-10 12:54:20 +00:00
Stig Bjørlykke
1ba57f4c04 Added a dissector table for AttributeId localForm. 
Use correct object identifier in ModificationList.

svn path=/trunk/; revision=35894
 2011-02-10 10:11:38 +00:00
Anders Broman
60297df554 - Add message name to info col in case of SERVICE REQUEST. 
- Get rid of check_col
- proto_tree_add_item -> ENC_BIG_ENDIAN

svn path=/trunk/; revision=35893
 2011-02-10 08:28:18 +00:00
Jeff Morriss
a67d2b9bf7 Use tvb_bytes_to_str_punct() instead of a homegrown version. 
svn path=/trunk/; revision=35892
 2011-02-09 22:43:06 +00:00
Jeff Morriss
685c29d386 Use tvb_bytes_to_str_punct() instead of bytestring_to_str(tvb_get_ptr(), ...) 
svn path=/trunk/; revision=35891
 2011-02-09 22:37:26 +00:00
Jeff Morriss
1d396a69e0 Register ett_gtp_bcm. 
Replace some tabs with spaces.


svn path=/trunk/; revision=35890
 2011-02-09 18:45:32 +00:00
Jaap Keuter
4ac0559b63 From Grzegorz Szczytowski: 
Update of packet-e212.c dissector according to local national regulatory 
MNC assignment document.
www.uke.gov.pl/uke/redir.jsp?place=galleryStats&id=24439

svn path=/trunk/; revision=35889
 2011-02-09 08:46:21 +00:00
Jeff Morriss
13d8e41e0f A couple of dissectors have/need an NTP-to-nstime routine, so put it in 
packet-ntp and export it to the other dissectors.

Move some macros (now) only used in packet-ntp.c into that file.

svn path=/trunk/; revision=35887
 2011-02-09 03:24:12 +00:00
Jeff Morriss
92cd49b4c2 Rename ntp_fmt_ts() to tvb_ntp_fmt_ts() and make it take a pointer to a TVB and 
an offset instead of (generally) a pointer into the TVB. Then use the standard
accessor functions to get data out of the TVB.


svn path=/trunk/; revision=35886
 2011-02-09 03:00:51 +00:00
Jeff Morriss
5d3a4a06bc Rewrite this dissector's NTP-to-nstime routine to take a TVB and an offset 
instead of a pointer into the TVB.  Then use the standard accessor functions
to get data out of the TVB.


svn path=/trunk/; revision=35885
 2011-02-09 02:54:12 +00:00
Jeff Morriss
a527fa4b49 Add NTP times using proto_tree_add_item(). 
Replace a couple not-very-descriptive blurbs with NULL.

svn path=/trunk/; revision=35883
 2011-02-09 02:27:41 +00:00
Anders Broman
87aaac83ce From Holger Freyther: 
Fix the GSMTAP to TETRA table

GSMTAP has the BSCH at 1... this means the table needs to have 9 entries, the
first being 0. 


--------------------------------------------------------------------------------

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659

svn path=/trunk/; revision=35882
 2011-02-08 22:01:33 +00:00
Anders Broman
771445d49a from Václav Horčák: 
Bug 5663 - [PATCH] Fix for MEGACO dissector context tracking.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5663

svn path=/trunk/; revision=35880
 2011-02-08 12:33:34 +00:00
Anders Broman
211e3a1eef - Use ENC_BIG_ENDIAN. 
- GSM_A_PDU_TYPE_BSSMAP.

svn path=/trunk/; revision=35879
 2011-02-08 12:32:34 +00:00
Guy Harris
fd941f3906 Don't look at any of the fields that come from the Auxiliary Security 
Header unless there *is* an Auxiliary Security Header.

svn path=/trunk/; revision=35878
 2011-02-08 06:55:53 +00:00
Jeff Morriss
045037dc71 Add NTP times using proto_tree_add_item(). 
svn path=/trunk/; revision=35876
 2011-02-08 03:16:35 +00:00
Jeff Morriss
b87a80f196 Add support for 4-byte NTP times (only the seconds) in proto_tree_add_item(). 
Use it in packet-diameter.c .  Eliminate an unnecessary local variable.

svn path=/trunk/; revision=35875
 2011-02-08 02:38:51 +00:00
Guy Harris
9d6671bbab The checkAPI script doesn't understand arrays of value_string tables, 
and that flavor of two-dimensional array requires you to declare a
maximum size for the value_string tables in the array.  Don't use an
array of value_string tables.

svn path=/trunk/; revision=35871
 2011-02-08 00:57:21 +00:00
Stephen Fisher
68b0cd7030 Fix bug #5657: Update my mail address 
svn path=/trunk/; revision=35868
 2011-02-07 23:14:54 +00:00
Jaap Keuter
d265580072 From Masashi Honma: 
Currently the Wireshark does not support Primary Device Type dissection. 
I made a patch for the dissection based on "Wi-Fi Simple Configuration 
Specification DRAFT Version 2.0.0.51".

svn path=/trunk/; revision=35867
 2011-02-07 22:47:43 +00:00
Anders Broman
42145f2e7c from Holger Freyther: 
gsmtap: Update header file, add tetra support

0001 Minor cleanup - made it look crocked in visual studio, changed bu hand.
0002 Update the definitions from the 'upstream' source 
0003 First bits of tetra decoding included in GSMTAP 
0004 Pass the tetra PDUs to the TETRA decoder 

Changed def. of gsmtap_to_tetra to make it compile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659

svn path=/trunk/; revision=35864
 2011-02-07 21:38:55 +00:00
Anders Broman
1d7c05c898 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Enhance add_tagged_field (and sub tagged field dissector)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=35863
 2011-02-07 20:50:13 +00:00
Bill Meier
121c65c613 Remove unneeded #includes (stdio.h,stdlib.h); 
Whitespace cleanup: trailing, indentation, "4-space tabs"

svn path=/trunk/; revision=35850
 2011-02-07 18:49:29 +00:00
Guy Harris
bd06390b7f Update URL (the document now includes all updates through Technical 
Corrigendum 1; presumably that's the "c1").

svn path=/trunk/; revision=35846
 2011-02-07 18:35:22 +00:00
Gerald Combs
8ae09e055c Mark a parameter unused. 
svn path=/trunk/; revision=35845
 2011-02-07 18:05:26 +00:00
Anders Broman
47cc39a0bb Use value_string_ext and ENC_BIG_ENDIAN. 
svn path=/trunk/; revision=35844
 2011-02-07 17:45:49 +00:00
Anders Broman
553cf70a68 Dissect V1 version , found in trace from: 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637

svn path=/trunk/; revision=35843
 2011-02-07 17:44:34 +00:00
Anders Broman
55f45d5266 Add a missing IE found in trace from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637 
svn path=/trunk/; revision=35842
 2011-02-07 17:43:26 +00:00
Guy Harris
4f7ae8bf3a For FT_{ABSOLUTE,RELATIVE}_TIME, make the rest of the encoding 
orthogonal to the byte order.

This means that we can't just test for a non-zero encoding to determine
whether the format is big-endian or little-endian when we set the
field's endianness flag; instead, for the types where we accept any
non-zero value as meaning "litle-endian", map it to ENC_LITTLE_ENDIAN.

When we use ENC_TIME_NTP, OR in the byte order flag.  While we're at it,
in the dissectors that used ENC_TIME_NTP, update all the other encoding
items in proto_tree_add_item() calls to use the appropriate ENC_ value.

svn path=/trunk/; revision=35841
 2011-02-07 08:18:12 +00:00
Jeff Morriss
8fc6e28b6a Add support for passing NTP times to proto_tree_add_item() by specifying 
an encoding of ENC_TIME_NTP.

This increases the number of decimal places shown for NTP times (from 6 to 9),
so round the value to the nearest microsecond.  (I can't tell if NTP times are
ever more precise than a microsecond--this rounding is mainly to be closer to
the old behavior.)

Use proto_tree_add_item() for some NTP times.

svn path=/trunk/; revision=35840
 2011-02-07 03:31:40 +00:00
Gerald Combs
4c44a66e43 [Automatic manuf, services and enterprise-numbers update for 2011-02-06] 
svn path=/trunk/; revision=35837
 2011-02-06 16:03:43 +00:00
Anders Broman
e373d9b454 From Alexis La Goutte: 
A patch to enhance add_fixed_field dissector 
* Replace proto_tree_add_uint/boolean/... by proto_tree_add_item
* Replace some macro by bitmask (TSI..)
* Other stuff...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5656

svn path=/trunk/; revision=35836
 2011-02-06 14:15:12 +00:00
Anders Broman
01ef9f73ef Remove debug printouts. 
svn path=/trunk/; revision=35834
 2011-02-05 14:37:52 +00:00
Tomas Kukosa
8b6e2eac3d Fix checkAPIs errors 
svn path=/trunk/; revision=35831
 2011-02-04 19:10:35 +00:00
Sake Blok
61d592c8ad Fix for bug 5645 : Ethernet packets with both VLAN tag and LLC header no longer displayed correctly 
svn path=/trunk/; revision=35830
 2011-02-04 17:12:47 +00:00
Anders Broman
80b18d0a15 Get rid of check_col(). 
svn path=/trunk/; revision=35829
 2011-02-04 16:28:26 +00:00
Anders Broman
eb9f184991 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Start Header Field by hf_80211_*

Part 16(Final)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5647

svn path=/trunk/; revision=35824
 2011-02-04 16:21:58 +00:00
Anders Broman
d53865f5e3 Get rid of check_col(). 
svn path=/trunk/; revision=35823
 2011-02-04 16:13:44 +00:00
Anders Broman
b723ccb30c Introduce preferences to set the strictness of Invoke/response 
tracking.

svn path=/trunk/; revision=35822
 2011-02-04 16:12:59 +00:00
Jeff Morriss
2195eb44bd Mark a parameter as unused. 
svn path=/trunk/; revision=35821
 2011-02-04 15:19:46 +00:00
Jeff Morriss
edc42ccfdd Mark some parameters as unused. 
Add a format string to some proto_tree_add_text()s.

Add a cast.

svn path=/trunk/; revision=35820
 2011-02-04 15:19:27 +00:00
Tomas Kukosa
e3808393e1 Erlang Port Mapper Daemon protocol updated and Erlang Distribution Protocol implemented 
svn path=/trunk/; revision=35819
 2011-02-04 14:10:37 +00:00
Anders Broman
da9d25c9eb From Samu Varjonen: 
Bug fix: Incorrect presentation of Domain Identifier type and length in HIP dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5649

svn path=/trunk/; revision=35818
 2011-02-04 12:30:42 +00:00
Anders Broman
758dc5b9a3 Fix Bug 5500 - failed assertion in ISAKMP dissector (proto.c:4002) 
By reinseringt the check in proto_tree_move_item() if tree vissible
removed in http://anonsvn.wireshark.org/viewvc?view=rev&revision=32443
Hopefully not breaking tshark again.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5500

svn path=/trunk/; revision=35817
 2011-02-04 12:16:26 +00:00
Anders Broman
95e14efafd From Alexis La Goutte: 
Patch to fix a typo error....

svn path=/trunk/; revision=35816
 2011-02-04 11:52:50 +00:00
Martin Mathieson
7d5ffdb44b Show some top-level info about PDCP frame in protocol root. 
Especially useful when PDCP is called from RLC.

svn path=/trunk/; revision=35815
 2011-02-04 11:47:38 +00:00
Anders Broman
6d269f2713 From Václav Horčák: 
Fix keeps  parser function in scope of current transactions, allowing multiple
transaction in one packet. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3420

svn path=/trunk/; revision=35814
 2011-02-04 11:45:37 +00:00
Anders Broman
3431f32a38 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Start Header Field by hf_80211_*

Part 10 - 15
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5647

svn path=/trunk/; revision=35810
 2011-02-04 10:04:50 +00:00
Anders Broman
06e619bf42 If ENBname is text, append the text. 
svn path=/trunk/; revision=35808
 2011-02-04 09:38:36 +00:00
Jaap Keuter
1048f71f5d From David Carne: 
col_set_str simply stores the pointer passed to it, and luaL_checkstring
returns a temporary pointer. Changing col_set_str to col_add_str in
Columns_newindex seems to fix the issue.

svn path=/trunk/; revision=35795
 2011-02-03 23:17:31 +00:00
Jeff Morriss
8ee172d021 Store the result of tvb_get_ntohs() in a guint16 instead of a guint8 to avoid a 
compiler warning.  (It looks like the only expected values will fit in 8 bits,
but it also appears that the code really is expecting 'of_code' to be stored in
16 bits on the wire.)


svn path=/trunk/; revision=35790
 2011-02-03 22:04:19 +00:00
Jaap Keuter
806bb18a7b From Roberto Morro: 
- add PATH-KEY object, PKSv4 and PKSv6 subobjects in ERO (RFC5520)
- new METRIC types, Objective Function (OF) object and TLV (RFC5541)
- new RP object Flags
- restructured PCEP_ERROR object dissection (easier to add new 
  error_types, error_values)

svn path=/trunk/; revision=35789
 2011-02-03 20:14:38 +00:00
Jeff Morriss
2832bf5aa1 Include packet-tetra.h in the source distribution. 
svn path=/trunk/; revision=35787
 2011-02-03 19:01:19 +00:00
Guy Harris
3908493548 Use the right proto_tree * variable. 
Clean up indentation.

svn path=/trunk/; revision=35786
 2011-02-03 18:15:56 +00:00
Anders Broman
5d6c22fdb8 Dissect Erroneous message. 
svn path=/trunk/; revision=35785
 2011-02-03 17:45:17 +00:00
Anders Broman
f0a410b170 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Start Header Field by hf_80211_*

Part 6 - 9
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5647

svn path=/trunk/; revision=35783
 2011-02-03 17:35:16 +00:00
Anders Broman
690d412c5a - Use the right tree for IE's 
- Dissect MME and VLR name
- Add strings to some IE's

svn path=/trunk/; revision=35782
 2011-02-03 16:36:22 +00:00
Anders Broman
6b38bce9c6 Hope fully this will be the correct set of files - finally. 
svn path=/trunk/; revision=35781
 2011-02-03 16:17:10 +00:00
Guy Harris
133e639dab Get rid of extra blank line at the end of the file. 
svn path=/trunk/; revision=35779
 2011-02-03 08:16:08 +00:00
Jaap Keuter
a54400c59f From Samu Varjonen: 
This patch fixes four issues with the Host Identity Protocol (HIP dissector:

1. The incorrect parsing of the "type 1" locator of HIP. 
2. Updates the comments to reflect the approval of RFC 5770.
3. Cosmetic change (uppercase SPI)
4. Change in the checksum dissection 
   (when the HIP packet is UDP encapsulated 0 checksum is correct).

svn path=/trunk/; revision=35777
 2011-02-03 06:32:35 +00:00
Martin Mathieson
6b4acef729 Allow PDCP dissector to be called for complete SDUs from UM RLC PDUs. 
svn path=/trunk/; revision=35775
 2011-02-02 23:23:07 +00:00
Martin Mathieson
82cbbca3e5 Add and use accessors to get/set per-packet data for LTE MAC. 
This will allow plugins to use the dissector.

svn path=/trunk/; revision=35774
 2011-02-02 23:21:16 +00:00
Anders Broman
ac057f8445 From Alexis La Goutte: 
A series of patch to enhance 802.11 Dissector : Start all Header field by hf_80211_*
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5647

svn path=/trunk/; revision=35772
 2011-02-02 23:09:41 +00:00
Jaap Keuter
9e367f5cff From njohnkev: 
Add support for LAPD data link type.

svn path=/trunk/; revision=35771
 2011-02-02 22:49:40 +00:00
Anders Broman
f02c4d6685 Warning: packet-tetra.c does not have an SVN Id tag. 
Error: the blurb for field "Carrier Number" ("tetra.carrier") matches the field name in packet-tetra.c
Error: the blurb for field "PDU" ("tetra.pdu") matches the field name in packet-tetra.c
Error: Found deprecated APIs in packet-tetra.c: dissector_add

svn path=/trunk/; revision=35769
 2011-02-02 21:06:51 +00:00
Anders Broman
9f45ee9883 From Alexis La Goutte: 
Cleanup renaming hf 80211 Part7.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

svn path=/trunk/; revision=35768
 2011-02-02 20:21:18 +00:00
Anders Broman
3d32921095 From Alexis La Goutte: 
Cleanup renaming hf 80211 Part 8 and 9.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

svn path=/trunk/; revision=35767
 2011-02-02 20:19:02 +00:00
Anders Broman
2395973d17 Integrate and build the tetra dissector. 
svn path=/trunk/; revision=35766
 2011-02-02 20:11:02 +00:00
Anders Broman
16f1460763 From Alexis La Goutte: 
Fix checkhf error (hf_ieee80211_ff_mesh_mgt_ie_id) and enhance dissect Mesh ID 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5636

svn path=/trunk/; revision=35764
 2011-02-02 19:54:14 +00:00
Anders Broman
94d8b44aec Use gprscdr to dissect CDRs. 
svn path=/trunk/; revision=35763
 2011-02-02 17:51:00 +00:00
Anders Broman
a740413286 Move gprscdr to dissectors with warnings. 
svn path=/trunk/; revision=35762
 2011-02-02 17:50:12 +00:00
Anders Broman
5bb082fde0 Build gsmcdr. 
svn path=/trunk/; revision=35761
 2011-02-02 17:16:29 +00:00
Anders Broman
ba18fd9cc7 Add packet-gprcdr.[ch] to SVN. 
svn path=/trunk/; revision=35760
 2011-02-02 17:15:27 +00:00
Anders Broman
6d4964bb49 Export more functions. 
svn path=/trunk/; revision=35757
 2011-02-02 17:09:05 +00:00