osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34873 commits 26 branches 0 tags 795 MiB
Commit graph

14928 commits

Author SHA1 Message Date
Bill Meier
23eaca915b Don't assign to a proto_item* if the value won't be used: Coverity 941 
svn path=/trunk/; revision=36336
 2011-03-25 22:13:33 +00:00
Bill Meier
ea10c028b1 Don't assign to a proto_item* if the value won't be used: Coverity 958-961. 
svn path=/trunk/; revision=36335
 2011-03-25 21:52:56 +00:00
Bill Meier
7d8633af66 Don't assign to a proto_item* if the value won't be used: Coverity 852,854; 
Add a hidden item to the correct subtree: Coverity 853.

svn path=/trunk/; revision=36334
 2011-03-25 21:09:28 +00:00
Jeff Morriss
38b9f1cfbd As suggested by Didier in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to some more dissectors.

svn path=/trunk/; revision=36333
 2011-03-25 20:04:54 +00:00
Jeff Morriss
cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
 2011-03-25 19:02:18 +00:00
Chris Maynard
28ef67fb39 Change urb_type from FT_STRING to FT_UINT8. This fixes the display filtering 
for this field.  This change was prompted because of the following query:
    http://ask.wireshark.org/questions/3113/usburb_type-values

Also, remove 2 unused fields found by running tools/checkhf.pl.

svn path=/trunk/; revision=36331
 2011-03-25 18:51:12 +00:00
Jeff Morriss
2c8e2564f6 Fix the problem reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3785#c14 : 
If we thought we finished reassembly (and called the subdissector) only to find
out that the subdissector asked for more data, handle the case where the
subdissector asked for DESEGMENT_UNTIL_FIN.  Previously we only handled the
possibility that the subdissector would ask for a specific number of bytes or
DESEGMENT_ONE_MORE_SEGMENT.

svn path=/trunk/; revision=36330
 2011-03-25 15:45:37 +00:00
Ronnie Sahlberg
f4a8e83704 remove two unused assignments 
coverity 1050


svn path=/trunk/; revision=36329
 2011-03-25 07:26:17 +00:00
Ronnie Sahlberg
79e0b02dcd use the newly created tree to store the new items instead of the parent tree 
coverity 842


svn path=/trunk/; revision=36328
 2011-03-25 07:22:23 +00:00
Ronnie Sahlberg
b48b51293d remove unused variable 
coverity 229


svn path=/trunk/; revision=36327
 2011-03-25 07:19:15 +00:00
Ronnie Sahlberg
8d93bec973 remove an unused variable 
coverity 1044


svn path=/trunk/; revision=36326
 2011-03-25 07:15:48 +00:00
Ronnie Sahlberg
d8f7b6f1ae remove assignment of an unused value 
coverity 1178

svn path=/trunk/; revision=36324
 2011-03-25 03:07:05 +00:00
Gerald Combs
2ea9b63ee7 If a segment looks like a retransmission, don't mark it out-of-order. 
svn path=/trunk/; revision=36323
 2011-03-25 00:28:47 +00:00
Bill Meier
e402e91dd1 Don't assign to a proto_item* if the value won't be used: 
Also: Fix a bug wherein PPP_RTP_CUD8 was being registered
 to "ppp.protocol" with the cudp16 handle rather than the cudp8 handle.

Coverity 1004-1013

svn path=/trunk/; revision=36322
 2011-03-24 23:34:13 +00:00
Bill Meier
845612e450 Fix a compile warning: unused variable 
svn path=/trunk/; revision=36320
 2011-03-24 23:05:36 +00:00
Gerald Combs
fcf51fc73b Add initial pcapng name resolution record support. Wireshark has read 
support; TShark has read+write support. Additionally TShark can read a
"hosts" file and write those records to a capture file.

This uses "struct addrinfo" in many places and probably won't compile on
some platforms.

svn path=/trunk/; revision=36318
 2011-03-24 22:47:57 +00:00
Bill Meier
57833dc778 Don't assign to a proto_item* if the value won't be used: Coverity 942-951 
Also: minor Code & Whitespace cleanup.

svn path=/trunk/; revision=36317
 2011-03-24 22:27:20 +00:00
Stephen Fisher
df50d409fb Only display the 3 digits of precision after the decimal that we have 
from the ICMP conversation response time tracking. 


svn path=/trunk/; revision=36316
 2011-03-24 21:22:07 +00:00
Bill Meier
78dda7cc7e Don't assign to a proto_item* if the value won't be used: Coverity 1124-1128; 
Also: minorwhitespace cleanup.


svn path=/trunk/; revision=36314
 2011-03-24 20:17:22 +00:00
Chris Maynard
9493ebe8e9 Display the value of the ICMP echo request/reply response time in milliseconds. 
svn path=/trunk/; revision=36313
 2011-03-24 18:05:10 +00:00
Tomas Kukosa
7755178447 Export next_tvb_... functions 
svn path=/trunk/; revision=36311
 2011-03-24 16:21:31 +00:00
Jeff Morriss
01ec42762f From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 3 :
Enhance MySQL : Request/Response sub-dissector/function 
(white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()...)

Patch 4 :
Enhance MySQL : packet_ok, server, capa sub-dissector/function (white space
changes, use ENC_NA when appropriate, use proto_tree_add_item()...)

Split mysql_dissect_caps in mysql_dissect_caps_client and
mysql_dissect_caps_server

Rename mysql_dissect_ext_caps to mysql_dissect_ext_caps_client

svn path=/trunk/; revision=36309
 2011-03-24 15:31:52 +00:00
Anders Broman
db3a34973a Beutify IMEISV IE output. 
svn path=/trunk/; revision=36308
 2011-03-24 10:36:39 +00:00
Anders Broman
d11e6439cd Fix Checkapi errors 
Error: the name for field " N32" ("gsm_rlcmac_dl.n32") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N51" ("gsm_rlcmac_dl.n51") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N26" ("gsm_rlcmac_dl.n26") has leading space in packet-gsm_rlcmac.c

svn path=/trunk/; revision=36307
 2011-03-24 10:35:29 +00:00
Anders Broman
4cd37afb6c From Vincent Helfre: 
I updated again the csn1 dissector to associate hf_field to each element.

svn path=/trunk/; revision=36306
 2011-03-24 09:20:14 +00:00
Jeff Morriss
bb61772be7 From Dirk: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2930 : 
Make the image (png, gif, jfif) dissectors "new style" so that they don't
dissect data that does not belong to them.

Modify the HTTP dissector to call heuristic dissectors on the body if the
registered subdissector does not accept/dissect the data.

From me: don't use assert() and don't add a preference to the HTTP dissector
for this behavior: it makes sense to behave like that by default.

svn path=/trunk/; revision=36305
 2011-03-24 02:49:05 +00:00
Jeff Morriss
8c73d0c6f4 If we've already seen a segment which starts a multi-segment pdu (i.e., it's 
a retransmission), don't add it to the list (tree) of multi-segment pdus.

Otherwise, if we'd already seen the rest of the pdu and the other segments
were not retransmitted, the retransmission would break dissection of the pdu
because lookups for the segment would find the retransmission (to which the
other segments were not attached).

Since we know this segment is a retransmission, don't bother handing it off
to the subdissector either.

Use PINFO_FD_VISITED().
Add some white space in the desegmentation routine to improve readability.

Apply the same changes to the SSL dissector.

svn path=/trunk/; revision=36304
 2011-03-24 02:10:04 +00:00
Ronnie Sahlberg
5f502a5bfb remove a conditional that can never be true 
coverity 247


svn path=/trunk/; revision=36301
 2011-03-23 21:17:29 +00:00
Chris Maynard
276e9cced3 Add ICMP echo request/reply conversation tracking. Closes bug 5770. 
svn path=/trunk/; revision=36298
 2011-03-23 20:20:40 +00:00
Jeff Morriss
e7a6230eca From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 1 :
Enhance MySQL : Reorder hf and Proto_reg

Patch 2 :
Enhance MySQL : white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()

svn path=/trunk/; revision=36296
 2011-03-23 19:12:24 +00:00
Bill Meier
95402cf9de Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)' 
Coverity 345

svn path=/trunk/; revision=36293
 2011-03-23 15:21:18 +00:00
Bill Meier
ae465d5d39 Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)' 
Coverity 346 & 347

svn path=/trunk/; revision=36292
 2011-03-23 15:15:02 +00:00
Stig Bjørlykke
03941b54ed Fixed second parameter to create_persconffile_profile. 
svn path=/trunk/; revision=36291
 2011-03-23 14:58:34 +00:00
Stig Bjørlykke
714c8c52b9 Ensure we create the "Default" personal configuration files directory before 
creating a new profile.  This fixes a bug when trying to create a new profile
from a newly installed wireshark with no saved preferences.

svn path=/trunk/; revision=36290
 2011-03-23 14:52:39 +00:00
Bill Meier
fc11b62891 Fix bug: 'guint8 |=0x8000'. 
Coverity 350

svn path=/trunk/; revision=36289
 2011-03-23 14:51:40 +00:00
Jeff Morriss
50c8f0f80a Don't use C++/C99-style comments. 
svn path=/trunk/; revision=36288
 2011-03-23 13:18:38 +00:00
Martin Mathieson
d620640a70 Remove some unncessary assignments to proto_item pointers. 
Coverity 904 & 905.

svn path=/trunk/; revision=36287
 2011-03-23 11:35:03 +00:00
Martin Mathieson
b47c36a4bd Don't assign proto_item pointers that are not used. 
Coverity CIDs 1021 & 1022.

svn path=/trunk/; revision=36286
 2011-03-23 10:58:24 +00:00
Martin Mathieson
473b578880 Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack. 
svn path=/trunk/; revision=36285
 2011-03-23 10:12:35 +00:00
Anders Broman
fd782e736c From Vincent Helfre: 
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description

svn path=/trunk/; revision=36284
 2011-03-23 09:14:50 +00:00
Stig Bjørlykke
aca69d699a Removed "comparing an array to null", with no effect. 
Coverity 532.

svn path=/trunk/; revision=36279
 2011-03-23 07:25:08 +00:00
Ronnie Sahlberg
0832de6b8e value&0x03 does not need to be shifted to the right by two. 
cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value

coverity 342


svn path=/trunk/; revision=36278
 2011-03-23 06:50:09 +00:00
Anders Broman
691c566900 CID 453,454 
Missing break

svn path=/trunk/; revision=36277
 2011-03-23 05:48:58 +00:00
Ronnie Sahlberg
89d3156883 Shift the correct number of steps when masking the UAAERP bit to 0/1 
coverity 348

svn path=/trunk/; revision=36274
 2011-03-23 04:55:22 +00:00
Ronnie Sahlberg
24eb2e7b6e The NSG bits in the login pdu are 0x0c not 0xc0 
coverity 344


svn path=/trunk/; revision=36273
 2011-03-23 04:50:17 +00:00
Ronnie Sahlberg
feaf55330e Coverity 989 
Remove some item=  assignments we dont need since we never use the value
of the created item.


svn path=/trunk/; revision=36269
 2011-03-22 20:48:36 +00:00
Bill Meier
1f5bfa75b1 Remove two tests for fail return from g_malloc(); Fixes Coverity #424 "FORWARD_NULL" 
svn path=/trunk/; revision=36267
 2011-03-22 19:27:48 +00:00
Stig Bjørlykke
fac93b08b2 Allocate correct size of nwk_keyring. 
Coverity 715.

svn path=/trunk/; revision=36265
 2011-03-22 19:16:19 +00:00
Stig Bjørlykke
41d5c9b750 Allocate correct size of hash_key. 
Coverity 713.

svn path=/trunk/; revision=36264
 2011-03-22 19:13:48 +00:00
Stig Bjørlykke
f51139e659 Allocate correct size of reload_frame. 
Coverity 714.

svn path=/trunk/; revision=36263
 2011-03-22 19:13:05 +00:00
Stig Bjørlykke
2cc2403a33 Initialize al_cto before usage. 
Coverity 808.

svn path=/trunk/; revision=36260
 2011-03-22 18:42:02 +00:00
Bill Meier
fda538056f Fix potential array overrun: Coverity CID #565. 
svn path=/trunk/; revision=36258
 2011-03-22 18:26:36 +00:00
Martin Mathieson
46857df13e Fix mask when extracting FACH Indicator. 
Coverity CID 349.

svn path=/trunk/; revision=36257
 2011-03-22 18:24:38 +00:00
Martin Mathieson
0370a7977d Remove redundant comparison. 
Coverity CID 361.

svn path=/trunk/; revision=36256
 2011-03-22 18:06:58 +00:00
Martin Mathieson
034820599a Make a struct static to avoid growing the stack too much. 
Coverity CID 753.

svn path=/trunk/; revision=36255
 2011-03-22 17:46:59 +00:00
Martin Mathieson
bed50222ac Don't assign top_ti - delete it for now. 
Coverity CID 862

svn path=/trunk/; revision=36254
 2011-03-22 17:37:47 +00:00
Stephen Fisher
b494b86514 From Dirk via bug #5771: Add heuristic dissector for images and HTTP 
Also add to AUTHORS file.


svn path=/trunk/; revision=36253
 2011-03-22 16:43:16 +00:00
Martin Mathieson
4611533752 There can be up to 15 DL HARQ processes (depending upon TDD config index). 
svn path=/trunk/; revision=36250
 2011-03-22 14:39:02 +00:00
Stig Bjørlykke
9ec9b1ccb9 Pass pointers to structs instead of struct values to create_ntlmssp_v2_key. 
Coverity 567.

svn path=/trunk/; revision=36248
 2011-03-22 12:12:04 +00:00
Stig Bjørlykke
bdf603c403 Close fp in error case in ssl_parse_key_list to avoid leakage. 
Coverity 597.

svn path=/trunk/; revision=36246
 2011-03-22 11:40:15 +00:00
Stig Bjørlykke
a07fff3b15 Corrected hack for TAPA by checking for "not IPv4". 
Coverity 343.

svn path=/trunk/; revision=36244
 2011-03-22 10:12:07 +00:00
Ronnie Sahlberg
ff04f85940 Coverity 512 
Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.



svn path=/trunk/; revision=36241
 2011-03-22 09:35:26 +00:00
Anders Broman
1ab6930388 - Add 9.4.5 IMEISV IE dissection 
- UE Time Zone is TLV
- Cell Global Identity  PDU type is SGSAP_PDU_TYPE

svn path=/trunk/; revision=36239
 2011-03-22 09:06:42 +00:00
Bill Meier
bdd6f7f692 Re-arrange code so Coverity Prevent doesn't falsely report several INFINITE_LOOPs: Coverity 427-429 (run 617) 
svn path=/trunk/; revision=36233
 2011-03-22 00:38:55 +00:00
Bill Meier
56bea38672 Fix an "infinite loop" defect reported by Coverity Prevent (Coverity 430 (run 616)). 
svn path=/trunk/; revision=36231
 2011-03-21 19:33:19 +00:00
Stig Bjørlykke
62559137c4 Corrected decoding of oid values with length 5. 
This fixes coverity 340.

svn path=/trunk/; revision=36230
 2011-03-21 18:58:48 +00:00
Bill Meier
6413294dae Add a comment re a "suspicious" sizeof() reported by Coverity Prevent. 
(The report seems correct but I'm not altogether sure).

svn path=/trunk/; revision=36227
 2011-03-21 17:34:58 +00:00
Chris Maynard
a1fcd675e1 From Jakub Zawadzki via wireshark-dev: Fix comment. 
svn path=/trunk/; revision=36223
 2011-03-21 13:28:20 +00:00
Gerald Combs
cbef93064a [Automatic manuf, services and enterprise-numbers update for 2011-03-20] 
svn path=/trunk/; revision=36216
 2011-03-20 15:03:47 +00:00
Guy Harris
5c3d724bca Clean up indentation. 
svn path=/trunk/; revision=36213
 2011-03-20 00:05:39 +00:00
Chris Maynard
1dd51f1e15 From Alexis La Goutte submitted in bug 5759: Use ENC_NA where appropriate. 
From me:  Remove unused header fields found by checkhf.pl.  One more ENC_NA.

svn path=/trunk/; revision=36211
 2011-03-18 20:02:45 +00:00
Chris Maynard
704838106e All fields are little-endian. Fixes bug 5759 reported by Tang Fulin. 
svn path=/trunk/; revision=36210
 2011-03-17 20:17:09 +00:00
Martin Mathieson
f69a54705c Respond to most of the clang warnings for this dissector. 
svn path=/trunk/; revision=36208
 2011-03-17 16:00:13 +00:00
Chris Maynard
92377b21df From Jakub Zawadzki: Simpler patch to resolve bug 5755 to properly display all 
strings in dissect_octet_string() without having to allocate extra memory.

svn path=/trunk/; revision=36207
 2011-03-17 15:37:28 +00:00
Jeff Morriss
8588676679 As per bug 5751, these header files are no longer needed/used. 
svn path=/trunk/; revision=36206
 2011-03-17 13:27:23 +00:00
Martin Mathieson
b138ffa9e7 Avoid some unnecessary assignments (as reported by clang). 
svn path=/trunk/; revision=36204
 2011-03-16 23:18:59 +00:00
Martin Mathieson
c1d824c46c Don't increment after reading last outheader value (as reported by clang). 
svn path=/trunk/; revision=36203
 2011-03-16 23:01:33 +00:00
Martin Mathieson
46f9b98003 2 VS Code Analyzer warnings were bogus. Avoid one and add a comment about the second one. 
svn path=/trunk/; revision=36201
 2011-03-16 22:51:45 +00:00
Chris Maynard
d40ddf49c6 From Fulko Hew via bug 5755: Fix dissect_octet_string() so it properly displays 
strings of any length.

svn path=/trunk/; revision=36199
 2011-03-16 14:51:53 +00:00
Anders Broman
9486d7dcc2 From Roland Knall: 
Patch, which removes both EPL and EPLv1 .h files, as well as adding a heuristic dissector hook to EPL (v1 is nearly nowhere in use anymore, therefore not needed)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5751

svn path=/trunk/; revision=36198
 2011-03-16 06:21:56 +00:00
Martin Mathieson
da45af3980 Try to fix checkApi script. 
svn path=/trunk/; revision=36197
 2011-03-15 22:55:53 +00:00
Martin Mathieson
2e7a9893c3 Fix calling of LTE dissectors for R9 DCT protocols. 
svn path=/trunk/; revision=36196
 2011-03-15 17:30:00 +00:00
Anders Broman
23400cd7a3 Add dissection of 
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK

svn path=/trunk/; revision=36195
 2011-03-15 06:03:58 +00:00
Stephen Fisher
55b1e9a877 Add expert info to UDP dissector for showing possible (Unix-style) 
traceroute packets: if the port number range is 33434 to 33434 + 30.


svn path=/trunk/; revision=36194
 2011-03-14 22:01:49 +00:00
Stephen Fisher
1fc46d7c4d Don't verify the checksum of an ICMP packet when it the payload of an 
error packet (pinfo->in_error_pkt), such as an ICMP destination
unreachable, because we probably don't have the whole original packet.


svn path=/trunk/; revision=36193
 2011-03-14 19:58:02 +00:00
Gerald Combs
670d38ec71 Properly initialize our filter counters. 
svn path=/trunk/; revision=36190
 2011-03-14 16:00:51 +00:00
Anders Broman
ab7e2fd487 Export 
tvb_new_composite
tvb_composite_finalize
tvb_composite_append

svn path=/trunk/; revision=36188
 2011-03-14 14:05:51 +00:00
Jaap Keuter
15a032af98 Fix for bug 3933: 
Decode TCP port 2443 as Secure Skinny (SCCPS).

svn path=/trunk/; revision=36187
 2011-03-14 07:49:05 +00:00
Anders Broman
338f238746 Add dissection of 
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE

svn path=/trunk/; revision=36186
 2011-03-14 07:15:25 +00:00
Gerald Combs
4d6d8c58a5 [Automatic manuf, services and enterprise-numbers update for 2011-03-13] 
svn path=/trunk/; revision=36183
 2011-03-13 15:03:43 +00:00
Anders Broman
5b60867fc6 ../../../epan/dissectors/packet-gtp.c:5607: error: unused variable ‘length’ 
svn path=/trunk/; revision=36182
 2011-03-13 09:33:45 +00:00
Anders Broman
285513860c Add sub dissection of AVP MBMS Service Area. 
svn path=/trunk/; revision=36181
 2011-03-12 23:26:55 +00:00
Stig Bjørlykke
d3cff4643b Use TRUE/FALSE for encoding_info to make it build. 
Added packet-mndp.c to Makefile build.

svn path=/trunk/; revision=36179
 2011-03-12 12:09:52 +00:00
Stephen Fisher
a8a7de17ea Improve r36177 per Guy's suggestion at bug #5746 to always call the 
PPP-over-HDLC dissector since it will do the check for us to see if
the HDLC framing is present or not.


svn path=/trunk/; revision=36178
 2011-03-12 02:06:25 +00:00
Chris Maynard
ebe492525f Handle PPP in HDLC framing. Fixes bug 5746. 
svn path=/trunk/; revision=36177
 2011-03-12 01:32:35 +00:00
Chris Maynard
a96eed7007 Add emem_tree_lookup32_array_le. Resolves bug 5744. 
svn path=/trunk/; revision=36176
 2011-03-09 17:20:29 +00:00
Jörg Mayer
df9543e3a1 Update/correct some TLVs 
svn path=/trunk/; revision=36175
 2011-03-09 13:27:13 +00:00
Bill Meier
ff6cd61a00 Check that imported private key is RSA; Prevents a crash. 
Fixes Bug #5662

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5662

svn path=/trunk/; revision=36174
 2011-03-09 00:43:49 +00:00
Jörg Mayer
3fc5ee8f53 Add support for Mikrotiks Neigbor Discovery Protocol (MNDP). 
Sample capture at
http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=mndp.pcap

svn path=/trunk/; revision=36170
 2011-03-08 19:10:46 +00:00
Chris Maynard
2cc88f04a1 Don't bother creating/finding conversations if we're encapsulated within an 
error packet, such as an ICMP destination unreachable.  Prior to this change,
I had captures that showed such encapsulated requests with responses indicated
in other frames, which obviously can't be true.

svn path=/trunk/; revision=36169
 2011-03-08 18:52:12 +00:00
Chris Maynard
4d20bdd60d Conversation tracking must be handled whether "tree" is NULL or not. 
svn path=/trunk/; revision=36168
 2011-03-08 18:33:45 +00:00
Jörg Mayer
cf8c877d0d Add support for the pre-rfc DAE port 1700 
svn path=/trunk/; revision=36167
 2011-03-08 18:29:30 +00:00
Bill Meier
d9beb8fcb0 From Martin Kaiser: initialize hdr_tag with NO_TAG 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

svn path=/trunk/; revision=36163
 2011-03-08 13:52:16 +00:00
Sake Blok
f28084f772 Fix for bug 5743 : tshark incorrectly calculates tcp stream for SYN packets when port numbers are re-used 
svn path=/trunk/; revision=36162
 2011-03-08 11:26:34 +00:00
Sake Blok
307c0d70fb Removal of the old packet-list in favor of the new packet list. 
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)


svn path=/trunk/; revision=36161
 2011-03-08 01:52:25 +00:00
Jeff Morriss
e6ce1793e2 Don't pass retransmitted chunks to subdissectors. Instead just mark them as 
retranmissions (in COL_INFO).  (Obviously this only works if TSN analysis is
enabled.)

This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).

svn path=/trunk/; revision=36159
 2011-03-07 19:23:55 +00:00
Anders Broman
aac7fca686 From Alexis La Goutte: 
enhance tag Power Constraint/Capability, TPC Request/Report, Supported Channel, csa 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36158
 2011-03-07 17:46:30 +00:00
Stephen Fisher
664916ad64 Squelch compiler warning: 
packet-dvbci.c: In function 'dissect_dvbci_lpdu':
packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this function
packet-dvbci.c:1153: note: 'hdr_tag' was declared here

By setting hdr_tag = 0, but see question on bug #5654 on whether 0 is a 
good default value or not.


svn path=/trunk/; revision=36157
 2011-03-07 17:01:55 +00:00
Bill Meier
523d4d1cbe From Stefan Metzmacher: smb2 multi-credit / large mtu support 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5729

From me: Update a comment re the "epoch" field: It's now called "credit charge".

svn path=/trunk/; revision=36156
 2011-03-07 16:43:55 +00:00
Anders Broman
24133413b9 Remove a no longer needed struct. 
svn path=/trunk/; revision=36155
 2011-03-07 12:31:49 +00:00
Anders Broman
840b816f05 Remove more obsolete code. 
svn path=/trunk/; revision=36154
 2011-03-07 11:56:21 +00:00
Anders Broman
6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used 
svn path=/trunk/; revision=36153
 2011-03-07 10:01:24 +00:00
Anders Broman
a7e379499d Remove the old code. 
svn path=/trunk/; revision=36152
 2011-03-07 09:36:24 +00:00
Bill Meier
3e92ea5c2f Fix compiler error on Windows 64: cast strlen() to (int); 
Also: Apparently the length of an address of type AT_STRINGZ must include the NULL.

svn path=/trunk/; revision=36151
 2011-03-07 03:10:51 +00:00
Bill Meier
16b528aaf1 From Martin Kaiser: dissector for DVB-CI (Common Interface) 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

From me:
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_...() for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
- (Other minor tweaks);
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;


svn path=/trunk/; revision=36149
 2011-03-07 02:22:48 +00:00
Martin Mathieson
4d3d029e09 Remove some instances of _U_ where the parameter is now used. 
svn path=/trunk/; revision=36148
 2011-03-06 23:10:28 +00:00
Martin Mathieson
d36178cd5d Improve expert info output when detect Scheduling Request 'state machine' problem. 
svn path=/trunk/; revision=36147
 2011-03-06 22:52:33 +00:00
Stig Bjørlykke
3e261511ab Mark value_string_ext bssgp_cause_vals_ext as WS_VAR_IMPORT. 
svn path=/trunk/; revision=36144
 2011-03-06 16:37:21 +00:00
Gerald Combs
c7990056c2 [Automatic manuf, services and enterprise-numbers update for 2011-03-06] 
svn path=/trunk/; revision=36143
 2011-03-06 16:03:46 +00:00
Anders Broman
b4941ca580 Prepare to remove old bssgp code by changing exports. 
svn path=/trunk/; revision=36142
 2011-03-06 09:42:41 +00:00
Anders Broman
9a7ad380af From Alexis La Goutte: 
Enhance tag fh_hopping_.., tclas, tspec, challenge_text...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36141
 2011-03-04 17:40:32 +00:00
Bill Meier
f7be370643 From Stefan Metzmacher: Patch that fixes false positives and allows large smb1/2 pdus 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914



svn path=/trunk/; revision=36140
 2011-03-04 15:09:29 +00:00
Tomas Kukosa
0b9c645150 Fix warning 
svn path=/trunk/; revision=36139
 2011-03-04 14:36:27 +00:00
Tomas Kukosa
3f8b9e87a9 Check only first 14 digits of GeneralizedTime which are fixed, next parts are optional 
svn path=/trunk/; revision=36138
 2011-03-04 14:01:57 +00:00
Anders Broman
7e17176c39 All messages converted to the "GSM style" dissection. 
svn path=/trunk/; revision=36137
 2011-03-04 12:57:55 +00:00
Stephen Fisher
eec3e70821 Change descriptions of NTP Reference Identifier Codes for stratum 1 
servers to match IANA assignment / RFC 5905.  A number of codes already
in Wireshark that aren't assigned were left intact.


svn path=/trunk/; revision=36136
 2011-03-04 00:25:56 +00:00
Stephen Fisher
47b9a1235e Correct the usage of tvb_memeql() after r35558: it doesn't return true 
if the values are the same; we have to check for "== 0" to see if they
are the same. 


svn path=/trunk/; revision=36135
 2011-03-04 00:17:01 +00:00
Stephen Fisher
ed9de27ba1 Change "Reference Clock ID" to "Reference ID" to match RFC5905 (also 
mention this RFC in the comments).


svn path=/trunk/; revision=36134
 2011-03-03 23:48:56 +00:00
Stephen Fisher
4c6e0d3604 Clarify / add explanations for the fields 
svn path=/trunk/; revision=36133
 2011-03-03 23:47:05 +00:00
Jeff Morriss
62edb47987 Add more duplicate fragment tests. 
svn path=/trunk/; revision=36132
 2011-03-03 23:28:32 +00:00
Jeff Morriss
4ed0e07ef0 When reassembling fragments, don't stop looking at fragments just because the 
current fragment pushes us past the reassembled size: it may be that the
current fragment is a duplicate/retransmission and will be ignored.

Also, if we detect a conflict between a previous and the current fragment,
flag the current (conflicting) fragment as FD_OVERLAPCONFLICT.  Do *not* flag
the fragment that got us into the reassembly routine (probably the final
fragment): it is not (may not be) the guilty fragment.

Clean up some spacing.

Also add reassembly tests for duplicate/retransmitted fragments.

svn path=/trunk/; revision=36131
 2011-03-03 20:22:45 +00:00
Anders Broman
675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID 
svn path=/trunk/; revision=36130
 2011-03-03 07:20:34 +00:00
Jeff Morriss
2ea51a7ad2 There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

Remove some unnecessary includes.

svn path=/trunk/; revision=36129
 2011-03-03 03:28:38 +00:00
Jeff Morriss
ad99181031 There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

svn path=/trunk/; revision=36128
 2011-03-03 03:09:21 +00:00
Jeff Morriss
609b1b1e1f Use tvb_memcpy() instead of tvb_get_ptr() + memcpy(). 
Remove a few unnecessary includes.

svn path=/trunk/; revision=36127
 2011-03-03 03:02:03 +00:00
Jeff Morriss
559c1e0d53 Use tvb_ether_to_str(). 
svn path=/trunk/; revision=36126
 2011-03-03 02:41:22 +00:00
Jeff Morriss
212a0274f7 Use tvb_get_guint8() instead of tvb_get_ptr(). 
Remove a few unnecessary includes.

svn path=/trunk/; revision=36125
 2011-03-03 02:32:18 +00:00
Jeff Morriss
26789f5d00 Use tvb_ether_to_str(). 
svn path=/trunk/; revision=36124
 2011-03-03 02:24:44 +00:00
Jeff Morriss
ab2b947088 Make the _to_str() functions in here take a pointer to a TVB and an offset 
rather than (generally) a pointer into the TVB.

Replace some tabs with spaces (for consistency).

Remove a couple unnecessary includes.

svn path=/trunk/; revision=36123
 2011-03-03 02:18:57 +00:00
Anders Broman
6db5c9387b Fix Error: Found non-ASCII characters in packet-ieee80211.c 
svn path=/trunk/; revision=36121
 2011-03-02 16:25:33 +00:00
Anders Broman
3ccb1950a4 From Alexis La Goutte: 
* Add 802.11 Standard Reference
* Reorder IE (Information Element) and define in decimal (the standard use
decimal...) 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36120
 2011-03-02 15:23:38 +00:00
Martin Mathieson
2f6486166f Allow linking back to previous UL tx 32 ms ago. 
svn path=/trunk/; revision=36119
 2011-03-02 11:33:46 +00:00
Martin Mathieson
c5c0195362 Don't overwrite isPhyRetx field for UL frames with DL check. 
svn path=/trunk/; revision=36118
 2011-03-02 11:16:28 +00:00
Martin Mathieson
3fac9089cb After SR failure, allow for another attempt in SR state machine (presumably with a subsequent RACH happening in-between...) 
svn path=/trunk/; revision=36109
 2011-03-01 14:58:51 +00:00
Tomas Kukosa
16bdcb2fbe QSIG: decoding of PSS1InformationElement 
svn path=/trunk/; revision=36108
 2011-03-01 13:01:26 +00:00
Martin Mathieson
0b2e755182 Tweak the way we setup FP R8 info. 
svn path=/trunk/; revision=36107
 2011-03-01 10:54:57 +00:00
Martin Mathieson
aa9102b72f Was reading F in mac-is descriptors the wrong way around... 
svn path=/trunk/; revision=36106
 2011-03-01 10:53:58 +00:00
Gerald Combs
91fe31c9b4 If we encounter an excessively long filter string or one with too many 
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
 2011-03-01 00:50:17 +00:00
Bill Meier
16097406f4 Define some globals as static; Remove uneeded #includes; Whitespace cleanup. 
svn path=/trunk/; revision=36100
 2011-02-28 23:50:01 +00:00
Bill Meier
ef997f2290 Remove unneeded #includes; Add #includes to packet-gsm_rlcmac.c 
svn path=/trunk/; revision=36099
 2011-02-28 23:46:07 +00:00