Please find attached a patch to the RSVP dissector that fixes a small inaccuracy when printing the SENDER TSPEC object.
Substantially, it changes the string
"C-type: 1 - Integrated Services" into the correct one
"C-type: 2 - Integrated Services"
svn path=/trunk/; revision=20900
When dissecting RTP packets with a H.263 payload, the "Mark" flag runs into the Mode A/B flag in the info column.
From me abriviate Payload type to PT.
svn path=/trunk/; revision=20899
Along with this bug, identified by Mark, there is another problem, in that one of the chunks of my earlier patch seemed to get missed off when Anders committed it. This won't break anything yet, as the H.223-over-RTP dissection hasn't landed on trunk yet, but it will cause all sorts of nasties when it does.
Here is a new patch, against current trunk, which should fix Mark's bug, my bug, and a comment typo.
And a patch wich improves the general robustness of the h.223 dissector (making it less likely to crash on malformed data).
Hopefully this also fixes a bug raised by Fabio Sguanci a few weeks ago.
Fabio: I think a better way to fix the problem is to stop the dissector crashing when it finds a malformed PDU, so that it just treats the first pdu as malformed; there is then no need to special-case it.
svn path=/trunk/; revision=20898
use this field in the policy handle helper to indicate not only which frames the handle was opened/close in but also the name of the function that opened it.
eventually, when other pidl support infrastructure is developed it would be nice if this could be expanded to also contain the name of the object/handle opened.
svn path=/trunk/; revision=20895
The H.223 dissector contains code to deal with "bitswapped" captures - ie, where all of the bytes have their bits backwards. It seems that this is much better handled as a separate dissector entry point, so that the right one can be chosen when the dissector is registered, rather than the current dubious heuristics.
svn path=/trunk/; revision=20893
This patch makes the defragmentation code in the iax2 dissector handle
pinfo->desegment_len=DESEGMENT_ONE_MORE_SEGMENT, in line with
Ronnie's changes to the tcp dissector of 11 November.
svn path=/trunk/; revision=20892
Here's a patch which adds an option enabling subdissectors to request defragmentation of packets over RTP streams, using the
pinfo->desegment_{len,offset} API.
svn path=/trunk/; revision=20891
01_reassemble_test.patch
------------------------
I didn't want to do anything without some unit tests, so here they are.
This allows a standalone binary, epan/reassemble_test, to be built; this can be run from the commandline and should end up printing out "success"
if all goes well.
NOTE the changes to makefile.am NOT checked in currently.
Incidentally: is it possible to get the buildbot to run things like this, exntest and tvbtest?
02_reassemble_refactor.patch
----------------------------
fragment_add_seq, fragment_add_dcerpc_dg and fragment_add_seq_check_work were all pretty much carbon-copies of each other. This patch factors out the common parts of the routines into a new routine, fragment_add_seq_key().
03_reassemble_partial_reassembly.patch
---------------------------------------
This makes fragment_set_partial_reassembly() work for datagrams assembled with fragment_add_seq(). The patch itself is actually quite small, but it adds another unit test which is reasonably lengthy.
svn path=/trunk/; revision=20888
bring the server message type dissection nearly to completion. As for RealVNC
protocol dissection, the only things not working at 100% is the TCP
reassembly and some ZRLE subencoding types. However, it is is much more useful
shape now than before.
svn path=/trunk/; revision=20886
This patch provide a new function to decode messages when several ASN1 encoding can be used.
This is the case, for example, when a same message has different encoding according to the MAP version, or in case of ASN1 encoder optimization.
At the same time, I did remove the configuration variable "old_gsm_map_version", which is taken into account in the patch.
And likewise, for all the messages defined with the ASN1 sequence "[3] SEQUENCE", this function is called for the decoding.
svn path=/trunk/; revision=20878
============================ Samba log start ============
------------------------------------------------------------------------
r21253 | jelmer | 2007-02-09 00:54:31 +0100 (Fri, 09 Feb 2007) | 7 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/TODO
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Util.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/Conformance.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
A /branches/SAMBA_4_0/source/pidl/tests/header.pl
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
A /branches/SAMBA_4_0/source/pidl/tests/wireshark-conf.pl
Merge some pidl fixes:
* Add tests for wireshark dissector generator
* Add tests for the header code
* Some cleanups
* Fix handling of elements without [in] or [out]
------------------------------------------------------------------------
r21254 | jelmer | 2007-02-09 01:18:06 +0100 (Fri, 09 Feb 2007) | 2 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/tests/header.pl
Fix running the testsuite outside pidl/
------------------------------------------------------------------------
r21260 | jelmer | 2007-02-09 10:44:11 +0100 (Fri, 09 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/tests/header.pl
Fix regex.
------------------------------------------------------------------------
r21297 | jelmer | 2007-02-12 13:12:12 +0100 (Mon, 12 Feb 2007) | 5 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/.bzrignore
M /branches/SAMBA_4_0/source/configure.ac
D /branches/SAMBA_4_0/source/gtk
M /branches/SAMBA_4_0/source/headermap.txt
M /branches/SAMBA_4_0/source/include/core.h
M /branches/SAMBA_4_0/source/lib/events/config.mk
M /branches/SAMBA_4_0/source/lib/events/events.h
M /branches/SAMBA_4_0/source/lib/registry/config.mk
M /branches/SAMBA_4_0/source/lib/registry/registry.h
M /branches/SAMBA_4_0/source/lib/talloc/talloc.h
M /branches/SAMBA_4_0/source/libcli/util/nt_status.h
M /branches/SAMBA_4_0/source/librpc/config.mk
M /branches/SAMBA_4_0/source/main.mk
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
M /branches/SAMBA_4_0/webapps/qooxdoo-0.6.5-sdk/frontend/framework/source/translation/C.po
Remove the GTK+ tools and library from the main repository. They are now maintained separately in bzr at http://people.samba.org/bzr/jelmer/samba-gtk
This also adds some more headers to the list that is installed and a couple of extra #include lines so these
headers can be used externally without problems.
------------------------------------------------------------------------
r21332 | jelmer | 2007-02-14 13:44:50 +0100 (Wed, 14 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Fix bug in pidl that prevented value(0) from working. Bug reported by metze.
------------------------------------------------------------------------
r21338 | jelmer | 2007-02-14 15:23:59 +0100 (Wed, 14 Feb 2007) | 6 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
A /branches/SAMBA_4_0/source/pidl/tests/samba3-cli.pl
Fix handling of top-level arrays for the Samba 3 client code. This doesn't
fix the winreg code yet (as that's an array on top of a pointer), but at least
it gets us closer.
Also added a couple of tests for the Samba 3 client code.
------------------------------------------------------------------------
r21340 | jelmer | 2007-02-14 15:42:42 +0100 (Wed, 14 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
Fix warning undef
------------------------------------------------------------------------
r21384 | jelmer | 2007-02-16 15:13:14 +0100 (Fri, 16 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
Change warning to pidl warning, fix uppercasing.
------------------------------------------------------------------------
r21411 | jelmer | 2007-02-18 00:38:57 +0100 (Sun, 18 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
A /branches/SAMBA_4_0/source/pidl/tests/wireshark-ndr.pl
Add some simple tests for the wireshark NDR generator.
------------------------------------------------------------------------
r21427 | jelmer | 2007-02-18 13:54:03 +0100 (Sun, 18 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Add tests for Needed*(), in preparation of refactoring.
------------------------------------------------------------------------
r21428 | jelmer | 2007-02-18 14:44:01 +0100 (Sun, 18 Feb 2007) | 2 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Handle representation types in Needed().
------------------------------------------------------------------------
r21430 | jelmer | 2007-02-18 17:21:28 +0100 (Sun, 18 Feb 2007) | 10 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/TODO
M /branches/SAMBA_4_0/source/pidl/idl.yp
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Expr.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
M /branches/SAMBA_4_0/source/pidl/tests/header.pl
M /branches/SAMBA_4_0/source/pidl/tests/ndr_deprecations.pl
M /branches/SAMBA_4_0/source/pidl/tests/ndr_tagtype.pl
M /branches/SAMBA_4_0/source/pidl/tests/parse_idl.pl
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Support tagged types without typedef. This means:
struct foo {
...
};
in IDL will now work. This is the first step towards nested types and
using typedefs for partial types (such as "typedef int *bar;"), a requirement
for complex uses of represent_as().
------------------------------------------------------------------------
r21431 | jelmer | 2007-02-18 17:46:59 +0100 (Sun, 18 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Dump.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
A /branches/SAMBA_4_0/source/pidl/tests/dump.pl
More tests, work on support in wireshark for tagged types.
------------------------------------------------------------------------
r21432 | jelmer | 2007-02-18 17:54:54 +0100 (Sun, 18 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/TDR.pm
Handle properties on tagged types in TDR.
------------------------------------------------------------------------
r21433 | jelmer | 2007-02-18 19:44:56 +0100 (Sun, 18 Feb 2007) | 9 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/lib/registry/regf.idl
M /branches/SAMBA_4_0/source/librpc/config.mk
D /branches/SAMBA_4_0/source/librpc/idl/dcom.idl
M /branches/SAMBA_4_0/source/librpc/idl/oxidresolver.idl
M /branches/SAMBA_4_0/source/librpc/idl/remact.idl
D /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/ODL.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
D /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/COM
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/SWIG.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/TDR.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4.pm
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
M /branches/SAMBA_4_0/source/pidl/pidl
A /branches/SAMBA_4_0/source/pidl/tests/tdr.pl
M /branches/SAMBA_4_0/source/script/build_idl.sh
M /branches/SAMBA_4_0/source/torture/rpc/oxidresolve.c
M /branches/SAMBA_4_0/source/torture/rpc/remact.c
Get rid of the COM support code - it's not used and unmaintained. We can
always bring it back if we need to. This code was getting in the way while
refactoring.
Add some tests for TDR.
Get rid of typedef in lib/registry/tdr_regf.idl and fix the
TDR code to be able to deal with it.
------------------------------------------------------------------------
r21437 | jelmer | 2007-02-19 00:48:16 +0100 (Mon, 19 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
A /branches/SAMBA_4_0/source/pidl/tests/typelist.pl
Cherrypick typelib tests.
------------------------------------------------------------------------
r21440 | jelmer | 2007-02-19 00:57:26 +0100 (Mon, 19 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Support different variables in environments.
------------------------------------------------------------------------
r21442 | jelmer | 2007-02-19 01:48:05 +0100 (Mon, 19 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
Allow more flexible data structure names.
------------------------------------------------------------------------
r21443 | jelmer | 2007-02-19 02:51:46 +0100 (Mon, 19 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
Refactor some of the NDR code in preparation of nested data structure support.
------------------------------------------------------------------------
r21455 | jelmer | 2007-02-19 20:42:51 +0100 (Mon, 19 Feb 2007) | 5 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Fix a bug in our handling of conformant arrays. The conformant array was
always pushed, even if just the buffers part of a struct had to be pushed.
Pull was not affected.
------------------------------------------------------------------------
r21456 | jelmer | 2007-02-19 22:37:54 +0100 (Mon, 19 Feb 2007) | 6 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
Allow anonymous and non-anonymous nested structures/unions/enums/bitmaps to be
used in the Samba 4 NDR parser.
This doesn't actually work yet as Parse::Pidl::NDR doesn't handle nested
data structures yet, but it's a first step.
------------------------------------------------------------------------
r21457 | jelmer | 2007-02-19 23:10:23 +0100 (Mon, 19 Feb 2007) | 3 lines
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl
Cope with anonymous nested types in the NDR layer. This doesn't handled
named nested types yet, as these have to be registered.
------------------------------------------------------------------------
r21458 | jelmer | 2007-02-20 00:11:01 +0100 (Tue, 20 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
Prepare for generating separate primitives/deferred code.
------------------------------------------------------------------------
r21459 | jelmer | 2007-02-20 02:27:48 +0100 (Tue, 20 Feb 2007) | 1 line
Changed paths:
M /branches/SAMBA_4_0
M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl
Remove name argument, more refactoring.
------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============
svn path=/trunk/; revision=20876
let this helper take a parameter to describe how the policy handle should be
managed (is this an open, close ?) to improve policy handle tracking.
(centralizing to a single function of code makes other changes easier)
create defines to indicate OPEN/CLOSE and use them as a start/test in the winreg conformance file.
svn path=/trunk/; revision=20872
pidl will probably be in flux for a short while and this checkin is to reduce the some noice generated to winreg while other changes are implemented.
this change only affects c-code comments in the pidl generated code
svn path=/trunk/; revision=20871
feature lists all of the content found in an HTTP stream (images, http, etc.)
and displays it in a list that allows the user to save each one as a file that
is already reassembled by the dissectors.
svn path=/trunk/; revision=20867
update the conformance file so the correct functions are loaded with the correct PARAM value to signal "in this frame, this policy handle was created"
svn path=/trunk/; revision=20857
While I reading source code of IuUP dissector, I notice some
obvious bugs inside the code. One is a missing assignment
that causes the following "if (iuup_circuit)" block to never execute.
Another is wrong field names.
Althoug both won't show up in final result (for the first bug, the call to
g_hash_table_insert several lines later will do the right thing anyway;
for the second bug, there is no services utilizing more than 3 subflows),
I think it is better to have them fixed.
svn path=/trunk/; revision=20853
Luis Ontanon