osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
39,002 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

39002 Commits

Author SHA1 Message Date
Guy Harris 96b89de3e9 Capitalize the "P" in "Packet" in "Add or Edit Packet Comment". Add 
"..." after it, as it pops up a dialog box to let you actually type in a
comment.

Add "Add or Edit Packet Comment" to the menubar's Edit menu.

svn path=/trunk/; revision=41005
 2012-02-12 23:09:14 +00:00
Michael Tüxen 13beca3bbf Fix debug output. 
svn path=/trunk/; revision=41004
 2012-02-12 21:56:00 +00:00
Anders Broman ad0df12982 Add a button row. 
svn path=/trunk/; revision=41003
 2012-02-12 21:15:11 +00:00
Guy Harris 1f971df298 Close parentheses in expert info. 
svn path=/trunk/; revision=41002
 2012-02-12 20:44:51 +00:00
Guy Harris f36fec7381 Don't trust the pointer value in a packet; it could be invalid, and this 
could cause an unsigned length value to be reduced by more than its
value, turning it into a very large value.

I couldn't exactly reproduce bug 6833, but it was due to an attempt to
allocate 4294967110 bytes, and this bug caused remaining_len to equal
4294967110, and it would try to create a reassembled packet tvbuff of
that size, so I'm guessing this fixes 6833.

svn path=/trunk/; revision=41001
 2012-02-12 20:03:37 +00:00
Alexis La Goutte 918a7f858b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41000
 2012-02-12 19:30:57 +00:00
Alexis La Goutte 3f9b521121 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40999
 2012-02-12 19:26:53 +00:00
Alexis La Goutte 26eebbc768 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40998
 2012-02-12 19:24:38 +00:00
Alexis La Goutte 9806283d4c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40997
 2012-02-12 18:06:37 +00:00
Alexis La Goutte 7ed5d356b4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40996
 2012-02-12 18:05:50 +00:00
Alexis La Goutte e86788796e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40995
 2012-02-12 18:05:22 +00:00
Alexis La Goutte dfb7f8dd19 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40994
 2012-02-12 18:05:02 +00:00
Alexis La Goutte 958afd725d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40993
 2012-02-12 18:04:26 +00:00
Alexis La Goutte e24afc8f39 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40992
 2012-02-12 18:03:17 +00:00
Alexis La Goutte 6718c41bd4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40991
 2012-02-12 18:02:58 +00:00
Alexis La Goutte da79574838 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40990
 2012-02-12 18:02:39 +00:00
Alexis La Goutte da053ea8d3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40989
 2012-02-12 17:47:11 +00:00
Alexis La Goutte f296d389b2 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40988
 2012-02-12 17:46:57 +00:00
Alexis La Goutte a34db114cc Enhance BGP Notification message 
* Make field filterable (3 proto_tree_add_text less ! but there are still 147 proto_tree_add_text...)
* Remove bgp_notify struct
* Use expert info to display a unknown error type

svn path=/trunk/; revision=40987
 2012-02-12 17:41:57 +00:00
Michael Tüxen 8aa280b721 Get it compiling. 
svn path=/trunk/; revision=40986
 2012-02-12 16:38:47 +00:00
Anders Broman 15d8fe8baa Get the comment and put it in the textview. 
svn path=/trunk/; revision=40985
 2012-02-12 16:18:25 +00:00
Anders Broman ff4a624dcf Try to make the buildbot happy. 
svn path=/trunk/; revision=40983
 2012-02-12 15:48:57 +00:00
Gerald Combs dbb3d008ae [Automatic manuf, services and enterprise-numbers update for 2012-02-12] 
svn path=/trunk/; revision=40981
 2012-02-12 15:03:25 +00:00
Anders Broman f78145ca9f Add the edit packet comment menu entry and the empty files 
to actually handel the menu to edit the comments.

svn path=/trunk/; revision=40980
 2012-02-12 14:56:06 +00:00
Anders Broman c36b0f1b03 From Steve Magnani: 
USB: add infrastructure for dissecting class-specific descriptors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6825

svn path=/trunk/; revision=40979
 2012-02-12 07:18:05 +00:00
Guy Harris 55140956e8 Use the length-on-the-network, not the captured length, when deciding 
how far to dissect.

svn path=/trunk/; revision=40978
 2012-02-11 20:57:26 +00:00
Guy Harris 357ab3c5f7 Don't bail out of a non-heuristic dissector routine just because there's 
not enough captured data in the tvbuff.

svn path=/trunk/; revision=40977
 2012-02-11 20:37:54 +00:00
Guy Harris 9f116d50cb Get rid of checkapi warning about %hh. 
svn path=/trunk/; revision=40976
 2012-02-11 20:36:35 +00:00
Guy Harris cd706946e5 mpeg_pat.cur_next_ind looks like a Boolean; make it one. That also 
fixes checkapi warnings about its value_string not being properly
terminated (by replacing it with a true_false_string).

svn path=/trunk/; revision=40975
 2012-02-11 20:35:03 +00:00
Anders Broman 74f2ef4f76 Store drop count if present. 
svn path=/trunk/; revision=40974
 2012-02-11 17:31:13 +00:00
Anders Broman 75de89cd1b From Steve Magnani: 
USB: support filtering of isochronous packets via usb.bInterfaceClass.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6824

svn path=/trunk/; revision=40973
 2012-02-11 16:59:38 +00:00
Anders Broman 4a0b7db0a2 From Guy Martin: 
Dissector for DVB MultiProtocol Encapsulation (DVB-MPE)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6822

svn path=/trunk/; revision=40972
 2012-02-11 16:52:32 +00:00
Anders Broman 9c731b2015 From Guy Martin: 
Dissector for MPEG Program Association Table (PAT)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6821

svn path=/trunk/; revision=40971
 2012-02-11 16:44:45 +00:00
Anders Broman 3724dbe6b4 From Guy Martin: 
Dissector for MPEG section packets.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6820

svn path=/trunk/; revision=40970
 2012-02-11 16:38:01 +00:00
Anders Broman 8aea738cda Add the abillity to read and write option comments unedited. 
This is POC we may want to have more efficient use of the frame data
structure etc. But this allows for work to be done on the GUI to actually add comments.

svn path=/trunk/; revision=40969
 2012-02-11 12:34:39 +00:00
Anders Broman 11e815e99a From David Wei: 
Udate AVP:s

svn path=/trunk/; revision=40968
 2012-02-11 09:09:27 +00:00
Guy Harris 0e2773b633 Don't use 16-bit integers as counters. The code won't be any faster on 
anything that can run Wireshark (it might be slower), and if the maximum
count value is 16-bit, you can loop forever if the maximum count value
happens to be 65535.

(Yes, this means that

	guint i, j;

		...

	for (i = 0; i < j; i++)
		...

risks looping forever if j is 2^32-1, and the same applies to 64-bit
counters.  There are probably fewer protocols with 32-bit counts, and
probably even fewer with 64-bit counts, but the way it should be done in
those cases, for safety, is

	i = 0;
	for (;;) {
		if (i >= j)
			break;

		...

		if (i == j - 1)
			break;
	}

or something such as that.)

Fixes bug 6809.

#BACKPORT
Will schedule for 1.6.x.

svn path=/trunk/; revision=40967
 2012-02-11 07:12:34 +00:00
Guy Harris 31204e8406 It is a complete mistake to have *ANY* messages during packet capture 
sent to the standard output if "-w" is specified because, when you
capture, you can capture with the output directed to the standard
output, and dumping some text crap to the standard output will corrupt
your capture file.

svn path=/trunk/; revision=40966
 2012-02-11 03:57:49 +00:00
Guy Harris c972b866b5 Use C89-style comment rather than C++/C99-style comment. 
svn path=/trunk/; revision=40965
 2012-02-11 02:45:58 +00:00
Guy Harris 3301c4cb85 Get rid of C++/C99-style comment; use #if 0/#endif instead. 
svn path=/trunk/; revision=40964
 2012-02-11 02:45:16 +00:00
Guy Harris 357a3e2837 Revert presumably-unintentional turning on of debug messages. 
svn path=/trunk/; revision=40963
 2012-02-11 02:41:04 +00:00
Guy Harris fd8beeae21 Global variables considered harmful. Pass pinfo along as a parameter; 
this appears to fix bug 6823 (the actual crash was a null pinfo being
passed to call_dissector()).

svn path=/trunk/; revision=40962
 2012-02-11 02:31:52 +00:00
Ronnie Sahlberg 232c882946 NETLOGON handle different schannel with the same source 
ip and dest i

from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40961
 2012-02-11 02:10:32 +00:00
Ronnie Sahlberg 4d2cb8bf94 NETLOGON: Fix bugs with netlogon decryption not working in some cases 
If there is only one Authenticatex in the file, decryption is not
working.

from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40960
 2012-02-11 02:09:20 +00:00
Ronnie Sahlberg 7a8e42888b NETLOGON: improve debugging messages 
from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40959
 2012-02-11 02:08:02 +00:00
Ronnie Sahlberg bec3996bb7 NTLM show the decrypted data buffer in a separate tab 
from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40958
 2012-02-11 02:06:45 +00:00
Ronnie Sahlberg d0f5a1842b NTLM print the whole string, not just half the string 
from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40957
 2012-02-11 02:05:57 +00:00
Ronnie Sahlberg 00cebab4aa NTLM: clear the nt_password_unicode buffer. 
from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40956
 2012-02-11 02:04:36 +00:00
Ronnie Sahlberg 9b24fe2822 NTLM make it easier to activate/deactivate debugging code in NTLM 
from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40955
 2012-02-11 02:03:20 +00:00
Ronnie Sahlberg 30e8d6371d NTLM: If we encounter an NTLM blob that is bigger than out fixed maxbuffer, 
log a warning to the user.

from Matthieu Patou <mat@matws.net>

svn path=/trunk/; revision=40954
 2012-02-11 02:01:47 +00:00