Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.
Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.
The API is under the Wireshark namespace to avoid conflicts with
system headers.
Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.
As dynamic channel data can be transported on top of TCP or UDP, we need to keep track
of the link between UDP and TCP connections so that the associated data can be shared
between the two transports.
I was hoping to avoid this, since the ptvcursor should already be
implicitly scoped to the tree it is working on. But there are a bunch of
call sites where the passed tree can be NULL (?) and a few places where
the tree is explicitly set/reset after creation, so requiring an
explicit scope is safer.
Avoids global memory pools in favour of ones the compiler can verify.
Avoids the use of the global memory pool in favour of one the compiler
actually knows must be in scope.
Also delete a few-hundred lines of if-0ed code that hadn't been active
in 15+ years.
IEC 61850 is directly over Ethernet, so use set_actual_length
like other such protocols so that the Ethernet dissector has a
chance to detect and dissect trailers / FCS.
And do it in the template from which packet-sv.c is generated, rather
than in packet-sv.c, so that it doesn't get overwritten if somebody
regenerates the sv dissector.
Added decoding and display of "Number of Schedule Slots"
and "Number of Packets" parameters contained in Request-Session
message in TWAMP Control protocol, in accordance with RFC-4656.
Added decoding and display of Conf-Sender and Conf-Receiver
parameters contained in Request-Session message in TWAMP
Control protocol, in accordance with RFC-4656 (OWAMP RFC
which is baseline for TWAMP).
Updated call to dissect_DIS_PARSER_IFF_PDU so that it contains the DIS version.
Updated info column so that it appends text in the right order. Added
System Designator and System Specific Information to DIS v7 IFF PDUs.
This is used to select ringbuffer savefile name template. Choose one of two
savefile name templates:
If value is 1, make running file number part before start time part; this is
the original and default behaviour (e.g. log_00001_20210828164426.pcap).
If value is greater than 1, make start time part before running number part
(e.g. log_20210828164426_00001.pcap).
The latter makes alphabetical sortig order equal to creation time order, and
keeps related multiple file sets in same directory close to each other (e.g.
while browsing in wireshark "Open file" dialog).
Signed-off-by: Juha Takala <juha.takala+rauta@iki.fi>
Migrate compress-pngs from a Bash script that ran Make to a Python
script, which should be usable on more platforms.
Add Efficient Compression Tool (ect) to the list of compressors.
Add the compressors to the various *-setup.sh scripts, but comment them
out for now.