Commit Graph

40249 Commits

Author SHA1 Message Date
Bill Meier 8bfe44619f Revert 3 conversions of spaces --> tabs (in text strings) done in SVN #42354.
svn path=/trunk/; revision=42356
2012-04-30 19:20:59 +00:00
pascal 95eb2e7288 From Martin Kaiser:
Fix some 'intermediate pointers must be const qualified' warnings
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7215

svn path=/trunk/; revision=42355
2012-04-30 19:14:14 +00:00
Bill Meier 0f3c6a288e Whitespace cleanup; reformat hf[] entries.
svn path=/trunk/; revision=42354
2012-04-30 19:08:15 +00:00
Chris Maynard 19fe681849 Add MTU probe, MTU reply and Traceroute IP option dissection support.
svn path=/trunk/; revision=42353
2012-04-30 17:32:33 +00:00
Gerald Combs 70d8b1c0f3 Update the annotations item.
svn path=/trunk/; revision=42352
2012-04-30 17:15:43 +00:00
pascal aa55f84987 Update comments with the RRLP version currently dissected
svn path=/trunk/; revision=42351
2012-04-30 16:45:03 +00:00
pascal ce8f5a4334 From Evan Huus:
Fix memory leak in process_body_part() when there is no body
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7212

svn path=/trunk/; revision=42350
2012-04-30 15:57:39 +00:00
Gerald Combs 01c4764ea2 Update the IEEE OUI and IAB URLs.
svn path=/trunk/; revision=42349
2012-04-30 15:40:39 +00:00
Chris Maynard e936265168 Add missing RFC791 PROG security definition. Reorder ipopts[] so it matches the order at http://www.iana.org/assignments/ip-parameters, which is ordered by 'Number'. Use the descriptions as they appear there as well. Add TODO placeholders in ipopt[] for the yet-to-be-implemented options.
svn path=/trunk/; revision=42348
2012-04-30 14:29:54 +00:00
pascal 89e4c91d7a From Martin Kaiser:
fix a few clang warnings in DVB-CI dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7215

svn path=/trunk/; revision=42347
2012-04-30 14:05:22 +00:00
pascal a752102faa From Martin Kaiser:
Fix clang warnings in HDCP dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7217

svn path=/trunk/; revision=42346
2012-04-30 13:43:52 +00:00
Jeff Morriss 2c103b9d5f From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7218 :
Add 'track-origins' option flag to valgrind script.

svn path=/trunk/; revision=42345
2012-04-30 13:20:27 +00:00
pascal 4f415d93c5 Fix some clang warnings (dead assignment/increment, assigned value is garbage or undefined)
svn path=/trunk/; revision=42344
2012-04-30 09:00:05 +00:00
pascal 5df9055044 Fix a few clang warnings
svn path=/trunk/; revision=42343
2012-04-30 08:38:26 +00:00
pascal d39ae2d807 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7064 :
Dissect basic security option according to RFC 791 or RFC 1108 depending on the option length and the first two bytes content.
Also dissect the extended security option.

svn path=/trunk/; revision=42342
2012-04-30 08:21:09 +00:00
Chris Maynard c70938b35d Fix a clang warning due to 'type' not being initialized.
svn path=/trunk/; revision=42341
2012-04-29 23:39:55 +00:00
pascal c69d317daf Fix typo errors
svn path=/trunk/; revision=42340
2012-04-29 18:25:06 +00:00
Gerald Combs e14f2371ba [Automatic manuf, services and enterprise-numbers update for 2012-04-29]
svn path=/trunk/; revision=42333
2012-04-29 14:03:30 +00:00
Guy Harris 4021d7c5ea Add ".dmp" as a suffix for pcap files of various flavors. Add ".ntar"
as a suffix for pcap-ng files.

svn path=/trunk/; revision=42330
2012-04-29 02:49:17 +00:00
Guy Harris ed15123049 Add .ntar as a suffix (some pcap-ng files use it).
Sort the suffixes alphabetically.

svn path=/trunk/; revision=42329
2012-04-29 02:38:55 +00:00
Guy Harris c492f45a1e Make the extension lower case.
Say "Pcap" rather than "Libpcap" - pcap format is used by WinPcap as
well (and it's also read and written by this library called Wiretap
:-)).

Add an additional entry for pcap-NG.

svn path=/trunk/; revision=42328
2012-04-29 02:27:08 +00:00
Martin Mathieson b77cd5d0f4 Check result of sscanf(), and avoid a mirrored variable declaration.
From Visual Studio Analyzer output.

svn path=/trunk/; revision=42327
2012-04-28 23:58:06 +00:00
Martin Mathieson b9677f575c Avoid needlessly shadowing a variable. From Visual Studio Analyzer.
svn path=/trunk/; revision=42326
2012-04-28 23:14:54 +00:00
Chris Maynard 7655cb2f5a Initialize u32RecDataLen to 0 to avoid a clang warning and in the event it never gets initialized in either dissect_IODWriteReqHeader_block() or dissect_IODReadReqHeader_block().
svn path=/trunk/; revision=42325
2012-04-28 18:50:20 +00:00
Chris Maynard 79b57614c5 Initialize val to 0 in case pdata != NULL but "di->conformant_run" is TRUE so the *pdata won't contain garbage as reported by clang.
svn path=/trunk/; revision=42324
2012-04-28 18:23:19 +00:00
Chris Maynard c47744e353 Fix dead initialization warning reported by clang.
svn path=/trunk/; revision=42323
2012-04-28 18:05:27 +00:00
Guy Harris 0fde5403ab Fix long name for reverse charging field.
svn path=/trunk/; revision=42322
2012-04-28 17:57:41 +00:00
Guy Harris 3016d07185 Remove redundant "X.25". (I'm not sure why the protcol name is included
in the reassembly information both here and, for example, IPv4 fragment
reassembly, but perhaps those are redundant as well.)

svn path=/trunk/; revision=42321
2012-04-28 17:42:55 +00:00
Chris Maynard da54d6136c Initialize the bits[] array to zero.
svn path=/trunk/; revision=42320
2012-04-28 17:42:23 +00:00
pascal 5e0e1ceea8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7213:
Update dissection of Reverse charging, fast select, and ICRD status selection facilities

svn path=/trunk/; revision=42319
2012-04-28 17:34:23 +00:00
pascal 120f19310a From Evan Huus:
Remove unused variables in SMB dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7211

svn path=/trunk/; revision=42318
2012-04-28 16:48:16 +00:00
Martin Mathieson f0b6f7a6ae Avoid assignement and clang warning.
svn path=/trunk/; revision=42317
2012-04-28 16:48:11 +00:00
Martin Mathieson eafce30cf0 Another unnecessary assignment removed to fix clang warning.
svn path=/trunk/; revision=42316
2012-04-28 16:40:54 +00:00
Martin Mathieson 8b8f87be81 Remove move unread updates to 'offset' to avoid clang warnings.
svn path=/trunk/; revision=42315
2012-04-28 16:33:19 +00:00
Martin Mathieson 68841134b7 Don't look up p_fp_info only to always overwrite it.
svn path=/trunk/; revision=42314
2012-04-28 16:23:23 +00:00
Martin Mathieson 6eb94dd35e Test a return value to avoid an initialised warning from clang.
svn path=/trunk/; revision=42313
2012-04-28 16:18:28 +00:00
Martin Mathieson ca382b40b4 Remove an unnecessary assignment from clang output. I can't see the
problem with the other 2 warnings for this file.
--This linen , and those below, will be ignored--

M    packet-umts_fp.c

svn path=/trunk/; revision=42312
2012-04-28 16:11:54 +00:00
Guy Harris 3684bb31a0 Remove _U_ from arguments that are actually used.
Fix a comment.

svn path=/trunk/; revision=42311
2012-04-28 16:05:18 +00:00
Martin Mathieson 21cca7ed28 Remove a couple of unused assignments pointed out by clang.
svn path=/trunk/; revision=42310
2012-04-28 15:57:50 +00:00
pascal 8d15f366c6 Remove unused header fields
svn path=/trunk/; revision=42309
2012-04-28 13:37:41 +00:00
pascal f8f3756ab0 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7051 :
Add option 82 suboptions 150/151/152 decoding to DHCP dissector

svn path=/trunk/; revision=42308
2012-04-28 13:20:41 +00:00
Ronnie Sahlberg d307c7fcd8 SCSI SBC: Add dissection of the ANCHOR and UNMAP bits in WRITESAME10/16
svn path=/trunk/; revision=42307
2012-04-28 08:16:17 +00:00
Guy Harris a59e931733 If xml_get_int() fails, bail immediately; don't use the variable it
would have filled in had it not failed.  (Thanks and a tip of the Hatlo
hat to the Clang static analyzer for complaining about this.)

svn path=/trunk/; revision=42306
2012-04-28 03:07:04 +00:00
Guy Harris faa13e5072 Neither C90 nor C99 explicitly guarantee that a memcpy() call with a
null source argument and a zero count will work; in practice, they
probably will (with a zero count, there's nothing to fetch from the
source),  but the Clang static analyzer still warns about it.

svn path=/trunk/; revision=42305
2012-04-28 02:25:15 +00:00
Guy Harris d6e5b20bf2 Get rid of some unnecessary assignments, to remove warnings from the
Clang static analyzer.

svn path=/trunk/; revision=42304
2012-04-28 02:01:40 +00:00
Jakub Zawadzki 8ab67b185e Like r42302 but in other place.
Followup to r42283: the loop which allocates operation summaries may not run
to completion, so don't try to free all the operation summaries.

svn path=/trunk/; revision=42303
2012-04-27 20:49:15 +00:00
Jeff Morriss a8a5721d47 Fix fuzz failure reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7209 :

Followup to r42283: the loop which allocates operation summaries may not run
to completion, so don't try to free all the operation summaries.

svn path=/trunk/; revision=42302
2012-04-27 20:43:22 +00:00
Jakub Zawadzki 4253c73d8f Fix sigsegv in filter expression dialog when user clicked on some BASE_CUSTOM field.
svn path=/trunk/; revision=42301
2012-04-27 20:35:17 +00:00
Jeff Morriss 6aa32cb03a As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.

svn path=/trunk/; revision=42300
2012-04-27 19:45:35 +00:00
Jeff Morriss 445790ccb7 Bugzilla always uses https (and has for quite a while), so use https in the URLs to the bugs.
svn path=/trunk/; revision=42299
2012-04-27 19:18:22 +00:00