Commit Graph

48376 Commits

Author SHA1 Message Date
Anders Broman 894ca4e904 From Johan Wåhl:
Dissect 3GPP AVP 637 UAR-Flags.

svn path=/trunk/; revision=51575
2013-08-29 17:09:14 +00:00
Michael Mann 951e0101a3 From Hauke Mehrtens:
Break out Signature Hash Algorithm into hash and signature values

From me:
Cleanup all "saved" trees throughout the dissector as well as removing a few unnecessary NULL tree checks.
Removed most of the tvb_ensure_bytes_exist checks because the line that follows will through an exception anyway if there isn't enough bytes in the tvb.




svn path=/trunk/; revision=51574
2013-08-29 14:25:38 +00:00
Bill Meier 3bd36d84d2 Minor reformatting; Also: remove some boilerplate comments.
svn path=/trunk/; revision=51573
2013-08-29 02:20:49 +00:00
Bill Meier 92fe2aa40d Minor cleanup:
- proto_reg_handoff_...() & related;
- Remove unneeded #includes

svn path=/trunk/; revision=51572
2013-08-29 02:17:00 +00:00
Bill Meier 3b9ecc4f4a Fix some indentation to match mode-lines; Do some other minor reformatting.
svn path=/trunk/; revision=51571
2013-08-29 02:05:31 +00:00
Jörg Mayer ee9c47b6eb Slightly improve the decoding of unknown Aironet IEs
svn path=/trunk/; revision=51570
2013-08-28 22:57:52 +00:00
Anders Broman 821b3f24e3 Fix a copy-paste error.
svn path=/trunk/; revision=51569
2013-08-28 19:53:44 +00:00
Anders Broman 87d4d484c7 packet-aruba-erm.c:136: warning: 'range_add_callback' defined but not used
svn path=/trunk/; revision=51568
2013-08-28 19:25:48 +00:00
Anders Broman f6b9c18eed Use dissector_delete_uint_range/dissector_add_uint_range
svn path=/trunk/; revision=51567
2013-08-28 19:10:33 +00:00
Jörg Mayer 29f0303517 svn version 1.7.11 no longer has local .svn directories,
just one at the top level. So on my system, /trunk no longer
contains a .svn directory. Check in parent directory as well.

svn path=/trunk/; revision=51566
2013-08-28 18:27:16 +00:00
Pascal Quantin 35f284caad Revert file committed by accident
svn path=/trunk/; revision=51565
2013-08-28 17:33:14 +00:00
Pascal Quantin 519a7778aa Fix copy/paste error introduced in r51541 and spotted by Joerg
svn path=/trunk/; revision=51564
2013-08-28 17:31:12 +00:00
Bill Meier 5c6670134c Fix formatting again (so blank line before "and by:" in AUTHORS output)
svn path=/trunk/; revision=51563
2013-08-28 15:57:10 +00:00
Chris Maynard 29947918fd Credit Martin Pool for his natural order string comparison algorithm.
svn path=/trunk/; revision=51562
2013-08-28 14:59:32 +00:00
Jörg Mayer b9a4e7a56c As reported by Ben Smith (thex1le@gmail.com) on #wireshark:
Aironet IE 20 is ClientMFP

svn path=/trunk/; revision=51561
2013-08-28 14:09:32 +00:00
Jörg Mayer 57b9b11e40 Comment out a line that seems to do nothing.
** CID 1068812: Unused pointer value (UNUSED_VALUE)

svn path=/trunk/; revision=51560
2013-08-28 10:47:23 +00:00
Jörg Mayer 5d4782b026 There is no use in checking for (cf) if we have already unconditionally
used cf-> ...

** CID 1068811: Dereference before null check (REVERSE_INULL)

svn path=/trunk/; revision=51559
2013-08-28 10:43:50 +00:00
Evan Huus c660aab935 Update the test suite for r51556. Use -Y in one place instead of -R where only
filtering is important. Use -2 and -R together in one place where the counting
functionality is important.

svn path=/trunk/; revision=51558
2013-08-28 02:30:50 +00:00
Gerald Combs c1c6545e30 Comment out some unused variables.
svn path=/trunk/; revision=51557
2013-08-28 01:38:23 +00:00
Evan Huus 5c851858d9 Fully deprecate read filter (-R) without two-pass (-2). It does exactly the same
thing as the display filter (-Y) in that case except with more confusing
semantics.

This also lets us fix -c in the single-pass case to unconditionally count
packets. This isn't the old behaviour (which counted them only if they passed
the read filter) but is more consistent with two-pass mode where they are
counted even if they pass the display filter, since they are counted on the
first pass and the display filter is applied on the second pass.

Anyone who wants to use -c to limit packet count conditionally on them passing a
filter should use it in tandem with -2 and -R: the read filter is applied on the
first pass before the count.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9048

svn path=/trunk/; revision=51556
2013-08-28 00:56:19 +00:00
Gerald Combs 25392c73f4 Let the QCustomPlot widget have focus.
svn path=/trunk/; revision=51555
2013-08-28 00:23:01 +00:00
Gerald Combs 66b8223688 Add initial mouse and keyboard controls. QCustomPlot uses different
mouse interactions than the GTK+ version, but they seem to match modern
UI conventions better. The keyboard shortcuts have been changed to match
modern UI conventions as well, but I'll try to support the old shortcuts
as much as possible.

svn path=/trunk/; revision=51554
2013-08-27 23:28:35 +00:00
Guy Harris b862ff08fd Make sure we initialize the array of file type extensions before we use
it.

svn path=/trunk/; revision=51553
2013-08-27 22:10:35 +00:00
Alexis La Goutte 574183b9ec Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51552
2013-08-27 21:13:09 +00:00
Alexis La Goutte af7e3d0835 Fix indent (use 4 spaces) And add modelines info
svn path=/trunk/; revision=51551
2013-08-27 21:13:00 +00:00
Alexis La Goutte f079ce9117 Fix indent (use 4 spaces) And add modelines info
svn path=/trunk/; revision=51550
2013-08-27 21:12:52 +00:00
Alexis La Goutte 37e43e58eb Enhance TLS ALPN dissection (Add length of ALPN)
svn path=/trunk/; revision=51549
2013-08-27 21:12:42 +00:00
Alexis La Goutte 5be903807b Enhance Profinet MRP (Merge LinkUp and LinkDown)
svn path=/trunk/; revision=51548
2013-08-27 21:12:32 +00:00
Guy Harris a505518e01 Have a separate list of extension sets to use in the Open dialog;
include only extensions used mostly by capture files (i.e., not ".txt"
or ".xml"), and list each extension set only once (it's silly to have,
for example, separate entries for NetMon, Shomiti Surveyor, and
NetScaler with ".cap" when you get all those types no matter which entry
you choose).

svn path=/trunk/; revision=51547
2013-08-27 20:46:47 +00:00
Gerald Combs a84b44f588 Credit Emanuel Eichhammer.
svn path=/trunk/; revision=51546
2013-08-27 20:42:54 +00:00
Pascal Quantin 0ead8d9b06 Try to fix error: enum conversion in assignment is invalid in C++ [-Werror=c++-compat]
svn path=/trunk/; revision=51545
2013-08-27 20:32:39 +00:00
Guy Harris abfc95ba40 QCustomPlot is C++, not C.
Additional changes needed for the TCP stream UI code.

svn path=/trunk/; revision=51544
2013-08-27 20:31:22 +00:00
Gerald Combs 7cfcf703e2 Fix some warnings.
svn path=/trunk/; revision=51543
2013-08-27 20:26:43 +00:00
Jörg Mayer b30a098dee Add qcustomplot.cpp to Makefile.common and CMakeLists.txt
a few whitespace fixes

svn path=/trunk/; revision=51542
2013-08-27 20:24:20 +00:00
Pascal Quantin 22c5585547 Add a DRX subtree to GTP dissector now that the subtree (useless for NAS and EPS NAS dissectors) was removed from de_gmm_drx_param in r51537
svn path=/trunk/; revision=51541
2013-08-27 19:38:35 +00:00
Anders Broman 7e3922cf43 Use dissector_delete_uint_range/dissector_add_uint_range
svn path=/trunk/; revision=51540
2013-08-27 19:21:20 +00:00
Gerald Combs cbae911dca Remove an attempt to fix a qmake warning.
svn path=/trunk/; revision=51539
2013-08-27 18:37:13 +00:00
Gerald Combs 6d731a3e79 Add TCP sequence number (Stevens-style) graphs.
Add the QCustomPlot widget. Thanks to Emanuel Eichhammer for granting a
license change. Move some common code from ui/gtk/tcp_graph.c to
ui/tap-tcp-stream.[ch]. Get rid of tcp_graph_selected_packet_enabled().
It was only used in the menu code and didn't match what we were doing
elsewhere.

Still quite a bit of work to do but it's a promising start.

svn path=/trunk/; revision=51538
2013-08-27 18:13:20 +00:00
Pascal Quantin 77f1ed0f93 Make SPLIT PG CYCLE CODE filterable
svn path=/trunk/; revision=51537
2013-08-27 17:01:58 +00:00
Pascal Quantin 7dfc77adcd From Jiri Engelthaler via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8849 :
IEC104: fix dissection of VTI Value and Normalised value

svn path=/trunk/; revision=51536
2013-08-27 14:56:00 +00:00
Pascal Quantin 165caf0869 From Hadar Shoham via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9076 :
MGCP: add support for option mp and fxr/fx

svn path=/trunk/; revision=51535
2013-08-27 12:28:21 +00:00
Alexis La Goutte ed8115e099 Remove tab and fix order
svn path=/trunk/; revision=51534
2013-08-27 11:19:12 +00:00
Martin Kaiser 6d97cc86bd revert the last commit, the comment was correct already
svn path=/trunk/; revision=51533
2013-08-27 11:10:36 +00:00
Martin Kaiser 285ab0a5f9 correct a comment: resource -> item
svn path=/trunk/; revision=51532
2013-08-27 11:04:12 +00:00
Martin Kaiser 155ac2eebd set item len correctly
svn path=/trunk/; revision=51531
2013-08-27 11:02:01 +00:00
Martin Kaiser 8911436697 better function name, make it clear what we want to do
svn path=/trunk/; revision=51530
2013-08-27 10:44:16 +00:00
Martin Kaiser 3f4cf67741 dissect the components of the HID descriptor
svn path=/trunk/; revision=51529
2013-08-27 08:32:01 +00:00
Martin Kaiser 75522d1697 register a dissector for HID class specific descriptors
start dissecting the HID descriptor

svn path=/trunk/; revision=51528
2013-08-27 07:40:50 +00:00
Anders Broman 0e81643540 From Michal Labedzki:
Full dissection of EIR/AD and little improve filtering, cd 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9050

svn path=/trunk/; revision=51527
2013-08-27 05:08:34 +00:00
Anders Broman 8ddf822285 From Chun-Yeow:
Decode the Mesh Configuration Capabilities Info in Details.
With a change to use tfs_yes_no.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9070

svn path=/trunk/; revision=51526
2013-08-27 04:57:27 +00:00