Commit Graph

9340 Commits

Author SHA1 Message Date
Olivier Biot 83b4a6158f Add support for GIF image dissection.
NOTE: I propose to use packet-MIME-TREE for future media types that will be
added to Ethereal (E.g., packet-image-png.c).

svn path=/trunk/; revision=9437
2003-12-24 02:06:26 +00:00
Guy Harris f941ab7b7d Do the "isprint()" hack for GTK+ 2.x or 1.3[.x], whether on UNIX or
Windows - the problem is that GTK+ 1.3[.x] and later assume strings
handed to them are UTF-8 strings, not, for example, ISO 8859/x strings.

In packet-radius.c, re-define "isprint()" rather than #ifdeffing its use
(the old code was also incorrectly treating 0x7f as a printable).

svn path=/trunk/; revision=9436
2003-12-24 01:21:32 +00:00
Guy Harris e6f433d884 Do the "isprint()" hack for GTK+ 2.x or 1.3[.x], whether on UNIX or
Windows - the problem is that GTK+ 1.3[.x] and later assume strings
handed to them are UTF-8 strings, not, for example, ISO 8859/x strings.

In packet-radius.c, re-define "isprint()" rather than #ifdeffing its use
(the old code was also incorrectly treating 0x7f as a printable).

svn path=/trunk/; revision=9435
2003-12-24 01:12:17 +00:00
Guy Harris 839ce07c9a Handle the move of "smpp" preferences to "smpp-gsm-sms".
svn path=/trunk/; revision=9434
2003-12-23 21:29:25 +00:00
Guy Harris 821baa3d48 Have "tvb_ensure_length_remaining()" throw the appropriate exception if
there's no data remaining - its callers largely depend on it doing so.

That means that the BEEP dissector doesn't have to check for it
returning 0.

svn path=/trunk/; revision=9433
2003-12-23 21:22:00 +00:00
Guy Harris 8afbfc0c60 Handle the case where "ssh_dissect_protocol()", for the first packet,
didn't determine the version number.

svn path=/trunk/; revision=9432
2003-12-23 21:16:27 +00:00
Olivier Biot 2a6e130e10 Move the GSM SMS dissection to a dedicated subdissector (currently still within
packet-smpp.c).

Now the higher-level protocols show up without the need of unfolding the SMPP
dissector tree.

Add a new address type AT_STRINGZ, and use it for GSM SMS message reassembly.

Get rid of the different UDH IE subtrees, and replace them with one subtree
for all UDH IEs.

Add debug logging to SMPP and SMPP GSM SMS dissectors.

Move the Short Message reassembly from the SMPP dissector to the SMPP GSM SMS
dissector. Fix duplicated "reassembled in" header fields.

Rename header fields that are now part of SMPP GSM SMS (including the dissector
table name, so it has also been updated in packet-wsp.c and packet-wtp.c).

Add an explicit "if (!tree) return" in the WSP add_headers() method.

NOTE: it would be great if we were able to merge the existing packet-gsm_sms.c
and the SMPP GSM SMS dissector.

svn path=/trunk/; revision=9431
2003-12-23 12:07:14 +00:00
Ulf Lamping 16cb58be9a removed COMMON_FILES_GNU from path,
use the directories xy_DIR from the settings above

svn path=/trunk/; revision=9430
2003-12-23 11:57:26 +00:00
Ulf Lamping bf729e3e15 calling tethereal in it's place, to prevent problems with dll loading
svn path=/trunk/; revision=9429
2003-12-23 11:53:25 +00:00
Guy Harris 75d6b95de1 Not all headers in HTTP, RTSP, SIP, etc. are entity headers; rename some
files, routines, data structures, etc..

svn path=/trunk/; revision=9428
2003-12-23 02:29:11 +00:00
Guy Harris f75e257cbd In HTTP-over-TCP, handle more than one HTTP message in a TCP segment.
Don't do that for HTTP-over-UDP, however.

svn path=/trunk/; revision=9427
2003-12-23 02:02:09 +00:00
Guy Harris b7b8245ea5 Process the content length.
svn path=/trunk/; revision=9426
2003-12-23 01:42:48 +00:00
Guy Harris 054f12a950 Note that we should do the same sort of entity header processing that
HTTP does.

Note that the RTSP RFC talks about packets with no content length,
although it also says they shouldn't exist.

Update a comment now that we *do* handle data that crosses TCP segment
boundaries.

Handle the payload length a bit differently, to make it a bit clearer
what's going on.

svn path=/trunk/; revision=9425
2003-12-23 01:25:23 +00:00
Guy Harris 5b3d2e36e4 Note that we should handle the Content-Length entity header.
svn path=/trunk/; revision=9424
2003-12-23 01:22:52 +00:00
Guy Harris b136fc7512 Base the count of selected packets on whether there's a
currently-selected packet.

Use "cfile.count" as the total number of packets in the capture.

Use "plurality" to display "packet" vs. "packets".

svn path=/trunk/; revision=9423
2003-12-23 00:32:45 +00:00
Ulf Lamping 467c05b3ea removed some MSVC warnings (conversions between double/float and int)
svn path=/trunk/; revision=9422
2003-12-23 00:16:46 +00:00
Guy Harris 447e29ec36 From Anders Broman: add the alternate TCP port.
svn path=/trunk/; revision=9421
2003-12-23 00:01:07 +00:00
Guy Harris c530cd35db Call subdissectors even if we're not building a protocol tree.
In the loop that processes TCP segment data, loop over the full reported
length of the segment, so that we throw an exception if the frame was
short.

svn path=/trunk/; revision=9420
2003-12-22 23:43:35 +00:00
Guy Harris e969b8d3ba Do reassembly of interleaved binary data.
svn path=/trunk/; revision=9419
2003-12-22 23:37:02 +00:00
Olivier Biot f4451d312b Move SIR to a dedicated subdissector.
Question: should we define "media type" subdissectors as special?

svn path=/trunk/; revision=9418
2003-12-22 22:57:09 +00:00
Guy Harris a7d9018c1f Have a "toc" file in the help directory, which gives a list of help
topic titles and help file names.

svn path=/trunk/; revision=9417
2003-12-22 22:17:30 +00:00
Guy Harris 9c89878b2e Have a "toc" file in the help directory, which gives a list of help
topic titles and help file names.

svn path=/trunk/; revision=9416
2003-12-22 21:52:41 +00:00
Ulf Lamping f86e376f5b get rid of the COMMON_FILES_GNU setting,
by getting the DLL's from the "source tree"

svn path=/trunk/; revision=9415
2003-12-22 21:41:40 +00:00
Ulf Lamping 9499f200a6 calling pod2man and pod2html indirectly through the bash
svn path=/trunk/; revision=9414
2003-12-22 21:34:13 +00:00
Ulf Lamping c263d27773 file "convert-include.sh" no longer used, so no need to distribute it
svn path=/trunk/; revision=9413
2003-12-22 21:01:29 +00:00
Guy Harris 126a5c1bda Set "pinfo->p2p_dir" if the packet wasn't received promiscuously.
svn path=/trunk/; revision=9412
2003-12-22 20:26:21 +00:00
Guy Harris b3c8b9bb2b Arrange to install the help files.
svn path=/trunk/; revision=9411
2003-12-22 20:04:32 +00:00
Olivier Biot 8751f63b3a Speed up WTP dissection by performing TPI subdissection only once and setting
the WTP length after processing the TPI.

Update reassembly so dissection of reassembled data is only enabled in the last
reassembled packet. This way, we alo see the WTP PDUs.

svn path=/trunk/; revision=9410
2003-12-22 11:55:10 +00:00
Guy Harris 40d418325f Use "rreh_do_reassembly()" to do reassembly.
svn path=/trunk/; revision=9409
2003-12-22 08:58:22 +00:00
Ulf Lamping 2e7258ed35 using distributed help text files, instead of "#include" built in texts
svn path=/trunk/; revision=9408
2003-12-22 08:12:10 +00:00
Ulf Lamping 57b6b53548 Patch from Guy: using distributed help text files,
instead of "#include" built in texts
(and some other minor changes)

svn path=/trunk/; revision=9407
2003-12-22 08:01:01 +00:00
Ulf Lamping 6a644f8426 distribute the text files in help dir
svn path=/trunk/; revision=9406
2003-12-22 07:57:43 +00:00
Guy Harris f152f847ed We need to do the "if the first fragment we see has no more fragments
after it, treat it as the only fragment" stuff for
"fragment_add_seq_next()" as well, so we handle non-fragmented packets.

svn path=/trunk/; revision=9405
2003-12-22 02:25:03 +00:00
Guy Harris 5d4586d191 Fix a typo.
svn path=/trunk/; revision=9404
2003-12-22 02:06:27 +00:00
Guy Harris 9a02e99750 Don't call "nds_defrag()" for positive ACK packets.
Put in some comments noting problems with NDS reassembly.

svn path=/trunk/; revision=9403
2003-12-22 02:04:18 +00:00
Guy Harris 9ecc68568e Pull the code to do reassembly of the request/response line, entity
headers, and body into a separate routine, for use by other dissectors.

svn path=/trunk/; revision=9402
2003-12-22 00:57:34 +00:00
Olivier Biot f2f164647a Fix unconditional handoff to subdissector introduced with the common reassembly
code.

Add the "Reassembled in" header field, and show it if the packet has been
reassembled, but not in the given packet. This also allows to use the "Jump to
the corresponding frame" feature in Ethereal.

svn path=/trunk/; revision=9401
2003-12-21 22:56:13 +00:00
Guy Harris 5c7fd0723c If we don't have any packets, or don't have any filtered packets, don't
even show the averages over the empty sets in question.

svn path=/trunk/; revision=9400
2003-12-21 22:32:07 +00:00
Guy Harris a97af4919b Arrays indexed by a 1-octet unsigned value, if we don't know which
values are permitted, must have 256 elements, not 255 elements.

svn path=/trunk/; revision=9399
2003-12-21 22:24:41 +00:00
Guy Harris ecbfe2fb77 "sizeof(array)" is the size of the array in bytes, not the number of
elements in the array.

svn path=/trunk/; revision=9398
2003-12-21 22:21:45 +00:00
Guy Harris 9ce5cd3548 In the MLUM-is-defined code path, "idx" is set - the only issue is if
MLUM isn't defined (which it isn't, by default).

svn path=/trunk/; revision=9397
2003-12-21 21:41:10 +00:00
Guy Harris 331b8b5a8b Add, for \xXX, the same sanity check (that 0xXX fits in a single byte)
that we have for \0OOO.

svn path=/trunk/; revision=9396
2003-12-21 21:04:56 +00:00
Olivier Biot 8e6953dcfe Fix a sprintf to non-malloc()ed memory by using g_strdup_printf() and g_free().
svn path=/trunk/; revision=9395
2003-12-21 18:12:33 +00:00
Jörg Mayer 297032573f warning: static declaration for ... follows non-static
svn path=/trunk/; revision=9394
2003-12-21 12:21:37 +00:00
Ulf Lamping 3b77bfee59 removed some MSVC warnings (moved pcap.h before glib.h)
svn path=/trunk/; revision=9393
2003-12-21 12:19:39 +00:00
Ulf Lamping 6126aad3b2 removed MSVC warning (uninitialized value)
svn path=/trunk/; revision=9392
2003-12-21 12:08:35 +00:00
Jörg Mayer b87ead52d3 warning: overflow in implicit constant conversion
svn path=/trunk/; revision=9391
2003-12-21 12:07:09 +00:00
Jörg Mayer 3086e0b9e7 warning: ISO C does not allow extra ; outside of a function
svn path=/trunk/; revision=9390
2003-12-21 11:40:45 +00:00
Jörg Mayer 7d6833db51 Updated to Dec 12 2003
svn path=/trunk/; revision=9389
2003-12-21 11:38:59 +00:00
Jörg Mayer 8d1f1c9b4f libpcap.c:1777: warning: implicit declaration of function htons
svn path=/trunk/; revision=9388
2003-12-21 06:02:06 +00:00