a340788eb2
Note that the "heuristic" is fatally weak, and must be strengthened or
...
eliminated.
Fix indentation.
Use tvb_reported_length(), so we throw an exception for packets cut
short by a snapshot length.
Don't bother showing or dissecting the payload if there isn't any.
Don't show an item with a zero-length payload as going to the end of the
packet.
svn path=/trunk/; revision=29603
2009-08-29 01:08:31 +00:00
988a595e79
From Neil Piercy:
...
Add new protocol for 3GPP 29.414 (Nb interface RTP Mux).
- Don't use C++-style comments (comments beginning with "//")
- Don't declare variables in the middle of executable code; not all C
compilers support that.
- Dont register preferences when none present.
- Removed CHECK_COL
svn path=/trunk/; revision=29602
2009-08-28 21:34:59 +00:00
29e52f7fd2
Fix code which could access uninitialized variables and display incorrect text in COL_INFO.
...
(Found by clang scan-build).
svn path=/trunk/; revision=29601
2009-08-28 19:15:43 +00:00
7279fbf6c0
Fix if test in fcn rs11():
...
return if either (as opposed to both) of the required sparameters is not present;
(Found by clang scan-build).
svn path=/trunk/; revision=29600
2009-08-28 18:37:53 +00:00
56eec34f80
Fix possible memmove with a NULL poiunter.
...
svn path=/trunk/; revision=29599
2009-08-28 16:52:05 +00:00
c680dc89a3
Don't coerce a possibly unaligned ptr to a (guint32 *);
...
Also: Calculate the same template hash whether on a LE or BE machine.
svn path=/trunk/; revision=29598
2009-08-28 16:36:24 +00:00
46fcebf274
Validate a function parameter
...
svn path=/trunk/; revision=29595
2009-08-28 13:52:52 +00:00
7081039a23
Reformat some long lines for readability....
...
svn path=/trunk/; revision=29570
2009-08-26 19:30:44 +00:00
94f28dd8f9
(FWIW) One step towards including stdio.h & stdlib.h only when req'd.
...
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
9e282cf141
export t38_add_address, prefer destination port for T.38 conversation searching
...
svn path=/trunk/; revision=29564
2009-08-26 15:10:31 +00:00
8437debcb6
Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter).
...
svn path=/trunk/; revision=29562
2009-08-26 09:13:14 +00:00
a1fc889259
From Thierry Andry via bug 3941:
...
Added preference to set radius request TTL.
svn path=/trunk/; revision=29561
2009-08-26 07:26:17 +00:00
57ec611fa1
From dragonlinux:
...
Add QNX OS VER 6's qnet ethernet protocol number.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934
svn path=/trunk/; revision=29558
2009-08-26 05:10:12 +00:00
eeb1f0df18
From swapnil:
...
Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940
svn path=/trunk/; revision=29556
2009-08-26 04:36:14 +00:00
8e1021f0c2
Rework code slightly to prevent several GCC "breaking strict-aliasing rules" warnings
...
svn path=/trunk/; revision=29554
2009-08-25 23:03:10 +00:00
14a35a650f
Init two struct members so gcc 4.1.4 doesn't complain about "may be used uninitialized";
...
Also: use gboolean for a true/false variable.
svn path=/trunk/; revision=29552
2009-08-25 21:54:12 +00:00
4e87c254f0
From Mike Morrin:
...
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889
Modified accoring to comments from Pascal Quantin(I hope I got it right).
svn path=/trunk/; revision=29549
2009-08-25 17:22:32 +00:00
5560cb61c0
Show CRC errors for RARs.
...
svn path=/trunk/; revision=29548
2009-08-25 11:01:51 +00:00
f8a37ac1d6
Make it possible to use bssgp.tlli as custom column.
...
Remove COL_BSSGP_TLLI and CHECK_COL.
svn path=/trunk/; revision=29543
2009-08-24 20:54:25 +00:00
75e727697f
Remove unneeded #includes; Clean up indentation; Comment a few "closing braces".
...
svn path=/trunk/; revision=29538
2009-08-24 15:17:58 +00:00
ce829a0f94
packet-tcp.c:1551: warning: 'cleared_writable' may be used uninitialized in this function
...
svn path=/trunk/; revision=29536
2009-08-24 09:29:05 +00:00
553ef57224
From: : " Michael"
...
packet-tcp marks a row as unwritable if there is more
than 1 PDU in a packet to prevent overwriting of the
protocol column.
However this breaks the proto,colinfo tap which checks
rows are writable or dies EVEN if it doesn't alter anything.
Suggested patch attached to restore the initial value
after all PDUs have been processed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675
svn path=/trunk/; revision=29535
2009-08-24 09:05:23 +00:00
60022bc5f2
Expert info for undecoded Q.932 and H.450 operations
...
svn path=/trunk/; revision=29534
2009-08-24 09:05:15 +00:00
ca5995f532
From Ivan Sy via bug 3931:
...
Added ND Proxy Flag for IPv6 RA flag.
svn path=/trunk/; revision=29533
2009-08-24 08:00:39 +00:00
c66f265dda
Rework code slightly to prevent a GCC 'strict-aliasing' warning.
...
svn path=/trunk/; revision=29532
2009-08-23 23:52:40 +00:00
58dedc3872
From kahou:
...
Add Fibre Channel Delimiter Dissector for Fibre Channel FC2.
svn path=/trunk/; revision=29531
2009-08-23 19:16:35 +00:00
60a30e223e
From Didier gautheron via bug 3929:
...
* Expert Info / Expert Info Composite requires a full protocol tree.
* Delay tree NULL pointer check in bootp dissector
svn path=/trunk/; revision=29530
2009-08-23 18:32:29 +00:00
1711f5899b
From Ivan Sy:
...
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not
just its equivalent.
Cleaned up presentation and included record number as well.
svn path=/trunk/; revision=29528
2009-08-23 17:18:29 +00:00
23d4eba3b1
Custom columnfication:
...
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta
svn path=/trunk/; revision=29524
2009-08-23 12:30:48 +00:00
b9cbd15469
Custom columnfication:
...
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative
svn path=/trunk/; revision=29523
2009-08-23 12:24:14 +00:00
55cf35e3a0
Custom columnfication:
...
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci
svn path=/trunk/; revision=29522
2009-08-23 12:16:10 +00:00
375f355046
Update list of PPIDs.
...
This fixes bug 3928.
svn path=/trunk/; revision=29520
2009-08-23 11:30:54 +00:00
51ca1739ae
Custom columfication:
...
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield
svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
00670c55c6
Custom columfication:
...
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid
svn path=/trunk/; revision=29517
2009-08-23 10:25:51 +00:00
205129d25c
Custom columfication:
...
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys
svn path=/trunk/; revision=29516
2009-08-23 10:20:42 +00:00
56369978ae
Custom columfication:
...
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call
svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
6b89de8393
Custom columfication:
...
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority
svn path=/trunk/; revision=29513
2009-08-23 09:07:54 +00:00
dfac9e4091
Get rid of a bunch of "warning: redundant redeclaration of" messages.
...
In that process, include the contents of packet-fmp_notify.h directly
in packet-fmp_notify.c - it wasn't used anywhere else.
svn path=/trunk/; revision=29512
2009-08-23 06:57:16 +00:00
6444abbf7e
Avoid 'cast to pointer from integer of different size'
...
svn path=/trunk/; revision=29511
2009-08-23 05:20:30 +00:00
035231b534
From Frederic Peters (made endian-aware by me):
...
fixed segfault with some GIOP packets
svn path=/trunk/; revision=29509
2009-08-22 22:46:41 +00:00
602e3a09e0
Remove col_check() guard wrt. COL_REL_CONV_TIME/COL_DELTA_CONV_TIME
...
svn path=/trunk/; revision=29508
2009-08-22 19:53:54 +00:00
fdf21357fc
From Ivan Sy:
...
NSEC3PARAM RR (RFC 5155), APL RR (RFC 3123), PX RR (RFC 2163), GPOS RR (RFC 1712),
NSAP RR (RFC 1706), NSAP-PTR RR (RFC 1348), AFSDB, RP, X25, ISDN, RT, RR (RFC 1183).
Also cleanup of protocol tree dependancies.
svn path=/trunk/; revision=29506
2009-08-22 17:28:54 +00:00
66afe84075
Use <gcrypt.h> instead of 'gcrypt.h'
...
svn path=/trunk/; revision=29501
2009-08-21 20:40:49 +00:00
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
9661baf237
Remove unneeded #includes
...
svn path=/trunk/; revision=29497
2009-08-21 19:48:11 +00:00
27f7d88c84
Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
...
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
7945bf1bc9
From Harald Welte :
...
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919
From me try to fix missuse of pinfo.
svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
283dbb4414
As pointed out by Alexis La Goutte via PM, r29474 didn't
...
support the different MAC formats (eui48 and eui64) properly.
Now, eui48 is printed as mac, the rest is still handled as
blob.
svn path=/trunk/; revision=29476
2009-08-19 15:42:24 +00:00
69069395df
Add support for Radio Mac/Wireless Specific Information optional
...
header fields. This patch lacks handling of padding since a) I don't
have a trace containing padding and b) I don't understand the
wording in the rfc (it's to ambigous for my liking).
svn path=/trunk/; revision=29474
2009-08-19 12:25:40 +00:00
8e00a20710
From Jochen Bartl:
...
EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907
svn path=/trunk/; revision=29473
2009-08-19 11:34:40 +00:00
87da96be52
From Jan Lübbe:
...
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915
svn path=/trunk/; revision=29472
2009-08-19 09:32:56 +00:00
43cbf13ad4
Minor clean up.
...
svn path=/trunk/; revision=29466
2009-08-18 14:39:32 +00:00
b62e6545b9
Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual.
...
svn path=/trunk/; revision=29464
2009-08-18 13:25:49 +00:00
c8ec27c000
Make build bot happy?
...
svn path=/trunk/; revision=29463
2009-08-18 12:15:36 +00:00
a4109274e2
Typo: parameter_tvb to be used.
...
svn path=/trunk/; revision=29462
2009-08-18 11:39:55 +00:00
a4e174b7f8
From Swapnil Barai:
...
Minor Bug in Bearer Context in Packet-gtpv2.c fixed.
svn path=/trunk/; revision=29460
2009-08-18 06:41:12 +00:00
d777d1dfed
Display Microsoft's Remote Desktop Protocol (RDP) extension to the X.224
...
connection request that shows the session load balancing information. There
appears to be more dissecting that can be done for this field, but I don't
have any sample captures to test this.
svn path=/trunk/; revision=29459
2009-08-18 00:32:11 +00:00
8de8a1cb6e
setbit() is (AFAIK) defined in <sys/param.h> (OpenBSD) so rename to dect_setbit() to avoid clash. getbit() is also renamed for consistency.
...
Fixes the issue reported by Stan: http://www.wireshark.org/lists/wireshark-users/200908/msg00128.html
svn path=/trunk/; revision=29456
2009-08-17 17:19:31 +00:00
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
96b2c411dd
The frame dissector contains a kludge to workaround the fact that the Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380.
...
svn path=/trunk/; revision=29428
2009-08-15 08:05:10 +00:00
7d44262406
This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation:
...
1) The tvb + name (aka. data_source) is only used when the protocol tree is visible
The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify.
A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated!
svn path=/trunk/; revision=29427
2009-08-15 06:38:10 +00:00
8760a6b49d
Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants).
...
svn path=/trunk/; revision=29420
2009-08-15 01:29:29 +00:00
97fda7386c
Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893
svn path=/trunk/; revision=29403
2009-08-13 12:17:20 +00:00
e7ed279da9
fix build failure without GnuTLS
...
svn path=/trunk/; revision=29402
2009-08-13 11:12:35 +00:00
ae5e82dc11
use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC
...
svn path=/trunk/; revision=29401
2009-08-13 10:36:53 +00:00
ebc78f0a07
Fix SSL decryption failure if client and server have the same TCP port
...
svn path=/trunk/; revision=29400
2009-08-13 09:07:03 +00:00
6aed88fadc
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891
svn path=/trunk/; revision=29399
2009-08-13 07:56:13 +00:00
088110624e
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886
svn path=/trunk/; revision=29398
2009-08-12 22:40:13 +00:00
5bd6d8eaaf
From William Preston via. 3549:
...
A typo in 2 of the field names causes the apn not to be displayed.
svn path=/trunk/; revision=29394
2009-08-12 15:12:19 +00:00
181f4c8364
Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
...
svn path=/trunk/; revision=29393
2009-08-12 12:55:27 +00:00
cb5415d399
fix memoryleak causing crash with long SSL traces
...
svn path=/trunk/; revision=29392
2009-08-12 06:10:08 +00:00
7267ec9782
Complete the fix in r29389.
...
svn path=/trunk/; revision=29390
2009-08-11 23:52:04 +00:00
4bfcd5993a
Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel
...
is unknown. Fixes bug 3864.
svn path=/trunk/; revision=29389
2009-08-11 23:44:22 +00:00
1f3776bf8b
Add some length checks.
...
svn path=/trunk/; revision=29388
2009-08-11 23:29:21 +00:00
80fbe4959a
From Ivan Sy (with minor modifications):
...
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.
svn path=/trunk/; revision=29387
2009-08-11 23:20:03 +00:00
07900e7a1a
From swapnil:
...
Small Bug in TFT (Flow label) and ULI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876
svn path=/trunk/; revision=29386
2009-08-11 21:27:36 +00:00
f625c7131d
Use the right size for FT_UINT16.
...
svn path=/trunk/; revision=29385
2009-08-11 21:11:12 +00:00
809fb769b4
Add some length checks. Fixes a few recent fuzz bugs.
...
svn path=/trunk/; revision=29384
2009-08-11 20:58:36 +00:00
0ff1dd7142
Add a bunch of length checks. Fixes bug 3826.
...
svn path=/trunk/; revision=29383
2009-08-11 18:37:59 +00:00
ca1cba6f30
Don't coerce a (void *) to a (guint32 *).
...
The (void *) pointer in this case may point to
"unaligned" data.
svn path=/trunk/; revision=29378
2009-08-11 13:44:35 +00:00
6c2c08c082
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R4 and R5).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866
svn path=/trunk/; revision=29377
2009-08-11 12:22:00 +00:00
bae780d14b
From swapnil:
...
Bugs Fixed in ULI in packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3860
svn path=/trunk/; revision=29376
2009-08-11 10:32:46 +00:00
a8fbd4577f
From swapnil:
...
Another Minor Bug for ULI in Packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3862
svn path=/trunk/; revision=29374
2009-08-11 07:41:46 +00:00
c6893212f1
For TLV items that are a single integral value and thus must have a
...
certain length:
attach the expert item to the length field if we're showing it,
otherwise put in a text item for the malformed TLV and attach
the expert item to that;
don't give up, as we'll just skip the bad item and move on to
the next item.
svn path=/trunk/; revision=29373
2009-08-10 22:15:22 +00:00
a8533d84e5
Initialize a variable to keep GCC happy ....
...
svn path=/trunk/; revision=29372
2009-08-10 21:46:30 +00:00
d7ecb89489
Validate two tag field lengths before attempting to do proto_tree_add_item();
...
Fixes bug #3841 .
svn path=/trunk/; revision=29371
2009-08-10 21:07:15 +00:00
72d8e6ad54
From Steve Osselton:
...
GIOP dissector update for MIOP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3847
svn path=/trunk/; revision=29369
2009-08-10 19:53:12 +00:00
6c352a2959
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3819
svn path=/trunk/; revision=29368
2009-08-10 19:48:42 +00:00
41aa8b4ed7
(Quick) fix for bug #3836 ;
...
Allow the DIR ("direction") AVP to be of variable length
(in the absence of any documentation for this protocol).
See the source for further comments.
svn path=/trunk/; revision=29367
2009-08-10 18:45:47 +00:00
842d1be224
Fix the build.
...
svn path=/trunk/; revision=29363
2009-08-10 15:33:54 +00:00
1e7031f1c0
Ivan Sy <ivan_jr@yahoo.com> via bug 3814
...
TTL-Check for local network group addresses: Normally the
only valid TTL is 1. Add a check for VRRP and GLBP, where
the only valid TTL is 255.
Me: change the logic so the funtion returns the valid ttl
instead of true/false.
svn path=/trunk/; revision=29362
2009-08-10 14:55:47 +00:00
fa940d3366
Use PTREE_FINFO.
...
svn path=/trunk/; revision=29356
2009-08-09 18:05:44 +00:00
083729e02c
Add PTREE_FINFO and use PITEM_FINFO when possible.
...
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
c1fea16295
Don't use DISSECTOR_ASSERT to check source/destination address type.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3825
svn path=/trunk/; revision=29347
2009-08-09 10:50:30 +00:00
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
6110a96f68
Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
0a5b014cec
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
5d5a5442d6
Don't guard col_set_str (COL_RES_DL_SRC/COL_RES_DL_DST) with col_check
...
svn path=/trunk/; revision=29343
2009-08-09 07:14:16 +00:00
4b6090e576
Don't guard col_set_str (COL_INFO) with col_check
...
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
24ca3c44c9
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29341
2009-08-09 06:47:24 +00:00
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
fc067ab910
Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug
...
3827.
svn path=/trunk/; revision=29339
2009-08-09 01:23:09 +00:00
ced157e4b7
Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658
svn path=/trunk/; revision=29336
2009-08-08 09:57:07 +00:00
4f501b3655
From Ivan Sy:
...
Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460.
svn path=/trunk/; revision=29334
2009-08-08 04:51:42 +00:00
7cf4114654
If we have a format error, don't try adding something to the
...
tree. Fixes bug 3822.
svn path=/trunk/; revision=29331
2009-08-08 00:27:31 +00:00
7110e957f6
From Matt P via bug 3774:
...
Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3()
routine to dynamically calculate the remaining payload length. This is then
compared to the length included in the CCSDS header.
svn path=/trunk/; revision=29329
2009-08-07 21:53:40 +00:00
d9531723b5
- Add rfc number comments on not-yet-decoded options
...
- Decode autoconfigure option
svn path=/trunk/; revision=29325
2009-08-07 18:45:06 +00:00
367bcb7abd
Clean up the last two DIRTY_DISSECTOR_SRC entries.
...
svn path=/trunk/; revision=29321
2009-08-07 00:15:35 +00:00
3c1bc8f251
Fix some individual cases of 'if (unsigned) < 0'
...
svn path=/trunk/; revision=29320
2009-08-06 23:51:45 +00:00
4acb789917
'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned.
...
The fix: change to 'if ((signed)curr_len <= 0)'.
This is a bit of a hack but I think it works.
See the comment in this file (packet-gsm_a_common.h).
svn path=/trunk/; revision=29319
2009-08-06 23:47:21 +00:00
c3aaf166c6
Those items are 32 bits or longer, so the cast should be safe; add an
...
additional cast in the hopes that they squelch "dereferencing
type-punned pointer" warnings.
svn path=/trunk/; revision=29318
2009-08-06 23:26:24 +00:00
8fcdcbd14f
packet-sctp.c seems to be clean (at least it is on Mac OS X).
...
svn path=/trunk/; revision=29317
2009-08-06 22:26:05 +00:00
191709f6af
Get it compiling when HAVE_LIBGCRYPT is not defined.
...
svn path=/trunk/; revision=29315
2009-08-06 21:55:10 +00:00
b38516fbd9
Fix some indentation and spacing
...
svn path=/trunk/; revision=29314
2009-08-06 21:42:40 +00:00
85f68c7461
Fix compilation warnings in a few dissectors and try moving them to the
...
"clean" list.
svn path=/trunk/; revision=29313
2009-08-06 20:55:04 +00:00
21d8e2d3e1
Prevent possible (benign ?) array references with an array index of -1.
...
svn path=/trunk/; revision=29312
2009-08-06 18:44:38 +00:00
eba5297683
Remove inadvertantly committed comments re issue yet to be fixed ...
...
svn path=/trunk/; revision=29311
2009-08-06 16:13:31 +00:00
413e64f1a6
Register ett[] subtree array only once.
...
svn path=/trunk/; revision=29310
2009-08-06 16:10:29 +00:00
7f7161f819
Register ett[] subtree array only once.
...
svn path=/trunk/; revision=29309
2009-08-06 16:06:11 +00:00
595f9b6630
Convert a GString to an ep_strbuf_t (and squelch a static analysis
...
warning in the process). Remove an unused variable.
svn path=/trunk/; revision=29308
2009-08-05 19:03:48 +00:00
b5aa261da6
From Gerasimos Dimitriadis:
...
Fixes/enhances the decoding of the Mobile Identity IE for type of identity
"TMGI and optional MBMS Session Identity".
svn path=/trunk/; revision=29307
2009-08-05 18:42:45 +00:00
8787b8ecc8
Fix for bug 3811:
...
Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml.
svn path=/trunk/; revision=29306
2009-08-05 18:21:52 +00:00
5c57e015d4
From Ivan Sy:
...
Add support for Support for DHCID RR (RFC 4701).
svn path=/trunk/; revision=29305
2009-08-05 18:17:18 +00:00
92b2bcf28a
Show power headroom report inside its own subtree.
...
svn path=/trunk/; revision=29303
2009-08-05 08:02:12 +00:00
203269175e
Fix for bug 3806:
...
Add presentation of Block Ack Bitmap.
svn path=/trunk/; revision=29302
2009-08-05 07:33:44 +00:00
931a750908
Add a couple of pointer checks.
...
svn path=/trunk/; revision=29301
2009-08-05 00:36:27 +00:00
c9e3f66d14
Optimize empty strings to NULL pointers.
...
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
d0f569953d
Fix benign double subtree registration of an ett_... variable.
...
svn path=/trunk/; revision=29297
2009-08-04 19:29:42 +00:00
cb7dac7100
Initialize several ett_... variables to -1
...
svn path=/trunk/; revision=29295
2009-08-04 18:52:01 +00:00
90e865cc54
Init ett_... variables to -1
...
svn path=/trunk/; revision=29294
2009-08-04 18:48:45 +00:00
8ffaa3b880
Remove duplicate entry from ett[]
...
svn path=/trunk/; revision=29293
2009-08-04 18:46:51 +00:00
b6660d06bf
Clean up white space a bit - use 2-space indenting.
...
Put a bunch of code that does nothing unless data_val is non-null inside
"if (data_val)", and get rid of the individual tests.
svn path=/trunk/; revision=29292
2009-08-04 18:39:43 +00:00
49c58bc1a4
Miscellaneous cleanups.
...
svn path=/trunk/; revision=29291
2009-08-04 17:59:48 +00:00
fef272347b
Show number of predefined bytes in info column.
...
svn path=/trunk/; revision=29290
2009-08-04 10:41:08 +00:00
87c095780a
Rework an assignment to keep static analyzers from complaining.
...
svn path=/trunk/; revision=29287
2009-08-03 23:51:13 +00:00
bd97aecdd3
Clean up indentation somewhat.
...
svn path=/trunk/; revision=29281
2009-08-03 21:17:30 +00:00
2c9c96744d
From Gerasimos Dimitriadis:
...
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.
svn path=/trunk/; revision=29280
2009-08-03 21:12:41 +00:00
f3944baaf0
Thou shalt terminate thy value_string arrays with {0, NULL}.
...
svn path=/trunk/; revision=29279
2009-08-03 21:07:08 +00:00
8224d4e436
Add a null pointer check. Remove some unused variables.
...
svn path=/trunk/; revision=29278
2009-08-03 19:50:35 +00:00
e0336d1243
From Ivan Sy:
...
Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension.
svn path=/trunk/; revision=29277
2009-08-03 18:23:04 +00:00
d4e1095f54
Reword some help text slightly.
...
svn path=/trunk/; revision=29274
2009-08-03 16:21:55 +00:00
1792c7d1a4
Do find_dissector_table() in proto_reg_handoff().
...
svn path=/trunk/; revision=29272
2009-08-03 15:18:44 +00:00
41a9e1c16f
(Trivial) Fix two typos.
...
svn path=/trunk/; revision=29271
2009-08-03 14:17:31 +00:00
dd79032722
Added missing packet-usb-hid.h
...
svn path=/trunk/; revision=29270
2009-08-03 09:58:14 +00:00
7714e602c8
Handle usb_hid_item_usage_vals as range_string.
...
svn path=/trunk/; revision=29269
2009-08-03 08:05:44 +00:00
2602c42fcb
Do dissector_add() only if port non-zero; register dissector for "decode-as".
...
svn path=/trunk/; revision=29268
2009-08-02 19:54:33 +00:00
3a61b43a42
packet-stun2 registers for TCP & UDP port 3478 so packet-stun need not register for same.
...
svn path=/trunk/; revision=29267
2009-08-02 19:20:20 +00:00
fa3443bbc1
Change default range from 1401,1401 to 1401 so that the port isn't double-registered.
...
svn path=/trunk/; revision=29266
2009-08-02 19:17:09 +00:00
1ab1e3889c
Don't do dissector_add twice on TCP port 3689;
...
packet-daap requests registration on that port via http_dissector_add
and thus packet-http does not need to do a default registration on that port.
Also: fix a typo in a comment.
svn path=/trunk/; revision=29265
2009-08-02 19:09:36 +00:00
082db3982a
Remove unneeded #include <epan/emem.h>; fix some indentation.
...
svn path=/trunk/; revision=29261
2009-08-02 12:58:57 +00:00
672a9f6e62
Add additional cypher types.
...
svn path=/trunk/; revision=29260
2009-08-02 12:53:14 +00:00
18478a63bc
Fix for bug 3800:
...
Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet.
svn path=/trunk/; revision=29259
2009-08-02 12:11:38 +00:00
ed930bece3
Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies.
...
svn path=/trunk/; revision=29258
2009-08-01 09:52:12 +00:00
f846e15d40
Fix indentation, get rid of a comment that might no longer apply (dump
...
*what* as hex? The stuff we now display as generic fields?).
svn path=/trunk/; revision=29257
2009-07-31 23:38:02 +00:00
62b8aa0837
From Adam Nielsen via bug 3659:
...
Here is a patch against SVN that implements preliminary support for USB HID
devices. At the moment it only dissects the initial set up packets (which you
will see if you hotplug a keyboard or mouse.)
The patch also fixes a minor bug in the USB dissector code which reported
certain packets as malformed due to miscounting bytes, and it reports control
packet data and padding data in a more user-friendly manner.
svn path=/trunk/; revision=29256
2009-07-31 22:16:29 +00:00
99bd70035d
Completely remove an unused variable, don't just comment it out
...
(especially with a C++/C99-style comment that not all compilers used to
compile Wireshark accept).
svn path=/trunk/; revision=29255
2009-07-31 20:13:53 +00:00
ee5d2e8788
From Holger Freyther via bug 3776:
...
Part 1:
Rename packet-gsm_abis_ip.c to packet-gsm_ipa.c.
Part 2:
Rename to the content to match the filename.
Part 3:
Add GSM A/SCCP support to the packet-gsm_ipa.c dissector
Adjusted patch to take laforge's comment into account. Use guint16 for the
length and use the ntohs routine to convert the length.
svn path=/trunk/; revision=29254
2009-07-31 19:19:25 +00:00
dd28a00a78
From Ivan Sy via bug 3797:
...
Support for SPF RR (RFC 4408)
- this has the same format as TXT RR (see section 3.1.1) below.
Currently wireshark 1.2.1 shows this as Unknown type 99
svn path=/trunk/; revision=29253
2009-07-31 16:37:53 +00:00
08b2e76773
From Ivan Sy:
...
Add support for SSHFP RR (RFC 4255).
svn path=/trunk/; revision=29252
2009-07-31 07:05:43 +00:00
0553926fcc
From Ivan Sy:
...
NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name.
svn path=/trunk/; revision=29250
2009-07-31 06:51:27 +00:00
9a35ed601d
Remove more unused variables.
...
svn path=/trunk/; revision=29249
2009-07-30 23:47:36 +00:00
db0698fd0a
Fix warnings:
...
the behavior of x = x++ is undefined by the ANSI C standard -
they obviously just meant x++;
get rid of unused variables.
svn path=/trunk/; revision=29248
2009-07-30 21:40:22 +00:00
532f424f33
From swapnil:
...
Packet-gtpv2.c dissector extended to support more IE's.
svn path=/trunk/; revision=29247
2009-07-30 21:11:26 +00:00
b249ff0487
Remove a couple of unused variables.
...
svn path=/trunk/; revision=29245
2009-07-30 17:22:00 +00:00
0abc55b7fc
Show backoff indicator value in subheader tree root.
...
svn path=/trunk/; revision=29244
2009-07-30 16:53:33 +00:00
e951661130
Remove some unused variable assignments.
...
svn path=/trunk/; revision=29243
2009-07-30 16:17:46 +00:00
0cceb40317
Remove some unused variables.
...
svn path=/trunk/; revision=29242
2009-07-30 00:40:32 +00:00
62a8504eda
Function dissect_zcl_attr_data_type() unused: comment it out
...
svn path=/trunk/; revision=29240
2009-07-29 22:54:28 +00:00
6de62aee00
Fix a potential crash and do various other minor changes:
...
- Fix an hf[] entry which had an invalid "strings" field which could cause a crash;
- Remove unneeded #includes;
- Make most functions & etc static;
- Remove declarations for functions never defined;
- Fix certain comments to refer to the correct function names;
- Change global variable to be local to proto_reg_handoff...
- ...
svn path=/trunk/; revision=29239
2009-07-29 22:33:08 +00:00
ad74edb139
From Chris Costa: Fix Bug 3786: "NDMP fragmentation fails when final fragment is very small".
...
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3786 )
svn path=/trunk/; revision=29236
2009-07-29 20:24:10 +00:00
512a32889c
Add packet-zbee-zcl.h to the source tarball.
...
svn path=/trunk/; revision=29235
2009-07-29 19:39:17 +00:00
d779b4f96f
From Neil Piercy:
...
The Cert Authority hashes in the IKEv2 Cert Request are not dissected properly:
the display offset is not correctly moved on, so the same info is displayed for
all Cert Authority fields.
svn path=/trunk/; revision=29234
2009-07-29 18:26:55 +00:00
148263ebf0
zigbee cluster dissector,
...
modified from entry in bug 3765 so it compiles cleanly
svn path=/trunk/; revision=29232
2009-07-29 11:29:53 +00:00
ad942553b3
start describing ReportEventW in the IDL and make use of the "bitmap"
...
for EventTypes.
This addresses also bug 3552 with the until now unusued code.
The eventlog dissector is very incomplete.
While the protocol specification is available now, what is lacking is
example capture files to test with when implementing more of the IDL
definitions.
svn path=/trunk/; revision=29231
2009-07-29 10:59:31 +00:00
e5f6cb05da
Fixup the correct names of the parameters for OpenEventLogW
...
svn path=/trunk/; revision=29230
2009-07-29 10:41:24 +00:00
1899a11f3f
update the idl to correctly dissect the read eventlog w flags as a
...
bitmap and not as a uint32
this addresses bug 3691 (that was already manually addressed by hand
in the generated dissector)
svn path=/trunk/; revision=29229
2009-07-29 10:28:10 +00:00
f56e93d1a5
Support for IPv6 addresses in URI
...
svn path=/trunk/; revision=29227
2009-07-29 09:13:03 +00:00
cde25ec6a2
From Ivan Sy:
...
Support for DLV RR (RFC 4431) and SHA-256 Digest for DS RR (RFC 4509).
svn path=/trunk/; revision=29226
2009-07-29 07:10:02 +00:00
cfc60e805d
update samr.idl and remove a keyword we no longer support in pidl
...
regenerate samr and frstrans with the new version of pidl
svn path=/trunk/; revision=29219
2009-07-28 14:11:08 +00:00
77fc0c9451
From Stefan Metzmacher
...
add generated FRSTRANS dissectors and add them to the build
svn path=/trunk/; revision=29217
2009-07-28 13:53:10 +00:00
3c1de7c38e
From Stefan Metzmacher :
...
Add IDL file for FRSTRANS
svn path=/trunk/; revision=29216
2009-07-28 13:50:22 +00:00
4802884629
regenerate SAMR using the new version of pidl
...
svn path=/trunk/; revision=29215
2009-07-28 13:39:42 +00:00
f8cf2d2c83
When we passed the crytobuffer to krb5_c_decrypt() we never actually
...
verified that we did have enough data in the buffer/tvb, which could
lead to a SEGV.
(for example if we enable KRB5 decryption but we do NOT use TCP
reassembly, and the encrypted data goes beyong the end of the current
segment)
Change the signature to decrypt_krb5_data() to take a TVB instead of a
buffer+length.
Actually check that we do have the entire encrypted PDU before calling
out to the kerberos libraries.
svn path=/trunk/; revision=29213
2009-07-28 13:01:41 +00:00
ac1b52a838
From: Matthieu Patou <mat+Informatique.Samba@matws.net>
...
Date: Mon, 27 Jul 2009 08:55:55 +0000 (+0200)
Subject: patch_ldap_260709
Add a few additional LDAP OIDs
and increase the maximum SASL blob size to be 1M instead of 256kb
svn path=/trunk/; revision=29210
2009-07-28 07:18:05 +00:00
dece30a6ce
Improve defragmentation:
...
1. Prevent tcpencap (ipsec-tcp) from incorrectly dissecting NDMP PDU fragments;
(Essentially: register NDMP as the dissector for the conversation);
Allows correct NDMP fragment reassembly whether or not the
TCP "Try heuristic sub-dissectors first" preference is enabled.
Fixes Bug #3755 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3755 )
2. Use a registered init routine to init the fragment and reassembled tables
each time a complete capture dissection is (re)started.
Fixes a crash.
3. Don't register on TCP port 10000 since the tcpencap dissector needs to own this
port. (The NDMP dissector is a heuristic dissector).
4. Strengthen the heuristic checking slightly.
5. Other minor changes.
svn path=/trunk/; revision=29208
2009-07-27 21:59:01 +00:00
d28b7ad2b8
From Vladimir Smrekar:
...
Change, that fix infinite loop for dissections of elements:
- Pulse notification
- Line Information
- PSTN FSM state
- Autonomous signalling sequence
- Sequence response
- Performance grading
- Rejection cp cause
Me prefix hf vars with hf_v52_
svn path=/trunk/; revision=29207
2009-07-27 14:47:12 +00:00
61683c409a
Move proto_reg_handoff to the end ...
...
svn path=/trunk/; revision=29206
2009-07-27 14:45:25 +00:00
d446944c82
From Gerasimos Dimitriadis:
...
Decoding support for 4 DTAP IEs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777
svn path=/trunk/; revision=29204
2009-07-27 13:08:17 +00:00
b86e69f348
Use consistent indentation ...
...
svn path=/trunk/; revision=29185
2009-07-23 21:25:02 +00:00
f0d16b990f
From Gerasimos Dimitriadis:
...
Minor enhancement to LAI decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3770
svn path=/trunk/; revision=29182
2009-07-23 20:36:16 +00:00
241aa76fc9
Saved by removing the bell.
...
svn path=/trunk/; revision=29181
2009-07-23 18:36:25 +00:00
65faee6470
Set editor modelines to be consistent between emacs and vi/ex;
...
Indentation and whitespace cleanup;
svn path=/trunk/; revision=29180
2009-07-23 17:46:09 +00:00
7b07422574
Don't divide the data rate by 2 - that loses information (yes, I have a
...
trace with at least one packet transmitted at 5.5 Mb/s).
Clean up indentation.
svn path=/trunk/; revision=29178
2009-07-23 09:32:58 +00:00
832087bfbf
- Ambiguous value for radiotap datarate.
...
The value given to proto_tree_add_uint_format() was not divided by 2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3747
- remove check_col()
- Indentation changes.
svn path=/trunk/; revision=29177
2009-07-23 08:56:09 +00:00
1e7878b53d
From Steve Karg:
...
BACnet Action property not decoded correctly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3766
svn path=/trunk/; revision=29173
2009-07-23 05:38:34 +00:00
f1e8e405ce
From Neil Piercy:
...
Another missing RRC dissector chaining link.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3769
svn path=/trunk/; revision=29172
2009-07-23 05:32:31 +00:00
0b0ff6cdcf
Get rid of check_col() in some of the more frequently used dissectors.
...
svn path=/trunk/; revision=29170
2009-07-22 21:33:47 +00:00
41b86b26b8
Improve/expand checks on reserved bit values.
...
svn path=/trunk/; revision=29167
2009-07-22 13:21:15 +00:00
7e99557d05
Another try to fix the compiler warnings on win64.
...
svn path=/trunk/; revision=29161
2009-07-21 22:23:34 +00:00
49cb1d37ee
Cummulative number of packets lost is a signed 24 bits value.
...
This fixes bug 3763.
Cleanup some proto_tree_add_uint() -> proto_tree_add_item().
svn path=/trunk/; revision=29160
2009-07-21 22:09:31 +00:00
Guy Harris