osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
29,154 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

8651 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam 830dd8e8f0 * Prefer col_append_str instead of col_append_fstr for constant strings 
* Remove check_col guards

svn path=/trunk/; revision=30126
 2009-09-24 20:07:41 +00:00
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col 
svn path=/trunk/; revision=30125
 2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam cf8138e195 Remove check_col() guard 
svn path=/trunk/; revision=30124
 2009-09-24 19:50:43 +00:00
Bill Meier bc67c25759 Remove unneeded #includes (along with C++ style comments added by mistake in the last commit). 
svn path=/trunk/; revision=30123
 2009-09-24 19:50:00 +00:00
Bill Meier 4a73b89199 Minor: Use tvb_reported_length... not tvb_length... 
svn path=/trunk/; revision=30122
 2009-09-24 19:26:45 +00:00
Bill Meier 8f95ef909a Various: 
- check_col no longer req'd;
 - Remove unneeded #includes;
 - Use consistent indentation/style;
 - Reformat a few lines;

svn path=/trunk/; revision=30121
 2009-09-24 19:05:26 +00:00
Bill Meier bc2f7b7b8b Add what appear to be missing breaks in two cases of a switch () {...}. 
svn path=/trunk/; revision=30119
 2009-09-24 19:01:42 +00:00
Bill Meier 263a93b9f3 Minor changes: 
- Use col_clear only once (in the right place);
 - Use col_add_fstr instead of col_clear/col_append_fstr;
 - check_col no longer req'd;

svn path=/trunk/; revision=30118
 2009-09-24 17:30:20 +00:00
Bill Meier 4bd230c8f2 Minor changes: 
Use col_clear (in the right place) instead of col_set_str(...,"");
  check_col no longer req'd;

svn path=/trunk/; revision=30117
 2009-09-24 16:54:54 +00:00
Bill Meier 8b2d2d9488 Minor changes: 
- remove unneeded includes;
 - check_col no longer req'd;
 - move proto_register/proto_reg_handoff to the end of the file;
 - fix some typos;

svn path=/trunk/; revision=30116
 2009-09-24 16:22:37 +00:00
Bill Meier 4f39e04e29 Minor changes: 
- check_col no longer req'd;
- use tvb_strncaseeql instead of tvb_get_ptr & etc;
- Change if (guint > 0) to if (guint != 0).

svn path=/trunk/; revision=30114
 2009-09-24 15:44:59 +00:00
Kovarththanan Rajaratnam 82778b3f86 Use val_to_str_const() since we intend on passing the string to col_set_str (which expects a constant string) 
svn path=/trunk/; revision=30112
 2009-09-24 13:36:02 +00:00
Anders Broman 9ac672ca81 Update *.vcproj to visual studio 8 
svn path=/trunk/; revision=30111
 2009-09-24 05:11:47 +00:00
Kovarththanan Rajaratnam 0b5f235491 Call subdissector even when tree is NULL 
svn path=/trunk/; revision=30108
 2009-09-24 04:52:35 +00:00
Jaap Keuter d909f9f62c Fix for bug 4046: 
Fix type of FIP dissector header field hf_fip_desc_map.

svn path=/trunk/; revision=30103
 2009-09-23 19:14:35 +00:00
Bill Meier 8790ed892f Define a global variable as static; 
#include <stdio.h> & <stdlib.h>  not req'd.

svn path=/trunk/; revision=30101
 2009-09-23 18:20:06 +00:00
Bill Meier 9310f13f19 Change gchar foo[mm][nn] = {"xxx", "yyy", ...} to static const gchar *foo[mm] = {...} 
Add a comment about a possible bug: some strings in array are never used ?
Do some minor reformatting.

svn path=/trunk/; revision=30097
 2009-09-23 17:55:37 +00:00
Bill Meier 81444cdda0 Quick fix for Bug #4040. 
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4040

ToDo: Fix usage of
 gchar xxx[..][..] = {"aaa", "bbb", ...};

svn path=/trunk/; revision=30094
 2009-09-23 16:06:39 +00:00
Anders Broman 1b454d9012 Propagate the changes to the .cnf file so they don't get lost when regenerating the dissector. 
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO

svn path=/trunk/; revision=30092
 2009-09-23 15:43:55 +00:00
Kovarththanan Rajaratnam 90a5e748c2 Don't col_clear(COL_PROTOCOL) followed by col_set_str(COL_PROTOCOL). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though) 
svn path=/trunk/; revision=30090
 2009-09-23 14:59:22 +00:00
Kovarththanan Rajaratnam 124faf721c Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO 
svn path=/trunk/; revision=30089
 2009-09-23 14:52:01 +00:00
Kovarththanan Rajaratnam 633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL 
svn path=/trunk/; revision=30088
 2009-09-23 14:43:23 +00:00
Kovarththanan Rajaratnam 99624329fa Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though) 
svn path=/trunk/; revision=30086
 2009-09-23 14:30:36 +00:00
Kovarththanan Rajaratnam c28bafe341 Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO 
svn path=/trunk/; revision=30082
 2009-09-22 21:18:11 +00:00
Anders Broman 2cacda1823 From Vincent Helfre: 
MS network capability enhancement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4039

svn path=/trunk/; revision=30075
 2009-09-22 19:15:30 +00:00
Anders Broman b8af7c77c8 From Gerasimos Dimitriadis: 
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

svn path=/trunk/; revision=30064
 2009-09-22 06:42:10 +00:00
Jaap Keuter f4b9554a27 From Julian Fielding: 
Function dissect_epath() expects path_length in bytes, but the value from the 
packet is in words, so there's lots of *2 and /2 in those parts of the code.
In this invocation dissect_epath( tvbIOI, pi, 0, preq_info->IOILen, TRUE );
preq_info->IOILen is in words.

In six places proto_tree_add_item is used with tvb NULL and size 0 to add an
FT_UINT8/16/32 item. I think it should be replaced with proto_tree_add_uint().

svn path=/trunk/; revision=30061
 2009-09-22 05:49:15 +00:00
Kovarththanan Rajaratnam 3ea9409792 Store 'color_filter' as const in 'frame_data' 
svn path=/trunk/; revision=30051
 2009-09-21 18:48:53 +00:00
Michael Tüxen 5879399609 Add initial support for DNS/SCTP. 
svn path=/trunk/; revision=30035
 2009-09-21 12:00:03 +00:00
Anders Broman c9dcf6c415 From Gerasimos Dimitriadis: 
DTAP decoding of Notification Indicator IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4029

svn path=/trunk/; revision=30028
 2009-09-20 21:54:39 +00:00
Jaap Keuter 1da709093c From Kjell Hultman: 
IEC104 Signal dissection added - not complete (only implemented what I needed for the moment).

svn path=/trunk/; revision=30026
 2009-09-20 21:08:04 +00:00
Kovarththanan Rajaratnam ebaaada382 Only duplicate string the first time around, i.e. 'pinfo->fd->flags.visited == FALSE' or else we end up leaking memory 
svn path=/trunk/; revision=30013
 2009-09-20 13:36:16 +00:00
Kovarththanan Rajaratnam a569e8d5b8 Use tvb_get_ephemeral_string() to avoid memleak (should have been part of r29994. 
svn path=/trunk/; revision=30003
 2009-09-20 08:42:51 +00:00
Kovarththanan Rajaratnam 9441e9b344 Use tvb_get_ephemeral_stringz() instead of tvb_get_stringz() 
svn path=/trunk/; revision=30002
 2009-09-20 08:40:01 +00:00
Kovarththanan Rajaratnam 57659e8133 Use tvb_get_ephemeral_string() to avoid memleak. 
svn path=/trunk/; revision=30001
 2009-09-20 08:35:49 +00:00
Kovarththanan Rajaratnam 47bdc0fda3 Use tvb_get_ephemeral_string() instead of tvb_get_string() 
svn path=/trunk/; revision=30000
 2009-09-20 08:31:24 +00:00
Kovarththanan Rajaratnam 6ec8e0ced3 Use tvb_get_ephemeral_string() instead of tvb_get_string() 
svn path=/trunk/; revision=29999
 2009-09-20 08:28:04 +00:00
Kovarththanan Rajaratnam acf0f2cdb4 Use ep_alloc() instead of g_malloc() for packet scoped allocations 
svn path=/trunk/; revision=29998
 2009-09-20 08:24:35 +00:00
Kovarththanan Rajaratnam 323e784022 Use tvb_get_ephemeral_string() to avoid memleak. 
svn path=/trunk/; revision=29996
 2009-09-20 08:15:51 +00:00
Kovarththanan Rajaratnam 47db27fcc1 Use ep_alloc() instead of g_malloc() for packet scoped allocations 
svn path=/trunk/; revision=29995
 2009-09-20 08:09:40 +00:00
Kovarththanan Rajaratnam 09c02f7118 Use tvb_get_ephemeral_string() to avoid memleak. 
svn path=/trunk/; revision=29994
 2009-09-20 08:06:20 +00:00
Kovarththanan Rajaratnam d256315e74 Use tvb_get_ephemeral_string() instead of tvb_get_string() 
svn path=/trunk/; revision=29993
 2009-09-20 07:56:16 +00:00
Kovarththanan Rajaratnam 4d0d37ed6f Use tvb_get_ephemeral_string() to avoid memleak. 
svn path=/trunk/; revision=29990
 2009-09-20 07:44:34 +00:00
Bill Meier 6f004d3f46 From yami<yamisoe At ...>: Fix Bug #3542: get_dfs_referral referral entry is not dissected corectly. 
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3542)

The current get_dfs_referral response code is based on old protocol specs,
which are unofficial, erroneous. 

I modify packet-smb.c to be confirm to protocol's official spec. Some
changes are:

  1. handle referral entry version 2, 3, 4 separately. The current code does
not distinguish v3 from v2, however they are not same.
  2. change server type, referral flags etc.
  3. refactor some code, such as string dissecting.

Also: From me: a small change to handle possible overflow
when subtracting from a guint16.


svn path=/trunk/; revision=29986
 2009-09-18 22:41:04 +00:00
Martin Mathieson d8726d2a01 Try again... 
svn path=/trunk/; revision=29985
 2009-09-18 22:01:30 +00:00
Martin Mathieson 66e8e24373 Change type to try to fix win64 build breakage. 
svn path=/trunk/; revision=29984
 2009-09-18 17:10:35 +00:00
Martin Mathieson b6acfd804e Use a UAT table to map from LCIDs 3-10 to RLC drb channel. 
Call RLC dissector for mapped LCIDs.

svn path=/trunk/; revision=29983
 2009-09-18 16:27:02 +00:00
Anders Broman 76f596fa1e Add coments. 
svn path=/trunk/; revision=29982
 2009-09-18 14:03:45 +00:00
Jaap Keuter e60027351b From Thomas Dreibholz: 
Added support for decoding the Info field in the SSP Ready message.

svn path=/trunk/; revision=29980
 2009-09-18 06:32:43 +00:00
Jaap Keuter fe03355556 From Harald Welte: 
Errors occur which means decrypted_len - esp_iv len will render a negative value and thus
cause the problem. This patch prevents the crash. Not sure if this is a proper fix. At least it 
looks like a sane check to do.

svn path=/trunk/; revision=29979
 2009-09-18 06:29:00 +00:00