Michael Tüxen
7f895c681b
Generate the capure sync pipe correctly.
...
Fix obtained from Irene Ruengeler.
svn path=/trunk/; revision=38349
2011-08-05 07:10:20 +00:00
Anders Broman
ce3db724c1
From Lei Chen:
...
patch to support gsm rr decoding of Immediate Assignment rest octet
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6119
svn path=/trunk/; revision=38348
2011-08-05 07:02:22 +00:00
Anders Broman
8e4b96ba4f
Typo
...
svn path=/trunk/; revision=38347
2011-08-05 05:16:37 +00:00
Anders Broman
d2e7e72794
Free the PangoLayout.
...
svn path=/trunk/; revision=38346
2011-08-05 05:13:42 +00:00
Gerald Combs
3d2c4f6182
Use GLIB2_LDFLAGS instead of GLIB2_LIBRARIES for wsutil, since it
...
includes the path to the libraries. Add gthread to wireshark_LIBS if
threads are enabled.
svn path=/trunk/; revision=38345
2011-08-05 00:25:02 +00:00
Jörg Mayer
5c064e144a
Replace almost all uses of GtkObject (which no longer exists
...
in GTK3) by GObject (which does).
These were the trivial cases, the two remaining uses in packet_win.c
are left for someone who understands the code.
svn path=/trunk/; revision=38344
2011-08-04 22:56:36 +00:00
Jörg Mayer
84995def5f
Remove usage of GDK_DRAWABLE macro.
...
svn path=/trunk/; revision=38343
2011-08-04 22:40:31 +00:00
Jörg Mayer
a6c39410ad
The macros GDK_DRAWABLE, GDK_IS_DRAWABLE, GTK_OBJECT are no longer
...
present and can probably just be removed without any ill effects or,
if there are problems, these should be solvable by using casts.
svn path=/trunk/; revision=38342
2011-08-04 22:38:44 +00:00
Jeff Morriss
c330acaa8c
As suggested by Anders: only compile with GSEAL_ENABLE if we're using GTK 2.22 or higher (and not GTK3)
...
svn path=/trunk/; revision=38341
2011-08-04 21:38:31 +00:00
Chris Maynard
78ef4cdd88
Don't report svn version if not building from svn. Change prompted by http://ask.wireshark.org/questions/5376/wireshark-161-title-shows-svn-rev-unknown-from-unknown .
...
svn path=/trunk/; revision=38340
2011-08-04 20:20:51 +00:00
Chris Maynard
b4ce593083
Don't call expert_add_info_format() from within an "if (tree)" block. Fixes bug 6198. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6198
...
svn path=/trunk/; revision=38339
2011-08-04 17:49:57 +00:00
Bill Meier
afae0c92ad
Remove unneeded #includes.
...
svn path=/trunk/; revision=38338
2011-08-04 16:51:21 +00:00
Bill Meier
f0cf1cbed7
Whitespace cleanup: convert mixture of "4 space" and "8 space" tabs to spaces.
...
svn path=/trunk/; revision=38337
2011-08-04 16:42:32 +00:00
Anders Broman
adbdd0d180
Put src and dst ports in the option of "Both" decorate with arrows.
...
svn path=/trunk/; revision=38336
2011-08-04 16:02:09 +00:00
Bill Meier
6d407e6490
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38335
2011-08-04 15:59:23 +00:00
Anders Broman
2c6babb113
- Get rid of some deprecated functions.
...
svn path=/trunk/; revision=38334
2011-08-04 14:41:45 +00:00
Anders Broman
42d800366d
Change the default to "Both"
...
svn path=/trunk/; revision=38333
2011-08-04 11:53:50 +00:00
Michael Tüxen
8986cd7228
gtkvumeter.[ch] seems to be used only on Windows. So only build it there...
...
svn path=/trunk/; revision=38332
2011-08-04 11:24:15 +00:00
Stig Bjørlykke
3cead1e9df
Removed a debug printf.
...
svn path=/trunk/; revision=38331
2011-08-04 10:02:37 +00:00
Stig Bjørlykke
04041a8f6a
Corrected position of FBAR and DOT.
...
svn path=/trunk/; revision=38330
2011-08-04 08:54:13 +00:00
Guy Harris
a468cc1b6a
Update some references.
...
svn path=/trunk/; revision=38329
2011-08-04 00:04:53 +00:00
Bill Meier
3b627d04fd
Convert "4 space tabs" to spaces + do other whitespace cleaup.
...
svn path=/trunk/; revision=38328
2011-08-03 21:14:04 +00:00
Bill Meier
e6cb34fbac
Minor cleanup
...
[benign] Remove _U_ from param arg when param is actually used;
[benign] Use 'item' (not 'tree') arg for proto_item_append_text()
Whitespace
svn path=/trunk/; revision=38327
2011-08-03 20:31:51 +00:00
Gerald Combs
6d8c52e6a5
From Dirk Jagdmann via bug 6194:
...
The attachted patch fixes and enhances the SCPS TCP option dissection. Changes
are:
- fix order of reserved Bit 1,2,3
- fix minimum TCP option length
- fix proto items
- add proto item for Connection ID
- removed the verify_scps() function. It's logic was broken, because it did
reset the scps_capable flag on both flows if one of them did not have it.
However sometimes that flag is only enabled in one flow direction and that flow
direction could see TCP options later on, which would get dissected as invalid.
See the attachted capture file for an example.
svn path=/trunk/; revision=38326
2011-08-03 19:11:07 +00:00
Anders Broman
7dcd23257d
Get rid of gdk_draw_layout().
...
svn path=/trunk/; revision=38325
2011-08-03 18:49:35 +00:00
Chris Maynard
539c74fb0c
From Jim Young via bug 3196: Enhancement to Expert Info Composite Tab Labels
...
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3196
svn path=/trunk/; revision=38324
2011-08-03 18:45:06 +00:00
Bill Meier
a71d51d0d7
AFAICT, the item for 'hf_gtpv2_stn_sr' should be used as the parent tree-item in dissect_gtpv2_stn_sr().
...
This is a different fix for Coverity 1248 than that committed in SVN 38314.
svn path=/trunk/; revision=38323
2011-08-03 18:38:23 +00:00
Martin Mathieson
0e83124e46
Fix the SR state report for when get SR following SR with no grant or failure in-between.
...
svn path=/trunk/; revision=38322
2011-08-03 17:05:30 +00:00
Bill Meier
869b51db0e
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38321
2011-08-03 16:06:00 +00:00
Stephen Fisher
eaaf35dcfd
Fix compiler warning turned error:
...
graph_analysis.c:1363: warning: unused parameter 'widget'
svn path=/trunk/; revision=38320
2011-08-03 15:39:16 +00:00
Anders Broman
2b93b58f17
Try to make the builbot happy
...
# define gtk_widget_is_drawable(x) GDK_IS_DRAWABLE(x)
svn path=/trunk/; revision=38319
2011-08-03 15:25:57 +00:00
Bill Meier
1293999174
'-Wno-error=unused-but-set-parameter' not req'd since no such warnings in Wireshark compile.
...
svn path=/trunk/; revision=38318
2011-08-03 15:24:06 +00:00
Anders Broman
7bcc6dd237
- Get rid of deprecated functions.
...
- Include pangocairo.
svn path=/trunk/; revision=38317
2011-08-03 14:54:03 +00:00
Gerald Combs
53c550831b
Define PACKAGE in config.h.
...
svn path=/trunk/; revision=38316
2011-08-02 21:23:00 +00:00
Chris Maynard
4e4f13db59
Fix 45 occurrences of unused values reported under Coverity CID's 1235-1241.
...
svn path=/trunk/; revision=38315
2011-08-02 20:39:53 +00:00
Chris Maynard
e7928ce630
Fix Coverity CID 1248: unused value.
...
svn path=/trunk/; revision=38314
2011-08-02 19:29:51 +00:00
Gerald Combs
d39696be6d
Add tap-hosts.c.
...
svn path=/trunk/; revision=38313
2011-08-02 18:13:16 +00:00
Anders Broman
4b0961fb7a
Bug 6146 - Malformed RANAP packets when HandOver procedure on iuh
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6146
svn path=/trunk/; revision=38312
2011-08-02 16:47:37 +00:00
Bill Meier
6e97a2e143
For now: treat GCC 4.6 'unused-but-set' reports as just warnings (i.e., when -Werror).
...
GCC 4.6 has added 'unused but set' reports so this change allows builds to proceed without
erroring out for those building from SVN with GCC 4.6.
(AFAIK Wireshark source distributions do not enable -Werror).
This change can be removed (at least globally) once the code as been fixed.
svn path=/trunk/; revision=38311
2011-08-02 16:17:25 +00:00
Anders Broman
9363362f5f
Channel Description includes the element identifier.
...
svn path=/trunk/; revision=38310
2011-08-02 12:52:59 +00:00
Martin Mathieson
23f8f9cf6a
Show version and mode in protocol root. Now dissects details whether tree is NULL or not.
...
svn path=/trunk/; revision=38309
2011-08-02 10:35:22 +00:00
Anders Broman
538ab09091
From Roland Knall:
...
openSAFETY: Cleaning up, removing multiple implementations and cleaning up code
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6180
svn path=/trunk/; revision=38307
2011-08-02 05:30:59 +00:00
Anders Broman
4b85603c80
From Jeremy Jones:
...
Add support for decoding NFSv4.1 OP_BIND_CONN_TO_SESSION.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6182
svn path=/trunk/; revision=38306
2011-08-02 05:18:58 +00:00
Anders Broman
955981834e
From Martin Kaiser:
...
DVB-CI dissector, packet reassembly on the link layer.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6075
svn path=/trunk/; revision=38305
2011-08-02 05:12:53 +00:00
Anders Broman
6d94629c4b
Gnenerate the dissector for previous commit.
...
svn path=/trunk/; revision=38304
2011-08-02 04:17:45 +00:00
Chris Maynard
b25c098e0c
From Paul Stath via bug 5731: The check for engineID length should only occur if the engineID has a non-zero length.
...
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731
svn path=/trunk/; revision=38303
2011-08-02 01:54:03 +00:00
Stephen Fisher
a7be167fe4
Update documentation to reflect configure option being "--with-gtk3" not
...
"--enable-gtk3"
svn path=/trunk/; revision=38302
2011-08-01 16:56:45 +00:00
Jörg Mayer
b96c45f026
Add tvb_get_bits
...
svn path=/trunk/; revision=38301
2011-08-01 14:48:19 +00:00
Michael Tüxen
b531e56156
gtk_widget_get_sensitive() seems to be available on gtk 2.18
...
svn path=/trunk/; revision=38300
2011-08-01 14:34:16 +00:00
Stig Bjørlykke
ffd28912d3
Another fix for building with MSVC2005.
...
The previous fixes in r37728 and r37730 did build a wireshark which was
unable to use the native windows file dialog (GetOpenFileName).
svn path=/trunk/; revision=38299
2011-08-01 12:38:58 +00:00