Commit Graph

28221 Commits

Author SHA1 Message Date
Anders Broman 7c0fb707a5 Implement new_packet_list_find_row_from_data()
Goto frame should work now.

svn path=/trunk/; revision=29147
2009-07-20 16:09:50 +00:00
Stig Bjørlykke f900d9c3a5 From Jakub Zawadzki via bug 3701:
Fix regressions in r29130 and r29133
In r29130 formating for DSECS was changed. (old: %01d now: %02d)
In r29133 adding sign was removed (old: buf[0] = '-' now: buf[0] = '\0')

svn path=/trunk/; revision=29146
2009-07-20 12:40:55 +00:00
Stig Bjørlykke d0a970fb72 Changed to use "Field type" instead of "Format", to be more descriptive.
Moved "Filed name" fields below "Field type", to improve the layout.
Always show the "Field name" fields, disable when field type is not custom.
Remember field name even when changing field type, so the user can change his
mind without losing the data entered.
Some small adjustments to "Add" and "Remove" buttons.
Added some tooltips.

svn path=/trunk/; revision=29145
2009-07-20 11:42:28 +00:00
Anders Broman 9de6f58cff Redraw the list when color filters are enabled/disabled.
svn path=/trunk/; revision=29144
2009-07-20 11:33:02 +00:00
Anders Broman 30c88f818c Avoid a crash if no color filter exists (SCTP trace).
svn path=/trunk/; revision=29143
2009-07-20 09:06:47 +00:00
Stephen Fisher edc8ae64f1 Introduce packet list coloring for the NEW_PACKET_LIST. One caveat: when
enabling/disabling the coloring of the packet list from the menus, the user
has to drag the mouse cursor over each displayed row to take away/add the
coloring.  Dragging the scroll bar up or down will also take care of this as
only the displayed rows are colored.


svn path=/trunk/; revision=29142
2009-07-20 06:21:35 +00:00
Gerald Combs 96be1a38da [Automatic manuf and enterprise-numbers update for 2009-07-19]
svn path=/trunk/; revision=29138
2009-07-19 15:03:36 +00:00
Stig Bjørlykke 221225e0f3 From Kovarththanan Rajaratnam via bug 3719:
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
2009-07-18 20:10:14 +00:00
Gerald Combs 72e160eb4d Set the extension channel correctly. Fixup whitespace.
svn path=/trunk/; revision=29135
2009-07-17 22:59:59 +00:00
Bill Meier 095f4a5c12 From Robert Hogan: "no need to register tn3270 for 'decode-as'".
svn path=/trunk/; revision=29134
2009-07-17 19:41:34 +00:00
Gerald Combs 25e7cac69d Fix an ep buffer overrun introduced in r29130.
svn path=/trunk/; revision=29133
2009-07-17 15:59:24 +00:00
Bill Meier 891d655e8a Minor changes: Move protocol_register & etc to end;
Use find_dissector instead of create_dissector_handle.

svn path=/trunk/; revision=29132
2009-07-17 14:25:56 +00:00
Anders Broman 2d76d327e1 make it possible to retreive the record with packet_list_get_value().
svn path=/trunk/; revision=29131
2009-07-17 13:42:46 +00:00
Anders Broman 3278582767 From Kovarththanan Rajaratnam:
Optimize column fill path.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3701

svn path=/trunk/; revision=29130
2009-07-17 08:24:06 +00:00
Jaap Keuter f9177273d8 From Robert Hogan:
I'm working on a tn3270 dissector. 
See: http://roberthogan.net/stuff/tn3270-dissector/

svn path=/trunk/; revision=29129
2009-07-17 06:49:58 +00:00
Gerald Combs 75e048491a Check for an overflow. This should hopefully fix bug 3672.
svn path=/trunk/; revision=29128
2009-07-16 22:25:06 +00:00
Gerald Combs bad647581b Initialize a variable and remove a check_col.
svn path=/trunk/; revision=29127
2009-07-16 22:24:31 +00:00
Gerald Combs b0aa9d9696 Use SE_COPY_ADDRESS instead of trying to attach ep_alloced data to an
se_alloced struct.

svn path=/trunk/; revision=29126
2009-07-16 21:35:54 +00:00
Anders Broman 1196da707d From Rajasekhar Reddy Gali:
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730

svn path=/trunk/; revision=29125
2009-07-16 21:27:56 +00:00
Anders Broman af3ad92c81 From Sean Yunjnz:
Problem in packet-per.c for ASN.1 PER Encoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3733

svn path=/trunk/; revision=29124
2009-07-16 21:09:18 +00:00
Gerald Combs fcac7c5695 Make sure some variables are initialized so that Valgrind quits
complaining.  Use se_memdup to copy memory.

svn path=/trunk/; revision=29123
2009-07-16 21:03:39 +00:00
Gerald Combs 753e9f65e5 Zero out the packet_info struct for each packet instead of trying to
initialize everything by hand. Fixes a Valgrind warning.

svn path=/trunk/; revision=29122
2009-07-16 20:52:36 +00:00
Jaap Keuter 05babef3b4 From David Dahlberg:
As for now, Wireshark supports only 96-bit (or 0-bit for NULL authentication)
integrity control values (ICVs) for IPsec ESP. While the autentication field is
of variable length, this may lead to situations where the whole packet is not
parsable.

To solve this, I added generic classes (not checked) for 128, 192 and 256 bit
ICVs to the ESP dissector. I also split the HMAC-SHA-256 autentication
algorithm to HMAC-SHA-256-128 (128 bit as defined in RFC 4868) and
HMAC-SHA-256-96 (from the very first draft, nevertheless unpatched Linux and
BSDs do it this way).

svn path=/trunk/; revision=29121
2009-07-16 19:57:15 +00:00
Gerald Combs 517d9cec5f Don't crash if we happen to load a bad MIB file.
svn path=/trunk/; revision=29118
2009-07-16 17:00:58 +00:00
Jeff Morriss bca2a16879 /MP also works with 2008EE
svn path=/trunk/; revision=29116
2009-07-16 12:39:50 +00:00
Stig Bjørlykke e9066532cf From Kahou via bug 3739:
New DLT value is added for Fibre Channel FC2.

svn path=/trunk/; revision=29115
2009-07-16 10:45:14 +00:00
Anders Broman 67d6f5976e Move th /MP flag setting to LOCAL_CFLAGS set in configure.nmake
for MSVC variant 2008 only. As suggested by Bill Meier.

svn path=/trunk/; revision=29114
2009-07-16 08:27:18 +00:00
Gerald Combs 6ade5c0615 Add a modeline blurb. Minor indentation fix.
svn path=/trunk/; revision=29111
2009-07-15 23:16:10 +00:00
Gerald Combs 143d15c4e4 Make sure we advance our offset during a while loop. This should fix recent
fuzz errors.

svn path=/trunk/; revision=29109
2009-07-15 22:51:01 +00:00
Guy Harris ba3ca797bc Get rid of C++-style comment (and anglicize it).
svn path=/trunk/; revision=29105
2009-07-15 21:30:37 +00:00
Anders Broman 91caa01090 Add /MP flag to make use of multi cores.
svn path=/trunk/; revision=29104
2009-07-15 20:55:31 +00:00
Stig Bjørlykke d41065097e Indent some comments.
svn path=/trunk/; revision=29103
2009-07-15 19:33:48 +00:00
Stig Bjørlykke 3ebdfb7c9c From Kovarththanan Rajaratnam:
Add "text" abbrev + tighten FT_FRAMENUM checks.

svn path=/trunk/; revision=29100
2009-07-15 08:56:12 +00:00
Gerald Combs 0230d48489 Remove an unused define.
svn path=/trunk/; revision=29098
2009-07-14 23:09:59 +00:00
Bill Meier 31ab30f1cf #include prefs.h not req'd; Also: remove unused #define
svn path=/trunk/; revision=29097
2009-07-14 21:34:03 +00:00
Anders Broman a9f5ba1bd8 From Vladimir Smrekar :
v5.2-User Adaptation Layer and V5.2 Interface.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3732

Me:
Removed check_col(), hf blurbs, removed global vars and regestering
SCTP port in packet-v52.c.

svn path=/trunk/; revision=29096
2009-07-14 20:49:34 +00:00
Gerald Combs 60877bb714 From Alvaro Vega Garcia via bug 3652:
Patch with some improvements for packet ziop dissector following patch
about MIOP dissector submitted by Kovarththanan Rajaratnam.

From me:

Add a link to the protocol specification.  Don't tvb_memcpy over
structs! Remove some more tvbuffs.  Don't call proto_item_add_subtree if
we're not going to use the trees.  Call proto_tree_add_item instead of
proto_tree_add_text Remove a bunch of unused ett_ variables and a few
other now-unused variables.  Register the field array with the correct
length.

svn path=/trunk/; revision=29095
2009-07-14 19:13:14 +00:00
Martin Mathieson 065374366a Trivial formatting changes to RAR output.
svn path=/trunk/; revision=29094
2009-07-14 17:43:20 +00:00
Anders Broman 4f7e3ace85 From Rajasekhar Reddy Gali:
"dictionary.xml file is very old..." - Update the Wimax .xml file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3731

svn path=/trunk/; revision=29093
2009-07-14 17:15:03 +00:00
Martin Mathieson 2751aca4f7 Add preference to control whether decode of CRC-error'd frames should be attempted.
svn path=/trunk/; revision=29092
2009-07-14 13:08:23 +00:00
Anders Broman 1ed2082073 Fix the sort routine.
svn path=/trunk/; revision=29091
2009-07-14 12:41:11 +00:00
Stig Bjørlykke 44d725fac2 Header field cleanup.
svn path=/trunk/; revision=29090
2009-07-14 09:33:54 +00:00
Guy Harris 5e7b2ff6bd Fix one place where we didn't mention "-t dd".
Put the description of the default time format after the description of
all the time formats, i.e. say "the default is relative" after we say
what "relative" is.

svn path=/trunk/; revision=29089
2009-07-13 23:35:26 +00:00
Jaap Keuter 95a687320f From Reinhard Speyerer:
The description of tshark -t dd is missing from tshark.pod.

svn path=/trunk/; revision=29088
2009-07-13 22:46:32 +00:00
Jaap Keuter 668e9b693a Fix for bug 3710:
Use the derived length of the control field i.s.o. assuming its size.

svn path=/trunk/; revision=29087
2009-07-13 22:29:59 +00:00
Gerald Combs e3be7b8b25 Check to see if tvb_child_uncompress returns NULL. Fixes bug 3705.
svn path=/trunk/; revision=29086
2009-07-13 20:12:53 +00:00
Gerald Combs 1d32de944e Squelch a couple of Valgrind warnings. This should fix bug 3700.
svn path=/trunk/; revision=29085
2009-07-13 18:54:24 +00:00
Guy Harris b0a612c56d Note what the "Unknown" value is.
svn path=/trunk/; revision=29084
2009-07-13 17:43:44 +00:00
Anders Broman be27e0d5b4 From Chris Costa:
SMB2 Error Response doesn't decode properly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3609

svn path=/trunk/; revision=29083
2009-07-13 17:40:31 +00:00
Anders Broman 683bdf3a42 From Kovarththanan Rajaratnam:
hci_h4: Optimize column/field handling
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3703

svn path=/trunk/; revision=29082
2009-07-13 17:33:14 +00:00