Commit Graph

40580 Commits

Author SHA1 Message Date
pascal 774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1)
svn path=/trunk/; revision=42722
2012-05-20 09:50:34 +00:00
Guy Harris 4a9b825c49 Change the "user_saved" member of a capture_file structure to
"unsaved_changes", and have it be TRUE iff changes have been made to the
file since it was read - *not* if it's a temporary file from a live
capture.

Check the "is_tempfile" member, and the "unsaved_changes" member, when
appropriate.

Just have a set_toolbar_for_capture_file() routine that updates the
"save", "close", and "reload" toolbar as appropriate, given a
capture_file structure - absorb the function of
set_toolbar_for_unsaved_capture_file() into it.

svn path=/trunk/; revision=42721
2012-05-20 08:56:06 +00:00
pascal acc2a3706b Fix RVALS() macro usage
svn path=/trunk/; revision=42720
2012-05-19 19:05:36 +00:00
Bill Meier a297af9d64 Add an 'if' test to prevent a potential null pointer dereference
identified by clang scan-build.


svn path=/trunk/; revision=42719
2012-05-19 17:21:32 +00:00
Bill Meier 576fcd2a47 Rework 'ct_nb_switch_page_cb()' slightly to prevent a scan-build "null pointer de-reference" message;
(In practice, the "null pointer de-reference" would not actually occur ?).

svn path=/trunk/; revision=42718
2012-05-19 16:55:22 +00:00
Bill Meier 12ba85a2a4 Rework proto_registrar_dump_protocols() to prevent a Clang scan-build "de-reference of a null poiunter" warning
(In practice, bug would not actually occur).

svn path=/trunk/; revision=42717
2012-05-19 16:07:50 +00:00
pascal cf0d560849 Use col_append_sep_str instead of col_append_str
svn path=/trunk/; revision=42716
2012-05-19 16:06:12 +00:00
Bill Meier 91e5923458 Fix some "warning: Value stored to '...' is never read" clang scan-build warnings.
Also; Do some whitespace cleanup in a few cases.

svn path=/trunk/; revision=42715
2012-05-19 14:20:55 +00:00
Jakub Zawadzki 63d6b6bf2a Z_BLOCK was added in zlib-1.2.0.5
Pass Z_NO_FLUSH to inflate() when Z_BLOCK is not defined,
just in case also disable fast seeking when it's not defined.

References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00145.html 

svn path=/trunk/; revision=42714
2012-05-19 13:27:43 +00:00
pascal 7bbbb88068 From Thomas Loockx via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7269 :
Add BGP MDT-SAFI dissection (RFC6037)

svn path=/trunk/; revision=42713
2012-05-19 12:32:10 +00:00
pascal 20793cc947 From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7262 :
Digest details display issue in SPB Digest subtlv (ISIS hello pdu)

svn path=/trunk/; revision=42712
2012-05-19 10:35:43 +00:00
Jakub Zawadzki aaa9b34c86 Improve Gadu-Gadu dissector and fix some comments.
svn path=/trunk/; revision=42711
2012-05-19 07:57:45 +00:00
Anders Broman 8499bf8b8e Fix the DCH data collection for conversation setup
svn path=/trunk/; revision=42710
2012-05-19 06:20:05 +00:00
Jakub Zawadzki 3bb88a972b Improve Gadu-Gadu dissector.
svn path=/trunk/; revision=42709
2012-05-18 17:43:48 +00:00
Jeff Morriss 5c0dfb9e8e There's no need to include Custom.common here; it gets pulled in by Makefile.common
svn path=/trunk/; revision=42708
2012-05-18 17:19:50 +00:00
Jeff Morriss af87b31852 Allow custom dissectors in automake too.
svn path=/trunk/; revision=42707
2012-05-18 16:20:36 +00:00
Guy Harris fb8054f131 Expand a comment.
Clear the struct sigaction *before* we fill in any fields in it.

svn path=/trunk/; revision=42706
2012-05-18 04:06:35 +00:00
Guy Harris 60637d4b70 When saving packets, fill in hdr.presence_flags from the flags in the
frame_data structure; there's no guarantee that the wtap_pkthdr in the
wtap structure reflects the current packet.

svn path=/trunk/; revision=42705
2012-05-18 03:31:50 +00:00
pascal b3dec16072 Tabs -> spaces
svn path=/trunk/; revision=42691
2012-05-17 21:24:48 +00:00
pascal 8f789f7ee2 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7255 :
dissector for generic ISO 7816 messages (atr and apdus)

svn path=/trunk/; revision=42689
2012-05-17 21:11:22 +00:00
Michael Tüxen 892f054257 Use some newer versions.
svn path=/trunk/; revision=42687
2012-05-17 20:49:09 +00:00
Bill Meier b315490d01 Fix an "unused variable" warning....
svn path=/trunk/; revision=42686
2012-05-17 20:41:46 +00:00
Bill Meier e332a8de56 Fix the fix ....
svn path=/trunk/; revision=42685
2012-05-17 20:36:23 +00:00
Bill Meier 47828c3170 Silence a "may be used uninitialiuzed" warning.....
svn path=/trunk/; revision=42684
2012-05-17 20:30:59 +00:00
Bill Meier bab856a504 General cleanup including as appropriate:
- Remove unneeded #include files (string.h, addr_resolv.h);
 - Remove unneeded 'if(!initialized){...}' in proto_reg_handoff();
 - Reformat hf[] entries;
 - Remove unneeded variable initializations;
 - "localize" some variables;
 - Whitespace/indentation/long lines/formatting
(in one case: re-order code slightly to not do col_set_str() & etc until
              after initial "frame acceptance testing" by dissector.

svn path=/trunk/; revision=42683
2012-05-17 20:13:22 +00:00
Jakub Zawadzki b4624651e9 Fix copy&paste: hf variable name in hfi->abbrev
svn path=/trunk/; revision=42682
2012-05-17 19:41:19 +00:00
Michael Tüxen 24fa3fb59a No leading whitespaces in the INFO column.
svn path=/trunk/; revision=42679
2012-05-17 15:31:15 +00:00
Bill Meier 6fbb09d50b General Cleanup including:
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
2012-05-17 14:35:11 +00:00
Michael Tüxen 6526ea3751 Add support for specifying an SCTP port number.
svn path=/trunk/; revision=42677
2012-05-17 14:34:09 +00:00
Jakub Zawadzki 91690d8a28 Fix string buffer overflow (bug #7029)
g_strlcpy() always return the size of strlen(src), so in case of truncation it could happen that offset_r > size or offset_e > size.
Fix it by adding new function protoo_strlcpy() which returns how many bytes was copied to dest buffer.


svn path=/trunk/; revision=42676
2012-05-17 10:18:53 +00:00
pascal b607964f1f Fix spice.common_cap_byte1 filter I changed by mistake in r42664
svn path=/trunk/; revision=42675
2012-05-17 08:22:34 +00:00
Gerald Combs 9e3487a953 Use BASE_DEC for spice.common_cap_byte1. (Hopefully that's correct.)
svn path=/trunk/; revision=42668
2012-05-16 22:05:47 +00:00
pascal 4a1de290f8 From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7264 :
Enhance the Spice dissector to deal with sized data streams and playback data
From me: fix a few hf entries

svn path=/trunk/; revision=42664
2012-05-16 21:20:16 +00:00
pascal f400e647b8 From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 :
GTP Extension headers are dissected incorrectly

svn path=/trunk/; revision=42663
2012-05-16 20:59:56 +00:00
Chris Maynard ff667657e8 Largely, whitespace and formatting changes. Added modelines to match.
Other misc. changes:
-> Delete useless, duplicate assignment of offset to 0 in dissect_vsnp().
-> Change short seq # display filter so it's not the same as the seq # filter.
-> pppoe.dump.gz looks to be malformed, so remove unnecessary "remlen" code in
   dissect_cp() and let the packets be displayed as malformed since they are.
-> Remove if (check_col()) checks.
-> Fix copy-and-paste of filter name for ipcp.opt.max_header.

svn path=/trunk/; revision=42661
2012-05-16 19:55:49 +00:00
Gerald Combs 805c4779fa Update INSTALL_DIR to match r42659.
svn path=/trunk/; revision=42660
2012-05-16 17:57:12 +00:00
Jeff Morriss ef756b397c Fix the *test_install targets so they put the test tools in the right directory (wireshark-gtk2 is one dir up from here).
svn path=/trunk/; revision=42659
2012-05-16 16:36:32 +00:00
Gerald Combs bdb614e264 Fix a bunch of uninitialized variables found by Coverity Scan. CIDs
702403, 702404, 702405, 702406, 702407, 702408, 702409, 702410, 702411,
and 702412.

svn path=/trunk/; revision=42658
2012-05-16 16:29:12 +00:00
Anders Broman 46e202503a se_allocate and store per packet data.
svn path=/trunk/; revision=42657
2012-05-16 14:56:34 +00:00
pascal e5f3a74723 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7186 :
Link together access-request and access-challenge messages

svn path=/trunk/; revision=42656
2012-05-16 13:24:10 +00:00
Anders Broman 3e2ea7b812 Handle DCH information in RadioLinkReconfigurationPrepareFDD
svn path=/trunk/; revision=42655
2012-05-16 13:05:27 +00:00
Jakub Zawadzki e8c69cef7e Free memory when create_tempfile() failed.
svn path=/trunk/; revision=42654
2012-05-16 09:07:19 +00:00
Anders Broman dc8224653e Only do HS-DSCH Control frames for now as something is broken.
svn path=/trunk/; revision=42653
2012-05-16 08:35:53 +00:00
Anders Broman e65a6548bf From David Wei:
Corrected info column for piggybacked GTPv2 messages.

svn path=/trunk/; revision=42652
2012-05-16 07:47:15 +00:00
Anders Broman 18c5ec235c Setup frame for HSDSCH
svn path=/trunk/; revision=42651
2012-05-16 06:03:06 +00:00
Anders Broman 7918984efc Bug fixes and add HSDSCH
svn path=/trunk/; revision=42650
2012-05-16 05:58:30 +00:00
Anders Broman ce6e224b5b Bug fixes and add HSDSCH
svn path=/trunk/; revision=42649
2012-05-16 05:57:41 +00:00
Jeff Morriss 6a4b07bb55 Store a copy of the default preferences (e_prefs; the dissectors' default
preference values have been stored for a while now).

If a preference has not been changed from its default value, comment it out
when writing the preferences file.  That way you won't get warnings about
some new "gui.*" (or other non-dissector) preference when switching between
SVN Wireshark and some older version.


Also fix some ommissions in copy_prefs() (preferences that were not copied).


(All these non-dissector preferences seem to require an awful lot of code;
it would be very nice to have a non-dissector preference registration API that
the GUI and core could use so we could eliminate a lot of this code.)

svn path=/trunk/; revision=42648
2012-05-16 03:06:08 +00:00
Bill Meier 2ed4baea4f all:
Merge .h files into .c files since .h files unused elsewhere;
     Do whitespace, indentation & formatting cleanup.
packet-acn.c:
     Fix 2 minor bugs wherein subtree not displayed in packet-details
     because tree variable used in proto_tree_add_text() always NULL.

svn path=/trunk/; revision=42647
2012-05-16 01:41:03 +00:00
Jeff Morriss 2071275974 Most dissectors don't register their preferences in subtrees, so don't allocate the submodules pe_tree until it's needed.
svn path=/trunk/; revision=42646
2012-05-16 01:20:55 +00:00