Remove length check when detected x-wap lwm2m.dm because the CoAP
message is not always 15 bytes.
Change-Id: Ib1e58a997a906a6723abae6f86fe4306bd5061c6
Reviewed-on: https://code.wireshark.org/review/36310
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
There are many reasons for an Rx ack packet; add the reason string to
the info column.
Change-Id: I7512fcff0a9eda2def20f8194cb5ca804497a4dc
Reviewed-on: https://code.wireshark.org/review/36293
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This /* kvno */ comment was clearly residual from a cut-n-paste.
Update it to reflect reality.
No functional change is incurred by this commit.
Change-Id: I34b65c1f9b6f8e6f11f17f1647303d75df1d2df1
Reviewed-on: https://code.wireshark.org/review/36292
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Windows installers are signed by the "Wireshark Foundation, Inc."
Change-Id: I69881faccaf6345c25d8e106e3dbb96bdc302599
Reviewed-on: https://code.wireshark.org/review/36302
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
The existing dissector does not extract the "Flow Direction" field,
leading to incorrect decoding of all subsequent fields and incorrect
warnings about additional data being present at the end of the packet.
This patch extracts the one byte field and provides human-readable
representations of the legal field values.
Change-Id: Iba69eb7265e0589744721eaff07143b638b71168
Reviewed-on: https://code.wireshark.org/review/36275
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Don't hijack Ctrl+C / Cmd+C for copy Packet List entry as plain text
in the main window because this will affect using this shortcut in
other dialogs.
Ctrl+C will now copy the selected row in the Packet List (without
the headers), or the selected entry in the Packet Details, and it
also works correctly in other dialogs.
This was introduced in gb3f240dbf8.
Change-Id: I99d87f49c436a6dbf98e51d638a09c15a18bcc72
Reviewed-on: https://code.wireshark.org/review/36280
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Includes DMG parameter, Spectrum management and Radio measurement
fields to DMG parameter whenever it is transmitted by a DMG STA/AP.
These fields were added in 802.11ad-2012 Spec.
Change-Id: I56356b804703251981772499534e029a324766df
Signed-off-by: Jambukumar Kulandaivel <jambukumar@codeaurora.org>
Reviewed-on: https://code.wireshark.org/review/36276
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
The point of testing multiple compiler versions is to catch bugs that
only occur in one particular version. After an analysis of 800+ failed
builds, it appears that a lot of the checks are redundant. Changes:
* Drop GCC 6 and keep GCC 5, Ubuntu 16.04 default GCC is 5.3. Fixes for
warnings in old compilers: commit 829d2c3752 (GCC 5 + 6), commit
e451ea0a4d (Clang 5, GCC 4 + 5). Maybe GCC 5 can also be dropped since
Ubuntu 18.04 is around for a while.
* Drop clang-nopcap, all errors caught by Clang were also caught by GCC.
One change caught by gcc-8-nopcap but not Clang: commit 036c3d6bc7.
* Remove Clang 5: even though it triggers some unique failures, no major
distro ships with it so remove it.
* Drop old Clang versions, newer versions catch all warnings from older.
* Upgrade to Clang 8 which is already installed in the Docker image.
* Remove EOL Fedora 28 and 29, use latest (31).
* Remove EOL openSUSE Leap 42.3, keep 15.1 as the latest.
Reduces from 20 jobs (15 build, 5 test) to 10 jobs (7 build, 3 test).
Change-Id: I4a355dd1a90cbbef9525bd63a8544fa3e22369a2
Reviewed-on: https://code.wireshark.org/review/36281
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Version 1 Type 2 trailers include the Early Traffic Secret
Bug: 16422
Change-Id: I6f0af63900928dba8c667a6a92bb29c8b9277f6a
Reviewed-on: https://code.wireshark.org/review/36266
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Add also link to Temporary IANA Registry and link of draft extension TP
Change-Id: I89fec06670ee65a7b20eb5f7766992c6be8eb09e
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/36264
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Changed some GVCP register names in order to reflect the latest
changes in the GigE Vision specification
- Moved GenDC component and part offsets into a subtree in order
to comply with the actual packet layout of the specification
- BUGFIX: the GenDC data_size field was displayed as a 64-bit
value while in fact it is 32-bit wide
Change-Id: Iddbd7f6d143ae2b78e4f3d3c31dea12358fb9804
Reviewed-on: https://code.wireshark.org/review/36229
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
As the documentation for QAbstractItemDelegate::createEditor says,
"The view's background will shine through unless the editor paints its
own background (e.g., with setAutoFillBackground())."
Set setAutoFillBackground(true) for a bunch of our editors where the
underlying widget's background was showing.
Change-Id: I77e96548e99c74a73c89f8037c1f894a6a5584f1
Reviewed-on: https://code.wireshark.org/review/36260
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Draft 13 changed it from a byte to a varint. Found during implementation
of draft-huitema-quic-ts-02 which uses 0x02F5.
Bug: 13881
Change-Id: I63d9469b539cf92b694bca85c00e07bd146abb5e
Reviewed-on: https://code.wireshark.org/review/36259
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Add baSourceIDs as FT_BYTES containing the whole array.
Change-Id: I3478b4f775c3b50035dfaf9aaca559c005bfca3c
Reviewed-on: https://code.wireshark.org/review/36257
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Kernel can now send a flow action cookie in drop monitor medatada.
Implement support for it.
Change-Id: If486c68bf334f81315d3c3f230bc4932e704e1a8
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Reviewed-on: https://code.wireshark.org/review/36254
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Dissection of "Class-specific Audio Control Interface Descriptor:
Selector Unit Descriptor" and "ENDPOINT DESCRIPTOR" for USB Audio
Device added.
The USB Audio class extended Standard USB Endpoint Descriptor 2
bytes further. A condition to check whether the interface class is
CLASS_AUDIO is added and the 2 bytes are dissected.
Change-Id: I63f1334df71b9e8cd92a299d533b732b0a13ace7
Reviewed-on: https://code.wireshark.org/review/36250
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The absolute radio-frequency channel numbers may overlap between
both DCS1800 and PCS1900 frequency bands. The purpose of the PCS
band indocator is to avoid ambiguity for the overlapping numbers.
Change-Id: I5c6e429e9c579d1e132994954a4d32f2f1bd6ca5
Reviewed-on: https://code.wireshark.org/review/36240
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
User can remove the previously set name, just by editing the current
name, and removing all text (empty string). Empty strings are skipped by
the name resolution code.
Bug: 11221
Change-Id: Id9c64885b5dd82fd72dd16b25a0f8046b8102a11
Reviewed-on: https://code.wireshark.org/review/36206
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Do not append separator to import directory path. Calling QFileInfo()
constructor with string ending in directory separator results in
creating QFileInfo instance for file with empty filename.
Bug: 16410
Change-Id: I4fe248fcdb0c0c67843652475ae58c2a473a9fa8
Reviewed-on: https://code.wireshark.org/review/36238
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Set usb conversation info vendor, product and version based on values
recorded in device product data. This results in USB dissectors that
register on VID/PID to get correct vendor, product and version
information if configuration descriptor is not present in the capture.
One such dissector is FTDI FT where the version is used to determine
chip type.
Ping-Bug: 11743
Change-Id: Idcc361861b616222e32fc0d8cef9f9dd687cf1e4
Reviewed-on: https://code.wireshark.org/review/36243
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Filipe Laíns <lains@archlinux.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Group command with parameters under its own subtree. Besides grouping,
this makes it possible to filter the command with specific parameters.
Ping-Bug: 11743
Change-Id: I4702a0cac6bd398a271c310185bf2670d352ba55
Reviewed-on: https://code.wireshark.org/review/36241
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Reviewed-by: Filipe Laíns <lains@archlinux.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Do not use QDir::separator() as a directory separator. QT internally
uses "/" as separator on all systems, including Windows. The zip files
were not unzipped into target directory because splitting path on
QDir::separator() in ProfileModel::cleanName() returned only one part
(there weren't any "\' in file name, only "/").
Qt documentation for QDir::separator() mentions:
"You do not need to use this function to build file paths.
If you always use "/", Qt will translate your paths to conform to
the underlying operating system. If you want to display paths to
the user using their operating system's separator use
toNativeSeparators()."
Bug: 16410
Change-Id: I9627684f58f4c1da24b6eec8958a2542fe07d915
Reviewed-on: https://code.wireshark.org/review/36237
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
When dissecting a trace containing the same FID multiple times (for
different file paths) Wireshark would get confused and show file path
of the latest occurence of the FID for all usage.
Example:
=> open req "\dir\lol.txt"
<= open rsp fid=0x123
from this point, 0x123 is "lol.txt", yet wireshark will show "bar.txt"
=> write req fid=0x123 data="foo"
<= write rsp ok
=> close req fid=0x123
<= close rsp ok
from this point, 0x123 is no longuer valid
=> open req "\dir\bar.txt"
<= open rsp fid=0x123
from this point, 0x123 is "bar.txt"
=> write req fid=0x123 data="foo"
<= write rsp ok
=> close req fid=0x123
<= close rsp ok
Wireshark displays "bar.txt" for all occurences of 0x123. This patch
fixes that and stores the interval (in frame numbers) in which each
FID is valid. From the first time the FID is seen to the time the
close is done.
Change-Id: I9027bb1756d1dbee0393b50786f49845b79f129c
Reviewed-on: https://code.wireshark.org/review/36192
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The assert mistakenly crashed the import
Bug: 16410
Change-Id: I385f4ba9b842f0f25d6ffe30db6065946fd55d84
Reviewed-on: https://code.wireshark.org/review/36233
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
This patch dissects the clock divisorset command. For the FT2232D it
will also calculate the clock based on the divisor.
Calculating the clock for newer chips requires more context that what we
currently have. The master clock is 60MHz by default but can be
configured to 12MHz for compatibility with older chips. We need to track
the "Divide by 5" commands (0x8A/0x8B) to be able to claculate the
clock.
Ping-Bug: 11743
Change-Id: Ica3acfa97b4db38c2f28bb14cb1e0576d9b5139e
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36167
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
When smb2_session_info() was factored out a bug was introduced where
instead of appending text in the parent it appended text in the new
sub item, showing it twice. Fix that by appending to the parent item
instead.
Change-Id: I87c681cd5ea233b3a8c451d0dde2cd2ddf8da48e
Reviewed-on: https://code.wireshark.org/review/36191
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Anders Broman