osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

pfcp: print Predefined Rules as ascii if possible 

Change-Id: I62d5ee7eb0171132f0905e5fbaf663f5a161dcff
Reviewed-on: https://code.wireshark.org/review/36291
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Joakim Karlsson 2020-03-05 14:23:47 +01:00 committed by Anders Broman
parent 548a08cadc
commit 64ad0a85c6
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
epan/dissectors/packet-pfcp.c
View File

@ -149,6 +149,8 @@ static int hf_pfcp_urr_id = -1;
static int hf_pfcp_qer_id_flg = -1;
static int hf_pfcp_qer_id = -1;
static int hf_pfcp_predef_rules_name = -1;
static int hf_pfcp_predef_rules_name_str = -1;
static int hf_pfcp_apply_action_flags = -1;
static int hf_pfcp_apply_action_flags_b6_ipmd = -1;
@ -4594,7 +4596,10 @@ dissect_pfcp_act_predef_rules(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree
/* Octet 5 to (n+4) Predefined Rules Name
* The Predefined Rules Name field shall be encoded as an OctetString
*/
proto_tree_add_item(tree, hf_pfcp_predef_rules_name, tvb, offset, length, ENC_NA);
if (tvb_ascii_isprint(tvb, offset, length))
proto_tree_add_item(tree, hf_pfcp_predef_rules_name_str, tvb, offset, length, ENC_ASCII | ENC_NA);
else
proto_tree_add_item(tree, hf_pfcp_predef_rules_name, tvb, offset, length, ENC_NA);
}
/*
* 8.2.73 Deactivate Predefined Rules
@ -4606,7 +4611,10 @@ dissect_pfcp_deact_predef_rules(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tre
/* Octet 5 to (n+4) Predefined Rules Name
* The Predefined Rules Name field shall be encoded as an OctetString
*/
proto_tree_add_item(tree, hf_pfcp_predef_rules_name, tvb, offset, length, ENC_NA);
if (tvb_ascii_isprint(tvb, offset, length))
proto_tree_add_item(tree, hf_pfcp_predef_rules_name_str, tvb, offset, length, ENC_ASCII | ENC_NA);
else
proto_tree_add_item(tree, hf_pfcp_predef_rules_name, tvb, offset, length, ENC_NA);
}
/*
* 8.2.74 FAR ID
@ -9044,6 +9052,11 @@ proto_register_pfcp(void)
FT_BYTES, BASE_NONE, NULL, 0x0,
NULL, HFILL }
},
{ &hf_pfcp_predef_rules_name_str,
{ "Predefined Rules Name", "pfcp.predef_rules_name",
FT_STRING, BASE_NONE, NULL, 0x0,
NULL, HFILL }
},
{ &hf_pfcp_apply_action_flags,
{ "Flags", "pfcp.apply_action_flags",
FT_UINT8, BASE_HEX, NULL, 0x0,