Commit Graph

29261 Commits

Author SHA1 Message Date
Stig Bjørlykke 70b264328c Made lua_load_script() static.
svn path=/trunk/; revision=30236
2009-10-01 14:47:57 +00:00
Stig Bjørlykke 6325c5d30f Return from dfilter_expr_dlg_accept_cb() if nothing selected.
svn path=/trunk/; revision=30235
2009-10-01 14:44:59 +00:00
Stig Bjørlykke 68778b862e Added check for valid pointers (to avoid warnings).
svn path=/trunk/; revision=30234
2009-10-01 14:41:34 +00:00
Stig Bjørlykke 9a0714cfed Fixed input argument for sscanf "%x" (shall be unsigned int).
Check that this value has been set.

svn path=/trunk/; revision=30233
2009-10-01 14:38:37 +00:00
Anders Broman 8537091ce8 Update to 3GPP TS 36.413 V9.0.0 (2009-09)
svn path=/trunk/; revision=30232
2009-10-01 14:21:40 +00:00
Anders Broman 5e6b38d75a Update to 3GPP TS 36.413 V8.7.0 (2009-09)
svn path=/trunk/; revision=30231
2009-10-01 13:48:36 +00:00
Stig Bjørlykke e37ca89f05 Cast a pointer to avoid a warning.
svn path=/trunk/; revision=30230
2009-10-01 11:20:33 +00:00
Stig Bjørlykke b82f3a8037 Cast a pointer to avoid a warning.
svn path=/trunk/; revision=30229
2009-10-01 11:09:27 +00:00
Stig Bjørlykke 98fd179d82 (minor) Indent fix.
svn path=/trunk/; revision=30228
2009-10-01 10:52:01 +00:00
Anders Broman e7948dc626 From : Didier Gautheron
A gtk tree view version of service response time.
Tested with AFP and SMB, variable size columns don't look great with SMB though.

svn path=/trunk/; revision=30227
2009-10-01 09:04:23 +00:00
Ronnie Sahlberg 2ea2589afb we need to copy the information about the transport syntax, i.e. i fit
is ndr64 or not, from the bind information to the data we store for each 
individual pdu, since the trnasport syntax may change dynamically back 
and forth between "normal" and "ndr64" on the same conversation.



svn path=/trunk/; revision=30226
2009-10-01 08:55:25 +00:00
Stephen Fisher f9fb2a7d7a Remove comment asking if this function should be in strutil.c since it is
already there.


svn path=/trunk/; revision=30225
2009-10-01 02:09:30 +00:00
Jaap Keuter 64d1ab68bc From Jared Renzullo:
The IPv6 SubscriberId object, which was added in the I04 spec, is not supported
in the cops dissector for PCMM. It was already supported for DQOS, however. The
object is identified by S-num = 3, S-type = 2.

svn path=/trunk/; revision=30224
2009-09-30 21:07:55 +00:00
Stig Bjørlykke 332502e77a Removed unused variable.
svn path=/trunk/; revision=30223
2009-09-30 19:48:52 +00:00
Stig Bjørlykke 448523881e Removed 'l' modifier for %g, as it will be ignored.
svn path=/trunk/; revision=30222
2009-09-30 19:48:10 +00:00
Stig Bjørlykke 5f9d734bf8 Corrected prototype for create_list().
svn path=/trunk/; revision=30221
2009-09-30 19:39:33 +00:00
Stig Bjørlykke 6f6497755a Added some check for a valid beep_frame_data.
Untabify file.

svn path=/trunk/; revision=30220
2009-09-30 19:33:39 +00:00
Stig Bjørlykke 8ec95312b7 Corrected hfinfo.ref_count -> hfinfo.ref_type.
(how did this ever compile?)

svn path=/trunk/; revision=30218
2009-09-30 15:03:39 +00:00
Jörg Mayer 1253eb7d5e Add a few more points to the todo list
svn path=/trunk/; revision=30217
2009-09-30 14:06:11 +00:00
Bill Meier bf85ecb308 Rename hfinfo.ref_count to hfinfo.ref_type since that's now how it's used.
svn path=/trunk/; revision=30216
2009-09-30 14:02:49 +00:00
Stig Bjørlykke 1d87c60187 Removed an unneeded assignment.
svn path=/trunk/; revision=30215
2009-09-30 13:42:58 +00:00
Bill Meier db7ff13a50 Remove unneeded 'if(check_col()...)'
svn path=/trunk/; revision=30214
2009-09-30 13:32:53 +00:00
Bill Meier 0882e38510 Remove some unneeded (indirect) 'if(check_col()...)' guarding.
svn path=/trunk/; revision=30213
2009-09-30 13:30:35 +00:00
Bill Meier 832013eee3 #include <epan/expert.h>, <epan/strutil.h>, <stdio.h> & etc not needed....
svn path=/trunk/; revision=30212
2009-09-30 13:22:56 +00:00
Bill Meier 7245b43dde Rework is_acn to use tvb_memeql insted of doing a tvb_get_epemeral_string and a memcmp;
Remove some unneeded calls to col_clear().

svn path=/trunk/; revision=30211
2009-09-30 13:19:14 +00:00
Bill Meier 53b061495d Whitespace changes
svn path=/trunk/; revision=30210
2009-09-30 13:04:06 +00:00
Ronnie Sahlberg a5e9e49e83 Move the definition of the uuid, and registration of its name, for the
standard ndr transfer syntax from the epm dissector to packet-dcerpc.c

Add a new transfer syntax : ndr64. This is a new syntax with different
scalar sizes and different alignment rules compared to normal ndr.
It is negotiated and used between w2k8 and samba4 boxens and one may 
assume, future versions of windows as well.

We need to associate the transfer syntax with the bind information since
the transfer syntax will change the packet encoding rules for the 
protocol.
For example, SAMR, as well as all other interfaces support both syntaxes 
and are thus encoded differently, wiht different alignments depending on 
which transfer was negotioated during the bind.



This will require additional changes to the dcerpc helpers and also to 
pidl.



svn path=/trunk/; revision=30209
2009-09-30 09:43:14 +00:00
Ronnie Sahlberg d69e9a3a05 The dcerpc dissectors used to walk the list of items upward parent by
parent in order to push teh display of extra interesting fields in the 
packet to higher up in the decode tree. This was useful for making sure 
that things like DomainNames etc are clearly visible without having to 
drill down 500 layers of NDR.

This code used to just blindly walk the indicated number of parents, and 
then attach the string to that item.
This relied on the "unsafe" assumption that the topmost item would have 
pointer point to itself, so this was "safe".

This is no longer safe since the root object in the tree now has NULL as 
parent, and thus some of these dcerpc interfaces can now cause a SEGV 
trying to dereference NULL->parent.


I added a macro to safely walk to the parent object, or remain at the 
current object if parent is NULL.



This was a serious bug, where dcerpc traffic could cause a SEGV.
Please merge into all stable versions.





svn path=/trunk/; revision=30208
2009-09-30 07:53:12 +00:00
Ronnie Sahlberg 3e5715008e add the name ModeSense6 to the list of known opcodes for mmc
svn path=/trunk/; revision=30207
2009-09-30 07:47:47 +00:00
Stig Bjørlykke 14d5fe6c49 Print correct destination for SIGCOMP_INSTR_COPY_LITERAL.
svn path=/trunk/; revision=30206
2009-09-29 20:59:30 +00:00
Stig Bjørlykke 47df714a09 Avoid a possible dereference of null pointer.
svn path=/trunk/; revision=30205
2009-09-29 20:48:41 +00:00
Stig Bjørlykke 2a0e507747 Mark unused argument instead of assigning to an unused variable.
svn path=/trunk/; revision=30204
2009-09-29 19:40:21 +00:00
Stig Bjørlykke b8ae6ea510 Don't include config.h in header files.
svn path=/trunk/; revision=30203
2009-09-29 19:30:42 +00:00
Stig Bjørlykke be378b901e Rewrite some local variable names to avoid function argument names.
svn path=/trunk/; revision=30202
2009-09-29 19:29:03 +00:00
Stig Bjørlykke a59f13dbf4 Renamed some local GtkWidget's to avoid variable shadowing.
svn path=/trunk/; revision=30201
2009-09-29 19:23:50 +00:00
Stig Bjørlykke 77c49f4d4b Made colorize_filter_te_as_deprecated() static.
svn path=/trunk/; revision=30200
2009-09-29 19:20:48 +00:00
Stig Bjørlykke 9401317238 Removed unused variable 'sep_len' in col_do_append_str().
svn path=/trunk/; revision=30199
2009-09-29 19:19:40 +00:00
Stig Bjørlykke 92a02af720 Fixed an if-check in gcp_analyze_msg().
svn path=/trunk/; revision=30198
2009-09-29 19:18:43 +00:00
Stig Bjørlykke ad14865ce0 Removed unused variable 'hfinfo' in proto_tree_set_time().
svn path=/trunk/; revision=30197
2009-09-29 19:16:52 +00:00
Stig Bjørlykke 4b7763036b Removed unused variable 'bytes' in oid_subid2encoded.
svn path=/trunk/; revision=30196
2009-09-29 19:16:00 +00:00
Stig Bjørlykke e384c2d682 Remove alloc of unused variables in sctp_analyse_cb().
This fixes bug 4064.

Set sctp_set_filter() static.
Use correct prototype for create_list().

svn path=/trunk/; revision=30195
2009-09-29 13:04:47 +00:00
Stig Bjørlykke 6b4aefe2c7 Use correct prototypes when having no arguments.
Made some functions static.
Removed C++ comments.

svn path=/trunk/; revision=30194
2009-09-29 11:50:07 +00:00
Stig Bjørlykke 155651b404 Move luaopen_bit() to wslua.h
svn path=/trunk/; revision=30193
2009-09-29 11:27:26 +00:00
Stig Bjørlykke 8ef079dc75 Made gcp_trx_to_str() static.
svn path=/trunk/; revision=30192
2009-09-29 10:22:06 +00:00
Stig Bjørlykke 6ef4914808 Corrected prototype for ex_opt_get_nth().
svn path=/trunk/; revision=30191
2009-09-29 10:01:06 +00:00
Stig Bjørlykke a1aee8c660 Put caqm inside INET6 guard in host_lookup6().
Removed unused functions:
- get_hostip()
- get_hostip6()
- name_resolution_changed()
- get_ether_hexa()

svn path=/trunk/; revision=30190
2009-09-29 09:49:43 +00:00
Stig Bjørlykke 4bdf8638b5 Read nsecs as a signed value.
svn path=/trunk/; revision=30189
2009-09-29 07:44:40 +00:00
Stig Bjørlykke ee37f6194f Initialize magic to avoid a warning about a possible uninitialized read.
svn path=/trunk/; revision=30188
2009-09-29 06:57:11 +00:00
Stig Bjørlykke e83dbefaaf Ensure we don't dereference a null pointer.
svn path=/trunk/; revision=30187
2009-09-29 06:52:51 +00:00
Stig Bjørlykke e362a37cbc Ensure we don't dereference a null pointer.
Made emem_canary() static.

svn path=/trunk/; revision=30186
2009-09-29 06:50:35 +00:00