Commit Graph

81198 Commits

Author SHA1 Message Date
Guy Harris 7477431325 wiretap: un-export some routines.
wtap_file_get_shb_for_new_file() and wtap_file_get_nrb_for_new_file()
are intended to be used only internally to libwiretap and by libwiretap
plugins.
2021-05-31 04:39:59 -07:00
Guy Harris 162251176a ascend: set rec->rec_type.
REC_TYPE_PACKET is 0, so if it's been initialized to 0, and never gets
overwritten, this fixes code withotu fixing a visible bug, but it should
be done anyway.
2021-05-31 02:44:57 -07:00
Nardi Ivan 26dd456e62 HTTP: fix typo in dissect_http_heur_tls()
Fixes: a1a2b536
Close #17414
2021-05-31 07:56:46 +00:00
Gerald Combs ffc5522a35 Packaging: "Acorn RISC Machine" was a long time ago.
Use "Arm 64" instead of "ARM 64" for our .dmg names.
2021-05-31 07:41:32 +00:00
Nardi Ivan eb71853533 TLS: add decoding of grease versions
See RFC-8701 Sec 2
2021-05-31 07:26:29 +00:00
Graham Bloice 59de442abb MQTT: Revert subdissector call to not pass topic as data
An inadvertent change in f6ad48 caused sub-dissectors to be called
with their data argument set to the message topic.

This isn't required for the SparkplugB heuristic dissector (or any
other it seems).
2021-05-30 19:56:50 +00:00
Chris Brandson a5df597b3d fixed typo 2021-05-30 19:15:25 +00:00
Chris Brandson aed5c63e73 fixed whitespace issues 2021-05-30 19:15:25 +00:00
Chris Brandson 8e97359883 Added expert info to mark depreciated Zigbee ZDO commands and made
dissection of ZDO responses with a status other than SUCCESS more
lenient, i.e. dissect what is possible and avoid reporting malformed
2021-05-30 19:15:25 +00:00
Gerald Combs a714805628 macOS: Name our .dmgs according to our architecture.
In osx-dmg.sh, add "ARM 64" or "Intel 64" to our .dmg name depending on
the architecture of Wireshark.app/Contents/MacOS/Wireshark.
2021-05-30 17:32:32 +00:00
Gerald Combs f4e18241b9 [Automatic update for 2021-05-30]
Update manuf, services enterprise numbers, translations, and other items.
2021-05-30 17:17:00 +00:00
Joerg Mayer bf33998a30 Add missing space before ']' 2021-05-30 18:51:02 +02:00
João Valverde 49e9ddbd28 release notes: Indent some paragraphs. 2021-05-30 10:38:40 +01:00
Lin Sun e058d47734 RTP: fix RTP Player play failed when SDP not exist
* packet-rtp.c: add conversation info for RTP packets to help RTP Player work
without SDP.
2021-05-30 08:29:17 +00:00
Uli Heilmeier a4b598d3d6 MQTT: Fix dissector call for payload
As we don't know which dissector we call we don't know which data type the
subdissector wants. Therefore we should only call with data for specific
dissectors.
2021-05-30 06:44:25 +00:00
Guy Harris 883f159c8b pcapng: fix some more WTAP_ERR_BAD_FILE err_info strings.
Just say "pcapng:", rather than giving the function name, to match the
style used here and for other capture file formats.
2021-05-29 23:17:27 -07:00
Guy Harris 5827009e7a pcapng: remove a second colon from a debug message. 2021-05-29 22:52:59 -07:00
Guy Harris 82dcb9196a wiretap: clean up WTAP_ERR_BAD_FILE error messages.
Consistently give a file type name at the beginning of the message.
2021-05-29 18:08:24 -07:00
Michael Tuexen 86b28f0d4b wiretap: improve code consistency in pcapng.c 2021-05-30 01:08:14 +02:00
Michael Tuexen 0b93ef669a ui: add support for updating on macOS using arm 2021-05-29 17:21:03 +00:00
Alfredo 1e467963d4 IMAP: Fix resetting of tls state
The ssl_requested field is reset with every frame, regardless of being a request or a
response. Reset ssl_requested only when the next frame is an OK response
2021-05-29 08:04:14 +00:00
Alfredo ddab0457f0 FTP: Add initial support for TLS
Add support for the AUTH TLS command as per RFC 2417 adding the new field tls_requested to FTP conversation, as soon as the 234 response code is received start the TLS communications
2021-05-29 07:42:07 +00:00
Dr. Lars Völker 642d1ca97d MKA: Stop warning for MKA v3
IEEE 802.1X-2020 defined MKA version 3, so the MKA dissector should
not warn that this version does not exist anymore.
2021-05-29 07:26:55 +00:00
Michael Tuexen 96aa5d9b68 macos-setup.sh: update sparkle 2021-05-29 01:41:15 +02:00
Gerald Combs a72b60b58b GitLab CI: Add CMake sections in more places.
Add section start and end markers for cmake in more places.
2021-05-28 18:39:28 +00:00
Thomas Dreibholz 5107ece526 Bugfix: Added Analyze -> SCTP -> Filter this Association
Analyze -> SCTP -> Filter this Association was missing in the menu, but available in the context menu for packets. This MR fixes the issue by adding Analyze -> SCTP -> Filter this Association again.
2021-05-28 16:35:05 +00:00
Thomas Dreibholz 08f1d27a9b Using G_GUINT64_FORMAT for printing DCCP sequence numbers. 2021-05-28 14:28:21 +00:00
Thomas Dreibholz 8dc0e42721 DCCP: Added preferences setting for relative sequence numbers. 2021-05-28 14:28:21 +00:00
Thomas Dreibholz 6928241b30 DCCP: Added support for displaying relative sequence numbers. 2021-05-28 14:28:21 +00:00
Thomas Dreibholz d7fb8c0bf7 Bugfix: Added Analyze -> Follow -> DCCP Stream again.
Analyze -> Follow -> DCCP Stream was missing in the menu, but available
in the context menu for packets. This MR fixes the issue by adding
Analyze -> Follow -> DCCP Stream again.
2021-05-28 14:00:11 +00:00
João Valverde ce41dee302 Add Qt runtime version to about dialog 2021-05-28 13:40:06 +00:00
Stig Bjørlykke 6f72d738de exported_pdu: Add a new TAG for p2p_dir
Add a new exported_pdu TAG to specify pinfo->p2p_dir.
2021-05-28 12:43:21 +00:00
Anders Broman e1e2aaf91a Geographical description, correct the bitmask. 2021-05-28 12:19:15 +00:00
João Valverde 1dba58789d dfilter: Fix handling of escaped quotes in macros
We can't unescape characters when expanding a display filter macro.
The escaping must be preserved until the expression is evaluated in
the display filter engine, otherwise it will likely generate a syntax
error in the parser.

In the macro body we allow '$' (or any other char) to be escaped
with backslash (preserving the backslash).

Fixes #17160.
2021-05-28 10:36:41 +00:00
Constantine Gavrilov 8d60d8c4f2 NVMe: decode Set Fatures data transfers.
This closes #17407.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov e75998cded NVMe: decode Set Fatures response (DWORD0) in CQE. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov d5c1bd9d93 NVMe: refactor CQE decoding to decode all fields and decode comand status. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov 12ddec82bf NVMe: decode Set Features DWORD11 and DWORD12 for each feature. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov f0b83585c1 NVMe: decode Set Features command. 2021-05-28 08:45:26 +00:00
Constantine Gavrilov 6755309958 NVMe: refactor command parsing to always print DWORD10-DWORD15. 2021-05-28 08:45:26 +00:00
Thomas Dreibholz 03921ac668 DCCP: Lookup of service code for DCCP Request and Response. 2021-05-28 04:22:29 +00:00
JanTheMan 108b816fcc doip: make version hdr for ISO13400-2:2019 usable
the already provided defines for the latest ISO version have been made
usable for the version detection in the protocol header
2021-05-28 03:14:58 +02:00
Richard Sharpe fa89a8f673 ieee80211: Fix an infinite loop in the HE Trigger handling.
fixes #17410

Change-Id: I04ce052722f3ed62eb36b8894ee7d67d7c522f94
2021-05-27 19:26:30 +00:00
João Valverde 9dbe29e2ec Minor style change to libpcap version string 2021-05-27 17:40:01 +00:00
Michael Tuexen a889e8e04b macos-setup.sh: improve arm support
Disable on arm the usage of assember code in nettle and sbc, since this
doesn't compile (yet) on arm platforms.
2021-05-27 14:18:45 +02:00
Lin Sun 5f338e5f1b opus: fix dissector error for win32 build
* packet-opus.c: the array for proto_tree_add_bitmask_list should end with NULL
2021-05-27 07:12:01 +00:00
Kirill Smorodinnikov dde67b0182 PCEP: Fixing PATH-SETUP-TYPE-CAPABILITY padding offset
Fix offset of padding in PATH-SETUP-TYPE-CAPABILITY TLV. The offset was incorrect.
2021-05-27 06:13:12 +00:00
Lin Sun 7f63556627 opus: fix build error on MacOS for commit ecd1ab5b23 2021-05-27 05:13:25 +00:00
John Thacker 1513237d10 DVB-S2-BB: Add preference for default mode adaptation format
DVB Baseband Frames have four possible mode adaptation formats, and
the check to distinguish them depends on only a CRC-8, so it's possible
to have ambiguity, particularly in a large capture. Add a preference to
for preferred format, defaulting to the SatLabs L.3 mode, since that's
the most common format I've seen in captures or in datasheets for
BBFrames over UDP or RTP. Also make L.3 the second highest preference
when something else is set to the default.
2021-05-26 21:57:05 -04:00
John Thacker 17f2fc32f7 tshark: Correct documentation about name resolution.
The tshark help and documentation has been incorrect for at least
eight years, claiming that by default all name resolutions are
performed. Fixes #11762
2021-05-26 23:09:53 +00:00