Commit Graph

44983 Commits

Author SHA1 Message Date
Bill Meier 6bdb92dd8a Use consistent indentation & formatting style.
svn path=/trunk/; revision=47727
2013-02-18 01:59:17 +00:00
Bill Meier 1c289aa89a Don't use index as a variable name (i knew that..).
Fixes compiler warning.

svn path=/trunk/; revision=47726
2013-02-18 01:18:51 +00:00
Michael Mann 0a135e8eb0 Bugfix data combined via ssl_desegment_app_data not visible via "Follow SSL Stream"
From Joe McEachern, bug 6434 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6434)

svn path=/trunk/; revision=47725
2013-02-18 00:58:21 +00:00
Bill Meier e7ff4a79c0 Implement proto_tree_write_fields without using ep_strbufs.
- Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8348:
   "tshark -T fields can't print the full value of fields where the value,
    as a text string, is longer than 65535 bytes"
- Reduces ep memory allocation & string copies;


svn path=/trunk/; revision=47724
2013-02-18 00:51:59 +00:00
Michael Mann 4e27a8a034 Improve SSH state machine so IGNORED messages don't upset the dissection by throwing the "packet count" off.
Bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064)

svn path=/trunk/; revision=47723
2013-02-17 23:00:57 +00:00
Chris Maynard 7735035230 Fix Coverity CID 981983: Unused pointer value.
Additionally:
1) Remove check_col()'s
2) Don't call expert_add_info_format() from within an if (tree) {} block.
3) tvb_reported_length_remaining() can return -1; be sure to handle it.
4) Misc. whitespace changes.

svn path=/trunk/; revision=47722
2013-02-17 22:44:47 +00:00
Michael Mann fd44f9a339 Remove C++ incompatibilities in c1222 dissector.
Also addresses an implicit cast in the epan/uat.h file

Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)

svn path=/trunk/; revision=47721
2013-02-17 22:15:16 +00:00
Pascal Quantin 73ef143f95 Update ITU-T E.212 to bulletin 1019 (01.I.2013)
svn path=/trunk/; revision=47720
2013-02-17 21:48:18 +00:00
Guy Harris fd180b7001 Get rid of zero-length array - we allow Wireshark to be compiled with
compilers that don't support zero-length arrays.

svn path=/trunk/; revision=47719
2013-02-17 21:24:31 +00:00
Guy Harris 3cd82d13c1 Add a macro to calculate, from the size of an AirpcapKeysCollection
structure, the number of keys in the key list, and use it.

svn path=/trunk/; revision=47718
2013-02-17 21:14:14 +00:00
Guy Harris 61f7b3e031 Squelch some more warnings.
svn path=/trunk/; revision=47717
2013-02-17 20:00:53 +00:00
Guy Harris 947da615c4 Squelch some warnings.
svn path=/trunk/; revision=47716
2013-02-17 19:58:56 +00:00
Michael Mann aa8b665141 Support for SCU/SCP Role Selection and Asynchronous Operations Window Negotiation
From Stefan Allers.  Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347)

svn path=/trunk/; revision=47715
2013-02-17 19:36:08 +00:00
Anders Broman ad636a9492 Try to fix merge problem.
svn path=/trunk/; revision=47714
2013-02-17 19:35:17 +00:00
Anders Broman 9341c04a12 Add a preferense to the Q.932 dissector wether facility messages should be dissected as QSIG or ETSI.
Add the ISUP Supplementary services dissector.

svn path=/trunk/; revision=47713
2013-02-17 19:28:59 +00:00
Guy Harris a26d951d8a Oops, the list is of Makefiles, not of directories that should contain
Makefiles.

svn path=/trunk/; revision=47712
2013-02-17 19:14:10 +00:00
Guy Harris c025682454 Add asn1/isdn-sup to the list of directories in which to generate a
Makefile.

svn path=/trunk/; revision=47711
2013-02-17 19:12:35 +00:00
Guy Harris 1e389e91c1 Give it an RCS ID.
svn path=/trunk/; revision=47710
2013-02-17 19:08:12 +00:00
Guy Harris 4e16c03bd1 Get rid of trailing CRs, set the usual svn properties to expand $Id$ and
use native line endings.

svn path=/trunk/; revision=47709
2013-02-17 19:07:27 +00:00
Michael Mann 0b916ad1b4 Bugfix DoS in CIMD dissector. Bug 8346 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8346)
svn path=/trunk/; revision=47708
2013-02-17 19:07:14 +00:00
Anders Broman f942b5e12a Add isdn-sup to the asn1 makefiles.
svn path=/trunk/; revision=47707
2013-02-17 18:32:35 +00:00
Anders Broman 7a60d0d9eb Add the files for an initial ISDN Supplimentary Services(ETSI) dissector.
svn path=/trunk/; revision=47706
2013-02-17 18:27:04 +00:00
Michael Mann 823493b927 Only allow one packet to act as an SDP response. This should probably be caught at a higher layer (SIP), but the safety net should be there.
Also, cleanup SIP "response error" range.

Fixes crash in bug 8343 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8343)

svn path=/trunk/; revision=47705
2013-02-17 18:25:22 +00:00
Evan Huus 010c8f9d61 Use wmem memory to build most of the diameter hf and ett arrays.
Cleans up many valgrind errors, since we were losing our pointers to
the arrays before shutdown.

svn path=/trunk/; revision=47702
2013-02-17 15:06:35 +00:00
Gerald Combs 8c0da052ca [Automatic manuf, services and enterprise-numbers update for 2013-02-17]
svn path=/trunk/; revision=47701
2013-02-17 15:03:20 +00:00
Evan Huus 0e5478cdcd From Alyssa Milburn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8341
With small additional changes by me

Make many of the length and offset fields in the websocket dissector unsigned.
This fixes a case where we could attempt to malloc (unsigned)-1 bytes of memory.
Also fix one small copy-paste string typo.

svn path=/trunk/; revision=47700
2013-02-17 14:39:16 +00:00
Guy Harris 8d7ffcc99b Add a macro that, for a given count of keys, returns the total size of
an AirpcapKeysCollection structure with that number of keys, and use it
instead of doing the calculation manually.

svn path=/trunk/; revision=47699
2013-02-17 03:45:06 +00:00
Guy Harris 806cb7224d Clean up white space (use spaces instead of tabs).
svn path=/trunk/; revision=47698
2013-02-17 03:28:23 +00:00
Guy Harris 5be3e9cb7a Clean up white space (get rid of 4-space tabs).
svn path=/trunk/; revision=47697
2013-02-17 03:16:57 +00:00
Evan Huus 808d171623 Add missing G_GUINT64_CONSTANT for 32-bit platforms.
svn path=/trunk/; revision=47696
2013-02-16 17:43:16 +00:00
Evan Huus 90ec697e89 From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313
New dissector for the SML protocol.

svn path=/trunk/; revision=47695
2013-02-16 16:48:30 +00:00
Evan Huus 0f8735b8a3 From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8287
Request-response tracking and response-time calculation for HTTP.

svn path=/trunk/; revision=47694
2013-02-16 14:59:00 +00:00
Pascal Quantin 9dc510fc8e Fix typo error
svn path=/trunk/; revision=47693
2013-02-16 13:55:10 +00:00
Jaap Keuter 649b979d36 From Alyssa Milburn:
This patch adds a check for a zero count to the existing sanity check code.

From me:
In addition drop superfluous sanity check.

svn path=/trunk/; revision=47692
2013-02-16 13:49:42 +00:00
Jörg Mayer b5efdcf02c Add Ethertype for Network Controller Sideband Interface
svn path=/trunk/; revision=47691
2013-02-16 10:31:20 +00:00
Michael Mann 46dbc91896 Add decryption algorithm preference to SNMP dissector.
Bug 8328 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8328)

svn path=/trunk/; revision=47690
2013-02-16 02:10:50 +00:00
Martin Mathieson 76b17b3f0c Set more preferences to be on by default.
svn path=/trunk/; revision=47689
2013-02-16 00:11:28 +00:00
Martin Mathieson 8cdb2c675b Make the number of RAPIDs in an RAR PDU a generated field.
svn path=/trunk/; revision=47688
2013-02-16 00:05:37 +00:00
Martin Mathieson 18cb86cc23 Show resegmented data as grey.
svn path=/trunk/; revision=47687
2013-02-16 00:00:06 +00:00
Martin Mathieson cf15301cbf Add support for reading/writing 'sprint' lines from test scripts.
svn path=/trunk/; revision=47686
2013-02-15 23:43:30 +00:00
Evan Huus 0fa191245e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8337
Make offset unsigned and add an additional sanity check.

svn path=/trunk/; revision=47681
2013-02-15 20:58:59 +00:00
Guy Harris 3b9b52e279 Get rid of an extra blank line.
svn path=/trunk/; revision=47677
2013-02-15 20:10:19 +00:00
Evan Huus ebe0005840 From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8264
Improve handling of truncated USB Configuration descriptors.

In contrast to other descriptor types, configuration descriptors have varying
lengths and may be quite long. This makes them much more prone to truncation
by a host that is cautious about reading large descriptors.

A real-world case has arisen where a host requests a partial configuration
descriptor of a USB webcam, and wireshark improperly reports that the response
is malformed.

Change configuration descriptor dissection to distinguish between truncation
induced by the host, which is not an error, and descriptor truncation or
reporting of invalid descriptor lengths by the device, which are.

This patch also relieves class-specific dissectors of the burden of checking
that the descriptor length and type fields are available, and that all the
bytes claimed by the descriptor length are also available.

svn path=/trunk/; revision=47676
2013-02-15 17:32:34 +00:00
Evan Huus 235a1eb09d From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8331
Fix UCS-2 string decoding for strings longer than 127 characters.

svn path=/trunk/; revision=47675
2013-02-15 16:59:20 +00:00
Michael Mann f5d559e879 Fix Voice RTP player crash if player is closed while playing
Bug 8065 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8065)

svn path=/trunk/; revision=47674
2013-02-15 15:31:24 +00:00
Evan Huus f95978cf08 From Hannes Mezger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8327
Updates to the OPCUA plugin so that subtrees of the dissector select the
appropriate number of bytes. Also fix dissection of the array dimensions
field for matrix values and the highlighting for empty string fields.

svn path=/trunk/; revision=47673
2013-02-15 15:24:39 +00:00
Evan Huus fb530b1a72 From Alyssa Milburn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8335
Make length field unsigned so that negative values fail the bounds check and
throw a regular exception before getting passed to glib (where they cause a
program-ending assert failure instead).

svn path=/trunk/; revision=47672
2013-02-15 13:10:06 +00:00
Bill Meier f9ecda41e4 Comment out a number of unused hf[] enrries found by checkhf.
svn path=/trunk/; revision=47670
2013-02-15 02:50:36 +00:00
Guy Harris 80b0bc752e Add a new WSLUA_CLASS_FNREG_ALIAS() macro to register methods where the
function name isn't the same as the method name; this is used if we're
providing compatibility aliases for method names.

Use WSLUA_CLASS_FNREG() and WSLUA_CLASS_FNREG_ALIAS() for all method
registrations.

Fix the spelling of "prepend", but leave a compatibility alias in place.

svn path=/trunk/; revision=47667
2013-02-15 01:38:45 +00:00
Bill Meier 2c269c2864 Fix a set of obscure bugs found by checkhf.
svn path=/trunk/; revision=47666
2013-02-15 01:31:27 +00:00