Guy Harris
692bd92699
Fix a comment, add another comment, and fix indentation.
...
svn path=/trunk/; revision=45268
2012-10-02 20:47:20 +00:00
Pascal Quantin
88324e39bb
Use a value string array for EPS Bearer Identity and remove useless de_esm_lnkd_eps_bearer_id function
...
svn path=/trunk/; revision=45267
2012-10-02 20:44:36 +00:00
Pascal Quantin
64272873f0
The Packet Filter Identifier range is [1;16] according to 3GPP 27.007 chapter 10.1.3
...
svn path=/trunk/; revision=45266
2012-10-02 20:17:08 +00:00
Gerald Combs
409b405d7c
Move the main window slots to main_window_slots.cpp.
...
svn path=/trunk/; revision=45259
2012-10-02 18:47:05 +00:00
Gerald Combs
498db62022
Test with the presence (-nVxr) and absence (-nr) of the tree. We now
...
use an array of arguments so additional combinations can be added.
svn path=/trunk/; revision=45258
2012-10-02 17:58:00 +00:00
Pascal Quantin
ff3bd58b74
Upgrade NAS EPS dissector to v11.4.0 (Release 11)
...
svn path=/trunk/; revision=45253
2012-10-02 12:46:21 +00:00
Pascal Quantin
dc1788a98e
According to 3GPP 24.011, information element name is RP-Originator Address, not RP-Origination Address
...
svn path=/trunk/; revision=45252
2012-10-02 10:58:36 +00:00
Jeff Morriss
6e5059382a
OK, ETSI has (not surprisingly) picked up 3GPP's values in later ETSI specs;
...
comment out the older, conflicting ETSI-specified values and use the more
modern ones.
Mark a couple of deprecated values as such (void).
svn path=/trunk/; revision=45251
2012-10-02 09:00:55 +00:00
Jeff Morriss
d800213b67
Add some Specific-Action enums from 29.214 v11.6.0.
...
Note a conflict here between 29.214 and the older ETSI spec for values 6 and
7.
svn path=/trunk/; revision=45250
2012-10-02 08:20:37 +00:00
Pascal Quantin
4afd80511e
Fix hf_me (it is a 2 bits long field, not a boolean)
...
svn path=/trunk/; revision=45249
2012-10-02 07:20:31 +00:00
Gerald Combs
e46cf2a726
Don't bother setting a background gradient in the toolbar on Windows.
...
svn path=/trunk/; revision=45246
2012-10-01 22:57:34 +00:00
Gerald Combs
0ffe19134b
Construct a proper directory URL.
...
svn path=/trunk/; revision=45245
2012-10-01 22:55:45 +00:00
Evan Huus
3e5ac249e9
Add new fileset ui file to cmake build.
...
svn path=/trunk/; revision=45244
2012-10-01 22:52:14 +00:00
Gerald Combs
d02a2328ef
Implement file sets.
...
Replace the original file set code with a UI form. Use more consistent
file names. List the files using a QTreeWidget instead of a grid.
fileset_is_file_in_set is only used in fileset.c so make it static.
In main_window.cpp reduce our usage of the global cfile variable.
svn path=/trunk/; revision=45243
2012-10-01 22:40:20 +00:00
Jaap Keuter
34e3d6d1f3
Make protocol 5 octets long and cut down code clutter,
...
svn path=/trunk/; revision=45242
2012-10-01 21:43:34 +00:00
Chris Maynard
724888c321
Widen the "Find text" dialog a bit so the entire title is visible.
...
svn path=/trunk/; revision=45241
2012-10-01 20:57:15 +00:00
Gerald Combs
447ade94b5
Add a window pointer so that we can figure out from whence we came.
...
Bring the timestamp output more in line with ISO 8601.
svn path=/trunk/; revision=45240
2012-10-01 20:14:47 +00:00
Pascal Quantin
5ec061bf0c
Add options to dissect MCCH from LTE MAC/RLC dissectors
...
svn path=/trunk/; revision=45239
2012-10-01 19:51:07 +00:00
Martin Kaiser
0836b3b16b
update the capture comment icon in the statusbar
...
when a capture comment was edited via Statistics/Summary
svn path=/trunk/; revision=45238
2012-10-01 19:11:14 +00:00
Jeff Morriss
2dc1b40a20
There is no longer the need to define HAVE_CONFIG_H.
...
svn path=/trunk/; revision=45232
2012-10-01 11:49:15 +00:00
Jeff Morriss
2fbf659e28
Stop defining HAVE_CONFIG_H on Windows builds too.
...
svn path=/trunk/; revision=45231
2012-10-01 11:47:36 +00:00
Jeff Morriss
f89635883f
The -B option is no longer only available in Win32: remove the Win32
...
restriction from the Synopsis.
This is the man page for Wireshark, not Tshark (fix a cut-n-pasteo).
svn path=/trunk/; revision=45229
2012-10-01 07:14:03 +00:00
Martin Kaiser
8b7686e9b8
use the correct status bar icon for the capture comment
...
if we have an empty capture comment (an existing comment was deleted),
we should use the same icon as if no comment was present
svn path=/trunk/; revision=45227
2012-09-30 18:37:59 +00:00
Chris Maynard
296d2900a1
Add displayed and marked percent columns and percent calculations for dropped and ignored packets in summary dialog. Also display percent calculations for displayed, marked, ignored and dropped packets in statusbar. Like ignored packets, only display marked packet count and percent in the statusbar if there are any.
...
Fixes enhancement bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2377
svn path=/trunk/; revision=45226
2012-09-30 18:28:04 +00:00
Chris Maynard
ee56ee5181
Revert r45185. While it looks better with an icon if "Filter toolbar style" is set to "Icons & Text", if the preference is set to "Icons only", all custom filters will have the same icon displayed and it will be difficult to know which is which w/out hovering on each for a tooltip. Maybe someone else can figure out how to add the icon, but only in the case of "Icons & Text"?
...
svn path=/trunk/; revision=45225
2012-09-30 18:15:40 +00:00
Martin Kaiser
1ca75014ae
dvb-ci: display cc item's name in the subtree title
...
svn path=/trunk/; revision=45224
2012-09-30 17:58:45 +00:00
Chris Maynard
a1722d352a
Trivial: LEDs -> Icons
...
svn path=/trunk/; revision=45223
2012-09-30 15:59:40 +00:00
Gerald Combs
ee6d50acba
[Automatic manuf, services and enterprise-numbers update for 2012-09-30]
...
svn path=/trunk/; revision=45220
2012-09-30 14:03:25 +00:00
Alexis La Goutte
26f28b0427
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=45219
2012-09-30 11:06:28 +00:00
Alexis La Goutte
84f7a07047
From Yu Zhang via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7769
...
Add Dissector for SuboptionDeviceInstance under DevicePropertiesOption in PROFINET DCP
In PROFINET DCP dissector, current build didn't have SuboptionDeviceInstance
(0x07) under DevicePropertiesOption (0x02). This patch add the support of
SuboptionDeviceInstance
svn path=/trunk/; revision=45218
2012-09-30 11:02:56 +00:00
Alexis La Goutte
7c59618e8d
From Olivier Benghozi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7734
...
Enhance Route Refresh Capability : Add draft-ietf-idr-bgp-enhanced-route-refresh-02
Not yet support new NOTIFICATION error code : ROUTE-REFRESH Message Error (Value To Be Defined)
From me :
* Make some Route Refresh fields filterable
svn path=/trunk/; revision=45217
2012-09-30 10:38:37 +00:00
Alexis La Goutte
cd519e450c
From Olivier Benghozi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7734
...
BGP bad decoding for Graceful Restart Capability with only helper support
BGP Capability in OPEN message: Graceful restart capability (64).
So when the length of the capability value is smaller that 6 (6 meaning full
support of GR capa, with significants elements and at least one AFI/SAFI), the
code interprets it as erroneous.
However,as described in RFC4724: " When a sender of this capability does not
include any <AFI, SAFI> in the capability, it means that the sender is not
capable of preserving its forwarding state during BGP restart, but supports
procedures for the Receiving Speaker (as defined in Section 4.2 of this
document). In that case, the value of the Restart Time field advertised by the
sender is irrelevant".
So, length of exactly 2 is valid but has to be interpreted with a particular
meaning.
In the dissector code, a length of 2 should be a special case for this capa,
decoding as "Graceful Restart helper mode only" or something like that, and
maybe also displaying an expert message if the Restart flag is not 0 in this
case, since here it's not expected to be possible.
svn path=/trunk/; revision=45216
2012-09-30 10:05:18 +00:00
Pascal Quantin
1b3fd6e7e1
Upgrade LTE RRC dissector to v11.1.0
...
svn path=/trunk/; revision=45215
2012-09-30 08:06:50 +00:00
Guy Harris
fbe74322b1
From Bill Parker:
...
Add some additional memory-allocation failure checks in Lemon.
Use NULL rather than 0 as the null-pointer constant in those
checks.
From me:
Catch one more of the NULL-vs-0 cases.
Fix some failure messages to use fprintf(stderr, ...) -
ErrorMsg() requires a file name and line number, and is
generally used if you're going to continue rather than just give
up.
svn path=/trunk/; revision=45214
2012-09-29 19:40:27 +00:00
Chris Maynard
73bf99ee7a
Add wrapDateLine to support continuous longitudinal panning.
...
svn path=/trunk/; revision=45213
2012-09-29 15:59:32 +00:00
Chris Maynard
5d64bef6e1
Revert most of r45210. We don't use the return value of GetExitCodeProcess(), but it still needs to be called to get childstatus.
...
svn path=/trunk/; revision=45212
2012-09-29 15:49:06 +00:00
Evan Huus
560cdd7ed5
More unused variables caught by cppcheck.
...
svn path=/trunk/; revision=45211
2012-09-29 14:15:20 +00:00
Evan Huus
73e5c4e40f
Don't fetch the exit code of our child process, we never use it.
...
svn path=/trunk/; revision=45210
2012-09-29 14:06:40 +00:00
Evan Huus
c103c2fe04
Fix some memleaks caught by cppcheck.
...
svn path=/trunk/; revision=45209
2012-09-29 14:03:36 +00:00
Evan Huus
813781f18c
Remove some unused variables caught by cppcheck.
...
svn path=/trunk/; revision=45208
2012-09-29 13:57:57 +00:00
Evan Huus
d908cf1132
From Andrew Kampjes via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7750
...
Pull SDH level out of ERF header if the user hasn't manually set the preference.
svn path=/trunk/; revision=45207
2012-09-29 13:44:45 +00:00
Pascal Quantin
99e7a5b4dc
From Mike Morrin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 :
...
Fix minor bug in dissection of "e" bit and add value strings for remaining data block header fields
svn path=/trunk/; revision=45206
2012-09-29 08:34:00 +00:00
Alexis La Goutte
0bddabb63b
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7767
...
Add the FeliCa Plug System Code
Fairly recently, Sony introduced the "FeliCa Plug" (AKA "NFC Dynamic Tag")
product - which also has a unique System Code value (0xFEE1) associated with
it, according to
http://www.sony.net/Products/felica/business/tech-support/data/fp_usmnl_1.11.pdf
svn path=/trunk/; revision=45205
2012-09-29 07:47:19 +00:00
Jakub Zawadzki
d45d88d161
remove some very old comments about multithreaded tap implementation...
...
svn path=/trunk/; revision=45202
2012-09-28 21:48:28 +00:00
Jakub Zawadzki
49ce5e127b
protect_thread_critical_region, unprotect_thread_critical_region are no-ops, cleanup code by removing them.
...
svn path=/trunk/; revision=45201
2012-09-28 21:36:21 +00:00
Pascal Quantin
99d2b14706
Remove a duplicate hf
...
svn path=/trunk/; revision=45200
2012-09-28 21:20:29 +00:00
Chris Maynard
85ac1f3ffd
Increase the default width of the capture options dialog so all columns are visible. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7766
...
svn path=/trunk/; revision=45199
2012-09-28 20:43:40 +00:00
Pascal Quantin
12c71b2ff1
Remove a duplicate hf
...
svn path=/trunk/; revision=45198
2012-09-28 20:36:03 +00:00
Bill Meier
f8a2fd3010
Fix another "set but unused" compiler warning...
...
svn path=/trunk/; revision=45197
2012-09-28 19:59:52 +00:00
Bill Meier
daab50bc27
Fix "set but unused" compiler error.
...
svn path=/trunk/; revision=45196
2012-09-28 19:56:16 +00:00