Commit Graph

12282 Commits

Author SHA1 Message Date
Anders Broman 4d0c391d5d From Michael Lum:
Fixes for E911 mobile positioning capability and Handoff Back2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4373

svn path=/trunk/; revision=31462
2010-01-07 20:27:38 +00:00
Stig Bjørlykke 6defe828fc Made more generic concat meta method for TvbRange, Int64 and UInt64.
This way we can concat more objects in one line.

svn path=/trunk/; revision=31461
2010-01-07 12:40:23 +00:00
Guy Harris 9038fc7098 We do proto_item_append_string() all over the place; make the tree
visible at the top level.

svn path=/trunk/; revision=31460
2010-01-07 02:51:57 +00:00
Stig Bjørlykke 703aa03948 Added concat meta method for TvbRange, Int64 and UInt64.
svn path=/trunk/; revision=31458
2010-01-06 22:14:25 +00:00
Martin Mathieson bd55fda74c From Pascal Quantin: some typo fixes
svn path=/trunk/; revision=31455
2010-01-06 17:07:37 +00:00
Stig Bjørlykke c5fac7edc4 Fix some documentation typos.
svn path=/trunk/; revision=31453
2010-01-06 10:13:56 +00:00
Stig Bjørlykke e619752c58 Added signed integer TvbRange methods.
svn path=/trunk/; revision=31452
2010-01-05 20:25:04 +00:00
Anders Broman 03929b6237 From Pascal Quantin:
[RRC] Update SIB PDU decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4371
I also removed dummy code.

svn path=/trunk/; revision=31451
2010-01-05 20:05:12 +00:00
Stig Bjørlykke a5c2c6fb0d Use correct method names in TvbRange error messages.
svn path=/trunk/; revision=31450
2010-01-05 16:07:21 +00:00
Stig Bjørlykke 31e116d74a Use correct field types for signed integer.
svn path=/trunk/; revision=31449
2010-01-05 15:37:45 +00:00
Stig Bjørlykke d298ea10e7 Terminate value_string user_vals.
svn path=/trunk/; revision=31448
2010-01-05 14:46:53 +00:00
Stig Bjørlykke 6a433058f9 Added check for SIZE constraints in bit-string.
svn path=/trunk/; revision=31447
2010-01-05 11:38:33 +00:00
Stephen Fisher bf2aae7784 More updates to the ISL dissector:
1) Rollback r14139 in two parts:

    a) Change user priority back to what Cisco's ISL documentation states that
       the values mean instead of the 802.1Q CoS values (see also note below).
    b) Change the destination address back to type FT_ETHER since the
       ISL-Frame values were added to manuf/wka.tmpl in r16741 with a /40
       mask.

2) Add 03-00-0C-00-00/40 to manuf/wka.tmpl for ISL over Token Ring.

3) Move the type and user fields to a tree elow the destination address since
   that is where the values come from. 

NOTE: Regarding change 1a, I noticed in the Wiki's isl-2-dot1q.cap sample
      capture file that bit #2 is being set to 1 when bits 0 and 1 are set to
      1.  When bits 0 and 1 are both set to 0, bit 2 is not set.  I cannot
      find a reference to this bit being used in Cisco's documentation. 


svn path=/trunk/; revision=31446
2010-01-05 10:15:11 +00:00
Stig Bjørlykke 9b3a53b8d1 Split in two asn files.
svn path=/trunk/; revision=31445
2010-01-05 08:50:15 +00:00
Stephen Fisher eb3313be94 Minor updates to ISL dissector:
- Bring URLs at top of file up to date.
- Replace redundant true false string (bpdu_tfs) with built-in one (tfs_yes_no)
- Change VLAN ID representations from hex to decimal 
- Change description (but not filter name) for BPDU indicator to indicate that,
  per Cisco documentation, it is set when it is not only a BPDU frame but also
  set for CDP and VTP frames.
- Add "(Color)" to VLAN ID field descriptions for nostalgic reasons :)


svn path=/trunk/; revision=31444
2010-01-05 08:17:09 +00:00
Guy Harris 853cb23801 Get rid of unused variables.
svn path=/trunk/; revision=31443
2010-01-05 02:11:24 +00:00
Anders Broman e8042d8eec From gonzalocas:
GSSE message dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4370

svn path=/trunk/; revision=31442
2010-01-04 23:17:37 +00:00
Anders Broman 38b0b13b23 As requested by Pascal Quantin:
Add the ability to call the UE EUTRA Capability dissector directly.

svn path=/trunk/; revision=31441
2010-01-04 15:36:51 +00:00
Martin Mathieson 7897e78d02 Added casts wanted by win64 compiler.
svn path=/trunk/; revision=31440
2010-01-04 15:24:33 +00:00
Martin Mathieson b8596e6ad6 Start to supply data for an RLC tap.
svn path=/trunk/; revision=31439
2010-01-04 14:07:24 +00:00
Gerald Combs b8a6f552b5 [Automatic manuf and enterprise-numbers update for 2010-01-03]
svn path=/trunk/; revision=31435
2010-01-03 16:03:26 +00:00
Stig Bjørlykke 05ec983b05 Corrected abbrev for message-id ack.
svn path=/trunk/; revision=31434
2010-01-03 15:42:53 +00:00
Stig Bjørlykke 31201a01cb Use different abbrev for IPv4 and IPv6 address.
svn path=/trunk/; revision=31433
2010-01-03 15:41:29 +00:00
Stig Bjørlykke a6d17fca9f Corrected abbrev for Client IP.
svn path=/trunk/; revision=31432
2010-01-03 15:40:14 +00:00
Stig Bjørlykke 0929d61df2 Changed abbrev for amqp_field.
svn path=/trunk/; revision=31431
2010-01-03 15:09:26 +00:00
Stig Bjørlykke aff9e3efe9 Use different abbrev for IPv4 and IPv6 address.
svn path=/trunk/; revision=31430
2010-01-03 15:08:50 +00:00
Stig Bjørlykke 31b77bac8a Use different abbrev for unknown data and unknown field.
svn path=/trunk/; revision=31429
2010-01-03 15:08:18 +00:00
Stig Bjørlykke 9995a69512 Changed abbrev for XML Body.
svn path=/trunk/; revision=31428
2010-01-03 15:07:16 +00:00
Stig Bjørlykke 1bf289e338 Fixed abbrev for entry_mask elements.
svn path=/trunk/; revision=31427
2010-01-03 15:06:35 +00:00
Stig Bjørlykke 4f4e8eed0b Changed abbrev for spare bytes.
svn path=/trunk/; revision=31426
2010-01-03 15:05:51 +00:00
Stig Bjørlykke 46e6206ecd Fixed abbrev for Padding and Flags.
Fixed some indent.

svn path=/trunk/; revision=31425
2010-01-03 15:01:32 +00:00
Stig Bjørlykke 35cdf7d240 Use proto_ntlmssp for protocol tree item.
svn path=/trunk/; revision=31424
2010-01-03 14:59:38 +00:00
Stig Bjørlykke 309989afb7 Fixed abbrev for attribute date.
svn path=/trunk/; revision=31423
2010-01-03 14:58:42 +00:00
Stig Bjørlykke 993f6cd4c5 Fixed abbrev for "Session Receiver Label Space Identifier".
svn path=/trunk/; revision=31422
2010-01-03 14:57:54 +00:00
Stig Bjørlykke b5b2953f61 Fixed abbrev for "Location information age IE".
svn path=/trunk/; revision=31421
2010-01-03 14:56:44 +00:00
Stig Bjørlykke 9c7aabb196 Fixed abbrev for PDU Length.
Removed unused hf entries.

svn path=/trunk/; revision=31420
2010-01-03 14:55:35 +00:00
Stig Bjørlykke 026f96bedf Use proto_mpeg_audio for protocol tree item.
svn path=/trunk/; revision=31419
2010-01-03 14:51:32 +00:00
Stig Bjørlykke c4441c8b43 Use proto_spnego for protocol tree item.
svn path=/trunk/; revision=31418
2010-01-03 14:50:36 +00:00
Stig Bjørlykke 452ff00056 Corrected type for ACRP-apdu aSO-context-name,
which has to be wrong in the ASN.1 spec.

svn path=/trunk/; revision=31417
2010-01-03 14:35:35 +00:00
Anders Broman 5e60817e81 From Hitoshi Irino:
More complete support for IPFIX Information Elements for packet-netflow.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4365

svn path=/trunk/; revision=31416
2010-01-03 14:23:08 +00:00
Stephen Fisher af48a878d4 Reformat value_string, its comments and whitespace.
svn path=/trunk/; revision=31415
2010-01-03 10:05:50 +00:00
Anders Broman 07abd85b14 Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31414
2010-01-02 23:06:02 +00:00
Anders Broman 0aabfbf3f8 Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31413
2010-01-02 22:12:14 +00:00
Anders Broman ce73a5030d From Pascal Quantin:
[RRC LTE] Add dissection of UE EUTRA Capability.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4367
Modified by me to also dissect the content for other RAT types except CDMA2000.

svn path=/trunk/; revision=31410
2010-01-02 16:50:31 +00:00
Anders Broman 7afd9b0c3b From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=31408
2010-01-02 09:46:16 +00:00
Stephen Fisher 02a69c1935 Oops. Capitalize the D in 802.1D.
svn path=/trunk/; revision=31407
2010-01-02 05:07:22 +00:00
Stephen Fisher 4f0203b47e Add descriptions to the priority and CFI fields in 802.1q VLAN packets.
svn path=/trunk/; revision=31406
2010-01-02 04:20:43 +00:00
Anders Broman e356fd0faa Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31404
2010-01-01 22:29:28 +00:00
Stig Bjørlykke e472e2cca9 Use correct length for FT_STRINGZ when adding the item to the tree.
svn path=/trunk/; revision=31401
2010-01-01 18:49:38 +00:00
Bill Meier c0d270e5f0 Fix Bug #4363: wireshark decodes kerberos AS-REQ PADATA incorrectly.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4363

svn path=/trunk/; revision=31400
2010-01-01 17:11:38 +00:00
Stig Bjørlykke 3988c9b848 Add missing stringz tvbrange method.
This fixes bug 2244.

svn path=/trunk/; revision=31398
2010-01-01 15:57:14 +00:00
Anders Broman ce85a08b8d Update to OMA-TS-ULP-V2_0-20091208-C
svn path=/trunk/; revision=31397
2010-01-01 14:54:05 +00:00
Stig Bjørlykke 8a9f1e89b9 From Alex Kirk via bug 4366:
Add DNS response addresses to tshark fields list.

svn path=/trunk/; revision=31394
2009-12-31 15:36:40 +00:00
Stig Bjørlykke ac8fdfe571 From babi via bug 4352:
* wslua doesnt null-terminate a char array properly after one strncpy call
* packet-smb-sidsnooping (disabled now but someone might enable it again)
  has a potential overflow crash (i think?)

svn path=/trunk/; revision=31392
2009-12-30 14:24:10 +00:00
Martin Mathieson 9781efbc67 Getting ready to dissect CPRI C&M commands.
svn path=/trunk/; revision=31391
2009-12-29 22:57:10 +00:00
Martin Mathieson ccaca7c006 Show in stats % of UL traffic that is padding (subheader or payload).
svn path=/trunk/; revision=31390
2009-12-29 22:55:39 +00:00
Gerasimos Dimitriadis 99155acdee From Pascal Quantin:
[NAS EPS] Fix Attach Reject message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4362

svn path=/trunk/; revision=31380
2009-12-29 14:56:53 +00:00
Stephen Fisher d0cd08b679 Update to SocketCAN dissector from bug #4299. This change makes the
dissector look at the data in network order instead of little endian.


svn path=/trunk/; revision=31378
2009-12-29 00:36:50 +00:00
Guy Harris 68cf37f81b Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).

svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00
Gerasimos Dimitriadis 88835212b1 Use true/false strings instead of actual numeric values when adding a boolean
field as a bits item and no custom strings are defined.

svn path=/trunk/; revision=31375
2009-12-28 21:20:27 +00:00
Bill Meier cfca0020c5 From Jakub Zawadzki: remove double NUL termination.
From me: fix a 3rd instance.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3339

svn path=/trunk/; revision=31373
2009-12-28 16:12:25 +00:00
Guy Harris fb3fccfc67 Some SMS characters require more than 2 bytes when encoded as UTF-8; the
maximum number of bytes required by UTF-8 for a single code point is 6 -
that's probably overkill here, as I don't think any *SMS* characters
require 6 bytes, but we'll go with an expansion factor of 6 anyway.

This fixes bug 4358.

svn path=/trunk/; revision=31365
2009-12-27 21:33:28 +00:00
Gerald Combs afc57e6fac Add NULL pointer checks. Fixes the fuzz crash in bug 4351.
svn path=/trunk/; revision=31362
2009-12-24 21:23:38 +00:00
Gerald Combs ad69bdd7ea Have get_host_ipaddr and get_host_ipaddr6 return FALSE if network name
resolution is disabled. Fix some indentation.

svn path=/trunk/; revision=31361
2009-12-24 17:21:02 +00:00
Gerald Combs b7702fd6d7 If we're using c-ares, have get_host_ipaddr and get_host_ipaddr6 time
out after 250ms. This should fix the annoying freeze in bug 658.

svn path=/trunk/; revision=31360
2009-12-24 00:58:31 +00:00
Stephen Fisher 49d7118bd2 Change two cases of FT_STRINGZ to BASE_NONE from BASE_HEX and BASE_DEC as
introduced in the last revision to this file.  This prevents an assertion
when starting tshark/wireshark.


svn path=/trunk/; revision=31359
2009-12-24 00:36:05 +00:00
Jaap Keuter 126782cfa9 From Kirby Files:
Cisco has recently released (in 15.0.1) support for integration between NBAR
and Flexible Netflow (FNF). This allows NBAR-recognized applications to be
identified in the Netflow output. To do so, 3 new template fields were added:
94: APPLICATION_DESC
95: APPLICATION_ID
96: APPLICATION_NAME

svn path=/trunk/; revision=31357
2009-12-23 20:24:41 +00:00
Anders Broman b7e9377583 Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31356
2009-12-23 14:06:57 +00:00
Anders Broman 3bcf0a84bf Update to V9.1.0 (2009-12)
svn path=/trunk/; revision=31354
2009-12-22 22:17:43 +00:00
Anders Broman bce5c2f17b Update to V9.1.0 (2009-12)
svn path=/trunk/; revision=31353
2009-12-22 21:17:25 +00:00
Gerasimos Dimitriadis 976be95b98 Fixes/enhancements/updates for 24.008 IEs:
MS Network Capability, LLC SAPI, Tear Down Indicator,
Packet Flow Identifier

svn path=/trunk/; revision=31352
2009-12-22 20:36:20 +00:00
Gerald Combs 4f30c2170e Change host_name_lookup_process to return TRUE if anything new has been
resolved since the last time it was called. Use this to redraw the packet
list and detail any time we have newly-resolved objects.

svn path=/trunk/; revision=31350
2009-12-22 20:01:06 +00:00
Stig Bjørlykke 8e3ca1a4f6 From Jon via bug 4344:
Decode "client last transaction time" and "associated ip"
options added to DHCP in RFC4388 as the proper types.

svn path=/trunk/; revision=31347
2009-12-22 12:07:49 +00:00
Gerald Combs 4381c54f07 Can someone explain why it's a good idea that functions like strlen
return a size_t and then not define a size_t format specifier for sprintf?

svn path=/trunk/; revision=31342
2009-12-21 21:34:18 +00:00
Gerald Combs 8fc1491a60 Switch to using a bundled version of the openSUSE Build Service packages
for GNUTLS since they provide 32-bit and 64-bit Windows packages. We no
longer have winposixtype.h, so remove its #includes and add a ssize_t
typedef to config.h.win32.

svn path=/trunk/; revision=31341
2009-12-21 21:06:01 +00:00
Stig Bjørlykke 2ab6b0f8eb Small rewrite for glib < 2.14 to make it work more than once.
svn path=/trunk/; revision=31340
2009-12-21 17:39:37 +00:00
Stig Bjørlykke 1925a4f5eb Make copy_persconffile_profile work with glib < 2.14.
svn path=/trunk/; revision=31339
2009-12-21 17:28:47 +00:00
Gerald Combs 708e80bf6f Add profile_store_persconffiles.
svn path=/trunk/; revision=31338
2009-12-21 17:20:49 +00:00
Anders Broman a8fa089227 Update to V9.1.0 (2009-12).
svn path=/trunk/; revision=31337
2009-12-21 15:40:32 +00:00
Stig Bjørlykke 885093fe09 Export copy_persconffile_profile.
svn path=/trunk/; revision=31336
2009-12-21 14:41:04 +00:00
Stig Bjørlykke fe793ed781 Added Copy Profile functionality.
svn path=/trunk/; revision=31335
2009-12-21 12:32:31 +00:00
Sake Blok 3b6cb4d3fa Fix some [-XX bytes missing in capture file] messages when doing
follow TCP stream.


svn path=/trunk/; revision=31334
2009-12-21 06:47:32 +00:00
Anders Broman 52c02f4eb8 Update to V9.1.0 (2009-12)
svn path=/trunk/; revision=31333
2009-12-21 06:35:45 +00:00
Stig Bjørlykke 941cfd993e Only add a delimiter to COL_INFO when actually adding something more.
(remaining data can be TCP segment data)

Removed calls to col_check().

svn path=/trunk/; revision=31332
2009-12-21 00:34:41 +00:00
Gerasimos Dimitriadis ec5cd4d450 Update SM Cause IE; Decode SM Cause 2 IE; Update
Activate PDP Context Accept msg

svn path=/trunk/; revision=31330
2009-12-20 23:17:40 +00:00
Anders Broman 141a03f3d8 Update to V9.1.0 (2009-12)
svn path=/trunk/; revision=31327
2009-12-20 21:47:43 +00:00
Stig Bjørlykke 5feb02cfa9 Rename some objects to avoid duplicate definitions.
svn path=/trunk/; revision=31324
2009-12-19 15:39:16 +00:00
Stig Bjørlykke 0041d498ac Regenerate with SIZE constraints checking.
svn path=/trunk/; revision=31322
2009-12-19 14:27:17 +00:00
Stig Bjørlykke fb56cceeb7 Regenerate P7 with SIZE constraints checking.
Added MSUpperBounds.asn.
Export upper bounds from X411, rename some duplicate definitions in P7.

svn path=/trunk/; revision=31321
2009-12-19 14:26:26 +00:00
Guy Harris 9a4bc11689 Oops, back out my little test change.
svn path=/trunk/; revision=31320
2009-12-19 03:21:28 +00:00
Guy Harris 8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Stig Bjørlykke 112fa32d0b Fixed some OPTIONAL vs. DEFAULT issues.
Regenerate the DOP dissector.

svn path=/trunk/; revision=31313
2009-12-18 17:43:54 +00:00
Stig Bjørlykke 71e627342c Regenerated with SIZE constraints checking.
Added MMSUpperBounds.asn.

svn path=/trunk/; revision=31312
2009-12-18 15:24:18 +00:00
Stig Bjørlykke 901cdc8a9c Regenerated with SIZE constraints checking.
Added IPMSUpperBounds.asn.

svn path=/trunk/; revision=31311
2009-12-18 15:22:45 +00:00
Stig Bjørlykke d5f8597e03 Regenerated with SIZE constraints checking.
Added MTSUpperBounds.asn.

svn path=/trunk/; revision=31310
2009-12-18 15:21:08 +00:00
Stig Bjørlykke e73a89d91a Added option (-C) to check for SIZE constraints in octet-string, integer,
enumerated, sequence-of and set-of types.

Added BER functions to check for SIZE constraints and give expert info warnings.

svn path=/trunk/; revision=31309
2009-12-18 15:18:31 +00:00
Stig Bjørlykke 29a4a0789a Added expert info group PI_PROTOCOL.
svn path=/trunk/; revision=31308
2009-12-18 15:13:44 +00:00
Martin Mathieson 3b0a092b18 Fix crash bug by allocating correct size of struct (used with SR tracking).
svn path=/trunk/; revision=31307
2009-12-18 12:32:14 +00:00
Anders Broman 1661212158 Dissect NumberPortabilityRequest return result.
svn path=/trunk/; revision=31306
2009-12-18 06:26:20 +00:00
Stephen Fisher 9317528c96 Introduce a value_string to provide descriptions for some SMTP response
codes.


svn path=/trunk/; revision=31305
2009-12-18 04:04:15 +00:00
Gerald Combs b33e11a0e9 Fix our match flags.
svn path=/trunk/; revision=31303
2009-12-18 01:25:46 +00:00
Gerald Combs 7c0dc5d7e7 If we don't have PCRE and we do have GLib >= 2.14, use GRegexes for the
"matches" operator.

svn path=/trunk/; revision=31302
2009-12-18 01:15:08 +00:00
Gerasimos Dimitriadis 309d920eb8 Fix/enhacement of Quality of Service IE
svn path=/trunk/; revision=31295
2009-12-17 16:56:56 +00:00
Martin Mathieson d7f78d0627 Remove stray #if 1
svn path=/trunk/; revision=31292
2009-12-17 13:33:00 +00:00
Martin Mathieson 5574e77571 Adding FT_NONE item with proto_tree_add_item() causes crashes later, so use
proto_tree_add_none_format() instead.

svn path=/trunk/; revision=31291
2009-12-17 13:15:29 +00:00
Stig Bjørlykke 47be3577a7 Introduce "Ignore Packet" in the packet list.
This will remove the package from the dissection functions without
removing it from the capture file.

svn path=/trunk/; revision=31287
2009-12-17 01:18:14 +00:00
Anders Broman faec4bde00 From Pascal Quantin:
Add dissection of UE Capability Information PDU.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4335

svn path=/trunk/; revision=31286
2009-12-16 21:34:03 +00:00
Gerasimos Dimitriadis 8c1b66f33a Expert info warning when Keypad Facility IE contains character that is
not a DTMF digit

svn path=/trunk/; revision=31284
2009-12-16 20:46:47 +00:00
Gerasimos Dimitriadis 021f402e5f Update CC Capabilities IE to decode ENICM and MCAT
svn path=/trunk/; revision=31283
2009-12-16 19:16:15 +00:00
Gerasimos Dimitriadis acd70335d1 More NULL entries in dtap_msg_sm_fcn[] to avoid out of bounds access
svn path=/trunk/; revision=31279
2009-12-15 22:09:32 +00:00
Gerasimos Dimitriadis af4c9216ce Fix/update for PDP Address IE
svn path=/trunk/; revision=31278
2009-12-15 21:48:05 +00:00
Stephen Fisher ae2b555a96 Fix a number of copy & paste errors introduced over various checkins and
change duplicated filter names used for different purposes by inserting
another word to differentiate between them.


svn path=/trunk/; revision=31274
2009-12-15 08:05:14 +00:00
Jaap Keuter 1e90e0e29a From Yaniv Kaul:
Attached patch fixes the dissection of the Set Colormap Entries server message. 
It was at least off-by-one to start with, and the dissection went a bit wrong from there on.

svn path=/trunk/; revision=31273
2009-12-15 07:45:14 +00:00
Anders Broman 393a236663 From Vasil Velichkov:
Bug 4330 - Add dissection of HighLayerCompatibility parameter in CAMEL/INAP InitialDP operation.

svn path=/trunk/; revision=31272
2009-12-15 06:31:18 +00:00
Guy Harris 07f9348849 Use the right field for the extension length. Should fix
http://buildbot.wireshark.org/trunk/builders/Ubuntu-7.10-x86-64/builds/311/steps/run-randpkt/logs/stdio

svn path=/trunk/; revision=31270
2009-12-14 23:55:50 +00:00
Jeff Morriss 6d11b171d6 Add support for LUDT/LUDTS in ANSI (ANSI added them in 2000/2001).
svn path=/trunk/; revision=31268
2009-12-14 20:08:11 +00:00
Martin Mathieson d0260a142b Add a cast to try to keep the win64 compiler happy
svn path=/trunk/; revision=31267
2009-12-14 16:50:42 +00:00
Anders Broman 7a4ae2c3b5 Add ETSI Applications.
svn path=/trunk/; revision=31266
2009-12-14 16:49:35 +00:00
Martin Mathieson 52163da600 Show the time between SR and failure or grant.
svn path=/trunk/; revision=31265
2009-12-14 16:04:14 +00:00
Martin Mathieson 469884ab44 Catch unexpected Scheduling Request state transitions as expert info.
svn path=/trunk/; revision=31261
2009-12-14 11:23:24 +00:00
Jaap Keuter 1c8d287094 From Thomas Dreibholz:
Add the missing message type "SSP Not Ready" to the SSP protocol
dissector.

In addition to that:
- make it a proper new style dissector, reporting dissected length,
- fix Keep Alive Ack, taking into account the indicated length.

svn path=/trunk/; revision=31260
2009-12-14 10:59:15 +00:00
Sake Blok 364fc7176a Remove obsoleted test (test is obsoleted by svn 31252)
svn path=/trunk/; revision=31253
2009-12-13 08:11:31 +00:00
Sake Blok 1580d332f4 Fix for bug 3955 and 4288. When doing Follow TCP stream, there was no
check whether a packet belonged to the correct tcp stream (when there 
are multiple streams in the tracefile with the samen ip addresses and 
tcp ports.


svn path=/trunk/; revision=31252
2009-12-13 01:10:55 +00:00
Jaap Keuter e1ec979363 From Mathieu Parent:
As defined in rfc4511 [Lightweight Directory Access Protocol (LDAP): The Protocol],
see the attached patch that dissects IntermediateMessage.

svn path=/trunk/; revision=31251
2009-12-12 09:30:49 +00:00
Jaap Keuter 98aaf48d95 From Yaniv Kaul:
VNC dissector fails to dissect properly the authentication used by the older
VNC protocol. Specifically, the part about version 3.3 in section 6.2 of the 
protocol was ignored / not properly implemented.

svn path=/trunk/; revision=31250
2009-12-12 08:39:38 +00:00
Guy Harris a4b7135ce3 Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it's
a mask to select the base_display_e value from a display field in a
header_field_info structure.

Never select that value by masking out the BASE_RANGE_STRING flag bit,
as that won't continue to work if more flag bits, or other bitfields,
are added.  Instead, mask with BASE_DISPLAY_E_MASK.

Note that the base_display_e value and BASE_RANGE_STRING flag are only
for integral field types, and clarify what BASE_DISPLAY_E_MASK is.

Give at least one of the reasons why hiding protocol fields is not
considered a good idea.

svn path=/trunk/; revision=31249
2009-12-12 03:15:28 +00:00
Balint Reczey 6b45b0a901 Suggest solutions on the missing MIBs popup window.
svn path=/trunk/; revision=31247
2009-12-12 01:41:32 +00:00
Jaap Keuter 6af0e4e002 From Richard Pecl:
Adding prefs_register_protocol_subtree to libwireshark.def

svn path=/trunk/; revision=31246
2009-12-11 17:35:10 +00:00
Jaap Keuter 3cb9c84da1 From Martin Willi:
The attached patch fixes the check for types with the long extension format and re-enables it.

svn path=/trunk/; revision=31244
2009-12-11 17:18:00 +00:00
Martin Mathieson 63fc401318 From Pascal Quantin: add PDCP framing method over UDP.
svn path=/trunk/; revision=31243
2009-12-11 14:31:40 +00:00
Guy Harris ac73800bfa Just use abs_time_secs_to_str() to display UTC times, now that it has a
flag to tell it to format the time in UTC.

svn path=/trunk/; revision=31239
2009-12-11 08:45:45 +00:00
Guy Harris 818b8c3878 Protect against localtime() failing.
svn path=/trunk/; revision=31238
2009-12-11 08:08:05 +00:00
Guy Harris 38316e0483 The pointer is "tmp", not "tm".
svn path=/trunk/; revision=31237
2009-12-11 07:17:09 +00:00
Guy Harris 229b262e15 Squelch warnings.
svn path=/trunk/; revision=31236
2009-12-11 07:14:52 +00:00
Guy Harris 488253bfe7 Add the time zone abbreviation to the result of abs_time_to_str() and
abs_time_secs_to_str().

svn path=/trunk/; revision=31234
2009-12-11 03:39:17 +00:00
Jaap Keuter 1e9498cf25 From Clif Bratcher:
Add a tap hook to the IPv6 dissector.

svn path=/trunk/; revision=31230
2009-12-10 23:15:12 +00:00
Stephen Fisher b665a515a8 Generated fields should not highlight any bytes in the packet bytes pane.
This is especially true in this case because the indication that an arp
packet is gratuitous is determined with the following code, which checks
multiple fields:

  if (((ar_op == ARPOP_REQUEST) || (ar_op == ARPOP_REPLY)) && (memcmp(spa_val, tpa_val, ar_pln) == 0))
    is_gratuitous = TRUE;
  else
    is_gratuitous = FALSE;


svn path=/trunk/; revision=31229
2009-12-10 22:35:09 +00:00
Guy Harris ab0a5a3e15 Show absolute times as UTC, as was done before.
svn path=/trunk/; revision=31228
2009-12-10 22:20:18 +00:00
Guy Harris 4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str()
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
2009-12-10 22:19:29 +00:00
Guy Harris e1a76d5e2b Well, not quite - proto_tree_add_item() doesn't work on FT_ABSOLUTE_TIME
fields, as there are several different possible time formats, and
there's not yet any way to specify the particular format.  However, we
don't need to format the time stamp - let the Wireshark core code do that.

svn path=/trunk/; revision=31226
2009-12-10 22:15:59 +00:00
Guy Harris 28ccd651bf Just use proto_tree_add_item(), don't use a fancy sequence of code that
yields the same result.

svn path=/trunk/; revision=31225
2009-12-10 21:59:35 +00:00
Guy Harris 9a4bdbf9ea Use existing code to format relative and absolute times.
svn path=/trunk/; revision=31224
2009-12-10 20:48:31 +00:00
Bill Meier 4bc9b95d69 Fix Bug #4319: IPMI dissector crash (on Windows) displaying date/time;
Using strftime(..., "%F %T", ...) crashes on Windows (VC9) (!!);
Use "%Y-%m-%d %H:%M:%S" instead.....

svn path=/trunk/; revision=31223
2009-12-10 20:26:39 +00:00
Stephen Fisher 2e94d6c37a Add a simple description to the PID field.
svn path=/trunk/; revision=31222
2009-12-10 19:15:37 +00:00
Bill Meier f3c1957f7c Fix Bug 4316: Crash when using custom RADIUS dictionary.
(The bug was caused by a variable not being initialized).
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4316

svn path=/trunk/; revision=31221
2009-12-10 18:13:38 +00:00
Gerasimos Dimitriadis 224298d17c Fix for Bug 4311:
Update context in case of Get Body Chunk; recognize empty body packets

svn path=/trunk/; revision=31220
2009-12-09 23:14:31 +00:00
Gerasimos Dimitriadis 2e138172a2 Constrained SEQ OF in PER encoding associated with wrong length;
also take into account cases of length 0.

svn path=/trunk/; revision=31219
2009-12-09 21:18:04 +00:00
Gerasimos Dimitriadis 142b31816c From Mathieu Parent:
Dissector for LDAP Content Synchronization Operation
(Modified in order to remove the unneeded oid_add_from_string's)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4309

svn path=/trunk/; revision=31218
2009-12-09 20:59:20 +00:00
Guy Harris 4ac5594f7b Note that there are similar functions to the "to_hexstr" functions
in strutil.c.

svn path=/trunk/; revision=31212
2009-12-09 01:31:41 +00:00
Jaap Keuter 0960a7221b Add the Id tag.
svn path=/trunk/; revision=31209
2009-12-08 22:21:51 +00:00
Stig Bjørlykke d71b1088f7 From Jakub Zawadzki:
Fix win64 build.

svn path=/trunk/; revision=31204
2009-12-08 10:17:37 +00:00
Stig Bjørlykke 7885ac7b92 Added defines for protocol identifier.
Added hf_addr_ext_form_orig for Originator.
Rewrote strings for addr_form.
Indicate national protocol.
Added expert info for unknown compression.
Some code cleanup.

svn path=/trunk/; revision=31203
2009-12-08 10:14:22 +00:00
Martin Mathieson f1977c1eb7 Add a link to protocol wiki page, where link to example program for UDP framing may be found.
svn path=/trunk/; revision=31202
2009-12-08 10:07:27 +00:00
Anders Broman e59f952b98 From Jakub Zawadzki:
Replace some g_snprintf() with 'probably' faster version.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4303

svn path=/trunk/; revision=31201
2009-12-08 07:45:06 +00:00
Anders Broman 62c3372576 From Jakub Zawadzki:
ctime() is not thread safe and it's obsolete.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4302

svn path=/trunk/; revision=31200
2009-12-08 07:41:43 +00:00
Stig Bjørlykke 9b246f9afc Added packet-socketcan.c
svn path=/trunk/; revision=31198
2009-12-08 07:30:07 +00:00
Stephen Fisher 09a4f2af2f From Felix Obenhuber via bug #4299: SocketCAN dissector patch
From me: Remove changes related to the ARP protocol because it doesn't
appear to be necessary for SocketCAN.  Will add later if Felix says it is
needed.


svn path=/trunk/; revision=31196
2009-12-08 07:21:33 +00:00
Stig Bjørlykke 7aa873dae6 A fix for bug 4301:
Check sip->extra_info for SMB_EI_NTI before usage.

svn path=/trunk/; revision=31187
2009-12-07 15:07:38 +00:00
Stig Bjørlykke 82e8cfe421 Build correct oraddress for several Teletex values.
Corrected label format for GenerationQualifier: GQ -> Q.

svn path=/trunk/; revision=31186
2009-12-07 12:17:13 +00:00
Martin Mathieson 68546e930e From Pascal Quantin. Add support a UDP framing format for LTE RLC.
svn path=/trunk/; revision=31185
2009-12-07 10:23:35 +00:00
Jaap Keuter a529270519 Let c-ares actually resolve IPv6 addresses.
svn path=/trunk/; revision=31181
2009-12-06 08:45:52 +00:00
Gerasimos Dimitriadis eff8b8dd39 From Bug 4298:
Add additional LDAP OIDs for LDAP Content Synchronization Operation
(Slightly modified in order to add code in packet-ldap-template.c)

svn path=/trunk/; revision=31179
2009-12-04 23:09:37 +00:00
Martin Mathieson 9a0c5d29c6 Fix length in loop (from Pascal Quantin).
svn path=/trunk/; revision=31178
2009-12-04 22:27:29 +00:00
Gerasimos Dimitriadis 809477b66e Fix for Bug 4197:
Neighbour Cell Description 2 decode error

svn path=/trunk/; revision=31177
2009-12-04 20:27:16 +00:00
Martin Mathieson 2267dcdd0e From Pascal Quantin via bug 4296.
- make framing format work when there are no optional parameters present
- when showing raw SDU, show formatted info as well as data itself.  This is done in a horrible way, but I can't find a nice way.

svn path=/trunk/; revision=31174
2009-12-04 17:39:39 +00:00
Bill Meier cc43ff3835 From: Ravi Kondamuru:
"... a patch to make the netscaler wiretap code independent of the
 host system endian-ness. 
 I have taken care of (1) reading and writing nstrace files (netscaler.c) and
 (2) reading in dissector code (packet-nstrace.c) also."

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3540#c26

svn path=/trunk/; revision=31171
2009-12-04 15:21:48 +00:00
Martin Mathieson 0015dc63be Show whether NACK is full or partial in expert info.
svn path=/trunk/; revision=31170
2009-12-04 11:22:33 +00:00
Martin Mathieson 27169c915c Provide frame links between grant or failure ind back to SR.
svn path=/trunk/; revision=31169
2009-12-04 11:13:20 +00:00
Stephen Fisher 5ee8a92d01 Fix a problem where the Info column's contents was changing erratically
because the Info column was being filled in with a string that didn't
stay around long enough.  Changed a col_set_str() to col_add_str() call. 


svn path=/trunk/; revision=31168
2009-12-04 02:41:23 +00:00
Anders Broman 571e210c76 From Pascal Quantin:
[NAS EPS] various small fixes for message decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4290

svn path=/trunk/; revision=31166
2009-12-03 20:12:13 +00:00
Stephen Fisher c5fdb8edae From Chris Maynard via bug #4287: Display IP protocol number in decimal
instead of hexadecimal.


svn path=/trunk/; revision=31165
2009-12-03 19:10:43 +00:00
Stig Bjørlykke 44f8b813ee Decode family and hook type.
svn path=/trunk/; revision=31164
2009-12-03 17:31:26 +00:00
Stig Bjørlykke b13082516f Added some Solaris AF_ types.
svn path=/trunk/; revision=31163
2009-12-03 17:31:03 +00:00
Bill Meier 7663aff6fc #include <string.h> not needed.
svn path=/trunk/; revision=31162
2009-12-03 16:40:35 +00:00
Stig Bjørlykke e592902393 From Petr Sumbera via bug 4284:
Added support for Solaris IPNET layer

From me:
Some code cleanup in packet-ipnet.c
Added packet-ipnet.c to CMakeFiles.txt
Added WTAP_ENCAP_IPNET to encap_table_base[]

svn path=/trunk/; revision=31159
2009-12-03 15:27:39 +00:00
Gerald Combs a4538a17a8 Back out r30376, which introduced a buffer overrun. Fixes bug 4285.
svn path=/trunk/; revision=31157
2009-12-02 22:29:06 +00:00
Anders Broman a7255dd3ba Make it possible to match transaction Id:s for Conversation where
both Originatingand Responding TID is present.

svn path=/trunk/; revision=31156
2009-12-02 20:16:21 +00:00
Martin Mathieson b3a836bc23 The beginnings of a state machine to track a UE's SR state and provide links between relevant frames.
svn path=/trunk/; revision=31153
2009-12-02 17:46:27 +00:00
Jaap Keuter 6be946c4bb From Samu Varjonen:
svn diff of the changes after draft-ietf-hip-nat-traversal-09 was approved to
become an RFC.

svn path=/trunk/; revision=31148
2009-12-02 07:34:55 +00:00
Gerasimos Dimitriadis 060ac76f82 Show spare bits under the IEs they belong
svn path=/trunk/; revision=31144
2009-12-01 20:19:01 +00:00
Gerald Combs 2ebdf97ca3 Add an item length check to the DTN dissector. Fixes bugs 4277
and 4278.  Add a couple of expert items.

svn path=/trunk/; revision=31133
2009-11-30 18:10:46 +00:00
Gerald Combs 9417a7c86f From Jakub Zawadzki via bug 4274:
Switch back to checking size instead of asize in emem_alloc_chunk. Make
sure we don't try to cross the streams by allocating a negative amount
of memory in the LTP dissector.

svn path=/trunk/; revision=31132
2009-11-30 17:31:13 +00:00
Stig Bjørlykke b5f2728811 Default enable DSP.
svn path=/trunk/; revision=31129
2009-11-30 13:11:14 +00:00
Stig Bjørlykke b9524c35d1 SearchArgumentData filter and EntryInformationSelection attributes are
OPTIONAL as they are defined with a DEFAULT.

svn path=/trunk/; revision=31128
2009-11-30 12:54:47 +00:00
Gerasimos Dimitriadis 5de2fed9aa PS LCS Capability IE updated according to 24.008 V8.6.0;
Change printing of values according to standard style.

svn path=/trunk/; revision=31127
2009-11-29 23:23:27 +00:00
Jaap Keuter 85748db18a Provide some utility macros for commonly used frame data fields.
svn path=/trunk/; revision=31126
2009-11-29 22:51:28 +00:00
Jaap Keuter 6cdc6d4968 Try to get the Win64 compile going as well.
svn path=/trunk/; revision=31124
2009-11-29 22:47:03 +00:00
Martin Mathieson 8713027d83 Obselete a couple of preferences that can always be on.
svn path=/trunk/; revision=31123
2009-11-29 22:45:06 +00:00
Stig Bjørlykke 1d845b1d80 Small fix for "Flag C" filter.
svn path=/trunk/; revision=31121
2009-11-29 19:55:02 +00:00
Jaap Keuter c795dd1af5 From Mithun Roy:
This is a patch for a new dissector that decodes LTP (Licklider Transmission
Protocol) data according to RFC 5326.

svn path=/trunk/; revision=31120
2009-11-29 19:11:55 +00:00
Bill Meier e9fd4a430e Add emacs 'editor modelines'.
svn path=/trunk/; revision=31119
2009-11-29 17:58:17 +00:00
Jaap Keuter b2e0568450 Fix EAP method type 25, 26 interpretation.
svn path=/trunk/; revision=31115
2009-11-29 13:55:34 +00:00
Jaap Keuter cf9260ec0d From Alexis La Goutte:
Based from a Cisco Sample (Thanks Tanmay)
Changelog :
* Fix a error about value of wbid 
* Support of CAPWAP fragmentation
* Add proper handling of the alignment stuff from the RFC for Radio MAC and Wireless specific information
* Add more support of Messages Element Type
* Add a option to dissector Cisco Sample (Cisco Controler use a old draft)

svn path=/trunk/; revision=31114
2009-11-29 13:33:05 +00:00
Anders Broman 4888a8de8a From Tobias Witek:
Add support for UMTS FP over UDP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4218

svn path=/trunk/; revision=31113
2009-11-29 12:05:23 +00:00
Anders Broman a5d39ef850 From Harald Welte:
Correctly parse SYSTEM INFORMATION messages in RSL BCCH FILLING.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4268

svn path=/trunk/; revision=31112
2009-11-29 09:33:22 +00:00
Anders Broman 135c24f2ba From Herbert Lischka:
Patch to resolve Error in decoding BACnet NotificationParameters,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4250

svn path=/trunk/; revision=31111
2009-11-29 09:28:14 +00:00
Stephen Fisher c241b33233 From enhancement bug #4272: Patch to add new filterable field -
frame.time_epoch


svn path=/trunk/; revision=31110
2009-11-29 09:26:01 +00:00
Kovarththanan Rajaratnam 3720bf815c Don't do check_col()
svn path=/trunk/; revision=31109
2009-11-29 02:33:31 +00:00
Anders Broman 8b78665a6a - Update ASN1 files to 3GPP TS 36.331 V8.7.0 (2009-09)
- Make it possible to use "decode as" on DL-CCCH messages sent over UDP.

svn path=/trunk/; revision=31107
2009-11-28 16:21:19 +00:00
Bill Meier 5cae51417c proto_reg_handoff...: if (!initialized) not req'd;
Remove unneeded #includes;
Use true_false_string definitions from tfs.c when possible. 

svn path=/trunk/; revision=31106
2009-11-28 14:47:12 +00:00