Commit Graph

12282 Commits

Author SHA1 Message Date
Jaap Keuter 4fff8a7922 Add Skein MAC authentication tag types.
svn path=/trunk/; revision=31598
2010-01-21 07:56:21 +00:00
Anders Broman eb136e00d8 From Alex Lindberg:
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999

svn path=/trunk/; revision=31597
2010-01-21 06:39:25 +00:00
Guy Harris 90765a3c3e To check which SIP method we saw, just #define values for the index in
the sip_methods[] table and check the index's value, don't do a string
comparison.

svn path=/trunk/; revision=31595
2010-01-20 21:05:24 +00:00
Anders Broman 46ba2a93c8 From Karl Heinz Wolf:
Marking in dialog SIP requests.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3588

svn path=/trunk/; revision=31594
2010-01-20 20:34:45 +00:00
Anders Broman db64e65ec2 From Jakub Zawadzki:
mmap() actually when fail returns MAP_FAILED (-1) not NULL
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

svn path=/trunk/; revision=31593
2010-01-20 20:26:01 +00:00
Stig Bjørlykke 8aa7359eb3 Use correct return value type from dissect_ppdu().
Fixed a typo.

svn path=/trunk/; revision=31590
2010-01-20 12:51:04 +00:00
Stig Bjørlykke 9b2f05da33 Don't try decode an empty octetstring as BER.
svn path=/trunk/; revision=31589
2010-01-20 12:47:26 +00:00
Martin Mathieson 417b1839f1 Add initial version of LTE RLC stats dialog.
svn path=/trunk/; revision=31588
2010-01-20 12:37:26 +00:00
Anders Broman 27bc3e2211 From Jakub Zawadzki:
Fix some bugs after merge.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

svn path=/trunk/; revision=31586
2010-01-20 06:37:56 +00:00
Anders Broman 6b4848afd5 From Gonzalo Casas:
The asn1 definition of AlternateAccessSelection of the MMS dissector was wrong. 
It didn't allow object access with nested AlternatedAccess.
I changed the definition as in ISO 9506-2 (2003).
I also added MMSString which was not present.

I also added the definition for UtcTime as in the annex G of IEC61850-8-1 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4404

svn path=/trunk/; revision=31584
2010-01-20 06:31:11 +00:00
Ronnie Sahlberg 9a9f7acffe From Julien Kerihuel, add support for
unaligned unmarshalling of dissectors generated by PIDL.

This will allow us to use PIDL and additional IDLs from the samba 
project since they use "noalign" for certain protocols.


This may also allow us to use PIDL to describe, and machinegenerate 
dissectors for normal, non-DCERPC, protocols.


This patch for PIDL is still under review, but the PIDL patch is l;ikely 
to be committed soonish.




svn path=/trunk/; revision=31583
2010-01-20 06:02:42 +00:00
Ronnie Sahlberg f817636cc6 remove an unusued variable
svn path=/trunk/; revision=31582
2010-01-20 03:55:03 +00:00
Bill Meier 37547c1791 Fix a few gcc _Wshadow warnings ....
svn path=/trunk/; revision=31580
2010-01-19 23:51:27 +00:00
Gerald Combs fadae76f0c Fix a potential compilation problem with older versions of c-ares.
svn path=/trunk/; revision=31579
2010-01-19 23:18:23 +00:00
Anders Broman 2183430a29 From Jakub Zawadzki:
Embed canary list inside chunk data.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

svn path=/trunk/; revision=31577
2010-01-19 21:28:48 +00:00
Anders Broman 46501fd7f6 From Jakub Zawadzki:
Make emem_create_chunk() a function.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

svn path=/trunk/; revision=31576
2010-01-19 20:54:27 +00:00
Anders Broman 8e276fa139 From Jakub Zawadzki:
Cleanup emem_create_chunk() - move common code outside #ifdef's
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

svn path=/trunk/; revision=31575
2010-01-19 20:53:02 +00:00
Guy Harris b0949d4db9 OK, I guess those URLs were for a protocol in the process of becoming
PIM v2; this appears to be the spec for v1 (Postscript, compressed in
the old "compress" format).

svn path=/trunk/; revision=31574
2010-01-19 19:55:43 +00:00
Anders Broman fa10f2e3b6 Update to V9.1.0 (2009-12)
svn path=/trunk/; revision=31573
2010-01-19 19:52:16 +00:00
Bill Meier e0064797fb Use more unique names for certain enum constants.
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
2010-01-19 19:37:03 +00:00
Gerald Combs 2efa26e0e1 Fix a double-free bug which was causing a crash. Our decryption buffer
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.

svn path=/trunk/; revision=31571
2010-01-19 19:28:30 +00:00
Guy Harris 92a3647ac4 Get rid of a dead link, use IETF links for what appear to be the last
I-Ds for PIMv1 (the next version of the dense-mode draft didn't run on
IGMP).

svn path=/trunk/; revision=31568
2010-01-19 18:53:41 +00:00
Gerald Combs 2799a0216f Remove an unused variable. Fixup whitespace.
svn path=/trunk/; revision=31567
2010-01-19 17:40:52 +00:00
Anders Broman 3e1c4ca38a Remove an include.
svn path=/trunk/; revision=31566
2010-01-19 17:21:19 +00:00
Anders Broman 2dfd8a1e8c If user data is xml display it.
svn path=/trunk/; revision=31565
2010-01-19 17:20:17 +00:00
Stig Bjørlykke 174de72350 Moved expert info for bitstring size constraints below bit values.
Enabled bitstring minimum length size check.

svn path=/trunk/; revision=31564
2010-01-19 08:54:13 +00:00
Stig Bjørlykke 6ff81c8f6a Change group for "Unknown bit(s)" expert info to Undecoded.
svn path=/trunk/; revision=31563
2010-01-19 08:11:23 +00:00
Guy Harris 4579732494 Even better - don't use a global variable in the first place, as its
value isn't used outside dissect_sss_request().

Get rid of some unused value_strings while we're at it; they duplicate
value_strings in packet-ncp-nmas.c, and if they're really needed here,
there should probably be only one instance, in, for example, the NCP
dissector.

Get rid of some unused variables, use -1 for "to the end of the tvbuff",
don't use "subverb" unless we've actually fetched its value.

svn path=/trunk/; revision=31562
2010-01-19 01:16:02 +00:00
Bill Meier 9b568ea691 Fix gcc -Wshadow warnings
svn path=/trunk/; revision=31561
2010-01-19 00:37:39 +00:00
Bill Meier c5614625ee Fix some gcc -Wshadow warnings ....
svn path=/trunk/; revision=31559
2010-01-18 23:16:10 +00:00
Bill Meier de4c6ff515 Fix a number of gcc _Wshadow warnings
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Bill Meier 55669f7127 Fix gcc -Wshadow warnings.
[And therefore fixing a benign bug where memory was allocated for sizeof(*p) rather than sizeof(p)].

svn path=/trunk/; revision=31556
2010-01-18 21:37:34 +00:00
Bill Meier b3685a583a Use true_false_strings from tfs.c when possible;
#include stdio, stdlib & string not req'd;
Fix a gcc -Wshadow warnng

svn path=/trunk/; revision=31555
2010-01-18 20:51:13 +00:00
Stig Bjørlykke 10466c4bbe Add expert info to unknown bitstring bits when having a named_bits table.
svn path=/trunk/; revision=31554
2010-01-18 20:08:56 +00:00
Bill Meier 1c11b9571e Use consistent indentation; Reformat a few hf[] array entries.
svn path=/trunk/; revision=31553
2010-01-18 18:00:23 +00:00
Anders Broman 9a030dda05 Get rid of check_col();
svn path=/trunk/; revision=31552
2010-01-17 18:16:06 +00:00
Gerald Combs fd5ca381c5 [Automatic manuf and enterprise-numbers update for 2010-01-17]
svn path=/trunk/; revision=31549
2010-01-17 16:03:29 +00:00
Stig Bjørlykke 1b9b0af135 Added packet-hp-erm.c.
svn path=/trunk/; revision=31548
2010-01-17 14:20:53 +00:00
Bill Meier 05eae470b9 Dissector for HP encapsulated remote mirroring.
svn path=/trunk/; revision=31547
2010-01-17 14:07:03 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Anders Broman ba8d7bd919 Get rid of check_col();
svn path=/trunk/; revision=31544
2010-01-17 12:19:02 +00:00
Anders Broman 0d3840e704 Update to version 9.1.0
svn path=/trunk/; revision=31543
2010-01-17 09:43:31 +00:00
Stephen Fisher 5531c24c67 Update URL in comments.
svn path=/trunk/; revision=31542
2010-01-16 03:34:07 +00:00
Guy Harris 268345f515 Use G_GSIZE_MODIFIER rather than casting to "gulong" and printing with
"%lu".

svn path=/trunk/; revision=31541
2010-01-16 02:57:42 +00:00
Guy Harris 969b98fa35 tvb_get_ntohl() doesn't return a long on any platform (it returns a
guint32, and on no platform supported by GLib, and thus on no platform
supported by Wireshark, does a guint32 have to be an unsigned long), so
there's no need to cast it to long and print it with %lld.

svn path=/trunk/; revision=31540
2010-01-16 02:39:25 +00:00
Jeff Morriss 508fd83368 Show spare bits in decimal, not as booleans.
svn path=/trunk/; revision=31537
2010-01-15 19:28:28 +00:00
Stig Bjørlykke 5c4ee8a291 Change col_set_str() call to col_add_str() since the string being passed
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31536
2010-01-15 14:05:06 +00:00
Stig Bjørlykke 9d918146ff Changed val_to_str() to val_to_str_const() when used with col_set_str().
svn path=/trunk/; revision=31535
2010-01-15 13:51:47 +00:00
Stig Bjørlykke 8255893114 Change col_set_str() call to col_add_str() since the string being passed
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31534
2010-01-15 13:40:14 +00:00
Anders Broman 4a38ad658c Get rid of check_col();
svn path=/trunk/; revision=31533
2010-01-15 07:32:04 +00:00
Anders Broman 90bf722451 From Chris Costa:
tcp.analysis.acks_frame and tcp.analysis.ack_rtt is not reliable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3311

svn path=/trunk/; revision=31532
2010-01-15 07:20:25 +00:00
Anders Broman a230916b8e From Didier Gautheron:
Don't use packet without data in sequence analysis.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2054

svn path=/trunk/; revision=31531
2010-01-15 07:07:28 +00:00
Gerasimos Dimitriadis a72447c0da Avoid assertion failure when adding a column of type
IEEE 802.11 TX rate.

svn path=/trunk/; revision=31527
2010-01-14 18:30:57 +00:00
Gerasimos Dimitriadis fe1e9d6296 Fix for Bug 3747:
use FT_FLOAT for the radiotap data rate because of .5 Mbps granularity

svn path=/trunk/; revision=31526
2010-01-14 18:21:09 +00:00
Gerald Combs 0e3ba74734 Fix several buffer overflows found by babi babi. Replace a lot of manual
fetching and displaying with proto_tree_add_item().

Use get_dns_name() instead of lwres_get_dns_name(), which fixes a separate
issue.

svn path=/trunk/; revision=31524
2010-01-14 01:22:00 +00:00
Anders Broman 69b7a06578 Remove redundant calls to check_col() in the .cnf files and regenerate.
svn path=/trunk/; revision=31523
2010-01-13 21:41:28 +00:00
Michael Tüxen c273169cbd Display correct chunk type for unknown chunks.
svn path=/trunk/; revision=31522
2010-01-13 21:31:24 +00:00
Anders Broman 04d526a914 check_col.diff
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31521
2010-01-13 21:27:44 +00:00
Anders Broman 526891f1b4 From Didier Gautheron:
fix a memory leak by using se_strdup rather for g_strdup for column text.
replace col_clear() follow by col_add_str() with the faster col_set_str()
remove redundant check_col() call

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31520
2010-01-13 21:16:46 +00:00
Anders Broman 440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Anders Broman 6343ffb68e Try to fix indentation sligtly.
svn path=/trunk/; revision=31518
2010-01-13 20:26:17 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Anders Broman 253ce6255d Try to fix a memory leak.
svn path=/trunk/; revision=31514
2010-01-13 16:35:50 +00:00
Anders Broman 0a5a3c1158 From Didier Gautheron:
Fix a memory leak.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31511
2010-01-13 07:42:42 +00:00
Stig Bjørlykke 86a6a0c2a4 Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci,
to try fixing a buildbot run-randpkt failure.

svn path=/trunk/; revision=31509
2010-01-12 21:25:35 +00:00
Anders Broman 8dea26e52c From Gonzalo Casas:
MMS TimeOfDay display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4387

svn path=/trunk/; revision=31508
2010-01-12 20:15:24 +00:00
Anders Broman 1f6a39eae9 Use g_snprintf()
svn path=/trunk/; revision=31507
2010-01-12 20:08:30 +00:00
Martin Mathieson d5c96e34e7 Use snprintf() to pass checkAPI
svn path=/trunk/; revision=31506
2010-01-12 18:43:18 +00:00
Martin Mathieson 23c5730798 Append to the SDU field only once (instead of for each byte!).
svn path=/trunk/; revision=31503
2010-01-12 16:12:27 +00:00
Stig Bjørlykke 3d32eed0b5 Update to RFC5035.
svn path=/trunk/; revision=31502
2010-01-12 14:31:08 +00:00
Stig Bjørlykke d215938257 Update to RFC5652.
svn path=/trunk/; revision=31501
2010-01-12 14:29:53 +00:00
Stig Bjørlykke 89980e1672 Update to RFC3369.
svn path=/trunk/; revision=31500
2010-01-12 11:49:17 +00:00
Anders Broman 324af9e6fa Fix part of Bug 3917 "tvb_new_real_data is prone to memory leak"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31499
2010-01-11 16:14:26 +00:00
Bill Meier 11ef8a5e0f Fix Bug 4183: "Wireshark can't decrypt WPA(2)-PSK when passphrase is 63 bytes".
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4183

svn path=/trunk/; revision=31498
2010-01-11 15:26:39 +00:00
Jaap Keuter b8ef5efede From Benoit Sibaud:
New option to allow retransmission detection with different source ports.

svn path=/trunk/; revision=31496
2010-01-11 14:28:51 +00:00
Stig Bjørlykke c66911dd59 Small cleanup in conformation file.
svn path=/trunk/; revision=31495
2010-01-11 13:39:09 +00:00
Stig Bjørlykke 7b9b38018f Update to X.511:08/2005.
svn path=/trunk/; revision=31494
2010-01-11 13:37:36 +00:00
Stig Bjørlykke df508b7b96 Update to X.518:08/2005 to add DitBridgeKnowledge.
Export Exclusions.

svn path=/trunk/; revision=31493
2010-01-11 13:36:30 +00:00
Stig Bjørlykke 3a79a59517 Add some missing DSEType's.
svn path=/trunk/; revision=31492
2010-01-11 13:34:05 +00:00
Stig Bjørlykke 672faadc76 Add missing DEFAULT for UpdateMode.
svn path=/trunk/; revision=31491
2010-01-11 13:32:55 +00:00
Anders Broman dd9d463bcf From Hitoshi Irino:
Failed to decode NetFlow v9 packets including a 0 length scope field.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4381

svn path=/trunk/; revision=31488
2010-01-11 08:05:09 +00:00
Anders Broman 759c418158 From Jim Young:
Patch to write "column.format:" preference values pairs to separate lines.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4380

svn path=/trunk/; revision=31487
2010-01-11 08:00:56 +00:00
Anders Broman 0d26e8ad2d From Gonzalo Casas:
Corrected utc-time display in goose dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4378

svn path=/trunk/; revision=31484
2010-01-11 07:52:17 +00:00
Stig Bjørlykke 4867f84826 From rmkml via wireshark-dev:
Redirect secure SMTP traffic on non-standard port 465 to the ssl dissector.

svn path=/trunk/; revision=31482
2010-01-10 19:39:35 +00:00
Stig Bjørlykke 30a2bbe872 Return correct offset from function handling ExtensionField/value,
because this changed from mandatory to optional in revision 28593.

Regenerated with some BIT STRING SIZE constraints checking.

svn path=/trunk/; revision=31480
2010-01-10 16:14:35 +00:00
Gerald Combs 2056ea5ef6 [Automatic manuf and enterprise-numbers update for 2010-01-10]
svn path=/trunk/; revision=31477
2010-01-10 16:03:28 +00:00
Gerasimos Dimitriadis 20e77097eb Fix for Bug 4369:
Use the correct function for adding an FT_STRING field and make some
checks regarding the length of parameters in cmd_manageuser().

svn path=/trunk/; revision=31476
2010-01-10 14:29:49 +00:00
Gerasimos Dimitriadis e53c76e9af Partial fix for Bug 4369:
Remove the possibility of infinite loop when counting items of length 0.

svn path=/trunk/; revision=31475
2010-01-10 14:00:49 +00:00
Stig Bjørlykke d94b155f74 Update ASN.1 files.
Added decoding of ADatP3Data, CorrectionsData, ForwardedEncryptedData, ACP127Data and ACP127NotificationResponse.

svn path=/trunk/; revision=31474
2010-01-09 20:52:47 +00:00
Stig Bjørlykke fc3f69f9c5 Export ReceiptTimeField.
svn path=/trunk/; revision=31473
2010-01-09 20:33:48 +00:00
Stephen Fisher 279fa465aa Change col_set_str() call to col_add_str() since the string being passed
to it is freed right afterwards.  This fixes an issue reported to
wireshark-users by Ershov Pavel on Jan 9, 2010 (in the U.S.).


svn path=/trunk/; revision=31472
2010-01-09 20:15:02 +00:00
Bill Meier e49599c588 Fix Bug #4177: Analyze ! Expert... doesn't show IP "Bad Checksum" errors.
svn path=/trunk/; revision=31471
2010-01-08 23:53:46 +00:00
Bill Meier 1afe329456 Changes to use consistent indentation.
svn path=/trunk/; revision=31470
2010-01-08 21:07:51 +00:00
Martin Mathieson 88447bd5cb Add needed offset to 'radio-type' attached to MAC frame.
svn path=/trunk/; revision=31469
2010-01-08 16:08:22 +00:00
Martin Mathieson 26c0a94dea Don't crash by calling null RRC dissector because TM appeared on 'impossible' channel type.
svn path=/trunk/; revision=31468
2010-01-08 16:07:14 +00:00
Tomas Kukosa f6e00fa93a fix Linux build error
svn path=/trunk/; revision=31467
2010-01-08 13:49:43 +00:00
Tomas Kukosa e18c3065fb display RTSP in VoIP calls (first simple attempt)
svn path=/trunk/; revision=31466
2010-01-08 13:04:49 +00:00
Bill Meier c7a7cf0771 Remove unneeded #includes.
svn path=/trunk/; revision=31465
2010-01-08 00:24:45 +00:00
Bill Meier ca9fd88be4 From Yaniv Kaul: VNC dissector cleanups and minor changes.
From me: Several fixes to the patch and some additional cleanup.

svn path=/trunk/; revision=31464
2010-01-07 23:34:39 +00:00
Gerasimos Dimitriadis e1af738d14 Partial fix for Bug 4369:
Remove the possibility of infinite loop when command length is 0.

svn path=/trunk/; revision=31463
2010-01-07 22:03:29 +00:00