The MNC is encoded in little endian format, not big endian.
The IEs impacted are 5GS tracking area identity list, service area list
and SOR transparent container.
Bug: 16162
Change-Id: I05acc5fb7d1c4a84f53cc5b2a21ee12c4813593d
Reviewed-on: https://code.wireshark.org/review/34874
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Get MMTYPE MSB from the three most significant bits, bits 5 through 7,
instead of bits 1 and 2. Get FMI Fragment count from the four most
significant bits instead of the four least significant bits. Get FMI
Fragment index from the four least significant bits instead of the four
most significant bits.
Bug: 16158
Change-Id: Ib51789486be4562f76114081cbbf3aa22a41ff2e
Reviewed-on: https://code.wireshark.org/review/34868
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Have dissect_kafka_string_new() set a flag if the length was negative.
If the length is negative, don't try to process what comes afterwards.
Make the length argument to decompression routines unsigned, and do
various checks. Don't try to decompress a zero-length block, and quit
if the decompressed block is zero-length.
Bug: 16082
Change-Id: I34c2ea99aa096b3f5724d9b113171b105bd6c60b
Reviewed-on: https://code.wireshark.org/review/34867
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Do not reset multiselect configuration to defaults on every extcap
configuration window open.
Change-Id: I04036ad6723f66c2ac036aae5bf70ded5029a66b
Reviewed-on: https://code.wireshark.org/review/34864
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
If boolean flag is active by default, then when launching extcap without
opening configuration dialog it would be added to extcap call regardless
of user configuration. Modify the logic so default value is used only if
there is no stored user configuration available.
Change-Id: I1855a058a99e2395da5593486411e160d48fca4b
Reviewed-on: https://code.wireshark.org/review/34865
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
The format argument (third argument) is used with the numerical value
passed to val_to_str(), so it should have a numerical format item, not a
string format item.
Bug: 16146
Change-Id: I91ae0edd7fe06fb95ae74697b06bd4f50b696f9f
Reviewed-on: https://code.wireshark.org/review/34866
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add support to Wireshark for new hop-by-hop option defined in:
https://tools.ietf.org/html/draft-ietf-6man-mtu-option-01
This Hop-by-Hop IPv6 option is designed to be used to
record the minimum Path MTU along the forward path between a source
host to a destination host. This collects a minimum recorded MTU
along the path to the destination. The value can then be
communicated back to the source using the return Path MTU field in
the option.
Change-Id: I5dfc1a70aedd347b128bc3c5cd96f9d5a0752e3b
Reviewed-on: https://code.wireshark.org/review/34786
Reviewed-by: João Valverde <j@v6e.pt>
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
They complain because of an uninitialized variable.
../epan/dissectors/packet-synphasor.c: In function ‘config_3_frame_fast’:
../epan/dissectors/packet-synphasor.c:782:7: error: ‘ai’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
ai[i].conv = 1;
^
../epan/dissectors/packet-synphasor.c:767:7: error: ‘pi’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
pi[i].unit = phasor_unit & 0x00000800 ? A : V;
^
Change-Id: I2013ca9ddff5551328d2b86decc5e52fe052b6d0
Reviewed-on: https://code.wireshark.org/review/34859
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
../epan/dissectors/packet-nfs.c:7070:48: error: format specifies type 'long' but the argument has type 'guint64' (aka 'unsigned long long') [-Werror,-Wformat]
proto_item_append_text(attr_tree, " = %ld", size);
~~~ ^~~~
%llu
Change-Id: Iab7c6e026e9e5668e5d744eaedc67cd055f5e3cc
Reviewed-on: https://code.wireshark.org/review/34860
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Config 3 frames are optional in the synchrophasor standard.
Add support so that they get dissected correctly.
Bug: 16140
Change-Id: I6e0f7f653b99a9fd817736d69687132ae9a8537d
Reviewed-on: https://code.wireshark.org/review/34800
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add dissector for the MDS threshold attribute for the
files layout type. For any other layout type just display
the bitmap mask and the bitmap opaque data.
Change-Id: I3325218eb0e8b29d20b1bb540148f3b18cd4ef8f
Reviewed-on: https://code.wireshark.org/review/34845
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fill out MDS HSM opcode processing.
Lustre 2.13/2.12.3 has added MDS_RMFID RPC.
Reorder MDS opcodes to numeric order.
Change-Id: I732b55f62195358b860ca7403f699fc4ff10faaf
Signed-off-by: Nathaniel Clark <nathaniel.clark@misrule.us>
Reviewed-on: https://code.wireshark.org/review/34826
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add the newly create ProtoField to the test_proto.fields in order to be freed.
ERROR: LeakSanitizer: detected memory leaks
Direct leak of 64 byte(s) in 1 object(s) allocated from:
#0 0x55e041f5ef86 in realloc (/home/vasko/sources/wireshark/build_clang/run/tshark+0x222f86)
#1 0x7fd8e0919e7d in g_realloc gmem.c:164:16
#2 0x7fd8e08e457b in g_array_maybe_expand garray.c:820:21
#3 0x7fd8e08e4b49 in g_array_append_vals garray.c:428:3
#4 0x7fd8ef112b6e in value_string_from_table /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:294:9
#5 0x7fd8ef10ee10 in ProtoField_new /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:646:24
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x55e041f5ef86 in realloc (/home/vasko/sources/wireshark/build_clang/run/tshark+0x222f86)
#1 0x7fd8e0919e7d in g_realloc gmem.c:164:16
#2 0x7fd8e08e457b in g_array_maybe_expand garray.c:820:21
#3 0x7fd8e08e4b49 in g_array_append_vals garray.c:428:3
#4 0x7fd8ef111e2e in range_string_from_table /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:226:17
#5 0x7fd8ef10e43f in ProtoField_new /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:642:24
Fixes: v3.1.1rc0-497-g0371994223 ("wslua: Improve parameter check in ProtoField.new()")
Change-Id: I05b8bf3d78c8a540c6cf33d11dc3f3e01f83b8c5
Reviewed-on: https://code.wireshark.org/review/34834
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Allow filterbuttons to be dragged to the display filter
bar
Change-Id: I25e87d0ca86fc7437a20994800bec164ccffef27
Reviewed-on: https://code.wireshark.org/review/34838
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Those are no longer needed by the GUI
Change-Id: I5eb12c2ebe84885ddba510b9d2b49679a292e7f0
Reviewed-on: https://code.wireshark.org/review/34855
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Not queueing up as most likely only one of these would pop up.
Not trying to show every possible error - only really verifying
that the binary and top-level config file are specified correctly.
Change-Id: I2adf2557989bfc67874f5ac2648b1ba8d2a3eb25
Reviewed-on: https://code.wireshark.org/review/34851
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Initially added feature to match linux kernel hash value of
stateid to the wireshark in
commit 05c47d755a
change id I70c6d2b88822b6f735e8bc506a1bfcb421f6ddb9
[NFS] adding stateid hash based on stateid.other
This has been broken by
commit b913bcc13a
change id I3bf7caefc3341887a4c9137500dfeac0115af8cf
NFSv4: Fix for duplicate StateId hashes
This patch fixes it to again calculate a crc32 hash to
make it to the linux kernel output.
Change-Id: Ibb29516de61bd9bdf2dd1164da4b14412aa7a71c
Reviewed-on: https://code.wireshark.org/review/34842
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
When using wiretap to create a pcapng file,
the drop_count field from the wtap_packet_header
in wiretap/wtap.h is not being dumped to the file
in pcapng_write_enhanced_packet_block function.
Bug: 16062
Change-Id: Id9b8dbd1f7406e019fab00ff7a4167ab27543f62
Reviewed-on: https://code.wireshark.org/review/34836
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
When parsing the description
ExpectedActivityPeriod ::= INTEGER (1..30|40|50|60|80|100|120|150|180|181,...)
asn2wrs.py was generating some code where the has_extension flag was
wrongly set to false, leading to a decoding error.
Bug: 16145
Change-Id: I0d54994c0656f5b48f3dcd1864218c45a4ebc308
Reviewed-on: https://code.wireshark.org/review/34837
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Add a script that fills in the <releases/> section of
wireshark.appdata.xml.
Change-Id: I643a8271f2bf1a5c2cd0be9930a6ca7c71935e42
Reviewed-on: https://code.wireshark.org/review/34824
Reviewed-by: Gerald Combs <gerald@wireshark.org>
The Net-SNMP code creates an Engine Id size based on the compilation
size, either 8 or 12 octets long. The initial change added handling of
the '4B/8B random, 4B epoch seconds' format. A different format seems
more likely though, hence this change, implementing handling of the
'4B random, 4B/8B epoch seconds' format instead.
Bug: 16051
Change-Id: I8105b0ba69004f6c15e6b1926c677cb4c5b76f17
Reviewed-on: https://code.wireshark.org/review/34816
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Forego of the button and move the reset functionality to a
context menu
Change-Id: Ib23029586c69c8f3cd7c989c8b7c1f09be219bb1
Reviewed-on: https://code.wireshark.org/review/34827
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Will show PB(<message_name>) in Protocol column, and details of top-level
message elements in the Info column.
Change-Id: Ia00fb90bb7ec990300a990555a0ab6fbddf01ef9
Reviewed-on: https://code.wireshark.org/review/34822
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Huang Qiangxiong <qiangxiong.huang@qq.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Allow the user to reset the changes done. This can be done
at any time, as long as the dialog has not been closed
Change-Id: I0d72a7972b4ea94b53fbed4c84ea952fd6f71b01
Reviewed-on: https://code.wireshark.org/review/34825
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Connect destroyed(QWidget *) signal instead of finished(int) to
flushAppSignals(). This is to ensure that flushAppSignals() is executed
after any potential accepted() or rejected() slots.
This fixes the code flow for preferences update. That is, the signals are
first queued in PreferencesDialog::on_buttonBox_accepted() before
flushAppSignal() is executed.
Change-Id: Ie1497df66adb52cdc10d1b7c701f531d4eeb7351
Reviewed-on: https://code.wireshark.org/review/34823
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
When preparing to decompress the encoded tree size is the minimum input
size. When not met the return value (FALSE) would still indicate success,
being value 0. This could lead to NULL pointer dereference later on.
Change the return value to -1 to match the function return type.
Change-Id: Ie81d98f55af33518a34bc0b79c29450064886bc3
Reviewed-on: https://code.wireshark.org/review/34818
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Having an enum in a class is an established technique, although it is
intended to be anonymous when not related to an attribute.
Change-Id: Id599da0432b5289217f2162d26616452d10b1922
Reviewed-on: https://code.wireshark.org/review/34817
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Roland Knall <rknall@gmail.com>
Make them anonymous as they are not related to any attribute
Change-Id: I697ce1c04196e035bf5d394b0785826d251fb8cf
Reviewed-on: https://code.wireshark.org/review/34821
Reviewed-by: Roland Knall <rknall@gmail.com>
Filter on columns being hidden or not
Change-Id: Ia41f556e00c7de471b1d4b7f9b5f6c099b7ddcf3
Reviewed-on: https://code.wireshark.org/review/34820
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
The current implementation has some serious bugs. e.g. if an added
column is moved, existing columns disappear. Also, if new columns
are being added, existing columns may disappear. This moves the column
preferences to a Movel/View concept and implements necessary checks
to ensure, that such an issue cannot occur
Change-Id: I73810812180e2fbed4d2fe67316f190aba82c719
Reviewed-on: https://code.wireshark.org/review/34819
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
GUIDs of the OPC UA protocol are always encoded in little endian format.
Using the default RFC4122 decoder assumes big endian and results in displaying
wrong values.
Change-Id: I0c2f60ca2f1c0ae118e8388ec58291dc0d1222b9
Reviewed-on: https://code.wireshark.org/review/34790
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Using mark_frame_as_depended_upon like other reassembling dissectors
Change-Id: I2b1f476d9339d8277fb0d3420d94ec32d402c0ee
Reviewed-on: https://code.wireshark.org/review/34807
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This handles the various Multi-AP additions and has been checked by
the WFA.
Change-Id: I56d32f3efec24923e1a710cb67c67f7e0b4630dc
Reviewed-on: https://code.wireshark.org/review/34794
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Add generic function to dissect the bitmap4 struct and
optionally its corresponding opaque data. The behavior
is customized by setting the nfs4_bitmap_info_t struct
given as argument. The items are displayed when their
corresponding hf_* labels are given (not set to NULL).
The type argument if set to NFS4_BITMAP_MASK only the
bitmap is dissected and displayed as a list of attribute
names. Otherwise if set to NFS4_BITMAP_VALUES the bitmap
is dissected including their respective values.
The function dissect_nfs4_fattrs was modified to use
dissect_nfs4_bitmap instead and all functionality which
dissects the value of each attribute was moved to a
separate function dissect_nfs4_fattr_value.
All functionality from dissect_nfs4_fattrs is given in
the new function dissect_nfs4_bitmap, but it also
includes additional functionality:
- Gracefully handle a bitmap attribute which does not
have a dissector and a warning is displayed.
- If there is a problem dissecting one of the bitmap
attribute values then do not attempt to dissect any
more values and a warning is given explaining why
the values were not dissected. In this case at least
the rest of the attributes names are displayed.
- If any error is found dissecting the values then all
bytes left undissected are just consumed so the rest
of the NFS packet is correctly dissected.
- Add subtree if the name is given, all bitmap data
will be under this main tree.
- Show mask label when the number of bitmap masks is 0
and the type is to display only the bitmap mask.
Use function dissect_nfs4_bitmap instead to process the
state protect bitmaps. Also, use correct labels
"spo_must_enforce" and "spo_must_allow" instead of using
the generic label "operation mask" for both bitmap masks.
Finally, display the operation masks including the list
of operation names in each mask.
Use function dissect_nfs4_bitmap instead to process the
hints mask in IO_ADVISE.
Use function dissect_nfs4_bitmap instead to process the
notify mask in GETDEVICEINFO.
Bug: 16107
Change-Id: Ic470fd003bbc18feeadbd5d2cd0aa56329682bd6
Reviewed-on: https://code.wireshark.org/review/34714
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Pascal Quantin