The sanity check is specific for Visual Studio so add those
guards. The PLATFORM variable is not standard for other toolchains.
Add a default "windows target platform" of Win64.
Add error output for win-setup.ps1.
The locale information can be excessively verbose. Cut down the
number of categories displayed to one, arguably the most relevant
for troubleshooting purposes.
This is more readable and the extra error checking is functionally
the same as the original upstream code too, that trigerred some
compiler warnings.
Add missing 'static' qualifier.
Add a test for 'ws_opterr'.
Protocol names can only be on the left hand side of filter expressions.
If a protocol name with an even number of characters ("fc", "dc", "ff",
"fefd", etc.) is on the right hand side of a filter expressions and
can be interpreted as a byte string instead, do so. Fix#12810.
If a macro identifier is not defined it evaluates to zero in an
expression, so the outer #ifdef is unnecessary and should be
avoided (the less the better).
Add a missing CMake comment while here.
Store all user specified values from the "Import from Hex Dump"
dialog in a profile import_hexdump.json file.
Set default ExportPDU dissector to "data".
Fixed a minor typo in a help text.
Added check on Command-Number on control message following
Accept-Session to detect the correct state. There are
various states possible after Accept-Session.
packet-signal-pdu.c:267:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_can' [-Wmissing-prototypes]
packet-signal-pdu.c:293:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_lin' [-Wmissing-prototypes]
packet-signal-pdu.c:314:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_someip' [-Wmissing-prototypes]
packet-signal-pdu.c:335:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_pdu_transport' [-Wmissing-prototypes]
packet-r09.c:152:1: warning: no previous prototype for function 'proto_register_r09' [-Wmissing-prototypes]
packet-r09.c:217:1: warning: no previous prototype for function 'proto_reg_handoff_r09' [-Wmissing-prototypes]
file-tiff.c:840:1: warning: no previous prototype for function 'proto_register_tiff' [-Wmissing-prototypes]
file-tiff.c:1143:1: warning: no previous prototype for function 'proto_reg_handoff_tiff' [-Wmissing-prototypes]
* introduced with 9b13c4352d
* HAVE_SMI_VERSION_STRING is always defined if libsmi found
Change-Id: I50480d37a3a6f31bcfe768f030af9176213b7366
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
Fix
wsutil/ws_getopt.c:93:21: error: possible misuse of comma operator here [-Werror,-Wcomma]
return ws_optind++, -1;
^
wsutil/ws_getopt.c:93:10: note: cast expression to void to silence warning
return ws_optind++, -1;
^~~~~~~~~~~
(void)( )
wsutil/ws_getopt.c:188:11: error: possible misuse of comma operator here [-Werror,-Wcomma]
name++, opt++;
^
wsutil/ws_getopt.c:188:5: note: cast expression to void to silence warning
name++, opt++;
^~~~~~
(void)( )
wsutil/ws_getopt.c:199:15: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
int l = arg-start;
~ ~~~^~~~~~
Add a .editorconfig entry for ws_getopt.[ch].
Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.
Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.
The API is under the Wireshark namespace to avoid conflicts with
system headers.
Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.
João Valverde